emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/repo_sync.c: CID 62763 (toctou)

Browse Source
This commit is contained in:
Juan RP
2014-10-08 09:55:12 +02:00
parent 0c74a5d7fe
commit 805f6aa1b2
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/repo_sync.c
View File

@@ -1,5 +1,5 @@
/*- /*-
* Copyright (c) 2009-2013 Juan Romero Pardines. * Copyright (c) 2009-2014 Juan Romero Pardines.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@@ -99,16 +99,15 @@ xbps_repo_sync(struct xbps_handle *xhp, const char *uri)
*/ */
lrepodir = xbps_xasprintf("%s/%s", xhp->metadir, uri_fixedp); lrepodir = xbps_xasprintf("%s/%s", xhp->metadir, uri_fixedp);
free(uri_fixedp); free(uri_fixedp);
/* /*
* Create repodir in metadir. * Create repodir in metadir.
*/ */
if (access(lrepodir, R_OK|X_OK|W_OK) == -1) { if ((rv = xbps_mkpath(lrepodir, 0755)) == -1) {
if ((rv = xbps_mkpath(lrepodir, 0755)) == -1) { if (errno != EEXIST) {
xbps_set_cb_state(xhp, XBPS_STATE_REPOSYNC_FAIL, xbps_set_cb_state(xhp, XBPS_STATE_REPOSYNC_FAIL,
errno, NULL, errno, NULL, "[reposync] failed "
"[reposync] failed to create repodir `%s': %s", "to create repodir `%s': %s", lrepodir,
lrepodir, strerror(errno)); strerror(errno));
free(lrepodir); free(lrepodir);
return rv; return rv;
} }