emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop converting relative symlinks to absolute.

Browse Source 
There's no reason to make them absolute, simply store in the metadata
the target file as is. This vastly simplifies the code and makes all
test pass correctly.
This commit is contained in:
Juan RP
2015-02-19 11:04:34 +01:00
parent 2f9dd7237b
commit 9ae3638429
7 changed files with 20 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/xbps/xbps-create/basic_test.sh
View File

@@ -33,7 +33,7 @@ hardlinks_size_body() {
atf_test_case symlink_relative_target
symlink_relative_target_head() {
atf_set "descr" "xbps-create(8): relative symlinks in destdir must be absolute"
atf_set "descr" "xbps-create(8): relative symlinks in destdir"
}
symlink_relative_target_body() {
@@ -48,7 +48,7 @@ symlink_relative_target_body() {
xbps-rindex -d -a repo/*.xbps
atf_check_equal $? 0
result="$(xbps-query -r root --repository=repo -f foo|tr -d '\n')"
expected="/usr/include/gsm/gsm.h/usr/include/gsm.h -> /usr/include/gsm/gsm.h"
expected="/usr/include/gsm/gsm.h/usr/include/gsm.h -> gsm/gsm.h"
rv=0
if [ "$result" != "$expected" ]; then
echo "result: $result"
@@ -61,7 +61,7 @@ symlink_relative_target_body() {
atf_test_case symlink_relative_target_cwd
symlink_relative_target_cwd_head() {
atf_set "descr" "xbps-create(8): relative symlinks to cwd in destdir must be absolute"
atf_set "descr" "xbps-create(8): relative symlinks to cwd in destdir"
}
symlink_relative_target_cwd_body() {
@@ -76,7 +76,7 @@ symlink_relative_target_cwd_body() {
xbps-rindex -d -a repo/*.xbps
atf_check_equal $? 0
result="$(xbps-query -r root --repository=repo -f foo|tr -d '\n')"
expected="/usr/include/gsm/gsm.h/usr/include/gsm.h -> /usr/include/gsm/gsm.h"
expected="/usr/include/gsm/gsm.h/usr/include/gsm.h -> ./gsm/gsm.h"
rv=0
if [ "$result" != "$expected" ]; then
echo "result: $result"