emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xbps-bin: make the 'check' target also test for modified symlinks.

Browse Source
This commit is contained in:
Juan RP 2011-06-01 07:31:38 +02:00
parent cfa637db48
commit c9a673cc11
1 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
bin/xbps-bin/check.c
View File

@ -30,18 +30,21 @@
#include <errno.h> #include <errno.h>
#include <assert.h> #include <assert.h>
#include <unistd.h> #include <unistd.h>
#include <sys/param.h>
#include <xbps_api.h> #include <xbps_api.h>
#include "defs.h" #include "defs.h"
/* /*
* Checks package integrity of an installed package. This * Checks package integrity of an installed package. This
* consists in four tasks: * consists in five tasks:
* *
* o Check for metadata files (files.plist and props.plist), * o Check for metadata files (files.plist and props.plist),
* we only check if the file exists and its dictionary can * we only check if the file exists and its dictionary can
* be externalized and is not empty. * be externalized and is not empty.
* o Check for missing installed files. * o Check for missing installed files.
* o Check for target file in symlinks, so that we can check that
* they have not been modified.
* o Check the hash for all installed files, except * o Check the hash for all installed files, except
* configuration files (which is expected if they are modified). * configuration files (which is expected if they are modified).
* o Check for missing run time dependencies. * o Check for missing run time dependencies.
@ -96,8 +99,8 @@ xbps_check_pkg_integrity(const char *pkgname)
prop_array_t array; prop_array_t array;
prop_object_t obj; prop_object_t obj;
prop_object_iterator_t iter; prop_object_iterator_t iter;
const char *file, *sha256, *reqpkg; const char *file, *sha256, *reqpkg, *tgt = NULL;
char *path; char *path, buf[PATH_MAX];
int rv = 0; int rv = 0;
bool broken = false, files_broken = false; bool broken = false, files_broken = false;
@ -147,6 +150,36 @@ xbps_check_pkg_integrity(const char *pkgname)
goto out; goto out;
} }
/*
* Check for target files in symlinks.
*/
array = prop_dictionary_get(filesd, "links");
if ((prop_object_type(array) == PROP_TYPE_ARRAY) &&
prop_array_count(array) > 0) {
iter = xbps_get_array_iter_from_dict(filesd, "links");
if (iter == NULL) {
rv = ENOMEM;
goto out;
}
while ((obj = prop_object_iterator_next(iter))) {
if (!prop_dictionary_get_cstring_nocopy(obj, "target", &tgt))
continue;
prop_dictionary_get_cstring_nocopy(obj, "file", &file);
if (realpath(file, buf) == NULL) {
prop_object_iterator_release(iter);
rv = errno;
goto out;
}
if (strcmp(buf, tgt)) {
fprintf(stderr, "%s: modified symlink `%s', "
"target: `%s' (shall be: `%s')\n",
pkgname, file, buf, tgt);
files_broken = true;
}
}
prop_object_iterator_release(iter);
}
/* /*
* Check for missing files and its hash. * Check for missing files and its hash.
*/ */