emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xbps_transaction_init: small memleaks found by valgrind.

Browse Source
This commit is contained in:
Juan RP 2014-05-22 10:41:07 +02:00
parent d94995eb5a
commit ea234f095f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/transaction_dictionary.c
View File

@ -180,6 +180,8 @@ xbps_transaction_init(struct xbps_handle *xhp)
xhp->transd = NULL; xhp->transd = NULL;
return EINVAL; return EINVAL;
} }
xbps_object_release(unsorted);
if ((mdeps = xbps_array_create()) == NULL) { if ((mdeps = xbps_array_create()) == NULL) {
xbps_object_release(xhp->transd); xbps_object_release(xhp->transd);
xhp->transd = NULL; xhp->transd = NULL;
@ -190,6 +192,8 @@ xbps_transaction_init(struct xbps_handle *xhp)
xhp->transd = NULL; xhp->transd = NULL;
return EINVAL; return EINVAL;
} }
xbps_object_release(mdeps);
if ((conflicts = xbps_array_create()) == NULL) { if ((conflicts = xbps_array_create()) == NULL) {
xbps_object_release(xhp->transd); xbps_object_release(xhp->transd);
xhp->transd = NULL; xhp->transd = NULL;
@ -200,6 +204,7 @@ xbps_transaction_init(struct xbps_handle *xhp)
xhp->transd = NULL; xhp->transd = NULL;
return EINVAL; return EINVAL;
} }
xbps_object_release(conflicts);
return 0; return 0;
} }
@ -260,6 +265,7 @@ xbps_transaction_prepare(struct xbps_handle *xhp)
/* /*
* The missing deps and conflicts arrays are not necessary anymore. * The missing deps and conflicts arrays are not necessary anymore.
*/ */
xbps_dictionary_remove(xhp->transd, "unsorted");
xbps_dictionary_remove(xhp->transd, "missing_deps"); xbps_dictionary_remove(xhp->transd, "missing_deps");
xbps_dictionary_remove(xhp->transd, "conflicts"); xbps_dictionary_remove(xhp->transd, "conflicts");
xbps_dictionary_make_immutable(xhp->transd); xbps_dictionary_make_immutable(xhp->transd);