Juan RP
1722635e08
Introduce xbps_sanitize_path() to fix #78 properly.
...
This removes multiple slashes of a path and returns you a buffer with
the sanitized string.
2015-02-18 15:12:39 +01:00
Juan RP
628a344560
libxbps: fix a memleak introduced in 1403826fa
.
2015-02-17 16:39:04 +01:00
Juan RP
1403826fa6
libxbps: detect and remove properly symlinks with relative targets.
...
Close #78
2015-02-17 11:59:05 +01:00
Juan RP
0fc297a471
lib/transaction_ops.c: minor optimization.
2015-02-16 11:18:58 +01:00
Juan RP
2aa844f3f7
lib/Makefile: remove some disabled warnings for lib{fetch,portableproplib}.
...
There's no need to set _GNU_SOURCE and disable those compiler warning flags.
2015-02-15 05:47:35 +01:00
Juan RP
b8b4694b33
portableproplib: use posix_madvise rather than madvise.
...
The posix variant is the standardized version of madvise.
2015-02-15 05:42:18 +01:00
Juan RP
4e0ce0fbb4
libxbps: make the vpkg_provider_and_revdeps_downgrade test case work.
2015-02-10 10:55:05 +01:00
Juan RP
1ebb245672
xbps_transaction_store: print repo too.
2015-02-05 10:26:53 +01:00
Juan RP
c0d7d930de
libxbps: make sure that revdeps of vpkg providers are always resolved.
...
Added new test cases to verify its correctness in upgrades and removals.
2015-02-05 10:04:42 +01:00
Juan RP
d607655371
libxbps: globally check for unresolved reverse dependencies.
...
Close #46 . See NEWS for more information.
2015-02-03 10:20:13 +01:00
Juan RP
3bc6354550
lib/repo_pkgdeps.c: fix some debug printfs.
2015-02-02 09:37:34 +01:00
Juan RP
076b3f8c44
libxbps: add pkgs on hold mode to the transaction, but ignore them.
...
Those are there mostly to be shown by the clients and notify that
there's an update in repos that is being ignored.
Idea by @chneukirchen.
2015-01-28 12:07:47 +01:00
Juan RP
571d96fa92
libxbps: make sure to remove pkg metadata file on upgrades with skip-obsoletes.
...
This fixes the following case:
- A-1.0_1 is installed and owns bin/foo.
- A-1.1_1 is in the transaction and depends on B-1.0_1 that owns bin/foo.
- B-1.0_1 is in the transaction and replaces A<1.1_1.
- A-1.1_1 in the transaction now has "skip-obsoletes".
- A is updated to 1.1_1, its metadata file (<pkgname>-files.plist) wasn't removed.
Added two new test cases to verify moving files from/to a dependency.
2015-01-27 17:53:37 +01:00
Juan RP
cbf1cfe0f5
libxbps: improve debug messages again.
2015-01-21 11:39:45 +01:00
Juan RP
b7fd0dcac5
xbps_transaction_shlibs: take into account shlibs from pkgs in the transaction.
2015-01-18 12:44:26 +01:00
Juan RP
f9eef6aa0d
Perform global tracking of unresolved shlibs before accepting transaction.
...
Rather than checking per package being installed or updated, check
all installed packages to have all its shlib-requires resolved.
2015-01-18 10:23:52 +01:00
Juan RP
d11230a29d
libxbps: abort pkg unpacking as soon as a file cannot be written.
...
Close #74
2015-01-18 10:22:05 +01:00
Juan RP
bce27b968e
xbps_find_*pkg_in_array: fix logic when transaction obj string matches.
2015-01-17 06:04:22 +01:00
Juan RP
e438aae13c
transaction_revdeps.c: remove dead code.
2015-01-14 21:00:37 +01:00
Juan RP
8263449f94
xbps_end: don't bother releasing everything; pkgdb is enough.
...
xbps-query -L now: 115ms
xbps-query -L before: 148ms
Fuck you valgrind!
2015-01-14 18:43:17 +01:00
Juan RP
a651f33832
xbps_pkgdb_release: don't bother releasing everything.
2015-01-14 17:34:00 +01:00
Juan RP
91b7b2fd5a
Use a sane umask(2) before unpacking package files.
...
See https://github.com/voidlinux/void-packages/issues/835
for more information.
2015-01-11 11:01:09 +01:00
Juan RP
b23855f692
xbps_repo_close: only unlock the file lock if repo was opened as such.
...
If xbps_repo_open() was called with the lock arg set, xbps_repo_close()
will now unlock the repo file lock, without the need to set it.
This avoids the need to always unlock the file lock even if it wasn't
locked previously. This also introduceds an ABI/API break, but this
way it's cleaner.
2015-01-11 09:11:38 +01:00
Juan RP
7dea05f507
xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb.
...
If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
2015-01-10 19:42:09 +01:00
Juan RP
7c153a2b15
pkgdb: disable pkgdb conversion code; 0.38 was released long ago.
2015-01-10 19:26:37 +01:00
Juan RP
ee175a2a68
Improve xbps_end() and use it before exit(3)ing.
...
- Simplify xbps_repo_open::repo_get_dict().
- Use xbps_end() in the utils where necessary.
- Make xbps_end() call xbps_pkgdb_unlock() if necessary.
- Make xbps_end() release rpool resources.
- Make xbps_end() release resources from xbps_handle.
- Fixed 90% of reported leaks (still reachable at exit) from valgrind.
That was to silence valgrind's memcheck with --leak-check=full.
2015-01-10 19:11:31 +01:00
Juan RP
8196811e2e
lib/repo.c: indent previous.
2015-01-10 12:00:36 +01:00
Juan RP
b09faadebc
xbps-{install,query}: --repository now accepts relative paths in local repos.
2015-01-10 11:59:31 +01:00
Juan RP
7b3a500139
libxbps: the provides obj now expects exact pkgver strings.
...
This reduces extra allocs and simplifies the code, which was just
there to workaround some broken pkgs anyway.
2015-01-10 07:26:23 +01:00
Juan RP
1f6a5c0e47
libxbps: detection of orphaned packages is now 66% faster.
2015-01-10 05:43:35 +01:00
Juan RP
5d7a5a646d
xbps_repo_get_pkg_revdeps: find pkg via repo_get_xxx not rpool_get_xxx.
2015-01-06 07:58:45 +01:00
Juan RP
9d582abe0f
Fixed a regression with virtual packages declared via xbps.d(5).
...
Added a new test case to verify its correctness. Somehow virtual packages
declared via xbps.d(5) were not working correctly for dependencies.
This now works as expected with vpkgs declared with and without a version
component.
2015-01-05 16:04:22 +01:00
Juan RP
eee895c6d8
Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations.
...
See the NEWS file for more information.
2014-12-31 08:51:45 +01:00
Juan RP
b513a5e15e
libfetch: misc cleanups due to nbcompat removal.
2014-12-28 03:34:36 +01:00
Juan RP
4ee6f943dd
libfetch: fix races in the cache connection code.
...
Tested by @Gottox.
2014-12-23 10:52:54 +01:00
Juan RP
6a985190aa
xbps_archive_fetch_xxx: avoid races with multiple threads in the libfetch code.
...
Protect our critical sections with a mutex for now, until libfetch
is really fixed to work correctly with multiple threads.
2014-12-22 18:18:20 +01:00
Juan RP
c8ecf4ac6c
xbps-reconfigure(8): new option -i, --ignore to ignore pkgs with -a, --all.
...
-i, --ignore can be specified multiple times and can be used to
ignore configuration of those packages while configuration of all
packages is being performed.
Close #67
2014-12-09 13:10:48 +01:00
Juan RP
16d2640df8
Files in the configuration directory have preference.
2014-12-09 12:05:18 +01:00
Juan RP
53c6a5d1d7
xbps_transaction_commit: if the pkg RSA signature is invalid print rval too.
2014-12-01 12:52:26 +01:00
Juan RP
c47beef740
xbps_transaction_commit: if pkg sha256 hash is invalid print rval.
2014-12-01 12:47:29 +01:00
Juan RP
4479bff03e
repo: if local repodata archive is incomplete, remove it.
2014-11-29 08:44:21 +01:00
Juan RP
fe9a795995
xbps-{install,query}: added -M --memory-sync option.
...
This explicitly enables the in memory fetch/store of remote repository
data archives mode, ignoring existing on-disk repodata archives.
This changes the previous behaviour of falling back to this mode if no
on-disk repodata archives were found.
Thanks to @Gottox and @dominikh for comments.
2014-11-27 10:42:05 +01:00
Juan RP
7401ea3e64
Added support to fetch remote repodata on the fly.
...
See the NEWS file for more information.
2014-11-26 16:07:16 +01:00
Juan RP
89d11e871f
xbps-{install,query}: added -i to ignore repos defined in xbps.d.
...
See the NEWS file for more information.
2014-11-21 10:56:41 +01:00
Juan RP
1789e527a9
Gratuitous ABI break: xbps_binpkg_get_xxx() -> xbps_archive_fetch_xxx().
2014-11-21 09:51:57 +01:00
Juan RP
1bae26606e
Introduce xbps_{pkgdb,rpool}_get_pkg_fulldeptree().
...
These routines return a xbps_array_t with a full sorted dependency graph
for the target pkg, by querying pkgdb or rpool.
Update xbps-query(8) to use the new libxbps API.
2014-11-20 09:23:51 +01:00
Juan RP
eb90fcc50c
xbps_binpkg_{arch,pkgver}: return a buffer of matched string instead.
...
... otherwise will pass an invalid pointer to free(3) later on.
2014-11-19 11:56:16 +01:00
Juan RP
428a747fad
Fix #69 (No way to set globally a custom architecture)
...
The "architecture" configuration keyword is now available to override
the native machine architecture returned by (uname(2)).
The XBPS_ARCH environment variable still has preference.
2014-11-19 11:36:09 +01:00
Juan RP
b2bc7af66e
Fix #68 (xbps_binpkg_arch() asserts if arch contains a dash)
2014-11-19 11:14:37 +01:00
Juan RP
c549252223
xbps_pkg_version: minor optimization.
2014-11-18 16:11:43 +01:00
Juan RP
77c6c3e504
Introduce xbps_binpkg_get_file_into_fd() and use it for xbps-query(8) --cat.
...
This allows you to print to stdout any file stored in a binary package,
locally or remotely!
$ xbps-query -R --cat=/usr/bin/ls coreutils > ls
$ file ls
ls: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=7a195fc46d1d5cdca32bfccd3b30f81784e342ed, stripped
$
2014-11-17 18:43:08 +01:00
Juan RP
a6516505e9
xbps-query(8: added --cat=FILE mode support.
...
- This mode prints to stdout the matching FILE stored in a binary package.
- ABI break: renamed xbps_get_pkg_plist_from_binpkg() xbps_binpkg_get_plist().
- Added xbps_binpkg_get_file() as a generic way to get pkg file contents.
- Removed useless comments from xbps_api_impl.h.
2014-11-17 15:45:46 +01:00
Juan RP
3afb9d709d
Get rid of repodata index-files; the archive is now 8x smaller.
...
See the NEWS file for more information.
2014-11-13 17:09:43 +01:00
Juan RP
2153c87464
lib/portableproplib/prop_array.c: comment out another debug printf.
2014-11-13 15:22:58 +01:00
Juan RP
3290df5d62
lib/portableproplib/prop_array.c: comment out a debug printf.
2014-11-13 15:22:13 +01:00
Juan RP
43c9497feb
Introduce xbps_array_add_first() to insert obj at the head of array.
...
The behaviour of this routine mimics the existing xbps_array_add() with
the difference that stored objects are moved to the right to insert
our object as the first element on the array.
Use this to add replaced packages in the transaction array at the head
rather than at the end, to preserve the proper sorting order.
2014-11-13 15:18:21 +01:00
Juan RP
74c30556fc
xbps_transaction_prepare: check for unresolved shlibs a bit early.
...
It's just better if we check for unresolved shlibs earlier because
the transaction array will be smaller if there are replaced packages.
2014-11-13 11:39:20 +01:00
Juan RP
04bde70969
xbps_init: print bestmatching value.
2014-11-07 10:18:01 +01:00
Juan RP
53f13d579e
Added the "bestmatching" configuration keyword to enable pkg best matching.
...
See the NEWS file for more information.
2014-11-07 10:07:51 +01:00
Juan RP
6c76f6786d
xbps_repo_open: do not create repodata file in locked mode.
...
... we want a proper errno value (ENOENT) if the archive does not exist.
2014-11-06 11:38:55 +01:00
Juan RP
5b522109f7
Replaced config/system {repo,preserve,virtualpkg}.d with a single directory.
...
See the NEWS file for more information.
2014-11-06 09:58:04 +01:00
Juan RP
9566a0e737
Re-add support for system virtualpkg.d (XBPS_SYS_VPKG_PATH).
...
This is still useful to set distro defaults for virtual packages, with
the option to override them via /etc/xbps/virtualpkg.d.
2014-11-05 09:40:32 +01:00
Juan RP
595136704e
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d).
...
Binary packages do not need to provide those virtualpkg configuration files
anymore; all vpkg info is now collected from pkgdb.
2014-11-04 11:17:27 +01:00
Juan RP
5dba1108d1
lib/package_remove.c: simplify link relative check.
2014-10-25 10:32:58 +02:00
Juan RP
ff3960696f
lib/package_remove.c: fix a memleak.
2014-10-25 08:08:04 +02:00
Juan RP
e75beec76f
unpack: get rid of code that checks for modified symlinks.
...
Unpacking those symlinks is so cheap that there's no point in wasting
resources just to check if those have been modified, just unpack them
unconditionally.
2014-10-25 06:52:12 +02:00
Juan RP
5fe3594cb5
Make sure that modified symlinks are preserved.
...
When removing a package, symlinks owned by this package that have been
modified should be preserved, unless the force flag is set via xbps-remove(8).
2014-10-25 06:43:30 +02:00
Juan RP
b81dedb770
lib/transaction_package_replace.c: simplify.
2014-10-25 05:20:13 +02:00
Juan RP
789326cf3a
xbps_repo_sync: fix regression introduced in 87ca42f3
.
2014-10-24 11:16:24 +02:00
Juan RP
87ca42f399
Remove xdelta support: it never worked and wasn't fully implemented.
2014-10-24 11:04:51 +02:00
Juan RP
654c77df25
Switch back to uncompressed plists.
...
There's no point in slowing down read performance just to save a few bytes.
2014-10-24 10:15:41 +02:00
Juan RP
e35d0c202c
unpack: simplify pkg metadata extraction.
...
There's no need to internalize props.plist because there are no changes
compared to the pkg dictionary stored in the repo index, simply ignore it.
The code only cares for the files.plist to check for obsolete files.
2014-10-21 09:25:15 +02:00
Juan RP
627a5afaaf
Make sure that automatic/manual installation modes are set as expected.
2014-10-20 07:59:06 +02:00
Juan RP
231582e671
libxbps: make sure to not add dups in transaction for remove.
2014-10-19 11:22:17 +02:00
Juan RP
fb868454b2
libxbps: make sure to not add dups in transaction for install/update.
2014-10-19 11:00:40 +02:00
Juan RP
e884270e06
xbps_transaction_prepare: ignore pkgs that will be removed.
2014-10-18 16:07:52 +02:00
Juan RP
ff189fd210
Replaced redundant dependency sorting code with a simpler implementation.
...
This fixes the issue found by "xbps-src bootstrap" when a package
without "provides" was declared as a virtual package.
2014-10-18 12:35:47 +02:00
Juan RP
adc0643ee4
Fully switch to zplists.
2014-10-17 10:27:58 +02:00
Juan RP
b1eb62a2df
lib/package_unpack.c: switch pkg meta files to zplist too.
2014-10-17 10:23:12 +02:00
Juan RP
fc368e159d
lib/portableproplib/prop_zlib.c: use a stack buffer to process compressed chunks.
2014-10-17 10:12:12 +02:00
Juan RP
83f5e35ec7
pkgdb: switch to zplists by default.
2014-10-17 10:11:56 +02:00
Juan RP
47310d3408
lib/archive.c: remove support to read zplists in archives.
...
It was never used and the binpkgs are already compressed...
2014-10-17 10:10:16 +02:00
Juan RP
d7633e88e0
Fix #62 (Dup replaced pkgs in transaction)
2014-10-17 09:52:32 +02:00
Juan RP
1c20086896
Package remove: disable file owner checks if euid==0.
...
All package files even not owned by root should be removed, so make sure
that those checks return success while being root.
This fixes package removal for polkit, that had /etc/polkit/rules.d
files owned by the polkitd user.
2014-10-17 09:17:07 +02:00
Juan RP
fe76af7702
proplib: use GCC atomic builtins if supported.
2014-10-09 14:41:43 +02:00
Juan RP
09c630a825
lib/transaction_commit.c: CID 62740 (toctou)
2014-10-08 10:13:21 +02:00
Juan RP
513f8a2bae
lib/repo.c: CID 62757 (toctou)
2014-10-08 10:00:17 +02:00
Juan RP
805f6aa1b2
lib/repo_sync.c: CID 62763 (toctou)
2014-10-08 09:55:12 +02:00
Juan RP
0c74a5d7fe
Revert "lib/portableproplib/prop_object.c: CID 62694 (data race condition)"
...
This reverts commit dc63aed221
.
2014-10-07 11:51:53 +02:00
Juan RP
967acd82b0
lib/fetch/http.c: CID 62725 (NULL pointer dereference)
2014-10-07 11:12:04 +02:00
Juan RP
a6cdd9a698
lib/fetch/common.c: CID 62709 (NULL pointer dereference)
2014-10-07 11:07:24 +02:00
Juan RP
6e7c160195
lib/fetch/file.c: CID 62701 (NULL pointer dereference)
2014-10-07 11:02:12 +02:00
Juan RP
d434b44cfc
lib/fetch/http.c: CID 62698 (NULL pointer dereference)
2014-10-07 10:51:37 +02:00
Juan RP
dc63aed221
lib/portableproplib/prop_object.c: CID 62694 (data race condition)
2014-10-07 10:27:07 +02:00
Juan RP
9c5af90fae
lib/portableproplib/prop_object.c: CID 62703 (argument cannot be negative)
2014-10-07 10:23:02 +02:00
Juan RP
6a02cb6534
lib/portableproplib/prop_data.c: CID 62728 (integer overflowed argument)
2014-10-07 10:19:32 +02:00
Juan RP
3a71db1d0b
lib/pubkey2fp.c: fix CID 62724 correctly.
2014-10-07 09:34:14 +02:00
Juan RP
ec438c36f9
Fix 1a19adf85c
correctly.
2014-10-07 09:18:28 +02:00
Juan RP
680abe50e7
lib/fetch/ftp.c: CID 62745 (unusued value)
2014-10-07 08:25:57 +02:00
Juan RP
fe87bc1a88
lib/util.c: CID 62710 (dead code)
2014-10-07 08:16:45 +02:00
Juan RP
a730a61df9
lib/initend.c: CID 62720 (NULL pointer dereference)
2014-10-07 07:59:07 +02:00
Juan RP
4be2a0ee84
lib/pkgdb.c: CID 62719 (NULL pointer dereference)
2014-10-07 07:57:38 +02:00
Juan RP
fcf464d2fa
lib/transaction_sortdeps.c: CID 62717 (NULL pointer dereference)
2014-10-07 07:45:20 +02:00
Juan RP
1a19adf85c
lib/transaction_commit.c: CID 62716 (argument cannot be negative)
2014-10-07 07:29:58 +02:00
Juan RP
9fc6c9d70e
lib/repo.c: CID 62706 (argument cannot be negative)
2014-10-07 07:27:45 +02:00
Juan RP
3a77ab0847
lib/download.c: CID 62691 (dereference NULL check)
2014-10-06 08:23:34 +02:00
Juan RP
fae4ef0cd6
lib/pubkey2fp.c: CID 62724 (dereference NULL return value)
2014-10-06 08:17:53 +02:00
Juan RP
a6f128a578
lib/plist.c: CID 62704 (argument cannot be negative)
2014-10-05 13:22:28 +02:00
Juan RP
be256ed77b
lib/repo.c: fix CID 62783 correctly
2014-10-05 13:11:59 +02:00
Juan RP
68ef66eb51
lib/fetch/fetch.c: CID 62784 (uninitialized pointer read)
2014-10-05 13:10:05 +02:00
Juan RP
8ccb48e65b
lib/initend.c: CID 62697 (dereference before NULL check)
2014-10-05 12:55:07 +02:00
Juan RP
7310322cbf
lib/transaction_package_replace.c: CID 62693 (dereference NULL return value)
2014-10-05 12:50:50 +02:00
Juan RP
66292180a3
lib/repo.c: CID 62671 (unchecked return value)
2014-10-05 12:22:18 +02:00
Juan RP
2212a05f89
lib/download.c: CID 62696 (dead code)
2014-10-05 12:13:34 +02:00
Juan RP
44f5fb107e
lib/fetch/fetch.c: CID 62738 (unused value)
2014-10-05 12:01:25 +02:00
Juan RP
89b8c61c47
lib/package_unpack.c: remove unused var (CID 62731)
2014-10-05 11:57:20 +02:00
Juan RP
c3dc804bc0
lib/fetch/http.c: try to fix CID 62683 (resource leak)
2014-10-05 10:32:09 +02:00
Juan RP
25e8fca7b4
lib/fetch/common.c: fix CID 62681 correctly (resource leak).
2014-10-05 10:21:18 +02:00
Juan RP
23fccb17f7
lib/transaction_revdeps.c: use-after-free (CID 62765)
2014-10-05 09:18:59 +02:00
Juan RP
3378c4487d
lib/package_config_files.c: resource leak (CID 62682)
2014-10-05 09:13:03 +02:00
Juan RP
c1959b3915
lib/fetch/common.c: resource leak (CID 62681)
2014-10-05 09:08:05 +02:00
Juan RP
9d90c75fcc
lib/fetch/http.c: buffer not NUL terminated (CID 62666)
2014-10-05 09:04:16 +02:00
Juan RP
6dcac6a840
lib/transaction_sortdeps.c: resource leak (CID 62688)
2014-10-05 08:12:49 +02:00
Juan RP
b28e85bfaa
lib/repo_pkgdeps.c: resource leak (CID 62700)
2014-10-05 07:38:20 +02:00
Juan RP
0608e0057f
lib/repo.c: fix build after aa8d88272e
.
2014-10-05 07:38:14 +02:00
Juan RP
aa8d88272e
lib/repo.c: resource leak (CID 62715)
2014-10-05 07:32:43 +02:00
Juan RP
4ae3d03594
lib/transaction_revdeps.c: resource leak (CID 62723)
2014-10-05 07:29:23 +02:00
Juan RP
aae88aa253
lib/verifysig.c: resource leak (CID 62727)
2014-10-05 07:27:13 +02:00
Juan RP
dd851f18a2
lib/package_unpack.c: zero out struct (CID 62755)
2014-10-05 07:12:30 +02:00
Juan RP
96a117c558
lib/repo_pkgdeps.c: fix a double free in error branch (CID 62754)
2014-10-05 07:09:40 +02:00
Juan RP
bc9ddcfcc8
lib/initend.c: rename a var to make gcc-4.6.x happy.
2014-10-04 22:02:56 +02:00
Juan RP
2fe35a5bf3
lib/package_unpack.c: do not initialize xucd at all, unnecessary.
...
Initializing with {0} wasn't understood with gcc-4.6.x on travis-ci,
so just remove it.
2014-10-04 21:59:47 +02:00
Juan RP
742af69185
Fix libxbps/update_shlibs:shlib_bump_revdep_diff test.
...
How to reproduce it:
- A-1.0_1 provides liba.so.1
- B-1.0_1 provides libb.so.1
- C-1.0_1 requires liba.so.1 and libb.so.1
- A-2.0_1 provides liba.so.2
- C-2.0_1 required liba.so.2
This test case failed because it was checking the required shared libraries
from current installed package, rather than the updated pkg in transaction.
2014-09-29 15:25:09 +02:00
Enno Boland
42f0152dce
trans_find_pkg(): search for reverts match with correct pkgver
2014-09-28 22:22:20 +02:00
Juan RP
2711b07b77
Fix package files removal with only read bit set.
...
The previous code was checking incorrectly if the file had the write
bit set, and this is wrong because a package could have files with
only the read bit set (0444).
2014-09-28 13:33:15 +02:00
Juan RP
72cefcfc83
Introduce xbps_mmap_file() and use it in strategic points.
...
Rather than using a random buffer from stack or heap, and decide
what size to use, create a private memory mapped object...
This simplifies the code in lib/verifysig.c and xbps-create.
2014-09-27 13:00:34 +02:00
Juan RP
97045960f9
xbps_pkg_reverts: style.
2014-09-27 11:28:29 +02:00
Enno Boland
b5a169b65c
xbps_pkg_reverts: this function can do more than just return false!
2014-09-23 21:18:47 +02:00
Enno Boland
a421bf7db5
xbps_pkg_reverts: return bool instead of int.
2014-09-23 20:50:34 +02:00
Enno Boland
dbab3f2cfc
xbps_pkg_reverts: use version instead of pkgname-version to find reverts
2014-09-23 18:22:57 +02:00
Enno Boland
50fb6c1605
rename xbps_pkgver_is_reverted to xbps_pkg_reverts
2014-09-23 13:54:06 +02:00
Enno Boland
cd9a9e78a8
lib/transaction_ops.c: trans_find_pkg will check the revert field too.
...
- if a package on the repo has a lower version than installed
libxbps will check if this package reverts the one installed
and downgrades to it if so.
2014-09-23 13:54:06 +02:00
Enno Boland
18204aeac1
lib/util.c: add function which tests if a given pkgver is reverted by a given pkg.
2014-09-23 13:54:06 +02:00
Enno Boland
5bbcdf2c62
lib/util_hash.c: enlarge read buffer for xbps_file_hash to increase performance.
2014-09-18 18:34:15 +02:00
Juan RP
f52eea34d4
xbps-install: abort transaction if there's insufficient disk space on rootdir.
...
The free disk space wasn't computed correctly and xbps-install(8) wasn't
handling ENOSPC rval in xbps_transaction_prepare().
2014-09-18 12:11:02 +02:00
Juan RP
741f8fbe04
lib/util_hash.c: update copyright year.
2014-09-17 07:24:00 +02:00
Juan RP
72c64c7626
xbps_file_hash: reduce memory footprint and process file in small chunks.
...
With xbps-rindex(8) -c/-r being multithreaded, the memory usage was
insanely high in the build server, with peaks of almost 4GB (this depends
on the file size being processed and number of threads).
Process the file in small chunks instead to compute the SHA256 hash.
2014-09-17 06:50:46 +02:00
Juan RP
6894980983
lib/package_msg.c: fix a heap overflow (noticed by @Gottox).
2014-09-16 09:13:32 +02:00
Juan RP
e902619220
Remove empty self replaced pkg arrays from pkgdb.
2014-09-14 18:16:43 +02:00
Juan RP
ac2c517bd7
Fixed install/update tests on pkgs with no files.
2014-09-14 18:04:10 +02:00
Juan RP
c9514ad617
libxbps: fixed replaces/replace_vpkg test case.
2014-09-14 12:50:17 +02:00
Juan RP
2b7c4d568a
Remove pkg self replacement from pkgdb; this must not be propagated.
2014-09-13 18:14:04 +02:00
Juan RP
dea31f0a15
Add xbps_remove_{pkgname,string}_from_array() to the API.
2014-09-13 18:13:25 +02:00
Juan RP
b42c3d8498
lib/pkgdb_conversion.c: avoid copying dangling pointer if "repository-origin" is unexistent.
2014-09-13 16:59:19 +02:00
Juan RP
d67f8bdc8c
xbps_register_pkg: do not modify the transaction pkg dictionary, use a copy instead.
...
Due to not using a copy the replace tests were failing at the configure phase,
because the "transaction" object was removed.
2014-09-13 13:31:56 +02:00
Juan RP
598022a60b
xbps_transaction_commit: add more debugging to know the unconfigured pkg reason.
2014-09-13 12:21:49 +02:00
Juan RP
411480e43d
pkgdb: repository-origin -> repository to match the repo pkg obj.
2014-09-13 10:49:13 +02:00
Juan RP
287665009b
Drop unused headers.
2014-09-13 08:54:12 +02:00
Juan RP
39aca1bbc9
Implement shlib checks for all pkg revdeps in the transaction.
...
Added three new test cases to verify its correctness.
2014-09-12 11:49:34 +02:00
Juan RP
4978fe9844
lib/transaction_package_replace.c: misc optimizations.
2014-09-11 17:55:05 +02:00
Juan RP
4ab831888a
xbps_repo_sync: fix swapped args (Hi Tox!)
2014-09-11 13:38:26 +02:00
Juan RP
2207517e13
Disable best pkg matching code; see NEWS for more information.
2014-09-11 12:19:52 +02:00
Juan RP
ed6b3c00f5
xbps_entry_install_conf_file: fix non debug build.
2014-09-11 11:56:23 +02:00
Juan RP
e1124800a5
lib/repo_sync.c: xbps_fetch_file_dest() expects 4 args not 5 (hi Tox)
2014-09-11 11:51:20 +02:00
Enno Boland
4689b07b85
lib/repo_sync.c: use xbps_fetch_file_dest() instead of xbps_fetch_delta().
...
Until the generation of deltas does not work reliably just download
the repo files instead of trying to get the delta.
2014-09-11 11:39:54 +02:00
Juan RP
30ea08e605
lib/transaction_ops.c: detect updates when an exact pkg version is set.
2014-09-11 11:13:20 +02:00
Juan RP
e4ff957e42
xbps_find_pkg_orphans: fix regression adding false positives.
2014-09-11 09:05:57 +02:00
Juan RP
dba767fb05
lib/pkgdb_conversion.c: remove metafile-sha256 obj if pkg contains no files.
2014-09-11 08:18:03 +02:00
Juan RP
01dbb968dd
Welcome pkgdb-0.38.
2014-09-11 00:12:12 +02:00
Juan RP
fb9c94fab9
Added support to use pkg shlib-{provides,requires} objects.
...
This effectively checks that all pkgs in a transaction to be installed
or updated, have not unmatched shared libraries, which might happen with
pkgs that had major soname bumps.
This implementation slow downs xbps_transaction_prepare() 2x, due to
the use of xbps_pkgdb_get_pkg_metadata(). A new pkgdb format is required
that adds the pkg shlib-provides objects to pkgdb, avoiding the need
to use xbps_pkgdb_get_pkg_metadata().
2014-09-09 11:08:54 +02:00
Juan RP
c61317e219
lib/external/fexec.c: fix build with glibc>=2.20 (needs _DEFAULT_SOURCE).
2014-09-08 18:46:12 +02:00
Juan RP
b67d4ec975
lib/download.c: debug: print url info only if it's available.
2014-09-07 09:45:47 +02:00
Juan RP
8ad8bca958
xbps_rpool_foreach: take into account xbps_repo_open returning NULL.
2014-09-07 09:35:38 +02:00
Juan RP
5863ec17fe
libxbps: two new functions to get the pkgver and arch components in a filename.
...
- xbps_binpkg_pkgver() returns a heap allocated string with the pkgver component.
- xbps_binpkg_arch() returns a heap allocated string with the architecture component.
A basename, full path or relative path is supported, i.e:
/path/to/foo-1.0_1.x86_64.xbps
../../foo/blah-0.1_1.x86_64.xbps
baz-0.1_1.x86_64.xbps
2014-09-05 20:59:00 +02:00
Juan RP
e2470f8697
xbps_entry_install_conf_file: add more assertions.
2014-09-05 20:58:20 +02:00
Juan RP
685a85a466
xbps_find_pkg_orphans: also take into account virtual pkgs.
2014-09-05 13:10:50 +02:00
Juan RP
bf92d1f5a3
xbps_repo_open: open archive read-only if lock is not set.
2014-09-05 12:39:53 +02:00
Juan RP
013731c502
Acquire/release a POSIX file lock on repository archives.
...
- xbps_repo_open() accepts a third argument (bool) to acquire a POSIX file
lock on the repository archive.
- xbps_repo_close() accepts a second argument (bool) to release a POSIX file
lock on the repository archive.
This avoids the issue of multiple xbps-rindex(8) processes being blocked
even for different repositories on the same architecture, resulting in
unnecessary contention.
2014-09-05 12:26:42 +02:00
Juan RP
472f622f6f
Finally fixed vpkg02 test (vpkg provider in transaction).
...
Rather than collecting dependencies for a pkg that has been added to the
transaction dictionary, do this for all pkgs in transaction once all
packages are already there.
2014-09-04 10:13:02 +02:00
Juan RP
25e8002737
fetch: hardcode HTTPS port and fallback to /etc/services for other unknown ports.
2014-08-25 16:07:47 +02:00
Juan RP
5a1919e520
xbps_pkg_is_installed(): a pkg in "unpacked" state is now accepted as installed too.
...
The reason is that even if the pkg was not configured, it should still be accepted
as installed. If installing packages via XBPS_TARGET_ARCH, pkgs are never configured,
so this must be taken into account.
Will be cherry-picked to 0.37 meanwhile.
2014-08-23 15:54:24 +02:00
Juan RP
7cef93ce07
Added support to replace vpkgs when the real pkgname matches any installed vpkg.
2014-08-22 12:44:18 +02:00
Juan RP
3cc8929ce1
xbps_get_pkg_plist_from_binpkg: fix a double free, found by Gottox.
...
xbps-query -Rf foo without network was enough to trigger it.
2014-08-19 10:45:46 +02:00
Juan RP
fbf4ed4d2a
lib/download.c: unconstify to fix a warning.
2014-08-13 22:11:25 +02:00
Juan RP
431674d733
lib/download.c: style twerks.
2014-08-13 21:49:44 +02:00
Enno Boland
8a992372ed
lib/repo_sync.c: use xbps_fetch_delta instead of xbps_fetch_file
2014-08-11 20:01:24 +02:00
Enno Boland
b0c090c39e
lib/download.c: delete vcdiffs after applying; cleanups.
2014-08-11 20:00:20 +02:00
Enno Boland
6a8f5d6235
lib/download.c: debug output for binary diffs
2014-08-11 19:24:02 +02:00
Enno Boland
f0f8534273
lib/download.c: use tempfile while decoding new file from binary diff.
...
this prevents corrupted files when filename == basefile.
2014-08-11 19:05:23 +02:00
Enno Boland
040e114ad4
lib/download.c: add basic support for vcdiffs
2014-08-11 18:40:44 +02:00
Juan RP
df93e790a6
xbps_init: performance: do not chdir() unnecessarily for each conf file.
2014-08-01 15:30:43 +02:00
Juan RP
f8d8f91a08
Implement support to "preserve" existent on-disk files.
...
See NEWS for more information. Fix #51
2014-08-01 15:09:51 +02:00
Juan RP
fa960c2425
xbps_init: print XBPS_RELVER in debug output.
2014-08-01 10:16:33 +02:00
Juan RP
04c7647492
lib/package_unpack.c: fix a typo that made modified files to not be unpacked.
2014-07-30 18:50:43 +02:00
Juan RP
cc6f9901f1
Fix #50 (Existent files on disk might be overwritten by packages with conf_files).
2014-07-30 16:18:57 +02:00
Juan RP
e92e86c2db
Share code to show pre-remove/post-install msgs.
2014-07-27 17:39:24 +02:00
Juan RP
a28046332f
Implemented support for pre-remove and post-install messages.
...
Close #44
2014-07-27 11:24:49 +02:00
Juan RP
0a7ea3250a
lib/transaction_dictionary.c: fix rootdir free size on 32bit systems.
2014-07-18 12:44:32 +02:00
Juan RP
607f01b2f5
If statvfs() fails don't consider this a critical error; compute free space correctly.
2014-07-14 10:09:34 +02:00
Juan RP
26fca48da2
xbps-install(8): added support to list pkgs that will be downloaded from remote repos.
2014-07-14 09:30:28 +02:00
Juan RP
4356b6fd65
Abort transaction if there's not enough free space on disk.
...
Close #7 .
2014-07-13 11:45:04 +02:00
Juan RP
79fe312302
Gather proper transaction stats (take into account binpkgs in cachedir, and "preserved" pkgs).
2014-07-13 09:56:06 +02:00
Juan RP
20e5b07b8b
lib/package_conflicts.c: do not add dups unnecessarily.
2014-07-13 09:34:19 +02:00
Juan RP
d4f82b24f9
lib/repo_pkgdeps.c: conflicts are checked via xbps_transaction_prepare() already.
2014-07-12 16:27:21 +02:00
Juan RP
e35d2e9415
Revert "lib/transaction_ops.c: also check conflicts for pkgs without rdeps."
...
This reverts commit e308097af5
.
package conflicts are checked in xbps_transaction_prepare() already.
2014-07-12 16:25:12 +02:00
Juan RP
e308097af5
lib/transaction_ops.c: also check conflicts for pkgs without rdeps.
2014-07-12 09:41:37 +02:00
Juan RP
b73fb67179
lib/repo_pkgdeps.c: print what dep has been added from repos (debug).
2014-07-12 09:40:07 +02:00
Juan RP
0385812a5a
transaction_sort: if curdep == curpkg don't do any sorting, it's sorted already.
2014-07-06 09:32:06 +02:00
Juan RP
b63cc62e3d
lib/package_unpack.c: add some comments.
2014-07-02 11:30:41 +02:00
Juan RP
e60677116d
Fix #43 (xbps-install: unhelpful message for invalid dependency)
...
If a package that is going to be installed or updated contains invalid
dependencies return ENXIO and XBPS_STATE_INVALID_DEP xbps state to clients.
This improves the error messages returned to the clients when such
condition happens.
2014-07-02 10:59:25 +02:00
Juan RP
21f32a75c5
Fixed a new issue with vpkgs replacing the same vpkg they are providing.
...
Added a new testcase to verify its correctness.
2014-07-01 15:35:55 +02:00
Juan RP
510c84d3bb
libfetch: synchronized with NetBSD's pkgsrc/libfetch, preserving our changes.
2014-06-29 10:29:36 +02:00
Juan RP
be1ef74ba2
libfetch: merge NetBSD's common.c 1.29 too to reduce differences and fix a warning.
2014-06-29 10:04:07 +02:00
Juan RP
7bb36ddaa2
libfetch: fetch_close: make sure conn->ssl is valid before shutting down.
2014-06-28 12:12:03 +02:00
Juan RP
633c20a2e6
libfetch: merge TLS SNI support from NetBSD with some other random changes.
...
Close GH #41
2014-06-28 12:01:00 +02:00
Juan RP
ae2fefeced
xbps_init: remove redundant dbg printf if xbps.conf cannot be read.
2014-06-04 10:49:39 +02:00
Juan RP
6bb61adb0e
Enable syslog logging by default; updated API to use xbps_handle::flags.
2014-06-04 09:39:02 +02:00
Juan RP
7f4753f50e
Process conf files in sys/conf foo.d dirs alphabetically.
2014-06-04 08:05:18 +02:00
Juan RP
776865b548
Added support for system/config virtualpkg.d directories.
...
The system virtualpkg directory set to <rootdir>/usr/share/xbps/virtualpkg.d contains
virtualpkg configuration files (.conf/.vpkg) that can be overrided by the admin
in <rootdir>/etc/xbps/virtualpkg.d bearing the same file name.
This obsoletes the "virtualpkgdir" keyword support from the xbps configuration file.
2014-05-31 07:05:57 +02:00
Juan RP
387987b146
Make system/config repo.d paths always relative to rootdir.
2014-05-31 06:44:07 +02:00
Juan RP
ec3323dcba
lib/package_config_files.c: simplify.
2014-05-31 06:00:33 +02:00
Juan RP
23fef46e9e
Implemented GH #39
...
The system repository directory set to <prefix>/share/xbps/repo.d contains
system repository configuration files (.conf) that can be overrided by the admin
in <sysconfdir>/xbps/repo.d bearing the same file name.
2014-05-30 11:48:10 +02:00
Juan RP
399a99753d
lib/initend.c: do not crash if the include keyword resolves to unexistent files.
2014-05-29 09:30:58 +02:00
Juan RP
19d36aaf04
portableproplib: use __attribute__((unused)) to fix a unused-but-set-variable warning.
2014-05-29 08:32:14 +02:00
Juan RP
61a1d33995
xbps-install(8): implemented single pkg updates without -u, --update.
...
The -u, --update is now only necessary to perform full system updates.
Close #35 (https://github.com/voidlinux/xbps/issues/35 )
2014-05-27 11:33:45 +02:00
Juan RP
18e0524287
libxbps: optimize rootdir access/creation by checking/creating it only once.
2014-05-27 10:02:01 +02:00
Juan RP
889e5d665e
Improve 869466278b
even more; it detects installs/updates correctly now.
2014-05-22 12:19:35 +02:00
Juan RP
ac5aa94e58
lib/package_config_files.c: avoid many small heap allocs and simplify.
2014-05-22 10:52:57 +02:00
Juan RP
0e7e2c0148
lib/package_remove.c: typo fix.
2014-05-22 10:49:01 +02:00
Juan RP
350852bf76
lib/package_remove.c: avoid many small heap allocs and simplify.
2014-05-22 10:42:27 +02:00
Juan RP
0f95cf4e46
lib/package_find_obsoletes.c: avoid many heap allocs and simplify.
2014-05-22 10:41:31 +02:00
Juan RP
ea234f095f
xbps_transaction_init: small memleaks found by valgrind.
2014-05-22 10:41:07 +02:00
Juan RP
d94995eb5a
Improve 869466278b
for non virtual packages.
...
If dependency is installed but does not satisfy the requirements, mark it
as an update and not install. The commit 869466278b
changed the logic
for virtual and non virtual packages.
2014-05-18 14:24:59 +02:00
Juan RP
cafbca06e7
Imported portableproplib-0.6.4.
2014-05-17 20:25:14 +02:00
Juan RP
a3f2898ea6
Explicitly set errno to ENOENT when a pkg hasn't been found in array/dictionaries.
2014-05-17 12:36:02 +02:00
Juan RP
869466278b
Fixed a new issue with virtual packages, as reported by Gottox.
2014-05-15 22:07:10 +02:00
Juan RP
f7d1ed6ae3
lib/initend.c: fix clang warning; no need to initialize partially glob_t.
2014-05-15 17:00:29 +02:00
Enno Boland
7485659687
libxbps: use strlcpy instead of strncpy
2014-05-13 11:58:51 +02:00
Enno Boland
295cfcea76
libxbps: insert space after conditionals
2014-05-13 11:44:49 +02:00
Enno Boland
152ec0354f
libxbps: file including in xbps.conf supports relative paths.
2014-05-13 11:37:09 +02:00
Juan RP
4070255529
pkgdb: added "repository-origin" obj to know its origin repository.
2014-05-11 10:03:17 +02:00
Juan RP
1e273bf575
lib/initend.c: move prototype to the correct place.
2014-05-06 10:21:44 +02:00
Juan RP
42a569b05c
lib/initend.c: add Enno Boland to copyright.
2014-05-06 09:29:26 +02:00
Enno Boland
e5d64d6319
lib/initend.c: include now supports file globbing.
2014-05-05 23:10:18 +02:00
Juan RP
96778da60c
libxbps: detect and fix pkgs that depend on itself.
2014-04-20 18:17:23 +02:00
Juan RP
bb491e2667
libxbps: detect and ignore incorrect deps of a pkg if those are virtual pkgs.
2014-04-20 16:54:50 +02:00
Juan RP
dacbb2f22f
Fixed some warnings reported by clang.
2014-04-20 10:02:54 +02:00
Juan RP
ada3483acc
lib/repo.c: fix two memleaks in error paths found by clang.
2014-04-19 16:07:29 +02:00
Juan RP
4bc6ba2b1c
lib/package_configure.c: fix use-after-free reported by clang.
2014-04-19 15:49:02 +02:00
Juan RP
4530c79bb2
Make sure that root symlinks in void are never removed or detected as obsoletes.
...
Added/improved test cases to detect those conditions work as expected.
2014-03-31 10:16:18 +02:00