Juan RP
91b7b2fd5a
Use a sane umask(2) before unpacking package files.
...
See https://github.com/voidlinux/void-packages/issues/835
for more information.
2015-01-11 11:01:09 +01:00
Juan RP
b23855f692
xbps_repo_close: only unlock the file lock if repo was opened as such.
...
If xbps_repo_open() was called with the lock arg set, xbps_repo_close()
will now unlock the repo file lock, without the need to set it.
This avoids the need to always unlock the file lock even if it wasn't
locked previously. This also introduceds an ABI/API break, but this
way it's cleaner.
2015-01-11 09:11:38 +01:00
Juan RP
7dea05f507
xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb.
...
If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
2015-01-10 19:42:09 +01:00
Juan RP
7c153a2b15
pkgdb: disable pkgdb conversion code; 0.38 was released long ago.
2015-01-10 19:26:37 +01:00
Juan RP
ee175a2a68
Improve xbps_end() and use it before exit(3)ing.
...
- Simplify xbps_repo_open::repo_get_dict().
- Use xbps_end() in the utils where necessary.
- Make xbps_end() call xbps_pkgdb_unlock() if necessary.
- Make xbps_end() release rpool resources.
- Make xbps_end() release resources from xbps_handle.
- Fixed 90% of reported leaks (still reachable at exit) from valgrind.
That was to silence valgrind's memcheck with --leak-check=full.
2015-01-10 19:11:31 +01:00
Juan RP
8196811e2e
lib/repo.c: indent previous.
2015-01-10 12:00:36 +01:00
Juan RP
b09faadebc
xbps-{install,query}: --repository now accepts relative paths in local repos.
2015-01-10 11:59:31 +01:00
Juan RP
7b3a500139
libxbps: the provides obj now expects exact pkgver strings.
...
This reduces extra allocs and simplifies the code, which was just
there to workaround some broken pkgs anyway.
2015-01-10 07:26:23 +01:00
Juan RP
1f6a5c0e47
libxbps: detection of orphaned packages is now 66% faster.
2015-01-10 05:43:35 +01:00
Juan RP
5d7a5a646d
xbps_repo_get_pkg_revdeps: find pkg via repo_get_xxx not rpool_get_xxx.
2015-01-06 07:58:45 +01:00
Juan RP
9d582abe0f
Fixed a regression with virtual packages declared via xbps.d(5).
...
Added a new test case to verify its correctness. Somehow virtual packages
declared via xbps.d(5) were not working correctly for dependencies.
This now works as expected with vpkgs declared with and without a version
component.
2015-01-05 16:04:22 +01:00
Juan RP
eee895c6d8
Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations.
...
See the NEWS file for more information.
2014-12-31 08:51:45 +01:00
Juan RP
b513a5e15e
libfetch: misc cleanups due to nbcompat removal.
2014-12-28 03:34:36 +01:00
Juan RP
4ee6f943dd
libfetch: fix races in the cache connection code.
...
Tested by @Gottox.
2014-12-23 10:52:54 +01:00
Juan RP
6a985190aa
xbps_archive_fetch_xxx: avoid races with multiple threads in the libfetch code.
...
Protect our critical sections with a mutex for now, until libfetch
is really fixed to work correctly with multiple threads.
2014-12-22 18:18:20 +01:00
Juan RP
c8ecf4ac6c
xbps-reconfigure(8): new option -i, --ignore to ignore pkgs with -a, --all.
...
-i, --ignore can be specified multiple times and can be used to
ignore configuration of those packages while configuration of all
packages is being performed.
Close #67
2014-12-09 13:10:48 +01:00
Juan RP
16d2640df8
Files in the configuration directory have preference.
2014-12-09 12:05:18 +01:00
Juan RP
53c6a5d1d7
xbps_transaction_commit: if the pkg RSA signature is invalid print rval too.
2014-12-01 12:52:26 +01:00
Juan RP
c47beef740
xbps_transaction_commit: if pkg sha256 hash is invalid print rval.
2014-12-01 12:47:29 +01:00
Juan RP
4479bff03e
repo: if local repodata archive is incomplete, remove it.
2014-11-29 08:44:21 +01:00
Juan RP
fe9a795995
xbps-{install,query}: added -M --memory-sync option.
...
This explicitly enables the in memory fetch/store of remote repository
data archives mode, ignoring existing on-disk repodata archives.
This changes the previous behaviour of falling back to this mode if no
on-disk repodata archives were found.
Thanks to @Gottox and @dominikh for comments.
2014-11-27 10:42:05 +01:00
Juan RP
7401ea3e64
Added support to fetch remote repodata on the fly.
...
See the NEWS file for more information.
2014-11-26 16:07:16 +01:00
Juan RP
89d11e871f
xbps-{install,query}: added -i to ignore repos defined in xbps.d.
...
See the NEWS file for more information.
2014-11-21 10:56:41 +01:00
Juan RP
1789e527a9
Gratuitous ABI break: xbps_binpkg_get_xxx() -> xbps_archive_fetch_xxx().
2014-11-21 09:51:57 +01:00
Juan RP
1bae26606e
Introduce xbps_{pkgdb,rpool}_get_pkg_fulldeptree().
...
These routines return a xbps_array_t with a full sorted dependency graph
for the target pkg, by querying pkgdb or rpool.
Update xbps-query(8) to use the new libxbps API.
2014-11-20 09:23:51 +01:00
Juan RP
eb90fcc50c
xbps_binpkg_{arch,pkgver}: return a buffer of matched string instead.
...
... otherwise will pass an invalid pointer to free(3) later on.
2014-11-19 11:56:16 +01:00
Juan RP
428a747fad
Fix #69 (No way to set globally a custom architecture)
...
The "architecture" configuration keyword is now available to override
the native machine architecture returned by (uname(2)).
The XBPS_ARCH environment variable still has preference.
2014-11-19 11:36:09 +01:00
Juan RP
b2bc7af66e
Fix #68 (xbps_binpkg_arch() asserts if arch contains a dash)
2014-11-19 11:14:37 +01:00
Juan RP
c549252223
xbps_pkg_version: minor optimization.
2014-11-18 16:11:43 +01:00
Juan RP
77c6c3e504
Introduce xbps_binpkg_get_file_into_fd() and use it for xbps-query(8) --cat.
...
This allows you to print to stdout any file stored in a binary package,
locally or remotely!
$ xbps-query -R --cat=/usr/bin/ls coreutils > ls
$ file ls
ls: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=7a195fc46d1d5cdca32bfccd3b30f81784e342ed, stripped
$
2014-11-17 18:43:08 +01:00
Juan RP
a6516505e9
xbps-query(8: added --cat=FILE mode support.
...
- This mode prints to stdout the matching FILE stored in a binary package.
- ABI break: renamed xbps_get_pkg_plist_from_binpkg() xbps_binpkg_get_plist().
- Added xbps_binpkg_get_file() as a generic way to get pkg file contents.
- Removed useless comments from xbps_api_impl.h.
2014-11-17 15:45:46 +01:00
Juan RP
3afb9d709d
Get rid of repodata index-files; the archive is now 8x smaller.
...
See the NEWS file for more information.
2014-11-13 17:09:43 +01:00
Juan RP
2153c87464
lib/portableproplib/prop_array.c: comment out another debug printf.
2014-11-13 15:22:58 +01:00
Juan RP
3290df5d62
lib/portableproplib/prop_array.c: comment out a debug printf.
2014-11-13 15:22:13 +01:00
Juan RP
43c9497feb
Introduce xbps_array_add_first() to insert obj at the head of array.
...
The behaviour of this routine mimics the existing xbps_array_add() with
the difference that stored objects are moved to the right to insert
our object as the first element on the array.
Use this to add replaced packages in the transaction array at the head
rather than at the end, to preserve the proper sorting order.
2014-11-13 15:18:21 +01:00
Juan RP
74c30556fc
xbps_transaction_prepare: check for unresolved shlibs a bit early.
...
It's just better if we check for unresolved shlibs earlier because
the transaction array will be smaller if there are replaced packages.
2014-11-13 11:39:20 +01:00
Juan RP
04bde70969
xbps_init: print bestmatching value.
2014-11-07 10:18:01 +01:00
Juan RP
53f13d579e
Added the "bestmatching" configuration keyword to enable pkg best matching.
...
See the NEWS file for more information.
2014-11-07 10:07:51 +01:00
Juan RP
6c76f6786d
xbps_repo_open: do not create repodata file in locked mode.
...
... we want a proper errno value (ENOENT) if the archive does not exist.
2014-11-06 11:38:55 +01:00
Juan RP
5b522109f7
Replaced config/system {repo,preserve,virtualpkg}.d with a single directory.
...
See the NEWS file for more information.
2014-11-06 09:58:04 +01:00
Juan RP
9566a0e737
Re-add support for system virtualpkg.d (XBPS_SYS_VPKG_PATH).
...
This is still useful to set distro defaults for virtual packages, with
the option to override them via /etc/xbps/virtualpkg.d.
2014-11-05 09:40:32 +01:00
Juan RP
595136704e
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d).
...
Binary packages do not need to provide those virtualpkg configuration files
anymore; all vpkg info is now collected from pkgdb.
2014-11-04 11:17:27 +01:00
Juan RP
5dba1108d1
lib/package_remove.c: simplify link relative check.
2014-10-25 10:32:58 +02:00
Juan RP
ff3960696f
lib/package_remove.c: fix a memleak.
2014-10-25 08:08:04 +02:00
Juan RP
e75beec76f
unpack: get rid of code that checks for modified symlinks.
...
Unpacking those symlinks is so cheap that there's no point in wasting
resources just to check if those have been modified, just unpack them
unconditionally.
2014-10-25 06:52:12 +02:00
Juan RP
5fe3594cb5
Make sure that modified symlinks are preserved.
...
When removing a package, symlinks owned by this package that have been
modified should be preserved, unless the force flag is set via xbps-remove(8).
2014-10-25 06:43:30 +02:00
Juan RP
b81dedb770
lib/transaction_package_replace.c: simplify.
2014-10-25 05:20:13 +02:00
Juan RP
789326cf3a
xbps_repo_sync: fix regression introduced in 87ca42f3
.
2014-10-24 11:16:24 +02:00
Juan RP
87ca42f399
Remove xdelta support: it never worked and wasn't fully implemented.
2014-10-24 11:04:51 +02:00
Juan RP
654c77df25
Switch back to uncompressed plists.
...
There's no point in slowing down read performance just to save a few bytes.
2014-10-24 10:15:41 +02:00
Juan RP
e35d0c202c
unpack: simplify pkg metadata extraction.
...
There's no need to internalize props.plist because there are no changes
compared to the pkg dictionary stored in the repo index, simply ignore it.
The code only cares for the files.plist to check for obsolete files.
2014-10-21 09:25:15 +02:00
Juan RP
627a5afaaf
Make sure that automatic/manual installation modes are set as expected.
2014-10-20 07:59:06 +02:00
Juan RP
231582e671
libxbps: make sure to not add dups in transaction for remove.
2014-10-19 11:22:17 +02:00
Juan RP
fb868454b2
libxbps: make sure to not add dups in transaction for install/update.
2014-10-19 11:00:40 +02:00
Juan RP
e884270e06
xbps_transaction_prepare: ignore pkgs that will be removed.
2014-10-18 16:07:52 +02:00
Juan RP
ff189fd210
Replaced redundant dependency sorting code with a simpler implementation.
...
This fixes the issue found by "xbps-src bootstrap" when a package
without "provides" was declared as a virtual package.
2014-10-18 12:35:47 +02:00
Juan RP
adc0643ee4
Fully switch to zplists.
2014-10-17 10:27:58 +02:00
Juan RP
b1eb62a2df
lib/package_unpack.c: switch pkg meta files to zplist too.
2014-10-17 10:23:12 +02:00
Juan RP
fc368e159d
lib/portableproplib/prop_zlib.c: use a stack buffer to process compressed chunks.
2014-10-17 10:12:12 +02:00
Juan RP
83f5e35ec7
pkgdb: switch to zplists by default.
2014-10-17 10:11:56 +02:00
Juan RP
47310d3408
lib/archive.c: remove support to read zplists in archives.
...
It was never used and the binpkgs are already compressed...
2014-10-17 10:10:16 +02:00
Juan RP
d7633e88e0
Fix #62 (Dup replaced pkgs in transaction)
2014-10-17 09:52:32 +02:00
Juan RP
1c20086896
Package remove: disable file owner checks if euid==0.
...
All package files even not owned by root should be removed, so make sure
that those checks return success while being root.
This fixes package removal for polkit, that had /etc/polkit/rules.d
files owned by the polkitd user.
2014-10-17 09:17:07 +02:00
Juan RP
fe76af7702
proplib: use GCC atomic builtins if supported.
2014-10-09 14:41:43 +02:00
Juan RP
09c630a825
lib/transaction_commit.c: CID 62740 (toctou)
2014-10-08 10:13:21 +02:00
Juan RP
513f8a2bae
lib/repo.c: CID 62757 (toctou)
2014-10-08 10:00:17 +02:00
Juan RP
805f6aa1b2
lib/repo_sync.c: CID 62763 (toctou)
2014-10-08 09:55:12 +02:00
Juan RP
0c74a5d7fe
Revert "lib/portableproplib/prop_object.c: CID 62694 (data race condition)"
...
This reverts commit dc63aed221
.
2014-10-07 11:51:53 +02:00
Juan RP
967acd82b0
lib/fetch/http.c: CID 62725 (NULL pointer dereference)
2014-10-07 11:12:04 +02:00
Juan RP
a6cdd9a698
lib/fetch/common.c: CID 62709 (NULL pointer dereference)
2014-10-07 11:07:24 +02:00
Juan RP
6e7c160195
lib/fetch/file.c: CID 62701 (NULL pointer dereference)
2014-10-07 11:02:12 +02:00
Juan RP
d434b44cfc
lib/fetch/http.c: CID 62698 (NULL pointer dereference)
2014-10-07 10:51:37 +02:00
Juan RP
dc63aed221
lib/portableproplib/prop_object.c: CID 62694 (data race condition)
2014-10-07 10:27:07 +02:00
Juan RP
9c5af90fae
lib/portableproplib/prop_object.c: CID 62703 (argument cannot be negative)
2014-10-07 10:23:02 +02:00
Juan RP
6a02cb6534
lib/portableproplib/prop_data.c: CID 62728 (integer overflowed argument)
2014-10-07 10:19:32 +02:00
Juan RP
3a71db1d0b
lib/pubkey2fp.c: fix CID 62724 correctly.
2014-10-07 09:34:14 +02:00
Juan RP
ec438c36f9
Fix 1a19adf85c
correctly.
2014-10-07 09:18:28 +02:00
Juan RP
680abe50e7
lib/fetch/ftp.c: CID 62745 (unusued value)
2014-10-07 08:25:57 +02:00
Juan RP
fe87bc1a88
lib/util.c: CID 62710 (dead code)
2014-10-07 08:16:45 +02:00
Juan RP
a730a61df9
lib/initend.c: CID 62720 (NULL pointer dereference)
2014-10-07 07:59:07 +02:00
Juan RP
4be2a0ee84
lib/pkgdb.c: CID 62719 (NULL pointer dereference)
2014-10-07 07:57:38 +02:00
Juan RP
fcf464d2fa
lib/transaction_sortdeps.c: CID 62717 (NULL pointer dereference)
2014-10-07 07:45:20 +02:00
Juan RP
1a19adf85c
lib/transaction_commit.c: CID 62716 (argument cannot be negative)
2014-10-07 07:29:58 +02:00
Juan RP
9fc6c9d70e
lib/repo.c: CID 62706 (argument cannot be negative)
2014-10-07 07:27:45 +02:00
Juan RP
3a77ab0847
lib/download.c: CID 62691 (dereference NULL check)
2014-10-06 08:23:34 +02:00
Juan RP
fae4ef0cd6
lib/pubkey2fp.c: CID 62724 (dereference NULL return value)
2014-10-06 08:17:53 +02:00
Juan RP
a6f128a578
lib/plist.c: CID 62704 (argument cannot be negative)
2014-10-05 13:22:28 +02:00
Juan RP
be256ed77b
lib/repo.c: fix CID 62783 correctly
2014-10-05 13:11:59 +02:00
Juan RP
68ef66eb51
lib/fetch/fetch.c: CID 62784 (uninitialized pointer read)
2014-10-05 13:10:05 +02:00
Juan RP
8ccb48e65b
lib/initend.c: CID 62697 (dereference before NULL check)
2014-10-05 12:55:07 +02:00
Juan RP
7310322cbf
lib/transaction_package_replace.c: CID 62693 (dereference NULL return value)
2014-10-05 12:50:50 +02:00
Juan RP
66292180a3
lib/repo.c: CID 62671 (unchecked return value)
2014-10-05 12:22:18 +02:00
Juan RP
2212a05f89
lib/download.c: CID 62696 (dead code)
2014-10-05 12:13:34 +02:00
Juan RP
44f5fb107e
lib/fetch/fetch.c: CID 62738 (unused value)
2014-10-05 12:01:25 +02:00
Juan RP
89b8c61c47
lib/package_unpack.c: remove unused var (CID 62731)
2014-10-05 11:57:20 +02:00
Juan RP
c3dc804bc0
lib/fetch/http.c: try to fix CID 62683 (resource leak)
2014-10-05 10:32:09 +02:00
Juan RP
25e8fca7b4
lib/fetch/common.c: fix CID 62681 correctly (resource leak).
2014-10-05 10:21:18 +02:00
Juan RP
23fccb17f7
lib/transaction_revdeps.c: use-after-free (CID 62765)
2014-10-05 09:18:59 +02:00
Juan RP
3378c4487d
lib/package_config_files.c: resource leak (CID 62682)
2014-10-05 09:13:03 +02:00
Juan RP
c1959b3915
lib/fetch/common.c: resource leak (CID 62681)
2014-10-05 09:08:05 +02:00