emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,785 Commits 1 Branch 0 Tags 11 MiB
d9f56c9cdf
Commit Graph

1236 Commits

Author SHA1 Message Date
Juan RP
36026451ce Fix some insecure temporary files reported by Coverity. 2015-07-26 09:02:04 +02:00
Juan RP
78f9a97980 lib/package_unpack: ignore remove(2) return value (CID #98681). 2015-07-26 08:22:27 +02:00
Juan RP
28f01b3836 xbps_transaction_package_replace: fix a resource leak (CID #98688). 2015-07-26 08:15:07 +02:00
Juan RP
0b7093e108 portableproplib/prop_object: handle possible NULL pointer deref (CID #62722). 2015-07-26 08:10:26 +02:00
Juan RP
a8d2b1d742 pkgdb: handle possible NULL pointer derefs (CID #98684). 2015-07-26 08:08:05 +02:00
Juan RP
7edabe907f xbps_rpool_release: fix a double free (CID #98695). 2015-07-26 08:03:16 +02:00
Juan RP
090464e4b2 xbps_sanitize_path: fix an out-of-bounds access (CID #98686). 2015-07-26 08:01:29 +02:00
Wolfgang Draxinger
47b5eea0f6 set umask for pkgdb creation/access so that pkgdb remains readable for world, even if xbps tools have been called with a very restrictive umask 2015-07-19 11:47:09 +02:00
Juan RP
a7378f70de fetch: fix regression introduced in 791e683e. 
us->size and us->{a,m}time must be set after there's real data.
 2015-06-30 21:48:21 +02:00
Juan RP
22ffc14026 Override and use a sane umask when performing pkg configuration. 
Close #106
 2015-06-28 05:14:02 +02:00
Juan RP
791e683e01 fetch: handle GET with offset == length. 
While xbps_fetch_file() creates the .part file and for whatever reason
it did not finish properly to rename the file, it could request the server
to restart the download with offset set to file size, resulting in HTTP 416
return code.

Handle this case by checking if the server returns 416 and then checking
if the returned file size matches the requested offset and just rename
the file.

Thanks to @beefcurtains for the test case.
 2015-06-28 04:28:55 +02:00
Juan RP
00149d0f37 xbps_transaction_prepare: if ENOSPC, keep the transaction dictionary. 
... we need this in xbps-install to print required/free space on rootfs.

Close #101
 2015-06-20 09:48:21 +02:00
Juan RP
1774d17e40 Keep /usr/sbin if found as obsolete, it's a symlink in void. 2015-06-05 08:29:05 +02:00
Juan RP
87fcc7d6a8 If pkg signature verification files, remove pkg archive and its signature file. 2015-06-04 09:59:52 +02:00
Juan RP
92c07c126f xbps_repo_lock: sleep() for a second if the lock is already taken. 
... rather than looping continuously.
 2015-06-04 08:08:40 +02:00
Juan RP
07e8330936 xbps-install(1): added -U --unpack-only to only unpack pkgs, skips configuration. 2015-06-03 11:15:11 +02:00
Juan RP
c464874c1e unpack: make sure the xucd callbacks don't get a dangling pointer. 
If the current entry filename has been changed, the pointer must be updated
to point to the updated string.
 2015-05-28 10:39:39 +02:00
Juan RP
769a997afb Introduce xbps_plist_{array,dictionary}_from_file(). 
Those are a wrapper around xbps_{array,dictionary}_internalize_from_zfile()
that prints a debugging msg when the plist file cannot be internalized.

Update xbps to use these wrappers.
 2015-05-28 10:15:05 +02:00
Juan RP
2ba31e048a proplib: check for EOF a bit early on the internalized plist. 2015-05-28 09:34:03 +02:00
Juan RP
fd30a00cb4 proplib: fix a NULL pointer dereference when internalizing empty blobs. 
_prop_object_internalize_context_alloc: make sure that passed xml string
is not NULL before derefering it a bit later.
 2015-05-28 09:14:28 +02:00
Juan RP
4fdc8de9d6 repo: make index and index-meta dicts immutable. 
For clients that want to modify its content they will need to copy a mutable
dictionary instead. This will avoid unwanted modifications.
 2015-05-22 12:19:48 +02:00
Juan RP
5e97a1eb39 xbps_pkgdb_update: return EINVAL if pkgdb cannot be internalized. 2015-05-22 12:18:54 +02:00
Juan RP
da74e3dd9e libxbps: stop and error out if pkg signature is not valid. 2015-05-09 06:27:03 +02:00
Juan RP
c5d6556c50 xbps-remove: fix #95 (xbps-remove -R pkg lists/removes orphans) 2015-05-06 17:21:13 +02:00
Juan RP
ea364affc8 libxbps: open fds with O_CLOEXEC to avoid warnings of leaked fds. 2015-04-15 21:02:38 +02:00
Juan RP
15893caf0b fetch: support keep-alive even if the HTTP server returns 304 (Not-Modified). 2015-04-13 12:05:40 +02:00
Juan RP
2216c84eca libxbps: continue updating all pkgs if xbps is uptodate. 2015-03-29 11:06:18 +02:00
Juan RP
83ade39960 xbps now autoupdates itself exclusively if there's an update. 
That was added for 0.21, but for some reason that I cannot remember it was
disabled a bit later... looks like it's useful to have.
 2015-03-29 09:56:28 +02:00
Juan RP
9a16283575 Introduce xbps_repo_{un,}lock() to serialize write access to repodata. 
We use a simple file lock that is created with O_CREAT|O_EXCL.
This should fix the concurrency issues with multiple processes
running xbps-rindex -a/-c on the same repository/arch combo.
 2015-03-25 12:00:59 +01:00
Juan RP
dc47dfd593 xbps_get_pkg_fulldeptree: detect pkgs depending on itself via virtual pkgs. 
Reported by Duncan Overbrook.

Update NEWS with recent changes.
 2015-03-20 08:03:06 +01:00
Juan RP
f9b6dd9d2d proplib: anonymous mappings need MAP_ANON. 
Somehow I removed this accidentally in a previous change... sigh.
 2015-03-11 17:06:45 +01:00
Juan RP
95d650bdb1 lib/transaction_shlibs.c: add a printf to see what's going on. 2015-03-07 08:02:39 +01:00
Juan RP
441f147f05 Fix reinstallation of pkgs in repolock mode. 
At the time we've been searching for the pkg in a repo, no repos
were registered resulting in EINVAL. While here, if there's no
declared repos return ENOENT instead.
 2015-03-05 21:23:58 +01:00
Juan RP
4922c808f4 Implemented feature #77 (Add package repository locked mode) 
Close #77
 2015-03-03 12:11:28 +01:00
Juan RP
976718417b libxbps: remove "skip-obsoletes" handling; unnecessary with the mtime checks. 2015-02-26 19:51:03 +01:00
Juan RP
b6b446d32e libxbps: properly detect obsolete files with files being between pkgs. 
120 test cases now successfully pass, and all known issues about
pkg updates that move files between them should be gone (hopefully).
 2015-02-26 19:37:46 +01:00
Juan RP
cbe493858c libxbps: apply file timestamps to unmodified files on-disk while unpacking. 2015-02-25 11:10:18 +01:00
Juan RP
b133b9023c lib/package_unpack.c: wrap some long lines and fix an obvious error. 2015-02-24 09:34:39 +01:00
Juan RP
7e21f1ee1a xbps_symlink_target: rename var to avoid shadowing a global var. 2015-02-19 11:44:10 +01:00
Juan RP
9083191e4b xbps_symlink_target: double free in rootdir == '/' case. 2015-02-19 11:39:59 +01:00
Juan RP
6d65e76f91 xbps_symlink_target: fix a memleak. 2015-02-19 11:36:09 +01:00
Juan RP
a05e039cce Revert "Stop converting relative symlinks to absolute." 
This reverts commit 9ae3638429.

This change is ok, but cannot be used right now because all existing
binpkgs were created with an old xbps-create(8).
 2015-02-19 11:11:58 +01:00
Juan RP
9ae3638429 Stop converting relative symlinks to absolute. 
There's no reason to make them absolute, simply store in the metadata
the target file as is. This vastly simplifies the code and makes all
test pass correctly.
 2015-02-19 11:04:34 +01:00
Juan RP
67eba7d912 Improve detection of target file in relative symlinks. 
If xbps-create(8) did not guess the target file of relative symlinks for
some reason, just compare the current symlink and what's stored as is,
without converting it to absolute.

This might happen with dangling relative symlinks or existing binary
packages that were not created with a newer xbps-create(8).
 2015-02-19 10:24:24 +01:00
Juan RP
05f879ec09 Introduce xbps_symlink_target() and use it in two places. 
This code is now shared by xbps-pkgdb and libxbps/xbps-remove.
 2015-02-19 09:47:09 +01:00
Juan RP
1722635e08 Introduce xbps_sanitize_path() to fix #78 properly. 
This removes multiple slashes of a path and returns you a buffer with
the sanitized string.
 2015-02-18 15:12:39 +01:00
Juan RP
628a344560 libxbps: fix a memleak introduced in 1403826fa. 2015-02-17 16:39:04 +01:00
Juan RP
1403826fa6 libxbps: detect and remove properly symlinks with relative targets. 
Close #78
 2015-02-17 11:59:05 +01:00
Juan RP
0fc297a471 lib/transaction_ops.c: minor optimization. 2015-02-16 11:18:58 +01:00
Juan RP
2aa844f3f7 lib/Makefile: remove some disabled warnings for lib{fetch,portableproplib}. 
There's no need to set _GNU_SOURCE and disable those compiler warning flags.
 2015-02-15 05:47:35 +01:00
Juan RP
b8b4694b33 portableproplib: use posix_madvise rather than madvise. 
The posix variant is the standardized version of madvise.
 2015-02-15 05:42:18 +01:00
Juan RP
4e0ce0fbb4 libxbps: make the vpkg_provider_and_revdeps_downgrade test case work. 2015-02-10 10:55:05 +01:00
Juan RP
1ebb245672 xbps_transaction_store: print repo too. 2015-02-05 10:26:53 +01:00
Juan RP
c0d7d930de libxbps: make sure that revdeps of vpkg providers are always resolved. 
Added new test cases to verify its correctness in upgrades and removals.
 2015-02-05 10:04:42 +01:00
Juan RP
d607655371 libxbps: globally check for unresolved reverse dependencies. 
Close #46. See NEWS for more information.
 2015-02-03 10:20:13 +01:00
Juan RP
3bc6354550 lib/repo_pkgdeps.c: fix some debug printfs. 2015-02-02 09:37:34 +01:00
Juan RP
076b3f8c44 libxbps: add pkgs on hold mode to the transaction, but ignore them. 
Those are there mostly to be shown by the clients and notify that
there's an update in repos that is being ignored.

Idea by @chneukirchen.
 2015-01-28 12:07:47 +01:00
Juan RP
571d96fa92 libxbps: make sure to remove pkg metadata file on upgrades with skip-obsoletes. 
This fixes the following case:

 - A-1.0_1 is installed and owns bin/foo.
 - A-1.1_1 is in the transaction and depends on B-1.0_1 that owns bin/foo.
 - B-1.0_1 is in the transaction and replaces A<1.1_1.
 - A-1.1_1 in the transaction now has "skip-obsoletes".
 - A is updated to 1.1_1, its metadata file (<pkgname>-files.plist) wasn't removed.

Added two new test cases to verify moving files from/to a dependency.
 2015-01-27 17:53:37 +01:00
Juan RP
cbf1cfe0f5 libxbps: improve debug messages again. 2015-01-21 11:39:45 +01:00
Juan RP
b7fd0dcac5 xbps_transaction_shlibs: take into account shlibs from pkgs in the transaction. 2015-01-18 12:44:26 +01:00
Juan RP
f9eef6aa0d Perform global tracking of unresolved shlibs before accepting transaction. 
Rather than checking per package being installed or updated, check
all installed packages to have all its shlib-requires resolved.
 2015-01-18 10:23:52 +01:00
Juan RP
d11230a29d libxbps: abort pkg unpacking as soon as a file cannot be written. 
Close #74
 2015-01-18 10:22:05 +01:00
Juan RP
bce27b968e xbps_find_*pkg_in_array: fix logic when transaction obj string matches. 2015-01-17 06:04:22 +01:00
Juan RP
e438aae13c transaction_revdeps.c: remove dead code. 2015-01-14 21:00:37 +01:00
Juan RP
8263449f94 xbps_end: don't bother releasing everything; pkgdb is enough. 
xbps-query -L now: 115ms
xbps-query -L before: 148ms

Fuck you valgrind!
 2015-01-14 18:43:17 +01:00
Juan RP
a651f33832 xbps_pkgdb_release: don't bother releasing everything. 2015-01-14 17:34:00 +01:00
Juan RP
91b7b2fd5a Use a sane umask(2) before unpacking package files. 
See https://github.com/voidlinux/void-packages/issues/835
for more information.
 2015-01-11 11:01:09 +01:00
Juan RP
b23855f692 xbps_repo_close: only unlock the file lock if repo was opened as such. 
If xbps_repo_open() was called with the lock arg set, xbps_repo_close()
will now unlock the repo file lock, without the need to set it.

This avoids the need to always unlock the file lock even if it wasn't
locked previously. This also introduceds an ABI/API break, but this
way it's cleaner.
 2015-01-11 09:11:38 +01:00
Juan RP
7dea05f507 xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb. 
If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
 2015-01-10 19:42:09 +01:00
Juan RP
7c153a2b15 pkgdb: disable pkgdb conversion code; 0.38 was released long ago. 2015-01-10 19:26:37 +01:00
Juan RP
ee175a2a68 Improve xbps_end() and use it before exit(3)ing. 
- Simplify xbps_repo_open::repo_get_dict().
- Use xbps_end() in the utils where necessary.
- Make xbps_end() call xbps_pkgdb_unlock() if necessary.
- Make xbps_end() release rpool resources.
- Make xbps_end() release resources from xbps_handle.
- Fixed 90% of reported leaks (still reachable at exit) from valgrind.

That was to silence valgrind's memcheck with --leak-check=full.
 2015-01-10 19:11:31 +01:00
Juan RP
8196811e2e lib/repo.c: indent previous. 2015-01-10 12:00:36 +01:00
Juan RP
b09faadebc xbps-{install,query}: --repository now accepts relative paths in local repos. 2015-01-10 11:59:31 +01:00
Juan RP
7b3a500139 libxbps: the provides obj now expects exact pkgver strings. 
This reduces extra allocs and simplifies the code, which was just
there to workaround some broken pkgs anyway.
 2015-01-10 07:26:23 +01:00
Juan RP
1f6a5c0e47 libxbps: detection of orphaned packages is now 66% faster. 2015-01-10 05:43:35 +01:00
Juan RP
5d7a5a646d xbps_repo_get_pkg_revdeps: find pkg via repo_get_xxx not rpool_get_xxx. 2015-01-06 07:58:45 +01:00
Juan RP
9d582abe0f Fixed a regression with virtual packages declared via xbps.d(5). 
Added a new test case to verify its correctness. Somehow virtual packages
declared via xbps.d(5) were not working correctly for dependencies.

This now works as expected with vpkgs declared with and without a version
component.
 2015-01-05 16:04:22 +01:00
Juan RP
eee895c6d8 Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations. 
See the NEWS file for more information.
 2014-12-31 08:51:45 +01:00
Juan RP
b513a5e15e libfetch: misc cleanups due to nbcompat removal. 2014-12-28 03:34:36 +01:00
Juan RP
4ee6f943dd libfetch: fix races in the cache connection code. 
Tested by @Gottox.
 2014-12-23 10:52:54 +01:00
Juan RP
6a985190aa xbps_archive_fetch_xxx: avoid races with multiple threads in the libfetch code. 
Protect our critical sections with a mutex for now, until libfetch
is really fixed to work correctly with multiple threads.
 2014-12-22 18:18:20 +01:00
Juan RP
c8ecf4ac6c xbps-reconfigure(8): new option -i, --ignore to ignore pkgs with -a, --all. 
-i, --ignore can be specified multiple times and can be used to
ignore configuration of those packages while configuration of all
packages is being performed.

Close #67
 2014-12-09 13:10:48 +01:00
Juan RP
16d2640df8 Files in the configuration directory have preference. 2014-12-09 12:05:18 +01:00
Juan RP
53c6a5d1d7 xbps_transaction_commit: if the pkg RSA signature is invalid print rval too. 2014-12-01 12:52:26 +01:00
Juan RP
c47beef740 xbps_transaction_commit: if pkg sha256 hash is invalid print rval. 2014-12-01 12:47:29 +01:00
Juan RP
4479bff03e repo: if local repodata archive is incomplete, remove it. 2014-11-29 08:44:21 +01:00
Juan RP
fe9a795995 xbps-{install,query}: added -M --memory-sync option. 
This explicitly enables the in memory fetch/store of remote repository
data archives mode, ignoring existing on-disk repodata archives.

This changes the previous behaviour of falling back to this mode if no
on-disk repodata archives were found.

Thanks to @Gottox and @dominikh for comments.
 2014-11-27 10:42:05 +01:00
Juan RP
7401ea3e64 Added support to fetch remote repodata on the fly. 
See the NEWS file for more information.
 2014-11-26 16:07:16 +01:00
Juan RP
89d11e871f xbps-{install,query}: added -i to ignore repos defined in xbps.d. 
See the NEWS file for more information.
 2014-11-21 10:56:41 +01:00
Juan RP
1789e527a9 Gratuitous ABI break: xbps_binpkg_get_xxx() -> xbps_archive_fetch_xxx(). 2014-11-21 09:51:57 +01:00
Juan RP
1bae26606e Introduce xbps_{pkgdb,rpool}_get_pkg_fulldeptree(). 
These routines return a xbps_array_t with a full sorted dependency graph
for the target pkg, by querying pkgdb or rpool.

Update xbps-query(8) to use the new libxbps API.
 2014-11-20 09:23:51 +01:00
Juan RP
eb90fcc50c xbps_binpkg_{arch,pkgver}: return a buffer of matched string instead. 
... otherwise will pass an invalid pointer to free(3) later on.
 2014-11-19 11:56:16 +01:00
Juan RP
428a747fad Fix #69 (No way to set globally a custom architecture) 
The "architecture" configuration keyword is now available to override
the native machine architecture returned by (uname(2)).

The XBPS_ARCH environment variable still has preference.
 2014-11-19 11:36:09 +01:00
Juan RP
b2bc7af66e Fix #68 (xbps_binpkg_arch() asserts if arch contains a dash) 2014-11-19 11:14:37 +01:00
Juan RP
c549252223 xbps_pkg_version: minor optimization. 2014-11-18 16:11:43 +01:00
Juan RP
77c6c3e504 Introduce xbps_binpkg_get_file_into_fd() and use it for xbps-query(8) --cat. 
This allows you to print to stdout any file stored in a binary package,
locally or remotely!

$ xbps-query -R --cat=/usr/bin/ls coreutils > ls
$ file ls
ls: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=7a195fc46d1d5cdca32bfccd3b30f81784e342ed, stripped
$
 2014-11-17 18:43:08 +01:00
Juan RP
a6516505e9 xbps-query(8: added --cat=FILE mode support. 
- This mode prints to stdout the matching FILE stored in a binary package.
- ABI break: renamed xbps_get_pkg_plist_from_binpkg() xbps_binpkg_get_plist().
- Added xbps_binpkg_get_file() as a generic way to get pkg file contents.
- Removed useless comments from xbps_api_impl.h.
 2014-11-17 15:45:46 +01:00
Juan RP
3afb9d709d Get rid of repodata index-files; the archive is now 8x smaller. 
See the NEWS file for more information.
 2014-11-13 17:09:43 +01:00
Juan RP
2153c87464 lib/portableproplib/prop_array.c: comment out another debug printf. 2014-11-13 15:22:58 +01:00
Juan RP
3290df5d62 lib/portableproplib/prop_array.c: comment out a debug printf. 2014-11-13 15:22:13 +01:00