5b43614e80
While looking for dependencies, we need to check if xbps_rpool_get_pkg() returned a suitable match; and then validate its result. This fixes the update_and_install test case that was reverted via #218.
452 lines
14 KiB
C
452 lines
14 KiB
C
/*-
|
|
* Copyright (c) 2008-2016 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
|
|
#include "xbps_api_impl.h"
|
|
|
|
static int
|
|
add_missing_reqdep(struct xbps_handle *xhp, const char *reqpkg)
|
|
{
|
|
xbps_array_t mdeps;
|
|
xbps_object_iterator_t iter = NULL;
|
|
xbps_object_t obj;
|
|
unsigned int idx = 0;
|
|
bool add_pkgdep, pkgfound, update_pkgdep;
|
|
int rv = 0;
|
|
|
|
assert(reqpkg != NULL);
|
|
|
|
add_pkgdep = update_pkgdep = pkgfound = false;
|
|
mdeps = xbps_dictionary_get(xhp->transd, "missing_deps");
|
|
|
|
iter = xbps_array_iterator(mdeps);
|
|
if (iter == NULL)
|
|
goto out;
|
|
|
|
while ((obj = xbps_object_iterator_next(iter)) != NULL) {
|
|
const char *curdep, *curver, *pkgver;
|
|
char *curpkgnamedep = NULL, *pkgnamedep = NULL;
|
|
|
|
assert(xbps_object_type(obj) == XBPS_TYPE_STRING);
|
|
curdep = xbps_string_cstring_nocopy(obj);
|
|
curver = xbps_pkgpattern_version(curdep);
|
|
pkgver = xbps_pkgpattern_version(reqpkg);
|
|
if (curver == NULL || pkgver == NULL)
|
|
goto out;
|
|
curpkgnamedep = xbps_pkgpattern_name(curdep);
|
|
if (curpkgnamedep == NULL)
|
|
goto out;
|
|
pkgnamedep = xbps_pkgpattern_name(reqpkg);
|
|
if (pkgnamedep == NULL) {
|
|
free(curpkgnamedep);
|
|
goto out;
|
|
}
|
|
if (strcmp(pkgnamedep, curpkgnamedep) == 0) {
|
|
pkgfound = true;
|
|
if (strcmp(curver, pkgver) == 0) {
|
|
free(curpkgnamedep);
|
|
free(pkgnamedep);
|
|
rv = EEXIST;
|
|
goto out;
|
|
}
|
|
/*
|
|
* if new dependency version is greater than current
|
|
* one, store it.
|
|
*/
|
|
xbps_dbg_printf(xhp, "Missing pkgdep name matched, curver: %s newver: %s\n", curver, pkgver);
|
|
if (xbps_cmpver(curver, pkgver) <= 0) {
|
|
add_pkgdep = false;
|
|
free(curpkgnamedep);
|
|
free(pkgnamedep);
|
|
rv = EEXIST;
|
|
goto out;
|
|
}
|
|
update_pkgdep = true;
|
|
}
|
|
free(curpkgnamedep);
|
|
free(pkgnamedep);
|
|
if (pkgfound)
|
|
break;
|
|
|
|
idx++;
|
|
}
|
|
add_pkgdep = true;
|
|
out:
|
|
if (iter)
|
|
xbps_object_iterator_release(iter);
|
|
if (update_pkgdep)
|
|
xbps_array_remove(mdeps, idx);
|
|
if (add_pkgdep) {
|
|
char *str;
|
|
|
|
str = xbps_xasprintf("MISSING: %s", reqpkg);
|
|
xbps_array_add_cstring(mdeps, str);
|
|
free(str);
|
|
}
|
|
|
|
return rv;
|
|
}
|
|
|
|
#define MAX_DEPTH 512
|
|
|
|
static int
|
|
find_repo_deps(struct xbps_handle *xhp,
|
|
xbps_array_t unsorted, /* array of unsorted deps */
|
|
xbps_array_t pkg_rdeps_array, /* current pkg rundeps array */
|
|
xbps_array_t pkg_provides, /* current pkg provides array */
|
|
const char *curpkg, /* current pkgver */
|
|
unsigned short *depth) /* max recursion depth */
|
|
{
|
|
xbps_dictionary_t curpkgd = NULL;
|
|
xbps_object_t obj;
|
|
xbps_object_iterator_t iter;
|
|
xbps_array_t curpkgrdeps = NULL, curpkgprovides = NULL;
|
|
pkg_state_t state;
|
|
const char *reqpkg, *pkgver_q, *reason = NULL;
|
|
char *pkgname, *reqpkgname;
|
|
int rv = 0;
|
|
|
|
if (*depth >= MAX_DEPTH)
|
|
return ELOOP;
|
|
|
|
/*
|
|
* Iterate over the list of required run dependencies for
|
|
* current package.
|
|
*/
|
|
iter = xbps_array_iterator(pkg_rdeps_array);
|
|
assert(iter);
|
|
|
|
while ((obj = xbps_object_iterator_next(iter))) {
|
|
bool error = false, foundvpkg = false;
|
|
reqpkg = xbps_string_cstring_nocopy(obj);
|
|
|
|
if (xhp->flags & XBPS_FLAG_DEBUG) {
|
|
xbps_dbg_printf(xhp, "%s", "");
|
|
for (unsigned short x = 0; x < *depth; x++) {
|
|
xbps_dbg_printf_append(xhp, " ");
|
|
}
|
|
xbps_dbg_printf_append(xhp, "%s: requires dependency '%s': ", curpkg ? curpkg : " ", reqpkg);
|
|
}
|
|
if (((pkgname = xbps_pkgpattern_name(reqpkg)) == NULL) &&
|
|
((pkgname = xbps_pkg_name(reqpkg)) == NULL)) {
|
|
xbps_dbg_printf(xhp, "%s: can't guess pkgname for dependency: %s\n", curpkg, reqpkg);
|
|
xbps_set_cb_state(xhp, XBPS_STATE_INVALID_DEP, ENXIO, NULL,
|
|
"%s: can't guess pkgname for dependency '%s'", curpkg, reqpkg);
|
|
rv = ENXIO;
|
|
break;
|
|
}
|
|
/*
|
|
* Pass 0: check if required dependency is ignored.
|
|
*/
|
|
if (xbps_pkg_is_ignored(xhp, pkgname)) {
|
|
xbps_dbg_printf_append(xhp, "%s ignored.\n", pkgname);
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
/*
|
|
* Pass 1: check if required dependency is provided as virtual
|
|
* package via "provides", if true ignore dependency.
|
|
*/
|
|
if (pkg_provides && xbps_match_virtual_pkg_in_array(pkg_provides, reqpkg)) {
|
|
xbps_dbg_printf_append(xhp, "%s is a vpkg provided by %s, ignored.\n", pkgname, curpkg);
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
/*
|
|
* Pass 2: check if required dependency has been already
|
|
* added in the transaction dictionary.
|
|
*/
|
|
if ((curpkgd = xbps_find_pkg_in_array(unsorted, reqpkg, NULL)) ||
|
|
(curpkgd = xbps_find_virtualpkg_in_array(xhp, unsorted, reqpkg, NULL))) {
|
|
xbps_dictionary_get_cstring_nocopy(curpkgd, "pkgver", &pkgver_q);
|
|
xbps_dbg_printf_append(xhp, " (%s queued)\n", pkgver_q);
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
/*
|
|
* Pass 3: check if required dependency is already installed
|
|
* and its version is fully matched.
|
|
*/
|
|
if ((curpkgd = xbps_pkgdb_get_pkg(xhp, pkgname)) == NULL) {
|
|
if ((curpkgd = xbps_pkgdb_get_virtualpkg(xhp, pkgname))) {
|
|
foundvpkg = true;
|
|
}
|
|
}
|
|
if (xhp->flags & XBPS_FLAG_DOWNLOAD_ONLY) {
|
|
/*
|
|
* if XBPS_FLAG_DOWNLOAD_ONLY always assume
|
|
* all deps are not installed. This way one can download
|
|
* the whole set of binary packages to perform an
|
|
* off-line installation later on.
|
|
*/
|
|
curpkgd = NULL;
|
|
}
|
|
|
|
if (curpkgd == NULL) {
|
|
if (errno && errno != ENOENT) {
|
|
/* error */
|
|
rv = errno;
|
|
xbps_dbg_printf(xhp, "failed to find installed pkg for `%s': %s\n", reqpkg, strerror(rv));
|
|
free(pkgname);
|
|
break;
|
|
}
|
|
free(pkgname);
|
|
/* Required dependency not installed */
|
|
xbps_dbg_printf_append(xhp, "not installed.\n");
|
|
reason = "install";
|
|
state = XBPS_PKG_STATE_NOT_INSTALLED;
|
|
} else {
|
|
/*
|
|
* Required dependency is installed, check if its version can
|
|
* satisfy the requirements.
|
|
*/
|
|
xbps_dictionary_get_cstring_nocopy(curpkgd, "pkgver", &pkgver_q);
|
|
|
|
/* Check its state */
|
|
if ((rv = xbps_pkg_state_dictionary(curpkgd, &state)) != 0) {
|
|
free(pkgname);
|
|
break;
|
|
}
|
|
|
|
if (foundvpkg && xbps_match_virtual_pkg_in_dict(curpkgd, reqpkg)) {
|
|
/*
|
|
* Check if required dependency is a virtual package and is satisfied
|
|
* by an installed package.
|
|
*/
|
|
xbps_dbg_printf_append(xhp, "[virtual] satisfied by `%s'.\n", pkgver_q);
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
rv = xbps_pkgpattern_match(pkgver_q, reqpkg);
|
|
if (rv == 0) {
|
|
char *curpkgname;
|
|
/*
|
|
* The version requirement is not satisfied.
|
|
*/
|
|
curpkgname = xbps_pkg_name(pkgver_q);
|
|
assert(curpkgname);
|
|
if (strcmp(pkgname, curpkgname)) {
|
|
xbps_dbg_printf_append(xhp, "not installed `%s (vpkg)'", pkgver_q);
|
|
if (xbps_dictionary_get(curpkgd, "hold")) {
|
|
xbps_dbg_printf_append(xhp, " on hold state! ignoring package.\n");
|
|
} else {
|
|
xbps_dbg_printf_append(xhp, "\n");
|
|
reason = "install";
|
|
}
|
|
} else {
|
|
xbps_dbg_printf_append(xhp, "installed `%s', must be updated", pkgver_q);
|
|
if (xbps_dictionary_get(curpkgd, "hold")) {
|
|
xbps_dbg_printf_append(xhp, " on hold state! ignoring package.\n");
|
|
} else {
|
|
xbps_dbg_printf_append(xhp, "\n");
|
|
reason = "update";
|
|
}
|
|
}
|
|
free(curpkgname);
|
|
free(pkgname);
|
|
} else if (rv == 1) {
|
|
/*
|
|
* The version requirement is satisfied.
|
|
*/
|
|
free(pkgname);
|
|
rv = 0;
|
|
if (state == XBPS_PKG_STATE_UNPACKED) {
|
|
/*
|
|
* Package matches the dependency pattern but was only unpacked,
|
|
* configure pkg.
|
|
*/
|
|
xbps_dbg_printf_append(xhp, "installed `%s', must be configured.\n", pkgver_q);
|
|
reason = "configure";
|
|
} else if (state == XBPS_PKG_STATE_INSTALLED) {
|
|
/*
|
|
* Package matches the dependency pattern and is fully installed,
|
|
* skip to next one.
|
|
*/
|
|
xbps_dbg_printf_append(xhp, "installed `%s'.\n", pkgver_q);
|
|
continue;
|
|
}
|
|
} else {
|
|
/* error matching pkgpattern */
|
|
xbps_dbg_printf(xhp, "failed to match pattern %s with %s\n", reqpkg, pkgver_q);
|
|
free(pkgname);
|
|
break;
|
|
}
|
|
}
|
|
if (xbps_dictionary_get(curpkgd, "hold")) {
|
|
xbps_dbg_printf(xhp, "%s on hold state! ignoring package.\n", curpkg);
|
|
continue;
|
|
}
|
|
/*
|
|
* Pass 4: find required dependency in repository pool.
|
|
* If dependency does not match add pkg into the missing
|
|
* deps array and pass to next one.
|
|
*/
|
|
if (((curpkgd = xbps_rpool_get_pkg(xhp, reqpkg)) == NULL) &&
|
|
((curpkgd = xbps_rpool_get_virtualpkg(xhp, reqpkg)) == NULL)) {
|
|
/* pkg not found, there was some error */
|
|
if (errno && errno != ENOENT) {
|
|
xbps_dbg_printf(xhp, "failed to find pkg for `%s' in rpool: %s\n", reqpkg, strerror(errno));
|
|
rv = errno;
|
|
break;
|
|
}
|
|
rv = add_missing_reqdep(xhp, reqpkg);
|
|
if (rv != 0 && rv != EEXIST) {
|
|
xbps_dbg_printf(xhp, "`%s': add_missing_reqdep failed\n", reqpkg);
|
|
break;
|
|
} else if (rv == EEXIST) {
|
|
xbps_dbg_printf(xhp, "`%s' missing dep already added.\n", reqpkg);
|
|
rv = 0;
|
|
continue;
|
|
} else {
|
|
xbps_dbg_printf(xhp, "`%s' added into the missing deps array.\n", reqpkg);
|
|
continue;
|
|
}
|
|
}
|
|
xbps_dictionary_get_cstring_nocopy(curpkgd, "pkgver", &pkgver_q);
|
|
reqpkgname = xbps_pkg_name(pkgver_q);
|
|
assert(reqpkgname);
|
|
/*
|
|
* Check dependency validity.
|
|
*/
|
|
pkgname = xbps_pkg_name(curpkg);
|
|
assert(pkgname);
|
|
if (strcmp(pkgname, reqpkgname) == 0) {
|
|
xbps_dbg_printf_append(xhp, "[ignoring wrong dependency %s (depends on itself)]\n", reqpkg);
|
|
xbps_remove_string_from_array(pkg_rdeps_array, reqpkg);
|
|
free(pkgname);
|
|
free(reqpkgname);
|
|
continue;
|
|
}
|
|
free(pkgname);
|
|
free(reqpkgname);
|
|
/*
|
|
* Installed package must be updated, check if dependency is
|
|
* satisfied.
|
|
*/
|
|
if (!strcmp(reason, "update")) {
|
|
switch (xbps_pkgpattern_match(pkgver_q, reqpkg)) {
|
|
case 0: /* nomatch */
|
|
break;
|
|
case 1: /* match */
|
|
pkgname = xbps_pkg_name(pkgver_q);
|
|
assert(pkgname);
|
|
/*
|
|
* If there's an update in transaction,
|
|
* it's assumed version is greater.
|
|
* So dependency pattern matching didn't
|
|
* succeed... return ENODEV.
|
|
*/
|
|
if (xbps_find_pkg_in_array(unsorted, pkgname, "update")) {
|
|
error = true;
|
|
rv = ENODEV;
|
|
}
|
|
free(pkgname);
|
|
break;
|
|
default:
|
|
error = true;
|
|
rv = EINVAL;
|
|
break;
|
|
}
|
|
if (error)
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* If package doesn't have rundeps, pass to the next one.
|
|
*/
|
|
curpkgrdeps = xbps_dictionary_get(curpkgd, "run_depends");
|
|
if (curpkgrdeps == NULL) {
|
|
/*
|
|
* Package is on repo, add it into the transaction dictionary.
|
|
*/
|
|
xbps_dictionary_set_cstring_nocopy(curpkgd, "transaction", reason);
|
|
rv = xbps_transaction_store(xhp, unsorted, curpkgd, reason, true);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "xbps_transaction_store failed for `%s': %s\n", reqpkg, strerror(rv));
|
|
break;
|
|
}
|
|
continue;
|
|
}
|
|
|
|
if (xhp->flags & XBPS_FLAG_DEBUG) {
|
|
xbps_dbg_printf(xhp, "%s", "");
|
|
for (unsigned short x = 0; x < *depth; x++) {
|
|
xbps_dbg_printf_append(xhp, " ");
|
|
}
|
|
xbps_dbg_printf_append(xhp, "%s: finding dependencies:\n", pkgver_q);
|
|
}
|
|
/*
|
|
* Recursively find rundeps for current pkg dictionary.
|
|
*/
|
|
(*depth)++;
|
|
curpkgprovides = xbps_dictionary_get(curpkgd, "provides");
|
|
rv = find_repo_deps(xhp, unsorted, curpkgrdeps, curpkgprovides, pkgver_q, depth);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "Error checking %s for rundeps: %s\n", reqpkg, strerror(rv));
|
|
break;
|
|
}
|
|
/*
|
|
* Package is on repo, add it into the transaction dictionary.
|
|
*/
|
|
xbps_dictionary_set_cstring_nocopy(curpkgd, "transaction", reason);
|
|
rv = xbps_transaction_store(xhp, unsorted, curpkgd, reason, true);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "xbps_transaction_store failed for `%s': %s\n", reqpkg, strerror(rv));
|
|
break;
|
|
}
|
|
}
|
|
xbps_object_iterator_release(iter);
|
|
(*depth)--;
|
|
|
|
return rv;
|
|
}
|
|
|
|
int HIDDEN
|
|
xbps_repository_find_deps(struct xbps_handle *xhp,
|
|
xbps_array_t unsorted,
|
|
xbps_dictionary_t repo_pkgd)
|
|
{
|
|
xbps_array_t pkg_rdeps, pkg_provides = NULL;
|
|
const char *pkgver;
|
|
unsigned short depth = 0;
|
|
|
|
pkg_rdeps = xbps_dictionary_get(repo_pkgd, "run_depends");
|
|
if (xbps_array_count(pkg_rdeps) == 0)
|
|
return 0;
|
|
|
|
xbps_dictionary_get_cstring_nocopy(repo_pkgd, "pkgver", &pkgver);
|
|
xbps_dbg_printf(xhp, "Finding required dependencies for '%s':\n", pkgver);
|
|
/*
|
|
* This will find direct and indirect deps, if any of them is not
|
|
* there it will be added into the missing_deps array.
|
|
*/
|
|
pkg_provides = xbps_dictionary_get(repo_pkgd, "provides");
|
|
return find_repo_deps(xhp, unsorted, pkg_rdeps, pkg_provides, pkgver, &depth);
|
|
}
|