fdec663855
- Rename regpkgs_dictionary to regpkgdb_dictionary to better describe what is is. - Change some funcs in plist.c to return a boolean rather than int. - Hide more internal funcs off the API. - Simplify xbps_repository_update_pkg() and remove its second arg. - Hide implementation details in xbps_repository_pool, now to iterate over the pool you have to use xbps_repository_pool_foreach and its struct repository_pool_index. - Introduce xbps_{init,end}, to initialize/destroy some stuff in the library. - Introduce xbps_dbg_printf to printf stuff for debugging purposes. - xbps-{bin,repo}: added -d arg to enable debugging output. - Before checking if a config file needs to be installed or such, check that package contains the "conf_files" array. - Remove obsolete dirs as well while updating packages. - If transaction dictionary is ready remove the "missing_deps" array. Bump XBPS_RELVER to 20101118. --HG-- rename : lib/regpkgs_dictionary.c => lib/regpkgdb_dictionary.c
243 lines
6.7 KiB
C
243 lines
6.7 KiB
C
/*-
|
|
* Copyright (c) 2009-2010 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
|
|
#include <xbps_api.h>
|
|
#include "xbps_api_impl.h"
|
|
#include "queue.h"
|
|
|
|
struct sorted_dependency {
|
|
SIMPLEQ_ENTRY(sorted_dependency) chain;
|
|
prop_dictionary_t dict;
|
|
};
|
|
|
|
static SIMPLEQ_HEAD(sdep_head, sorted_dependency) sdep_list =
|
|
SIMPLEQ_HEAD_INITIALIZER(sdep_list);
|
|
|
|
static struct sorted_dependency *
|
|
find_sorteddep_by_name(const char *pkgname)
|
|
{
|
|
struct sorted_dependency *sdep = NULL;
|
|
const char *curpkgname;
|
|
|
|
SIMPLEQ_FOREACH(sdep, &sdep_list, chain) {
|
|
prop_dictionary_get_cstring_nocopy(sdep->dict,
|
|
"pkgname", &curpkgname);
|
|
if (strcmp(pkgname, curpkgname) == 0)
|
|
return sdep;
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
int HIDDEN
|
|
xbps_sort_pkg_deps(prop_dictionary_t chaindeps)
|
|
{
|
|
prop_array_t sorted, unsorted, rundeps, missingdeps;
|
|
prop_object_t obj, obj2;
|
|
prop_object_iterator_t iter, iter2;
|
|
struct sorted_dependency *sdep;
|
|
size_t ndeps = 0, rundepscnt = 0, cnt = 0;
|
|
const char *pkgname, *pkgver, *str;
|
|
char *pkgnamedep;
|
|
int rv = 0;
|
|
|
|
assert(chaindeps != NULL);
|
|
|
|
/*
|
|
* If there are missing dependencies, bail out.
|
|
*/
|
|
missingdeps = prop_dictionary_get(chaindeps, "missing_deps");
|
|
if (prop_array_count(missingdeps) > 0)
|
|
return ENOENT;
|
|
|
|
sorted = prop_array_create();
|
|
if (sorted == NULL)
|
|
return ENOMEM;
|
|
|
|
/*
|
|
* All required deps are satisfied (already installed).
|
|
*/
|
|
unsorted = prop_dictionary_get(chaindeps, "unsorted_deps");
|
|
if (prop_array_count(unsorted) == 0) {
|
|
prop_dictionary_set(chaindeps, "packages", sorted);
|
|
return 0;
|
|
}
|
|
ndeps = prop_array_count(unsorted);
|
|
|
|
iter = prop_array_iterator(unsorted);
|
|
if (iter == NULL) {
|
|
prop_object_release(sorted);
|
|
return ENOMEM;
|
|
}
|
|
again:
|
|
/*
|
|
* Order all deps by looking at its run_depends array.
|
|
*/
|
|
while ((obj = prop_object_iterator_next(iter)) != NULL) {
|
|
prop_dictionary_get_cstring_nocopy(obj, "pkgname", &pkgname);
|
|
prop_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver);
|
|
xbps_dbg_printf("Sorting package '%s': ", pkgver);
|
|
if (find_sorteddep_by_name(pkgname) != NULL) {
|
|
xbps_dbg_printf_append("skipping, already queued.\n",
|
|
pkgname);
|
|
continue;
|
|
}
|
|
|
|
sdep = malloc(sizeof(struct sorted_dependency));
|
|
if (sdep == NULL) {
|
|
rv = ENOMEM;
|
|
goto out;
|
|
}
|
|
/*
|
|
* Packages that don't have deps go unsorted, because
|
|
* it doesn't matter.
|
|
*/
|
|
rundeps = prop_dictionary_get(obj, "run_depends");
|
|
if (rundeps == NULL || prop_array_count(rundeps) == 0) {
|
|
xbps_dbg_printf_append("added (no rundeps) into "
|
|
"the sorted queue.\n");
|
|
sdep->dict = prop_dictionary_copy(obj);
|
|
SIMPLEQ_INSERT_TAIL(&sdep_list, sdep, chain);
|
|
cnt++;
|
|
continue;
|
|
}
|
|
iter2 = prop_array_iterator(rundeps);
|
|
if (iter2 == NULL) {
|
|
rv = ENOMEM;
|
|
free(sdep);
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* Iterate over the run_depends array, and find out if they
|
|
* were already added in the sorted list.
|
|
*/
|
|
xbps_dbg_printf_append("\n");
|
|
xbps_dbg_printf("Checking '%s' run depends for sorting...\n",
|
|
pkgver);
|
|
while ((obj2 = prop_object_iterator_next(iter2)) != NULL) {
|
|
str = prop_string_cstring_nocopy(obj2);
|
|
if (str == NULL) {
|
|
free(sdep);
|
|
rv = EINVAL;
|
|
goto out;
|
|
}
|
|
pkgnamedep = xbps_get_pkgpattern_name(str);
|
|
if (pkgnamedep == NULL) {
|
|
free(sdep);
|
|
rv = EINVAL;
|
|
goto out;
|
|
}
|
|
xbps_dbg_printf(" Required dependency '%s': ", str);
|
|
/*
|
|
* If dependency is already satisfied or queued,
|
|
* pass to the next one.
|
|
*/
|
|
if (xbps_check_is_installed_pkg(str)) {
|
|
rundepscnt++;
|
|
xbps_dbg_printf_append("installed.\n");
|
|
} else if (find_sorteddep_by_name(pkgnamedep) != NULL) {
|
|
xbps_dbg_printf_append("queued.\n");
|
|
rundepscnt++;
|
|
} else {
|
|
xbps_dbg_printf_append("not installed.\n");
|
|
}
|
|
free(pkgnamedep);
|
|
}
|
|
prop_object_iterator_release(iter2);
|
|
|
|
/* Add dependency if all its required deps are already added */
|
|
if (prop_array_count(rundeps) == rundepscnt) {
|
|
sdep->dict = prop_dictionary_copy(obj);
|
|
SIMPLEQ_INSERT_TAIL(&sdep_list, sdep, chain);
|
|
xbps_dbg_printf("Added package '%s' to the sorted "
|
|
"queue (all rundeps satisfied).\n\n", pkgver);
|
|
rundepscnt = 0;
|
|
cnt++;
|
|
continue;
|
|
}
|
|
xbps_dbg_printf("Unsorted package '%s' has missing "
|
|
"rundeps (missing %zu).\n\n", pkgver,
|
|
prop_array_count(rundeps) - rundepscnt);
|
|
free(sdep);
|
|
rundepscnt = 0;
|
|
}
|
|
|
|
/* Iterate until all deps are processed. */
|
|
if (cnt < ndeps) {
|
|
xbps_dbg_printf("Missing required deps! queued: %zu "
|
|
"required: %zu.\n", cnt, ndeps);
|
|
prop_object_iterator_reset(iter);
|
|
goto again;
|
|
}
|
|
prop_object_iterator_release(iter);
|
|
|
|
/*
|
|
* Add all sorted dependencies into the sorted deps array.
|
|
*/
|
|
while ((sdep = SIMPLEQ_FIRST(&sdep_list)) != NULL) {
|
|
if (!prop_array_add(sorted, sdep->dict)) {
|
|
free(sdep);
|
|
rv = EINVAL;
|
|
goto out;
|
|
}
|
|
SIMPLEQ_REMOVE(&sdep_list, sdep, sorted_dependency, chain);
|
|
prop_object_release(sdep->dict);
|
|
free(sdep);
|
|
}
|
|
|
|
/*
|
|
* Sanity check that the array contains the same number of
|
|
* objects than the total number of required dependencies.
|
|
*/
|
|
if (ndeps != prop_array_count(sorted)) {
|
|
rv = EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
if (!prop_dictionary_set(chaindeps, "packages", sorted))
|
|
rv = EINVAL;
|
|
|
|
prop_dictionary_remove(chaindeps, "unsorted_deps");
|
|
|
|
out:
|
|
/*
|
|
* Release resources used by temporary sorting.
|
|
*/
|
|
prop_object_release(sorted);
|
|
while ((sdep = SIMPLEQ_FIRST(&sdep_list)) != NULL) {
|
|
SIMPLEQ_REMOVE(&sdep_list, sdep, sorted_dependency, chain);
|
|
prop_object_release(sdep->dict);
|
|
free(sdep);
|
|
}
|
|
|
|
return rv;
|
|
}
|