remove is_cfi and use_cfi_cast from windows build

Since original is down

.github/workflows/build_bromite_dev.yaml

@@ -22,6 +22,10 @@ on:
         description: 'arch [arm64/x64]'
         required: true
         default: 'x64'
+      targetos:
+        description: 'targetos [android/win]'
+        required: true
+        default: 'android'
       type:
         description: 'runner? [dev/ci]'
         required: true
@@ -181,15 +185,22 @@ jobs:
         USELOCALIMAGE: true       # CUSTOM RUNNER: permit use of local images
         USEINTERNALNETWORK: true  # CUSTOM RUNNER: create the docker network as internal
         WORKSPACE: /home/lg/working_dir
+        # kythe
         KYTHE_CORPUS: chromium.googlesource.com/chromium/src
         KYTHE_ROOT_DIRECTORY: /home/lg/working_dir/chromium/src
         KYTHE_OUTPUT_DIRECTORY: /home/lg/working_dir/chromium/src/out/bromite/kythe
+        # cross build
+        DEPOT_TOOLS_WIN_TOOLCHAIN_BASE_URL: /win_sdk/10.0.20348.0/
+        WINDOWSSDKDIR: "/win_sdk/10.0.20348.0/Windows Kits/10/"
+        GYP_MSVS_OVERRIDE_PATH: /win_sdk/10.0.20348.0/
         # compile in debug mode
         TARGET_ISDEBUG: ${{ github.event.inputs.debug }} 
         TARGET_CPU: ${{ github.event.inputs.build }}
+        TARGET_OS: ${{ github.event.inputs.targetos }}
       volumes:
-        - /storage/images/${{ github.event.inputs.build }}/${{ github.event.inputs.sha }}:/home/lg/working_dir/chromium/src/out/bromite
+        - /storage/images/${{ github.event.inputs.targetos }}/${{ github.event.inputs.build }}/${{ github.event.inputs.sha }}:/home/lg/working_dir/chromium/src/out/bromite
         - /tmp/proxy:/tmp/proxy
+        - /win_sdk:/win_sdk
         
     steps:    
       - name: Prepare Build Container
@@ -249,10 +260,15 @@ jobs:
           if [[ OUT_PRESENT -eq 0 ]]; then
 
              echo "::group::-------- gn gen"
-             [[ "$USEGOMA" = "true" ]] && \
-                gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") use_goma=true goma_dir=\"$WORKSPACE/goma\" $(cat ../../build_args.gni) " out/bromite \
-                || \
-                gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") $(cat ../../build_args.gni) " out/bromite              
+             if [[ "$TARGET_OS" = "android" ]] 
+             then
+               [[ "$USEGOMA" = "true" ]] && \
+                  gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") use_goma=true goma_dir=\"$WORKSPACE/goma\" $(cat ../../build_args.gni) " out/bromite \
+                  || \
+                  gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") $(cat ../../build_args.gni) " out/bromite    
+             else
+                gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") target_cpu = \"x64\" target_os = \"win\" $(cat ../../build_args.gni) " out/bromite
+             fi
              echo "::endgroup::"
 
              echo "::group::-------- gn args"
@@ -294,10 +310,15 @@ jobs:
           PATH=$WORKSPACE/chromium/src/third_party/llvm-build/Release+Asserts/bin:$WORKSPACE/depot_tools/:/usr/local/go/bin:$WORKSPACE/mtool/bin:$PATH
           cd $WORKSPACE/chromium/src
           
-          [[ "$USEGOMA" = "true" ]] && \
-            autoninja -j $GOMAJOBS -C out/bromite chrome_public_apk \
-            || \
-            autoninja -C out/bromite chrome_public_apk
+          if [[ "$TARGET_OS" = "android" ]] 
+          then
+            [[ "$USEGOMA" = "true" ]] && \
+              autoninja -j $GOMAJOBS -C out/bromite chrome_public_apk \
+              || \
+              autoninja -C out/bromite chrome_public_apk
+          else
+            autoninja -C out/bromite chrome
+          fi
 
       - name: Get ninja logs
         shell: bash
@@ -363,12 +384,14 @@ jobs:
         run: |
           PATH=$WORKSPACE/chromium/src/third_party/llvm-build/Release+Asserts/bin:$WORKSPACE/depot_tools/:/usr/local/go/bin:$WORKSPACE/mtool/bin:$PATH
           cd $WORKSPACE/chromium/src
-          
-          $WORKSPACE/ninja/ninja -C $WORKSPACE/chromium/src/out/bromite -a chrome_public_apk \
-            -t compdb cc cxx objc objcxx >$WORKSPACE/chromium/src/out/bromite/compile_commands.json
 
           test -f out/bromite/bromite.idx || \
-            /home/lg/working_dir/clangd_snapshot_20211205/bin/clangd-indexer --executor=all-TUs out/bromite/compile_commands.json >out/bromite/bromite.idx
+            cp -r out/bromite out/clangd && \
+            gn gen --args="import(\"/home/lg/working_dir/bromite/build/bromite.gn_args\") $(cat ../../build_args.gni) skip_clangd_unsupported_options = true" out/clangd && \
+            $WORKSPACE/ninja/ninja -C $WORKSPACE/chromium/src/out/clangd -a chrome_public_apk \
+              -t compdb cc cxx objc objcxx >$WORKSPACE/chromium/src/out/clangd/compile_commands.json && \
+            /home/lg/working_dir/clangd_snapshot_20211205/bin/clangd-indexer --executor=all-TUs out/clangd/compile_commands.json >out/bromite/bromite.idx && \
+            rm -rf out/clangd
 
       - name: Generate Supersize data
         if: ${{ github.event.inputs.debug == 'false' }}

README.md

@@ -1,3 +1,42 @@
 # bromite-buildtools
 
 this repo contains my build machine and some scripts I use for Bromite development. the ci uses a modified version of the gihub runner (avaiable [here](https://github.com/uazo/runner)) and use [sysbox](https://github.com/nestybox/sysbox) to improve security. it also contains everything you need to use a self-hosted modified version of [goma](https://github.com/uazo/goma-server) for a multi-machine build
+
+### Setting-up
+
+1. Prepare folders
+
+```
+cd ~ && mkdir gh-runner
+cd gh-runner && mkdir docker-inner
+SYSBOX_UID=$(cat /etc/subuid | grep sysbox | cut -d : -f 2)
+sudo chown $SYSBOX_UID:$SYSBOX_UID docker-inner/
+
+mkdir /storage
+sudo chown $SYSBOX_UID:$SYSBOX_UID /storage
+```
+
+2. Clone this repo
+3. Prepare `.env`
+
+```
+cd bromite-buildtools/images/github-runner/
+cp .env.example .env
+```
+
+4. Edit `.env` file
+
+```
+RUNNER_NAME=pd-gh-runner
+GITHUB_PERSONAL_TOKEN=<git-token>
+GITHUB_OWNER=uazo
+GITHUB_REPOSITORY=bromite-buildtools
+RUNNER_LABELS=dev
+ALLOWEDAUTHORSLIST=uazo
+```
+
+5. Start the runner
+```
+cd bromite-buildtools/images/github-runner/
+./start-runner.sh
+```

export-all-patch.sh

@@ -18,15 +18,11 @@ for patch in $ALLPATCHS_E; do
 
 	if [ -z "$PATCH_FILE" ]
 	then
-		#git -C ~/chromium/src/ show -s $patch
 		PATCH_FILE=$(git -C ~/chromium/src/ show -s $patch | tail -n 1)
 		if [[ "$PATCH_FILE" != *".patch" ]]; then
-			PATCH_FILE=$NO_NAME.patch
-			NO_NAME=$NO_NAME.1
-			echo No Name ${NO_NAME}, press return
+			PATCH_FILE=00$(git -C ~/chromium/src/ show -s $patch | head -n 5 | tail -n 1 | xargs | tr " " - | tr [:punct:] -).patch
+			echo New Patch: ${PATCH_FILE}
 		fi
-
-		read  -n 1
 	fi
 
 	bash ~/bromite-buildtools/export-single-patch.sh $patch $PATCH_FILE

export-patch-list.sh

@@ -16,6 +16,9 @@ for patch in $ALLPATCHS_E; do
 	if [[ "$PATCH_FILE" == *"Automated-domain-substitution"* ]]; then
 		continue
 	fi
+	if [[ -z "$PATCH_FILE" ]]; then
+		PATCH_FILE=00$(git -C ~/chromium/src/ show -s $patch | head -n 5 | tail -n 1 | xargs | tr " " - | tr [:punct:] -).patch
+	fi
 
 	echo $PATCH_FILE >>~/bromite/build/patches-new/patch-list
 

export-single-patch.sh

@@ -16,16 +16,29 @@ fi
 git -C ~/chromium/src/ format-patch -1 --keep-subject --stdout --full-index --zero-commit --no-signature $patch >~/bromite/build/patches-new/$PATCH_FILE
 echo "   exported"
 
+CHANGE_REF=""
 while read line; do
-	#echo $line
-	if [[ "$line" == index* ]]; then
-		next_line=$(grep -A1 "${line}" ~/bromite/build/patches-new/$PATCH_FILE | tail -n 1 )
-		if [[ "$next_line" != "GIT binary patch" ]]; then
-			sed -i "/^$line/d" ~/bromite/build/patches-new/$PATCH_FILE
+	for i in {1..5}
+	do
+		if [[ "$line" == index* ]]; then
+			read next_line
+			if [[ "$next_line" != "GIT binary patch" ]]; then
+				CHANGE_REF=${CHANGE_REF}"/^${line}/d;"
+				break
+			else
+				line=$next_line
+				continue
+			fi
+		else
+			break
 		fi
-	fi
+	done
 done <~/bromite/build/patches-new/$PATCH_FILE
 
+if [ "$CHANGE_REF" ]
+then
+	sed -i "$CHANGE_REF" ~/bromite/build/patches-new/$PATCH_FILE
+fi
 sed -i '/^From 0000000000000000000000000000000000000000/d' ~/bromite/build/patches-new/$PATCH_FILE
 sed -i '/^FILE:/d' ~/bromite/build/patches-new/$PATCH_FILE
 sed -i '/^ mode change/d' ~/bromite/build/patches-new/$PATCH_FILE

images/bromite-build/build_args.gni

@@ -1,7 +1,6 @@
 
 declare_args() {
   _is_debug_build = ""
-  target_cpu = "x64"
 }
 
 _is_debug_build = getenv("TARGET_ISDEBUG")
@@ -15,14 +14,21 @@ if(getenv("TARGET_CPU") != "") {
 
 enable_kythe_annotations = true
 # clang_use_chrome_plugins = false
-chrome_public_manifest_package = "org.bromite.bromite.dev"
+if (target_os == "android") {
+  chrome_public_manifest_package = "org.bromite.bromite.dev"
+}
 
 if(_is_debug_build == "true") {
 # print("Debug build on")
   is_debug = true
   is_official_build = false
   dcheck_always_on = true
-  symbol_level = 1
+  if (target_os == "win") {
+    symbol_level = 0
+    use_large_pdbs = true
+  } else {
+    symbol_level = 1
+  }
   strip_debug_info = false
   generate_linker_map = false
 
@@ -31,5 +37,12 @@ if(_is_debug_build == "true") {
   is_cfi = false # disable it
   use_cfi_cast = false # disable it
 } else {
-  generate_linker_map = true
+  if (target_os == "android") {
+    generate_linker_map = true
+  }
+
+  if (target_os == "win") {
+    is_cfi = false # disable it
+    use_cfi_cast = false # disable it
+  }  
 }

images/build-deps/Dockerfile

@@ -16,13 +16,14 @@ RUN dpkg --add-architecture i386
 
 RUN apt-get update &&\
     DEBIAN_FRONTEND=noninteractive \
-    apt-get -f -y install sudo lsb-release cl-base64 bash wget apt-utils python sed tzdata build-essential lib32gcc-9-dev
+    apt-get -f -y install sudo lsb-release cl-base64 bash wget apt-utils python sed tzdata build-essential lib32gcc-9-dev g++-multilib
 
 ENV user lg
 
 RUN useradd -m -d /home/${user} ${user} && \
     chown -R ${user} /home/${user} && \
     adduser ${user} sudo && \
+    chmod 4755 /usr/bin/sudo && \
     echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
 USER ${user}
 
@@ -31,18 +32,13 @@ USER ${user}
 
 WORKDIR /home/${user}
 
-RUN wget https://chromium.googlesource.com/chromium/src/+/refs/tags/$VERSION/build/install-build-deps.sh?format=TEXT -O install-build-deps.sh.base64 \
+RUN wget https://raw.githubusercontent.com/chromium/chromium/$VERSION/build/install-build-deps.sh \
     && \
-    wget https://chromium.googlesource.com/chromium/src/+/refs/tags/$VERSION/build/install-build-deps-android.sh?format=TEXT -O install-build-deps-android.sh.base64 \
+    wget https://raw.githubusercontent.com/chromium/chromium/$VERSION/build/install-build-deps-android.sh \
     && \
-    base64 -d install-build-deps.sh.base64 >install-build-deps.sh && \
-    base64 -d install-build-deps-android.sh.base64 >install-build-deps-android.sh && \
     sed -i 's/snapcraft/wget/' install-build-deps.sh && \
     chmod +x ./install-build-deps.sh && \
     chmod +x ./install-build-deps-android.sh && \
     sudo ./install-build-deps.sh --no-prompt --lib32 --no-chromeos-fonts && \
     sudo ./install-build-deps-android.sh --no-prompt
 
-
-   
-

images/chr-source/depot_tools.diff

@@ -1,57 +1,60 @@
 diff --git a/gclient_scm.py b/gclient_scm.py
+index f58c07a8..c8409726 100644
 --- a/gclient_scm.py
 +++ b/gclient_scm.py
-@@ -1012,28 +1012,35 @@ class GitWrapper(SCMWrapper):
-     gclient_utils.safe_makedirs(parent_dir)
-
-     template_dir = None
-+    use_fetch = False
+@@ -1137,31 +1137,29 @@ class GitWrapper(SCMWrapper):
+       clone_cmd.append(url)
+ 
+       template_dir = None
++      use_fetch = False
 +
-+    tmp_dir = tempfile.mkdtemp(
-+        prefix='_gclient_%s_' % os.path.basename(self.checkout_path),
-+        dir=parent_dir)
++      tmp_dir = tempfile.mkdtemp(
++          prefix='_gclient_%s_' % os.path.basename(self.checkout_path),
++          dir=parent_dir)
 +
-     if hasattr(options, 'no_history') and options.no_history:
-       if gclient_utils.IsGitSha(revision):
-         # In the case of a subproject, the pinned sha is not necessarily the
-         # head of the remote branch (so we can't just use --depth=N). Instead,
-         # we tell git to fetch all the remote objects from SHA..HEAD by means of
-         # a template git dir which has a 'shallow' file pointing to the sha.
--        template_dir = tempfile.mkdtemp(
--            prefix='_gclient_gittmp_%s' % os.path.basename(self.checkout_path),
--            dir=parent_dir)
--        self._Run(['init', '--bare', template_dir], options, cwd=self._root_dir)
--        with open(os.path.join(template_dir, 'shallow'), 'w') as template_file:
--          template_file.write(revision)
--        clone_cmd.append('--template=' + template_dir)
-+        self._Run(['init', tmp_dir], options, cwd=self._root_dir)
+       if hasattr(options, 'no_history') and options.no_history:
+         if gclient_utils.IsGitSha(revision):
+-          # In the case of a subproject, the pinned sha is not necessarily the
+-          # head of the remote branch (so we can't just use --depth=N). Instead,
+-          # we tell git to fetch all the remote objects from SHA..HEAD by means
+-          # of a template git dir which has a 'shallow' file pointing to the
+-          # sha.
+-          template_dir = tempfile.mkdtemp(prefix='_gclient_gittmp_%s' %
+-                                          os.path.basename(self.checkout_path),
+-                                          dir=parent_dir)
+-          self._Run(['init', '--bare', template_dir],
+-                    options,
+-                    cwd=self._root_dir)
+-          with open(os.path.join(template_dir, 'shallow'),
+-                    'w') as template_file:
+-            template_file.write(revision)
+-            clone_cmd.append('--template=' + template_dir)
++          self._Run(['init', tmp_dir], options, cwd=self._root_dir)
 +
-+        self._Run(['-C', tmp_dir, 'remote', 'add', 'origin', url], options, cwd=self._root_dir)
++          self._Run(['-C', tmp_dir, 'remote', 'add', 'origin', url], options, cwd=self._root_dir)
 +
-+        clone_cmd = cfg + ['-C', tmp_dir, 'fetch', '--progress']
-+        clone_cmd.append('--depth=1')
-+        clone_cmd.append(url)
-+        clone_cmd.append(revision)
-+        use_fetch = True
-       else:
-         # Otherwise, we're just interested in the HEAD. Just use --depth.
-         clone_cmd.append('--depth=1')
-
--    tmp_dir = tempfile.mkdtemp(
--        prefix='_gclient_%s_' % os.path.basename(self.checkout_path),
--        dir=parent_dir)
-     try:
++          clone_cmd = cfg + ['-C', tmp_dir, 'fetch', '--progress']
++          clone_cmd.append('--depth=1')
++          clone_cmd.append(url)
++          clone_cmd.append(revision)
++          use_fetch = True
+         else:
+           # Otherwise, we're just interested in the HEAD. Just use --depth.
+           clone_cmd.append('--depth=1')
+ 
+-      tmp_dir = tempfile.mkdtemp(prefix='_gclient_%s_' %
+-                                 os.path.basename(self.checkout_path),
+-                                 dir=parent_dir)
 -      clone_cmd.append(tmp_dir)
 +      if use_fetch == False:
 +        clone_cmd.append(tmp_dir)
-+
-       if self.print_outbuf:
-         print_stdout = True
-         filter_fn = None
-@@ -1328,6 +1335,9 @@ class GitWrapper(SCMWrapper):
+ 
+       try:
+         self._Run(clone_cmd,
+@@ -1452,6 +1450,9 @@ class GitWrapper(SCMWrapper):
      if refspec:
        fetch_cmd.append(refspec)
-
+ 
 +    if hasattr(options, 'no_history') and options.no_history:
 +      fetch_cmd.append('--depth=1')
 +

images/chr-source/prepare-build.sh

@@ -22,21 +22,26 @@ echo -e ${RED} -------- download chromium repo ${NC}
 mkdir ./chromium
 cd ./chromium
 
+export DEPOT_TOOLS_UPDATE=0
+
 gclient root
 
 mkdir ./src
 cd ./src
 
-git init
-git remote add origin https://chromium.googlesource.com/chromium/src.git
+#CHR_SOURCE=https://chromium.googlesource.com/chromium/src.git
+CHR_SOURCE=https://github.com/chromium/chromium.git
 
-git fetch --depth 2 https://chromium.googlesource.com/chromium/src.git +refs/tags/$VERSION:chromium_$VERSION
+git init
+git remote add origin $CHR_SOURCE
+
+git fetch --depth 2 $CHR_SOURCE +refs/tags/$VERSION:chromium_$VERSION
 git checkout $VERSION
 VERSION_SHA=$( git show-ref -s $VERSION | head -n1 )
 
 echo >../.gclient "solutions = ["
 echo >>../.gclient "  { \"name\"        : 'src',"
-echo >>../.gclient "    \"url\"         : 'https://chromium.googlesource.com/chromium/src.git@$VERSION_SHA',"
+echo >>../.gclient "    \"url\"         : '$CHR_SOURCE@$VERSION_SHA',"
 echo >>../.gclient "    \"deps_file\"   : 'DEPS',"
 echo >>../.gclient "    \"managed\"     : True,"
 echo >>../.gclient "    \"custom_deps\" : {"
@@ -68,3 +73,16 @@ gclient runhooks
 
 echo -e ${RED} -------- download objdump ${NC}
 tools/clang/scripts/update.py --package=objdump
+
+echo -e ${RED} -------- build rc ${NC}
+cd build/toolchain/win/rc
+git clone -q https://github.com/nico/hack
+cd hack/res
+
+../../../../../../third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ \
+		-std=c++14 rc.cc -Wall \
+		-Wno-c++11-narrowing -O2 -fno-rtti -fno-exceptions -DNDEBUG \
+        -o rc-linux64 -fuse-ld=lld -target x86_64-unknown-linux-gnu
+cd ../../../../../../
+cp build/toolchain/win/rc/hack/res/rc-linux64 build/toolchain/win/rc/linux64/rc
+

images/github-runner/start-runner.sh

@@ -37,6 +37,7 @@ do
     -v $GHRUNNERHOME/tmp/forward-proxy:/tmp/forward-proxy:rw \
     -v $GHRUNNERHOME/redis:/redis:rw \
     -v $GHRUNNERHOME/var/run:/var/run \
+    -v /casefold:/win_sdk \
     --network none \
     --device=/dev/kvm \
     uazo/github-runner