midou/citra-shitamoto-network
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

game_list: Resolve variable shadowing within LoadCompatibilityList()

Browse Source 
"value" is already a used variable name within the outermost ranged-for
loop, so this variable was shadowing the outer one. This isn't a bug,
but it will get rid of a -Wshadow warning.
This commit is contained in:
Lioncash 2018-09-11 22:34:07 -04:00 committed by fearlessTobi
parent 52f12e303a
commit d864d9bf03
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/citra_qt/game_list.cpp
View File

@ -553,9 +553,9 @@ void GameList::LoadCompatibilityList() {
QString directory = game["directory"].toString();
QJsonArray ids = game["releases"].toArray();
for (const QJsonValueRef& value : ids) {
QJsonObject object = value.toObject();
QString id = object["id"].toString();
for (const QJsonValueRef& id_ref : ids) {
QJsonObject id_object = id_ref.toObject();
QString id = id_object["id"].toString();
compatibility_list.emplace(
id.toUpper().toStdString(),
std::make_pair(QString::number(compatibility), directory));