midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core/hw/rsa: Make GetSignature() a const member function

Browse Source 
This doesn't directly modify instance state, so it can be made const.
This commit is contained in:
Lioncash 2020-05-01 10:17:01 -04:00
parent c55e81b946
commit 3ab0701192
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/hw/aes/key.cpp
View File

@ -223,7 +223,7 @@ void LoadNativeFirmKeysOld3DS() {
return;
}
auto rsa = RSA::GetSlot(0);
const auto rsa = RSA::GetSlot(0);
if (!rsa) {
LOG_ERROR(HW_AES, "RSA slot is missing");
return;

2
src/core/hw/rsa/rsa.cpp
View File

@ -31,7 +31,7 @@ std::vector<u8> HexToBytes(const std::string& hex) {
constexpr std::size_t SlotSize = 4;
std::array<RsaSlot, SlotSize> rsa_slots;
std::vector<u8> RsaSlot::GetSignature(const std::vector<u8>& message) {
std::vector<u8> RsaSlot::GetSignature(const std::vector<u8>& message) const {
CryptoPP::Integer sig =
CryptoPP::ModularExponentiation(CryptoPP::Integer(message.data(), message.size()),
CryptoPP::Integer(exponent.data(), exponent.size()),

2
src/core/hw/rsa/rsa.h
View File

@ -14,7 +14,7 @@ public:
RsaSlot() = default;
RsaSlot(std::vector<u8> exponent, std::vector<u8> modulus)
: init(true), exponent(std::move(exponent)), modulus(std::move(modulus)) {}
std::vector<u8> GetSignature(const std::vector<u8>& message);
std::vector<u8> GetSignature(const std::vector<u8>& message) const;
explicit operator bool() const {
// TODO(B3N30): Maybe check if exponent and modulus are vailid