midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core/hw/rsa: Take std::vector instances by value

Browse Source 
Allows us to std::move them and allow calling code to eliminate copies
from occurring entirely.
This commit is contained in:
Lioncash 2020-05-01 10:12:45 -04:00
parent 85d37c9994
commit 75bac1e514
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/hw/rsa/rsa.cpp
View File

@ -74,7 +74,7 @@ void InitSlots() {
std::vector<u8> exponent(256);
file.ReadArray(exponent.data(), exponent.size());
rsa_slots[0] = RsaSlot(exponent, modulus);
rsa_slots[0] = RsaSlot(std::move(exponent), std::move(modulus));
// TODO(B3N30): Initalize the other slots. But since they aren't used at all, we can skip them
// for now
}

8
src/core/hw/rsa/rsa.h
View File

@ -11,9 +11,9 @@ namespace HW::RSA {
class RsaSlot {
public:
RsaSlot() : init(false) {}
RsaSlot(const std::vector<u8>& exponent, const std::vector<u8>& modulus)
: init(true), exponent(exponent), modulus(modulus) {}
RsaSlot() = default;
RsaSlot(std::vector<u8> exponent, std::vector<u8> modulus)
: init(true), exponent(std::move(exponent)), modulus(std::move(modulus)) {}
std::vector<u8> GetSignature(const std::vector<u8>& message);
operator bool() const {
@ -22,7 +22,7 @@ public:
}
private:
bool init;
bool init = false;
std::vector<u8> exponent;
std::vector<u8> modulus;
};