0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when aborting instance import

Browse Source 
Also turned a loop var into a reference to avoid copies on each iteration
This commit is contained in:
Jeremy Lorelli 2022-05-27 16:41:57 -07:00
parent 3ff26d5cfe
commit 48e20cb5f7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
launcher/InstanceImportTask.cpp
View File

@ -72,7 +72,8 @@ InstanceImportTask::InstanceImportTask(const QUrl sourceUrl, QWidget* parent)
bool InstanceImportTask::abort()
{
m_filesNetJob->abort();
if (m_filesNetJob)
m_filesNetJob->abort();
m_extractFuture.cancel();
return false;
@ -386,7 +387,7 @@ void InstanceImportTask::processFlame()
{
auto results = m_modIdResolver->getResults();
m_filesNetJob = new NetJob(tr("Mod download"), APPLICATION->network());
for(auto result: results.files)
for(const auto& result: results.files)
{
QString filename = result.fileName;
if(!result.required)