This will no longer show 'American English' with the statistics of
'British English', yet show the correct translations - and will now
display 'British English'.
Presumably this is caused by the bump to GCC 11 in Fedora 34. See
the error that did occur below...
./MultiMC5/application/KonamiCode.cpp: In member function ‘void KonamiCode::input(QEvent*)’:
./MultiMC5/application/KonamiCode.cpp:38:23: error: comparison of integer expressions of different signedness: ‘int’ and ‘std::array<Qt::Key, 10>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
38 | if(m_progress == konamiCode.size())
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
This resolves an issue with the modpacks.ch search functionality, in
which a search issued while one is currently in progress won't be made
and the UI won't allow for the search to be made after.
Reproduction Steps:
1. Open the FTB pane in the Add Instance Dialog
2. Perform a search while MMC is still performing the initial search
The search won't be performed, the existing search will have been
aborted, and you are unable to try the search again (without trying a
different search in the meantime).
This was caused by 2 things:
1. A search cannot be re-attempted, and this logic doesn't consider
failures.
2. The failure slot wasn't called when the NetJob was aborted, so
the search would never be performed - but the term would be
stored as if it had (trigering point 1).
I have resolved this by doing 2 things:
1. If the failure slot is called, set a searchState of Failed. Allow
search re-attempts in this case.
2. If there is a present NetJob, abort and reset it. The immediately
continue with the search.
This is prepatory work for implementing jarmods support for
modpacks.ch, where we will need to look through files in a directory -
which would require that those files are present at such time.
This might even fix some weird bugs, maybe - I've not encountered any
bugs from how this previously worked, but I feel that what's going on
is slightly clearer now.
There aren't any (currently) packs on modpacks.ch that use Fabric, but
they do have support in their modpacklauncher. This patch just means
we preemptively have support should any packs that require it be
introduced.
