flow
8409aa2571
tidy: Fix clang-tidy issues on files changed in this PR
...
The checks used are roughly the same as the ones proposed in the
clang-tidy PR (except perhaps that I used modernize-* instead of listing
them individually,though I don't think this caused any readability
detriments).
In ModrinthModel.cpp and FlameModModel.cpp I ignored the
modernize-avoid-c-arrays one, mostly because making the sorts array an
std::array would most likely increase the code complexity because of the
virtual function. Aside from that, the static_cast warning from
Application.h was not dealt with, since it's not in this PR's scope.
2022-03-14 17:43:36 -03:00
flow
b3c2a56ece
fix: delete semicolons at the end of .cpp file's functions
...
my lsp is weird sometimes
2022-03-07 19:55:20 -03:00
flow
9c57b54a81
refactor: move things around so that related things are close together
...
This also adds some comments around ModModel.cpp and ModPage.cpp to add
some ease of reading the code.
Also move some things from headers to cpp files.
2022-03-07 19:32:28 -03:00
flow
b131d3b2ec
refactor: move more common code to base class
...
Also removes unused imports and organize the ModModel header
2022-03-07 18:28:24 -03:00
flow
16bfafa29e
refactor: de-duplicate common code in network mod APIs
2022-03-07 17:45:28 -03:00
flow
f714adf6d2
refactor: move NetJob away from ModModel to ModAPI
...
This is done so that 1. ModAPI behaves more like an actual API instead
of just a helper, and 2. Allows for more easily creating other mod
providers that may or may not use network tasks (foreshadowing lol)
2022-03-07 16:22:57 -03:00
flow
39bd04f06f
refactor: use Enum instead of raw int for ModLoaderType
2022-03-06 16:45:39 -03:00
flow
d755174bee
clarify some method names and comments
2022-03-06 16:04:24 -03:00
flow
1229e90817
merge upstream
2022-03-06 15:28:18 -03:00
flow
5a638fa977
refactor: move "get versions" task from page to model
...
This seems more reasonable
2022-03-06 15:23:00 -03:00
flow
5e9d49a910
refactor: use only a single unique_ptr for the api
2022-03-06 13:54:55 -03:00
Sefa Eyeoglu
53468ea474
Merge pull request #221 from flowln/install_button
2022-03-05 20:43:44 +01:00
flow
e0c025b162
fix extra spacing in resource packs and shader packs, and move button up
...
hopefully now its finally ok
2022-03-03 09:51:46 -03:00
flow
9e443faba3
hack: hide 'Download Mods' button when not in the mods tab
2022-03-03 04:02:22 -03:00
flow
f95cebaf06
change 'Install Mods' -> 'Download Mods' and change position
2022-03-03 01:10:10 -03:00
flow
9a8599e4ba
fix windows compilation
2022-03-03 00:06:37 -03:00
flow
2d68308d49
refactor: move url creation for mods to modplatform/
...
Moves all things related to creating the URLs of the mod platforms
that go to network tasks to a single place, so that:
1. Maintaining and fixing eventual issues is more straightforward.
2. Makes it possible to factor out more common code between the
different modplatform pages
2022-03-02 23:13:04 -03:00
flow
0dd1c26cf3
refactor: extract common code in mod pages and model
...
This creates a hierarchy in which ModPage and ModModel are the parents
of every mod provider, providing the basic functionality common to all
of them.
It also imposes a unique .ui file (they were already equal before, just
duplicated basically) on all mod providers.
2022-03-02 21:52:44 -03:00
flow
881b2f2b38
refactor: Use a single indexed pack for mods
...
Since there's little difference between them, let's remove duplication
and merge them.
2022-03-02 18:49:19 -03:00
Ezekiel Smith
ca211558b5
Merge pull request #216 from txtsd/ignore_paths
...
Don't build when updating non-code
2022-03-02 11:48:45 +11:00
txtsd
3a03f90831
Ignore certain paths for CI
2022-03-02 01:17:08 +05:30
timoreo22
9020f632b2
Merge pull request #214 from PolyMC/ZekeSmith-newReadme
...
Modify readme to use website
2022-03-01 16:56:41 +01:00
timoreo22
8bdd2befe9
Merge pull request #205 from timoreo22/fix-version-select
...
Fixed wrong version info
2022-03-01 16:56:10 +01:00
Ezekiel Smith
ebececf8c6
Update and link latest build to actions
2022-03-01 23:19:30 +10:00
Ezekiel Smith
e1f28be151
Merge pull request #163 from txtsd/windows_data_dir
...
Replace build layouts with Launcher_PORTABLE cmake flag
2022-03-02 00:03:31 +11:00
Ezekiel Smith
10231aa404
Modify readme to use website
2022-03-01 10:33:59 +10:00
Sefa Eyeoglu
139ff82432
Merge pull request #207 from flowln/curseforge_api
2022-02-28 13:35:58 +01:00
flow
4e8f075ff3
fix: Do not loop when its not a fabric mod on Flame version validation
...
Since there's no validation for forge mods since the start, we were just
looping with no porpuse in this situation.
2022-02-27 22:02:43 -03:00
Lenny McLennington
148775b3e9
Update FMLLIBS_BASE_URL
...
Updated FMLLIBS_BASE_URL to https://files.polymc.org/fmllibs/
Fixes #208
2022-02-27 19:40:52 +00:00
flow
075d900d45
fix: Always tell Flame API which modloader we are using
...
Fixes #206 partially. Although we don't list mods that have no
compatibility with the mod loader we are using, mods that have support
for both loaders still show up, and the versions for both the loaders
are still shown.
Also simplifies a little the logic in
FlameModIndex::loadIndexedPackVersions
2022-02-27 16:07:45 -03:00
txtsd
5d1ca33b84
Apply suggestions from code review
...
Co-authored-by: LennyMcLennington <lenny@sneed.church>
2022-02-27 08:35:47 -08:00
timoreo
ccc493cb2b
Cleanly free NetJob in flame modpack
2022-02-27 13:14:12 +01:00
timoreo
2745325ae0
Fixed wrong version info
2022-02-27 11:55:24 +01:00
dada513
84e9ce71b0
Merge pull request #203 from glowiak/patch-4
2022-02-27 09:53:56 +01:00
Sefa Eyeoglu
88fc1e32ee
Merge pull request #201 from Scrumplex/fix-instancetype-reregistration
2022-02-26 14:37:27 +01:00
glowiak
4f975bfb04
Notify about needed AppBSD version
2022-02-26 13:04:35 +01:00
timoreo22
692b9cf0e0
Merge pull request #195 from babbaj/nix-refactor
...
nix: Use POLYMC_JAVA_PATHS
2022-02-26 07:34:19 +01:00
timoreo22
ae354688c9
Merge pull request #193 from flowln/develop
...
Allow for downloading multiple mods at once
2022-02-26 07:33:11 +01:00
Sefa Eyeoglu
c9bf7f9896
fix: load instances no matter their instance type
2022-02-26 00:31:37 +01:00
Babbaj
e8929599a5
nix: Use POLYMC_JAVA_PATHS
2022-02-25 16:47:47 -05:00
Sefa Eyeoglu
27f37315f8
Merge pull request #199 from Scrumplex/fix-translations
2022-02-25 17:47:08 +01:00
flow
c4f4e9e620
merge upstream and resolve conflicts
2022-02-25 13:43:27 -03:00
Ezekiel Smith
f2b850ad20
Merge pull request #183 from timoreo22/fix-versions-segfault
...
Fixed segfault in mod download
2022-02-26 01:55:11 +11:00
Ezekiel Smith
ccc27d1b7c
Merge pull request #192 from Scrumplex/refactor-remove-legacy-instances
...
Drop legacy instances
2022-02-26 01:54:15 +11:00
Sefa Eyeoglu
4835ec3f6d
fix(i18n): update translations URL
2022-02-25 15:19:15 +01:00
flow
40a9828fba
fix: improve readability and set ok button as disabled by default
2022-02-23 19:17:33 -03:00
flow
04840d0638
fix(ui): add translation func to text in the confirm dialog
2022-02-23 14:44:55 -03:00
flow
38f12c50f7
Merge branch 'PolyMC:develop' into develop
2022-02-23 14:34:51 -03:00
Sefa Eyeoglu
ca8b62291f
fix: use legacy data path if it exists
2022-02-23 16:22:53 +05:30
txtsd
69d01204e0
Implement PR suggestions
2022-02-23 16:22:53 +05:30
