pollymc/launcher/modplatform/flame
flow d2fdbec41d
fix: move file deletion to the end of the instance update
This makes it harder for problems in the updating process to affect the
current instance. Network issues, for instance, will no longer put the
instance in an invalid state.

Still, a possible improvement to this would be passing that logic to
InstanceStaging instead, to be handled with the instance commiting
directly. However, as it is now, the code would become very spaguetti-y,
and given that the override operation in the commiting could also put
the instance into an invalid state, it seems to me that, in order to
fully error-proof this, we would need to do a copy operation on the
whole instance, in order to modify the copy, and only in the end
override everything an once with a rename. That also has the possibility
of corrupting the instance if done without super care, however, so I
think we may need to instead create an automatic backup system, with an
undo command of sorts, or something like that. This doesn't seem very
trivial though, so it'll probably need to wait until another PR. In the
meantime, the user is advised to always backup their instances before
doing this kind of action, as always.

What a long commit message o.O

Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20 18:36:09 -03:00
..
FileResolvingTask.cpp fix: add abort handlign in Flame's FileResolvingTask 2022-07-26 20:33:33 +02:00
FileResolvingTask.h fix: add abort handlign in Flame's FileResolvingTask 2022-07-26 20:33:33 +02:00
FlameAPI.cpp feat: add 'getFiles' by fileIds route in Flame API 2022-09-20 18:36:07 -03:00
FlameAPI.h feat: add 'getFiles' by fileIds route in Flame API 2022-09-20 18:36:07 -03:00
FlameCheckUpdate.cpp fix: fix translations for mod updater 2022-07-19 18:03:45 +02:00
FlameCheckUpdate.h fix: std::list -> QList 2022-07-17 11:33:45 -03:00
FlameInstanceCreationTask.cpp fix: move file deletion to the end of the instance update 2022-09-20 18:36:09 -03:00
FlameInstanceCreationTask.h fix: correctly set managed pack fields in CF pack 2022-09-20 18:36:09 -03:00
FlameModIndex.cpp feat: lazy-load CF mod descriptions 2022-08-01 07:33:30 -03:00
FlameModIndex.h feat: lazy-load CF mod descriptions 2022-08-01 07:33:30 -03:00
FlamePackIndex.cpp fix https://github.com/PolyMC/PolyMC/issues/798 2022-06-15 09:11:23 +02:00
FlamePackIndex.h Merge pull request #634 from flowln/donate_links 2022-06-14 23:52:00 +10:00
PackManifest.cpp feat: add curseforge modpack updating 2022-09-20 18:36:08 -03:00
PackManifest.h feat: add curseforge modpack updating 2022-09-20 18:36:08 -03:00