Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

export file select dialogue does not correctly reject empty filenames - two (probably long standing) coding errors: use of method name 'strip' instead of calling it, and does not isolate the filename from the full pathname

Browse Source 
svn: r21270
This commit is contained in:
Tim G L Lyons 2013-02-01 17:46:43 +00:00
parent 8f7a645ece
commit 6154ebad23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ExportAssistant.py
View File

@ -357,7 +357,8 @@ class ExportAssistant(gtk.Assistant, ManagedWindow.ManagedWindow) :
filename = filechooser.get_filename()
folder = filechooser.get_current_folder()
#the file must be valid, not a folder, and folder must be valid
if filename and filename.strip and Utils.find_folder(filename) == '' \
if filename and os.path.basename(filename.strip()) \
and Utils.find_folder(filename) == '' \
and folder and Utils.find_folder(folder):
#this page of the assistant is complete
self.set_page_complete(filechooser, True)