moving to the 'trusty' distribution which has Python 3.3 (coverage needs
3.3 or more) and also a Python 3 version of pyicu. This doesn't use the
virtualenv at all, so the various pip installs are removed. There are
still some minor omissions, noted in FIXMEs; in particular, the code
should be tested under Python 3.2 (which is the minimum Gramps
requirement).
gramps.plugins.database.dbapi_support.sqlite.Sqlite.try_execute ignores
errors Check if the table 'person' exists to determine whether the
database is new.
In the process of searching for uses of ErrorDialog which
did not have a "parent" argument, I stumbled on this module
-- and noticed something different in it.
Benny changed the original "ErrorDialog" calls to a
"ERROR = ErrorDialog" variant in
9a2fd50642
on 30 January 2011, "to allow a QML interface" (which by the
way has subsequently been removed from the mainline gramps
code).
In the same commit, in cli/clidbman.py, he added an
_errordialog function and an "ERROR = _errordialog" line,
evidently so all DB errors, no matter whether in GUI or CLI
code, could be changed to things like:
ERROR(_("Could not rename family tree"), str(msg))
But then in 16 February 2011 MDNauta, in
7c1b26d969
changed the generic ERROR to either DbManager.ERROR or else
CLIDbManager.ERROR, depending on whether it was in GUI code
or CLI code.
Which of course defeated the purpose of the change to the
generic call, so I have changed it back to the original
ErrorDialog call, directly.
The decision was made even easier by noticing lots of
more-recent error-handling code which used the ErrorDialog
form as opposed to Benny's variant.
cli/arghandler.py went from 8.30 to 9.52
cli/argparser.py went from 8.43 to 9.74
cli/grampscli.py went from 7.99 to 9.29
cli/plug/__init__.py went from 7.63 to 9.69
