emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libiproute: fix buggy open check: s/if (fd)/if (fd >= 0)/

Browse Source 
less: small optimization -15 bytes
This commit is contained in:
Denis Vlasenko 2008-12-10 14:14:09 +00:00
parent 311c19a661
commit 12abcb36c8
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
miscutils/less.c
View File

@ -774,9 +774,7 @@ static void buffer_line(int linenum)
static void open_file_and_read_lines(void)
{
if (filename) {
int fd = xopen(filename, O_RDONLY);
dup2(fd, 0);
if (fd) close(fd);
xmove_fd(xopen(filename, O_RDONLY), STDIN_FILENO);
} else {
/* "less" with no arguments in argv[] */
/* For status line only */

2
networking/libiproute/ll_map.c
View File

@ -172,7 +172,7 @@ int xll_name_to_index(const char *const name)
#endif
sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
if (sock_fd) {
if (sock_fd >= 0) {
struct ifreq ifr;
int tmp;