emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ftpd: work around LIST -aXYZ too, not only LIST -lXYZ

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2010-04-21 18:05:10 -04:00
parent 5a7c72015c
commit 238c83bd82
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
networking/Config.in
View File

@ -122,8 +122,8 @@ config FEATURE_FTPD_ACCEPT_BROKEN_LIST
default y
depends on FTPD
help
Some ftp-clients (among them KDE's Konqueror) issue illegal
"LIST -la" requests. This option works around those problems.
Some ftp clients (among them KDE's Konqueror) issue illegal
"LIST -l" requests. This option works around such problems.
It might prevent you from listing files starting with "-" and
it increases the code size by ~40 bytes.
Most other ftp servers seem to behave similar to this.

4
networking/ftpd.c
View File

@ -618,10 +618,10 @@ popen_ls(const char *opt)
argv[4] = NULL;
/* Improve compatibility with non-RFC conforming FTP clients
* which send e.g. "LIST -l", "LIST -la".
* which send e.g. "LIST -l", "LIST -la", "LIST -aL".
* See https://bugs.kde.org/show_bug.cgi?id=195578 */
if (ENABLE_FEATURE_FTPD_ACCEPT_BROKEN_LIST
&& G.ftp_arg && G.ftp_arg[0] == '-' && G.ftp_arg[1] == 'l'
&& G.ftp_arg && G.ftp_arg[0] == '-'
) {
const char *tmp = strchr(G.ftp_arg, ' ');
if (tmp) /* skip the space */