emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

setserial: make it NOEXEC

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-08-06 18:06:46 +02:00
parent 08e66a8149
commit 97b738d359
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NOFORK_NOEXEC.lst
View File

@ -310,7 +310,7 @@ setfont
setkeycodes
setlogcons
setpriv - spawner, changes state, let's play safe and not be noexec
setserial
setserial - noexec
setsid - spawner, uses fork_or_rexec() [not audited to work in noexec], let's play safe and not be noexec
setuidgid - noexec. spawner
sha1sum - noexec. runner

7
miscutils/setserial.c
View File

@ -15,7 +15,7 @@
//config: help
//config: Retrieve or set Linux serial port.
//applet:IF_SETSERIAL(APPLET(setserial, BB_DIR_BIN, BB_SUID_DROP))
//applet:IF_SETSERIAL(APPLET_NOEXEC(setserial, setserial, BB_DIR_BIN, BB_SUID_DROP, setserial))
//kbuild:lib-$(CONFIG_SETSERIAL) += setserial.o
@ -746,14 +746,15 @@ int setserial_main(int argc UNUSED_PARAM, char **argv)
opts = getopt32(argv, "bGavzgq");
argv += optind;
if (!argv[1]) /* one arg only? */
opts |= OPT_LIST_OF_DEVS;
if (!argv[1]) /* one arg only? (nothing to change?) */
opts |= OPT_LIST_OF_DEVS; /* force display */
if (!(opts & OPT_LIST_OF_DEVS)) {
serial_set(argv, opts);
argv[1] = NULL;
}
/* -v effect: "after setting params, do not be silent, show them" */
if (opts & (OPT_VERBOSE | OPT_LIST_OF_DEVS)) {
do {
serial_get(*argv, opts & OPT_MODE_MASK);