emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ash: add a fixme comment at run_nofork_applet

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-08-03 19:56:29 +02:00
parent 19c9f31af1
commit cfd392bea9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shell/ash.c
View File

@ -9918,11 +9918,13 @@ evalcommand(union node *cmd, int flags)
if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) { if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) {
listsetvar(varlist.list, VEXPORT|VSTACK); listsetvar(varlist.list, VEXPORT|VSTACK);
/* run <applet>_main() */ /* run <applet>_main() */
//FIXME: do we need INT_OFF / INT_ON here?
//wouldn't open files and allocations leak on ^C otherwise?
status = run_nofork_applet(applet_no, argv); status = run_nofork_applet(applet_no, argv);
break; break;
} }
#endif #endif
/* Can we avoid forking off? For example, very last command /* Can we avoid forking? For example, very last command
* in a script or a subshell does not need forking, * in a script or a subshell does not need forking,
* we can just exec it. * we can just exec it.
*/ */