busybox

Author	SHA1	Message	Date
Denys Vlasenko	d16e612c93	hush: fix redirect code (was using uninitialized variables) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-11 15:41:39 +02:00
Denys Vlasenko	9a7d0a0191	shell: add OPTARG poisoning to getopt_optarg.tests ash fails this! Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-11 02:37:48 +02:00
Denys Vlasenko	81f962f3df	hush: teach getopts to set/unset OPTARG Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-11 02:05:21 +02:00
Denys Vlasenko	74d4058928	hush: getopts builtin function old new delta builtin_getopts - 271 +271 bltins1 372 384 +12 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/0 up/down: 283/0) Total: 283 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-11 01:32:46 +02:00
Denys Vlasenko	11f2e99c13	hush: optional times builtin function old new delta builtin_times - 108 +108 bltins1 360 372 +12 static.times_tbl - 9 +9 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 1/0 up/down: 129/0) Total: 129 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 16:34:03 +02:00
Denys Vlasenko	1f41c885fc	hush: implement -d DELIM option for 'read' The POSIX standard only requires the 'read' builtin to handle '-r': http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html However, Bash introduced the option '-d <DELIM>' to override IFS for just one invocation, and it is quite useful. We already support this in ash, let's add it to hush, too. function old new delta builtin_read 263 284 +21 .rodata 163587 163589 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 23/0) Total: 23 bytes Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-09 13:52:36 +02:00
Denys Vlasenko	80e8e3cc05	noexec: consolidate code function old new delta run_noexec_applet_and_exit - 61 +61 find_applet_by_name 128 124 -4 run_applet_no_and_exit 441 434 -7 tryexec 169 152 -17 pseudo_exec_argv 338 321 -17 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/6 up/down: 61/-48) Total: 13 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 19:24:57 +02:00
Denys Vlasenko	c9c1ccc4ed	noexec: do GETOPT_RESET() before entering APPLET_main() hush -c 'yes \| head -1' was not happy. function old new delta tryexec 159 169 +10 pseudo_exec_argv 328 338 +10 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 18:59:35 +02:00
Denys Vlasenko	f2cf1cc716	noexec: set comm field for noexecs function old new delta set_task_comm - 18 +18 tryexec 152 159 +7 pseudo_exec_argv 321 328 +7 main 106 97 -9 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/2 up/down: 34/-13) Total: 23 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 18:45:33 +02:00
Denys Vlasenko	248a67fb75	free,stat: make NOEXEC pkill/pgrep/pidof uncovered another quirk: what about noexec's _process names_? Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 18:18:09 +02:00
Denys Vlasenko	49e6bf2db9	sheel: improve comments on signal handling Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 14:28:16 +02:00
Denys Vlasenko	39701204cf	hush: do not accept "if() { echo; }" function def function old new delta parse_stream 2634 2692 +58 msg_and_die_if_script - 21 +21 syntax_error_unexpected_ch 41 46 +5 syntax_error_at 14 18 +4 die_if_script 31 28 -3 setup_redirects 319 308 -11 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/2 up/down: 88/-14) Total: 74 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 19:46:14 +02:00
Denys Vlasenko	84ea60ed65	line editing: make read_line_input() not take timeout param It's almost always -1. function old new delta read_line_input 3902 3912 +10 new_line_input_t 24 31 +7 pgetc 583 585 +2 save_command_ps_at_cur_history 80 78 -2 read_line 76 74 -2 fgetc_interactive 246 244 -2 addLines 84 82 -2 doCommands 2226 2222 -4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/5 up/down: 19/-12) Total: 7 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 17:27:28 +02:00
Denys Vlasenko	dd4b446f76	hush: make SIGINT handling visually less confusing $ echo $$ 18448 $ echo $? <wait here, run "kill -INT 18448" in other shell><press enter> <=== NOTHING?? $ That empty line does not look right. After this patch: $ echo $$ 18448 $ echo $? <wait here, run "kill -INT 18448" in other shell><press enter> ^C $ function old new delta fgetc_interactive 245 246 +1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 16:52:12 +02:00
Denys Vlasenko	7c40ddd950	NOFORK fixes "rm -i FILE" and "yes" can now be interrupted by ^C in hush. This also now works: $ usleep 19999999 ^C $ echo $? 130 function old new delta run_pipe 1668 1711 +43 pseudo_exec_argv 312 321 +9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 52/0) Total: 52 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 16:37:39 +02:00
Denys Vlasenko	cee603d921	hush: remove redundant "G_flag_return_in_progress = -1" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 18:06:07 +02:00
Denys Vlasenko	5b3d2eb327	hush: fix "true \| func_with_return" not allowing return. function old new delta pseudo_exec_argv 305 312 +7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 18:02:28 +02:00
Denys Vlasenko	75481d3634	hush: functions have priority over builtins (!) function old new delta pseudo_exec_argv 291 305 +14 run_pipe 1560 1555 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 14/-5) Total: 9 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 05:27:09 +02:00
Denys Vlasenko	bf1c344dfd	hush: if STANDALONE, close interactive fd for NOEXECed children function old new delta pseudo_exec_argv 291 305 +14 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 04:54:53 +02:00
Denys Vlasenko	32fdf2f9fc	ash,hush: ">&10" redirects to script/tty fds should not work The fact that shell has open fds to tty and/or scripts should be unobservable, if possible. In particular, if redirect tries to dup one of them via ">&script_fd", it's better to pretend that script_fd is closed, and thus redirect fails with EBADF. Fixes these two testcase failures: ash-redir/redir_to_bad_fd.tests hush-redir/redir_to_bad_fd3.tests function old new delta redirect 1018 1129 +111 setup_redirects 250 359 +109 readtoken1 2651 2655 +4 cmdloop 185 187 +2 changepath 194 195 +1 save_fd_on_redirect 203 194 -9 evaltree 501 484 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/2 up/down: 227/-26) Total: 201 bytes text data bss dec hex filename 914553 485 6848 921886 e111e busybox_old 914754 485 6848 922087 e11e7 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 04:35:18 +02:00
Denys Vlasenko	657e9005a9	hush: massage redirect code to be slightly more like ash function old new delta save_fd_on_redirect - 203 +203 xdup_CLOEXEC_and_close - 75 +75 setup_redirects 245 250 +5 xdup_and_close 72 - -72 save_fds_on_redirect 221 - -221 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/0 up/down: 283/-293) Total: -10 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 04:08:09 +02:00
Denys Vlasenko	0f018b3070	hush: fix handling of empty heredoc EOF marker function old new delta parse_stream 2609 2634 +25 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-29 20:43:26 +02:00
Denys Vlasenko	2093ad296f	hush: fix ${##}, ${#?}, ${#!} handling function old new delta parse_dollar 786 820 +34 expand_one_var 1579 1592 +13 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 47/0) Total: 47 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-26 00:07:27 +02:00
Denys Vlasenko	86981e3ad2	ash: allow "trap NUM [SIG]..." syntax While at it, make get_signum() return -1 for numeric strings >= NSIG. function old new delta trapcmd 292 306 +14 get_signum 295 300 +5 builtin_trap 413 412 -1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 19/-1) Total: 18 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-25 20:06:17 +02:00
Denys Vlasenko	645c697372	hush: treat ${#?} as "length of $?" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-25 15:18:57 +02:00
Denys Vlasenko	621fc50e83	hush: fix a case when redirect to a closed fd #1 is not restoring (closing) it function old new delta setup_redirects 200 245 +45 append_squirrel - 41 +41 save_fds_on_redirect 256 221 -35 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/1 up/down: 86/-35) Total: 51 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-24 12:42:17 +02:00
Denys Vlasenko	0675b03de4	hush: use mempcpy where useful function old new delta o_addblock 58 42 -16 expand_one_var 1618 1555 -63 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-79) Total: -79 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-24 02:17:05 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	f9d656f787	hush: remove contradicting size info in config help Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:23:55 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	d2c15bc763	hush: tweak "help" output Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 18:14:42 +02:00
Denys Vlasenko	cf5110978b	hush: fix readonly2.tests failure Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 15:58:02 +02:00
Denys Vlasenko	5b2cc0aaee	hush: do not assign to readonly VAR in "VAR=VAL CMD" syntax too Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 02:44:06 +02:00
Denys Vlasenko	38ef39a1ab	hush: add readonly testcase, fix fallout function old new delta helper_export_local 185 214 +29 run_pipe 1549 1560 +11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 40/0) Total: 40 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 01:40:01 +02:00
Denys Vlasenko	3bab36b18b	hush: convert exp/ro/local parameters to bitfields in one flag param function old new delta helper_export_local 174 185 +11 set_local_var 424 420 -4 run_list 1048 1044 -4 set_vars_and_save_old 88 83 -5 set_local_var_from_halves 27 22 -5 run_pipe 1554 1549 -5 builtin_export 173 168 -5 set_pwd_var 40 34 -6 builtin_readonly 70 64 -6 expand_one_var 1625 1618 -7 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/9 up/down: 11/-47) Total: -36 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 01:05:24 +02:00
Denys Vlasenko	6b0695bb66	hush: HUSH_READONLY depends on HUSH Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 21:47:27 +02:00
Denys Vlasenko	6b48e1f121	hush: forgot to emit error on (failing) second "readonly VAR=VAL" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 21:31:17 +02:00
Denys Vlasenko	b95ee96e75	hush: smaller code in !READONLY configs Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 21:19:53 +02:00
Denys Vlasenko	1e660422b1	hush: implement "readonly" builtin function old new delta builtin_readonly - 70 +70 helper_export_local 152 174 +22 bltins1 348 360 +12 expand_one_var 1620 1625 +5 builtin_export 168 173 +5 set_pwd_var 36 40 +4 set_local_var 410 414 +4 set_vars_and_save_old 85 88 +3 set_local_var_from_halves 24 27 +3 run_pipe 1551 1554 +3 run_list 1046 1048 +2 builtin_type 116 114 -2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 10/1 up/down: 133/-2) Total: 131 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 21:10:50 +02:00
Denys Vlasenko	0ba80e4fa2	hush: small fix to last commit die_if_script() indeed dies only in scripts! Must handle the case where it continues. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 16:50:20 +02:00
Denys Vlasenko	e32b6503e7	hush: support ${VAR:N:-M} function old new delta expand_one_var 1602 1615 +13 builtin_type 114 116 +2 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 16:46:57 +02:00
Denys Vlasenko	203fd7bc66	shells: expand TODO comments, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-17 16:13:35 +02:00
Denys Vlasenko	b24e55da84	hush: fix "cmd1 && cmd2 &" handling on NOMMU function old new delta done_pipe 234 238 +4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-16 20:29:35 +02:00
Denys Vlasenko	ee553b929c	hush: fix and_or_and_backgrounding.tests failure function old new delta done_pipe 133 218 +85 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-15 22:51:55 +02:00
Denys Vlasenko	2ed74e25d3	hush: make "wait %1" work even if the job is dead Example script: sleep 1 \| (sleep 1;exit 3) & sleep 2 echo Zero:$? wait %1 echo Three:$? function old new delta clean_up_last_dead_job - 24 +24 process_wait_result 426 447 +21 builtin_wait 285 293 +8 insert_job_into_table 264 269 +5 builtin_jobs 68 73 +5 remove_job_from_table 59 57 -2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 4/1 up/down: 63/-2) Total: 61 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 19:58:46 +02:00
Denys Vlasenko	0c5657e911	hush: remove superfluous comparison function old new delta builtin_wait 291 285 -6 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 19:27:03 +02:00
Denys Vlasenko	9fda609a60	hush: add support for "set -e" function old new delta run_list 978 1046 +68 o_opt_strings 24 32 +8 reset_traps_to_defaults 136 142 +6 pick_sighandler 57 60 +3 packed_usage 31772 31770 -2 hush_main 983 961 -22 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/2 up/down: 85/-24) Total: 61 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 13:36:48 +02:00
Denys Vlasenko	b057806a6a	hush: add TODO for "set -e" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-10 10:33:27 +02:00
Denys Vlasenko	9e55a156f8	hush: simplify insert_job_into_table() a bit function old new delta done_word 767 761 -6 insert_job_into_table 325 264 -61 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 59/-126) Total: -67 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-10 10:01:12 +02:00
Denys Vlasenko	1609629a91	hush: rename a few functions Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-10 10:00:28 +02:00
Denys Vlasenko	13102634bb	hush: explain why wait5.tests is failing Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-08 00:24:32 +02:00
Denys Vlasenko	840a4355d0	hush: fix "(sleep 1; exit 3) & sleep 2; echo $?; wait $!; echo $?" function old new delta process_wait_result 414 426 +12 builtin_wait 283 291 +8 run_list 974 978 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 24/0) Total: 24 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-07 22:56:02 +02:00
Denys Vlasenko	2db74610cd	hush: fix two redirection testcase failures function old new delta save_fds_on_redirect 183 256 +73 fcntl_F_DUPFD - 46 +46 restore_redirects 74 96 +22 xdup_and_close 51 72 +21 setup_redirects 196 200 +4 hush_main 988 983 -5 static.C 12 - -12 run_pipe 1595 1551 -44 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 4/2 up/down: 166/-61) Total: 105 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-07 22:07:28 +02:00
Denys Vlasenko	69a5ec9dcc	main: fix the case where user has "halt" as login shell. Closes 9986 halt::0:0::/:/sbin/halt function old new delta run_applet_and_exit 748 751 +3 run_applet_no_and_exit 467 459 -8 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-07 19:08:56 +02:00
Denys Vlasenko	50b8b2914b	hush: add a TODO about redir3.tests failure Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-06 20:57:37 +02:00
Denys Vlasenko	e59591a364	hush: Print error messages on shift -1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-06 20:12:44 +02:00
Denys Vlasenko	5dad7bdc3b	hush: implement negative start in the ${v: -n[:m]} idiom Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-06 19:48:20 +02:00
Denys Vlasenko	7456298472	hush: "adopt" ash signal4.tests Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-06 18:40:45 +02:00
Denys Vlasenko	637982f5bb	hush: correctly handle quoting in "case" even if !BASH_PATTERN_SUBST Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-06 01:52:23 +02:00
Denys Vlasenko	bd43c6784f	hush: fix quoted_punct.tests failure Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-05 23:12:15 +02:00
Denys Vlasenko	d4e4fdb5ce	fixes for bugs found by make_single_applets.sh Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-03 21:31:16 +02:00
Denys Vlasenko	2e989ef232	msh: delete this applet It's deprecated since 2009 and interferes with make_single_applets.sh tests. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-03 16:56:37 +02:00
Denys Vlasenko	4ee824f6ba	randomconfig fixes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-03 01:22:13 +02:00
Denys Vlasenko	f547041940	ash,hush: fix SIGCHLD interrupting read builtin function old new delta readcmd 169 217 +48 shell_builtin_read 1087 1097 +10 localcmd 366 364 -2 builtin_read 197 193 -4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/2 up/down: 58/-6) Total: 52 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-05-22 19:34:45 +02:00
Denys Vlasenko	10ad622dc2	Spelling fixes in comments, documentation, tests and examples By klemens <ka7@github.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-17 16:13:32 +02:00
Denys Vlasenko	205d48e948	*: add comment about APPLET_ODDNAME format It confused me more than once Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-29 14:57:33 +01:00
Denys Vlasenko	8944c67b1f	hush: reinstate [[ builtin Mike deleted it: commit `39456a18a1` Author: Mike Frysinger <vapier@gentoo.org> Date: Sat Mar 28 12:21:57 2009 +0000 stop lying about [[ test support probably because it was not properly ifdefed around, and was enabled even when bash compat is off. I just tested it - it works: $ [ .diff = z.diff ]; echo $? 0 $ [[ .diff = z.diff ]]; echo $? 1 Of course, not all numerous bash tricks of [[ ]] are implemented... function old new delta bltins2 60 72 +12 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 14:22:00 +01:00
Kang-Che Sung	027d3ab57d	hush: split bash compatible extensions into separate defines. No code changes Splitting these options makes it self-documenting about what bash-compatible features we have. Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 14:18:30 +01:00
Denys Vlasenko	80f806cac9	hush: shorten output of "help" builtin text data bss dec hex filename 891272 485 6856 898613 db635 busybox_old 891232 485 6856 898573 db60d busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 16:51:10 +01:00
Denys Vlasenko	a1184af5f8	hush: reorder builtins (cd and pwd ought to be close, etc), no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 15:58:02 +01:00
Denys Vlasenko	265062d59d	shells: make hush test optional, rename ASH_BUILTIN_foo -> ASH_foo This makes hash and ash more symmetrical wrt config menu and config options. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 15:13:30 +01:00
Denys Vlasenko	f560422fa0	Big cleanup in config help and description Redundant help texts (one which only repeats the description) are deleted. Descriptions and help texts are trimmed. Some config options are moved, even across menus. No config option _names_ are changed. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 14:58:54 +01:00
Denys Vlasenko	1cc6804f69	hush: make echo builtin optional It's a bit overkill (who would want it off?) but ash already has it configurable. Let's be symmetric. Also tweak kbuild logic to use ASH_BUILTIN_ECHO to select echo.o, not ASH. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 17:10:04 +01:00
Denys Vlasenko	2b1559056c	hush: fix a bug in argv restoration after sourcing a file if sourced file "shift"ed argvs so that $1 is NULL, restore wasn't done. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 08:13:21 +01:00
Denys Vlasenko	4e4f88e569	hush: global_args_malloced is used only if set builtin is enabled function old new delta run_pipe 1623 1635 +12 builtin_source 210 222 +12 save_and_replace_G_args 70 60 -10 builtin_shift 132 94 -38 restore_G_args 98 - -98 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 2/2 up/down: 24/-146) Total: -122 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 07:57:38 +01:00
Denys Vlasenko	cc2fd5a986	hush: fix 'defined but not used' warning Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 06:19:55 +01:00
Denys Vlasenko	5362cc4b8c	hush: remove redundand test for ENABLE_HUSH_JOB Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 05:57:13 +01:00
Denys Vlasenko	fd68f1e80d	hush: fix kill builtin without jobs support Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 05:47:57 +01:00
Denys Vlasenko	442a414d66	typo fix Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 05:11:09 +01:00
Denys Vlasenko	41ade05cac	hush: conditionalize print_escaped() on EXPORT \|\| TRAP Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 18:56:24 +01:00
Denys Vlasenko	4471969db2	hush: make memleak builtin optional Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 18:44:41 +01:00
Denys Vlasenko	6ec76d8719	hush: make export builtin optional Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 18:40:41 +01:00
Denys Vlasenko	d5933b1125	hush: make umask builtin optional Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 18:31:39 +01:00
Denys Vlasenko	10d5ece64a	hush: make set/unset builtins optional Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 18:28:43 +01:00
Denys Vlasenko	7a85c60e7e	hush: make read and trap builtins optional Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 17:40:18 +01:00
Denys Vlasenko	1125d7d680	hush: kill builtin and kill %jobspec support Also made it and printf, type and wait builtins optional. function old new delta builtin_kill - 323 +323 bltins1 336 348 +12 builtin_type 114 116 +2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/0 up/down: 337/0) Total: 337 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 17:19:38 +01:00
Denys Vlasenko	d5b5c2fa15	hush: support %%, %+ and % jobspec (meaning "current job") function old new delta parse_jobspec 83 133 +50 builtin_wait 278 283 +5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 15:46:04 +01:00
Denys Vlasenko	b05bcaf29c	hush: correct exitcode for unterminated ')' - exitcode2.tests testcase function old new delta parse_stream 2595 2609 +14 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-03 11:47:50 +01:00
Denys Vlasenko	0b8835861b	Make it possible to select "sh" and "bash" aliases without selecting ash or hush The same can be done for msh, but we are probably better off just deleting it in a next versio or two. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-23 16:56:43 +01:00
Denys Vlasenko	6704746c69	shell: move "config" blocks above their use in coditional includes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-22 15:21:58 +01:00
Denys Vlasenko	b6afcc7819	shell: suppress "unused var/func" warnings on some configs Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-12 16:30:20 +01:00
Denys Vlasenko	4b89d512b1	ash,hush: make ^C in interactive mode visually much closer to bash behavior Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-25 03:41:03 +01:00
Denys Vlasenko	8660aeb312	ash,hush: ^C from command line should set $? to 128+SIGINT Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-24 17:44:02 +01:00
Denys Vlasenko	87e039d016	hush: make getch/peek functions directly called Indirect calls are more difficult to predict. Unfortunately, on x64 direct call is 5 bytes while indirect "call (reg+ofs)" is 3 bytes: function old new delta i_getch - 82 +82 i_peek - 63 +63 parse_stream 2531 2579 +48 parse_dollar 771 797 +26 parse_redirect 296 321 +25 add_till_closing_bracket 408 420 +12 encode_string 256 265 +9 i_peek_and_eat_bkslash_nl 93 99 +6 add_till_backquote 110 114 +4 parse_and_run_stream 139 141 +2 expand_vars_to_list 1143 1144 +1 static_peek 6 - -6 setup_string_in_str 39 18 -21 setup_file_in_str 40 19 -21 static_get 27 - -27 file_peek 52 - -52 file_get 65 - -65 ------------------------------------------------------------------------------ (add/remove: 2/4 grow/shrink: 9/2 up/down: 278/-192) Total: 86 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 22:35:05 +01:00
Denys Vlasenko	00a06b9715	hush: renumber PIPE_foo, make PIPE_SEQ = 0 PIPE_SEQ is used most often, having it zero makes code smaller: function old new delta done_word 719 707 -12 parse_stream 2546 2531 -15 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 20:35:53 +01:00
Denys Vlasenko	6c635d62d4	hush: small optimization in run_list I thought gcc can detect this itself. It doesn't. function old new delta run_list 1030 1021 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 20:26:11 +01:00
Denys Vlasenko	5cc9bf6a21	hush: deindent large block of code, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 17:34:44 +01:00
Denys Vlasenko	1eada9ad8d	hush: simplify insert_bg_jobs function old new delta insert_bg_job 366 281 -85 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 17:28:45 +01:00
Denys Vlasenko	830ea35484	hush: make "wait %1" less likely to play with signal mask Was playing with "sleep 3 \| exit 3 & wait %1" and noticed that often SIGCHLD arrives even before I get to signal masking. Can avoid it in this case. function old new delta wait_for_child_or_signal 228 265 +37 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 04:59:11 +01:00
Denys Vlasenko	02affb4afd	hush: rework "wait %jobspec" to work in non-interactive shells too Also add tests. wait5.tests so far fails (but works for ash and dash). function old new delta builtin_wait 305 283 -22 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-08 00:59:29 +01:00
Denys Vlasenko	26ad94bedc	hush: "wait $!; echo $?" should return 127 if $! already exited It would be nice to provide bash-like "remember las exitcode" thingy, but it's a bit complex. For now, match ash and dash. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-07 23:07:21 +01:00
Denys Vlasenko	62b717b75e	hush: implement "wait %jobspec" function old new delta parse_jobspec - 83 +83 job_exited_or_stopped - 79 +79 builtin_wait 236 302 +66 wait_for_child_or_signal 199 228 +29 checkjobs 142 158 +16 builtin_jobs 59 68 +9 process_wait_result 453 408 -45 builtin_fg_bg 272 203 -69 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 4/2 up/down: 282/-114) Total: 168 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-07 22:12:18 +01:00
Denys Vlasenko	4e1c8b4f6a	hush: factor out %jobspec parsing Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-07 20:06:40 +01:00
Denys Vlasenko	5d5a611df2	hush: comment fix Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-07 19:36:50 +01:00
Denys Vlasenko	4224647c8d	hush: do not allow sh -c '{ echo boo }' Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-07 16:22:35 +01:00
Denys Vlasenko	aeaee43d5a	hush: case logic for setting $? was still wrong Resetting to 0 should happen in "esac". Matched branch must still see previous $?. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-04 20:14:04 +01:00
Denys Vlasenko	30bfcf612b	hush: non-matching "case" statement sets $? to 0 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-04 18:52:48 +01:00
Denys Vlasenko	672a55e606	hush: allow { cmd } to not be terminated by semicolon in some cases Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-04 18:46:14 +01:00
Denys Vlasenko	9db74e49e5	hush: fix "(sleep 1; exit 3) & sleep 2; echo $?; wait $!; echo $?" "wait $!" may be just a bit too late: backgrounded $! is gone. Do not bomb out in this case. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-28 22:39:12 +02:00
Denys Vlasenko	7e6753609d	hush: fix "wait PID" It was not properly interruptible, and did not update job status (the exited processes were still thought of as running). function old new delta process_wait_result - 453 +453 wait_for_child_or_signal - 199 +199 run_list 996 1002 +6 checkjobs_and_fg_shell 41 43 +2 builtin_wait 328 215 -113 checkjobs 516 142 -374 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/2 up/down: 660/-487) Total: 173 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-28 21:59:09 +02:00
Denys Vlasenko	2eb0a7e1b9	ash: [SHELL] Expand ENV before using it Upstream commit: Date: Sun, 13 Jul 2008 21:51:52 +0800 [SHELL] Expand ENV before using it Per POSIX ENV needs to undergo parameter expansion. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-27 11:28:59 +02:00
Denys Vlasenko	b7adf7ac32	ash,hush: set exit code 127 in "sh /does/not/exist" case Upstream commit 1 for ash: [ERROR] Allow the originator of EXERROR to set the exit status Some errors have exit status values specified by POSIX and it is therefore desirable to be able to set the exit status at the EXERROR source rather than in main.c. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Upstream commit 2 for ash: [INPUT] Use exit status 127 when the script to run does not exist This commit makes dash exit with return code 127 instead of 2 if started as non-interactive shell with a non-existent command_file specified as argument (or a directory), as documented in http://www.opengroup.org/onlinepubs/009695399/utilities/sh.html#tag_04_128_14 The wrong exit code was reported by Clint Adams and Jari Aalto through http://bugs.debian.org/548743 http://bugs.debian.org/548687 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> NB: in fact, http://bugs.debian.org/548687 was not fixed by this: "sh /dir/" thinks that EISDIR error on read is EOF, and exits 0. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-25 17:00:13 +02:00
Denys Vlasenko	7f0ebbc69e	hush: add commented-out debug printouts in "memleak" built-in Allocation addresses of malloc() are jittery, thought I had a mem leak in hush, but it was malloc variability. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-03 17:42:53 +02:00
Denys Vlasenko	a769390da6	hush: fix a memory corruption when exported variable is modified The construct such as this: t=1 export t t=new_value1 had a small probability of momentarily using free()d value. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-03 15:01:06 +02:00
Denys Vlasenko	04465dad66	hush: fix exitcode on exec failure with EACCES - should be 126 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-03 01:01:15 +02:00
Denys Vlasenko	80729a4472	whitespace fixes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-02 22:33:15 +02:00
Denys Vlasenko	61508d9624	hush: fix var3.tests Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-02 21:12:02 +02:00
Denys Vlasenko	ebedb9478d	sh: do not print empty line at the end of "help" output It's pointless. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-02 18:45:09 +02:00
Denys Vlasenko	04b46bced9	hush: 'return' should have effect earlier Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-01 22:28:03 +02:00
Denys Vlasenko	ed6ff5edfc	hush: enable "msh is deprecated" message in msh stub After giving a few more years for everyone to notice and migrate, can nuke all remains of msh. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-30 12:28:37 +02:00
Denys Vlasenko	08755f9bcb	hush: fix typo in comment Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-30 02:02:25 +02:00
Denys Vlasenko	4074d49557	hush: fix interactive input handling of backslash+newline function old new delta fgetc_interactive - 258 +258 i_peek_and_eat_bkslash_nl 43 93 +50 static_peek2 7 - -7 setup_string_in_str 46 39 -7 setup_file_in_str 47 40 -7 file_peek 72 52 -20 expand_vars_to_list 1167 1143 -24 file_peek2 74 - -74 file_get 326 65 -261 ------------------------------------------------------------------------------ (add/remove: 1/2 grow/shrink: 1/5 up/down: 308/-400) Total: -92 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-30 01:49:53 +02:00
Denys Vlasenko	0448c55cc8	hush: G.user_input_buf[] is needed only if line editing is enabled Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 20:25:44 +02:00
Denys Vlasenko	46e6498b2a	hush: speed optimizations Make o_addchr() faster: do not call o_grow_by() each time. Create i_getch_and_eat_bkslash_nl(), use it instead of peek+getch pair. function old new delta o_addchr 42 54 +12 parse_dollar 761 771 +10 o_grow_by 48 37 -11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/1 up/down: 24/-11) Total: 11 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 19:50:55 +02:00
Denys Vlasenko	657086a3dc	hush: fix handling of by backslash-newline in $((arith)) and $(cmd) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 18:07:42 +02:00
Denys Vlasenko	d17a91db6e	hush: rework input char buffering to allow more than one-deep peek ...this time with actual hush.c changes too :) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 18:02:37 +02:00
Denys Vlasenko	78c9c736ab	hush: fix 'eval ""' handling Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 01:44:17 +02:00
Denys Vlasenko	992e0ff7e9	hush: fix ". EMPTY_LINE" not setting $? to 0 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-29 01:27:09 +02:00
Denys Vlasenko	d6a37d86ba	hush: document better where bad redirect syntax is detected Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-20 16:22:24 +02:00
Denys Vlasenko	aa3576a29b	hush: fix "redirects can close script fd" bug Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-22 19:54:12 +02:00
Denys Vlasenko	7b25b1c5b2	hush: do not leak script fds into NOEXEC children We set all opened script fds to CLOEXEC, thus making then go away after fork+exec. Unfortunately, CLOFORK does not exist. NOEXEC children will still see those fds open. For one, "ls" applet is NOEXEC. Therefore running "ls -l /proc/self/fd" in a script from standalone shell shows this: lrwx------ 1 root root 64 Aug 20 15:17 0 -> /dev/pts/3 lrwx------ 1 root root 64 Aug 20 15:17 1 -> /dev/pts/3 lrwx------ 1 root root 64 Aug 20 15:17 2 -> /dev/pts/3 lr-x------ 1 root root 64 Aug 20 15:17 3 -> /path/to/top/level/script lr-x------ 1 root root 64 Aug 20 15:17 4 -> /path/to/sourced/SCRIPT1 ... with as many open fds as there are ". SCRIPTn" nest levels. Fix it by closing these fds after fork (only for NOEXEC children). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-20 15:58:34 +02:00
Denys Vlasenko	869994cf4f	hush: bit better comments in redirect code. No logic changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-20 15:16:00 +02:00
Denys Vlasenko	e9abe75fda	hush: `cmd` and arithmetic also need the fix for FILE rewind Discovered by running testsuite with a newest glibc Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-19 20:15:26 +02:00
Denys Vlasenko	215b0ca6e4	hush: fix a bug in FEATURE_SH_STANDALONE=y config. Closes 9186 Run this in a "sh SCRIPT": sha256sum /dev/null echo END sha256sum is a NOEXEC applet. It runs in a forked child. Then child exit()s. By this time, entire script is read, and buffered in a FILE object from fopen("SCRIPT"). But fgetc() did not consume entire input. exit() lseeks back by -9 bytes, from <eof> to 'e' in 'echo'. (this may be libc-specific). This change of fd position is shared with the parent! Now parent can read more, and it thinks there is another "echo END". End result: two "echo END"s are run. Fix this by _exit()ing instead. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-19 18:43:06 +02:00
Denys Vlasenko	49117b4800	hush: fix a possible bug Not sure this was actually a triggerable bug, but the code looked flaky. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-21 14:42:13 +02:00
Denys Vlasenko	85378cded7	hush: code shrink function old new delta builtin_wait 347 328 -19 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-11 21:47:11 +02:00
Denys Vlasenko	550bf5b4a4	remove global "jmp_buf die_jmp" from !FEATURE_PREFER_APPLETS builds function old new delta xfunc_has_died - 21 +21 sleep_much - 12 +12 sleep10 - 9 +9 die_func - 4 +4 fflush_stdout_and_exit 35 36 +1 builtin_type 121 119 -2 die_sleep 4 - -4 xfunc_die 60 24 -36 hush_main 1128 1011 -117 die_jmp 156 - -156 ------------------------------------------------------------------------------ (add/remove: 4/2 grow/shrink: 1/3 up/down: 47/-315) Total: -268 bytes text data bss dec hex filename 939992 992 17652 958636 ea0ac busybox_old 939880 992 17496 958368 e9fa0 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-09 16:42:57 +02:00
Denys Vlasenko	d60752f8c9	build system: -fno-builtin-printf Benefits are: drops reference to out-of-line putchar(), fixes a few cases of failed string merge. function old new delta i2cdump_main 1488 1502 +14 sha256_process_block64 423 433 +10 sendmail_main 1183 1185 +2 list_table 1114 1116 +2 i2cdetect_main 1235 1237 +2 fdisk_main 2852 2854 +2 builtin_type 119 121 +2 unicode_conv_to_printable2 325 324 -1 scan_recursive 380 378 -2 mkfs_minix_main 2687 2684 -3 buffer_fill_and_print 178 169 -9 putchar 152 - -152 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 7/4 up/down: 34/-167) Total: -133 bytes text data bss dec hex filename 937788 932 17676 956396 e97ec busybox_old 937564 932 17676 956172 e970c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 22:42:45 +02:00
Denys Vlasenko	5711a2a4ad	libbb: more compact API for bb_parse_mode() function old new delta make_device 2182 2188 +6 parse_command 1440 1443 +3 parse_params 1497 1499 +2 install_main 773 769 -4 mkdir_main 168 160 -8 getoptscmd 641 632 -9 builtin_umask 158 147 -11 bb_parse_mode 431 410 -21 umaskcmd 286 258 -28 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/6 up/down: 11/-81) Total: -70 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 17:55:33 +02:00
Denys Vlasenko	6283f98283	hush: fix umask: umask(022) was setting umask(755) Based on the patch by Rich Felker <dalias@libc.org> function old new delta builtin_umask 121 161 +40 umaskcmd 318 279 -39 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 16:56:20 +02:00
Denys Vlasenko	b5be13ccd9	hush: fix a nommu bug where a part of function body is lost if run in a pipe Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-09-04 06:22:10 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Maninder Singh	97c6491b4e	typo fixes Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-05-25 13:46:36 +02:00
Denys Vlasenko	8dff01d06a	libbb: introduce and use is_prefixed_with() function old new delta is_prefixed_with - 18 +18 complete_username 78 77 -1 man_main 737 735 -2 fsck_device 429 427 -2 unpack_ar_archive 80 76 -4 strip_unsafe_prefix 105 101 -4 singlemount 1054 1050 -4 rtc_adjtime_is_utc 90 86 -4 resolve_mount_spec 88 84 -4 parse_one_line 1029 1025 -4 parse_conf 1460 1456 -4 may_wakeup 83 79 -4 loadkmap_main 219 215 -4 get_irqs_from_stat 103 99 -4 get_header_cpio 913 909 -4 findfs_main 79 75 -4 fbsplash_main 1230 1226 -4 load_crontab 776 771 -5 expand_vars_to_list 1151 1146 -5 date_main 881 876 -5 skip_dev_pfx 30 24 -6 make_device 2199 2193 -6 complete_cmd_dir_file 773 767 -6 run_applet_and_exit 715 708 -7 uudecode_main 321 313 -8 pwdx_main 197 189 -8 execute 568 560 -8 i2cdetect_main 1186 1176 -10 procps_scan 1242 1230 -12 procps_read_smaps 1017 1005 -12 process_module 746 734 -12 patch_main 1903 1891 -12 nfsmount 3572 3560 -12 stack_machine 126 112 -14 process_timer_stats 449 435 -14 match_fstype 111 97 -14 do_ipaddr 1344 1330 -14 open_list_and_close 359 343 -16 get_header_tar 1795 1779 -16 prepend_new_eth_table 340 323 -17 fsck_main 1811 1794 -17 find_iface_state 56 38 -18 dnsd_main 1321 1303 -18 base_device 179 158 -21 find_keyword 104 82 -22 handle_incoming_and_exit 2785 2762 -23 parse_and_put_prompt 774 746 -28 modinfo 347 317 -30 find_action 204 171 -33 update_passwd 1470 1436 -34 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/49 up/down: 18/-540) Total: -522 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-03-12 17:48:34 +01:00
Denys Vlasenko	841f8331d7	ash,hush: run reinit_unicode() only if makes sense With static Unicode support, no need to check $LANG et al. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-08-13 10:09:49 +02:00
Denys Vlasenko	c538d5bcc3	hush: make ${#var} unicode-aware This mimics bash Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-08-13 09:57:44 +02:00
Denys Vlasenko	3fa97af7cc	ash,hush: set $HOSTNAME is bash compat. Closes 7028 function old new delta hush_main 1056 1128 +72 ash_main 1442 1487 +45 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-15 11:43:29 +02:00
Denys Vlasenko	2bba591991	hush: make "true" built-in Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-03-14 12:43:57 +01:00
Denys Vlasenko	8bd810bd27	hush: typo fixes in comments Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-11-28 01:50:01 +01:00
Denys Vlasenko	e95738f635	typo fix in comment Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-08 03:13:08 +02:00
Denys Vlasenko	2301d127a2	unicode: check $LC_CTYPE too to detect Unicode mode Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-05 22:00:57 +02:00
Denys Vlasenko	3e7ecb179b	unicode: check $LC_ALL to detect Unicode mode, not only $LANG Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-02 17:30:23 +02:00
Denys Vlasenko	ff463a885d	hush: fix build failure if FEATURE_EDITING=y && !HUSH_INTERACTIVE Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-05-12 02:45:23 +02:00
Flemming Madsen	d96ffda62e	ash,hush: history builtin function old new delta show_history - 39 +39 builtin_history - 16 +16 historycmd - 13 +13 bltins1 312 324 +12 builtintab 336 344 +8 popstring 134 140 +6 hush_main 1048 1046 -2 ash_main 1398 1396 -2 size_from_HISTFILESIZE 44 40 -4 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 3/3 up/down: 94/-8) Total: 86 bytes Signed-off-by: Flemming Madsen <busybox@themadsens.dk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-04-07 18:47:24 +02:00
Denys Vlasenko	3beab83e4f	hush: fix for "while false && true; do echo BUG; break; done". closes 6170 function old new delta run_list 959 941 -18 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-04-07 18:16:58 +02:00
Denys Vlasenko	88b532d59a	hush: source builtin should override $N only if it has args function old new delta builtin_source 174 184 +10 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-17 14:11:04 +01:00
Denys Vlasenko	6830ade6aa	whitespace fixes. no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-15 13:58:01 +01:00
Denys Vlasenko	60cb48ca50	whitespace cleanup. no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-14 15:57:44 +01:00
Denys Vlasenko	9d75370238	hush: remove sighandler_t definition hack, platform.h has it too Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-04-26 10:59:01 +02:00
Denys Vlasenko	8cab66730a	fix build breakage found by randconfig Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-04-20 14:48:00 +02:00
Denys Vlasenko	0d6bbb0497	hush: remove unused member struct command::is_stopped function old new delta builtin_umask 133 132 -1 checkjobs 551 544 -7 builtin_fg_bg 291 267 -24 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-03-27 14:32:48 +02:00
Denys Vlasenko	e45af7ad17	lineedit: remove SAVE_HISTORY bit, ->hist_file can be used as indicator Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 16:15:24 +02:00
Denys Vlasenko	bede215cf1	lineedit: add support for history saving on exit Based on the patch by Dennis Groenen <tj.groenen@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 16:12:33 +02:00
Denys Vlasenko	4840ae8a06	lineedit: fix atomic replace of history file; hush: fix $HISTFILE handling Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 15:28:03 +02:00
Denys Vlasenko	b347df9131	randomconfig fixes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-09 22:49:15 +02:00
Denys Vlasenko	6e42b89b8d	hush: fix remaining known two bugs with IFS expansion. Closes 4027. function old new delta expand_vars_to_list 1054 1140 +86 parse_stream 2425 2479 +54 expand_on_ifs 258 310 +52 builtin_umask 133 132 -1 done_word 820 779 -41 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 192/-42) Total: 150 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-01 18:16:43 +02:00
Denys Vlasenko	4fb53fb08c	hush: partially fix wrong expansion on $IFS (bug 4027). In the added testcase, before patch we failed 8 out of 9 tests, now we fail only 2 (4th and 5th). function old new delta expand_on_ifs 225 258 +33 expand_vars_to_list 1038 1054 +16 o_save_ptr_helper 115 119 +4 builtin_umask 132 133 +1 o_addQstr 165 161 -4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/1 up/down: 54/-4) Total: 50 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-01 14:06:20 +02:00
Denys Vlasenko	56a3b82e96	hush: better comment. No code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-01 12:47:07 +02:00
Denys Vlasenko	00ae989ee5	hush: fix a corner case of empty "do \n done" structure The structure is: while cmd; do done bash doesn't accept it at all. We were accepting it but execution was buggy. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-31 17:35:45 +02:00
Denys Vlasenko	29f9b7268a	hush: fix misparsing of "... do eval a= ...". Closes 3721 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-14 11:27:36 +02:00
Denys Vlasenko	60a9414cad	fix "variable 'foo' set but not used" warnings Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-13 20:57:01 +02:00
Denys Vlasenko	0806e401d6	hush: install signal handlers with filled sigmask function old new delta install_sighandler - 39 +39 hush_main 1001 1031 +30 builtin_trap 386 392 +6 install_sighandlers 121 123 +2 switch_off_special_sigs 87 86 -1 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/1 up/down: 77/-1) Total: 76 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 23:06:20 +02:00
Denys Vlasenko	75e77deab1	hush: fixes and small shrink for HUSH_JOB!=y Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 13:12:47 +02:00
Denys Vlasenko	ebc1ee2e2a	hush: remove one sigprocmask from exit path Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 10:59:18 +02:00
Denys Vlasenko	0c40a731e3	hush: add forgotten {} in multi-statement if. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 09:50:12 +02:00
Denys Vlasenko	f58f705c58	hush: fix login shell's signal handling; add -l option so that it's easier to test function old new delta hush_main 958 1001 +43 install_special_sighandlers 47 52 +5 packed_usage 28752 28741 -11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 48/-11) Total: 37 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 02:10:33 +02:00
Denys Vlasenko	9d6cbafe72	hush: replace signal handling machinery With new version of signal handling, read builtin should be less buggy wrt signals. function old new delta install_sighandlers - 121 +121 switch_off_special_sigs - 84 +84 pick_sighandler - 58 +58 install_special_sighandlers - 47 +47 builtin_wait 284 319 +35 record_pending_signo - 21 +21 execvp_or_die 43 48 +5 file_get 290 288 -2 run_list 1004 998 -6 static.zero_timespec 8 - -8 sigprocmask_set 14 - -14 sigwaitinfo 23 - -23 record_signal 23 - -23 __GI_sigwaitinfo 23 - -23 sigtimedwait 25 - -25 builtin_trap 417 392 -25 __GI_sigtimedwait 25 - -25 hush_main 1003 965 -38 check_and_run_traps 263 217 -46 __rt_sigtimedwait 52 - -52 reset_traps_to_defaults 213 126 -87 init_sigmasks 198 - -198 builtin_read 536 197 -339 ------------------------------------------------------------------------------ (add/remove: 5/10 grow/shrink: 2/7 up/down: 371/-934) Total: -563 bytes text data bss dec hex filename 903075 936 17736 921747 e1093 busybox_old 902547 936 17736 921219 e0e83 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-11 23:56:11 +02:00
Denys Vlasenko	10c0131a8a	hush: use SA_RESTARTed signal handlers across read. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-11 11:49:21 +02:00
Denys Vlasenko	54e9e1217c	hush: code shrink Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-09 00:52:15 +02:00
Denys Vlasenko	80542bad2f	hush: make read builtin interruptible. function old new delta builtin_read 185 471 +286 check_and_run_traps 200 262 +62 nonblock_immune_read 73 119 +46 sigismember - 44 +44 record_signal - 21 +21 sigisemptyset - 16 +16 ... ------------------------------------------------------------------------------ (add/remove: 5/0 grow/shrink: 7/5 up/down: 483/-46) Total: 437 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-08 21:23:43 +02:00
Denys Vlasenko	b8709032a3	hush: fix incorrect PS2 dispaly and trap handling while reading command The fix affects only !ENABLE_FEATURE_EDITING configuration Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-08 21:20:01 +02:00
Denys Vlasenko	2c4de5b045	ash,hush: optional support for $HISTFILESIZE. Based on patch from Alexey Fomenko (ext-alexey.fomenko AT nokia.com) function old new delta size_from_HISTFILESIZE - 44 +44 hush_main 998 1025 +27 ash_main 1348 1374 +26 read_line_input 3361 3372 +11 new_line_input_t 17 24 +7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-31 13:16:52 +02:00
Denys Vlasenko	a439fa93f6	hush: remove outdated comments Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-30 19:11:46 +02:00
Denys Vlasenko	cecbc98611	hush: fix source1.tests function old new delta parse_and_run_stream 95 139 +44 static_get 22 25 +3 file_get 260 263 +3 builtin_umask 133 132 -1 parse_stream 2442 2425 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 50/-18) Total: 32 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-30 18:54:52 +02:00
Denys Vlasenko	3eab24e64a	hush: make parse errors in sourced file non-fatal in interactive script Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-24 05:25:59 +01:00
Denys Vlasenko	68d5cb5dac	hush: fix a case where return in sourced file has no effect Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-24 02:50:03 +01:00
Denys Vlasenko	20704f0662	ash,hush: recheck LANG before every line input Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-23 17:59:27 +01:00
Denys Vlasenko	6b6af53426	ash/hush: shrink help text Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-08 10:24:17 +01:00
Denys Vlasenko	b0b834342f	ash/hush: provide help text $ ./busybox ash --help BusyBox v1.19.0.git (2011-03-07 11:25:29 CET) multi-call binary. Usage: ash [-/+OPTCHARS] [-/+o OPTNAME]... [-c 'SCRIPT' [ARG0 [ARGS]] / SCRIPT_FILE [ARGS]] Unix shell interpreter $ ./busybox hush --help BusyBox v1.19.0.git (2011-03-07 11:25:29 CET) multi-call binary. Usage: hush [-nx] [-c 'SCRIPT' [ARG0 [ARGS]] / SCRIPT_FILE [ARGS]] Unix shell interpreter function old new delta packed_usage 28163 28212 +49 setcmd 85 78 -7 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 49/-7) Total: 42 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-07 12:34:59 +01:00
Denys Vlasenko	7c6f2468cc	hush: do not print killer signal's name for SIGPIPE Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-14 17:17:10 +01:00
Denys Vlasenko	66c5b12dbf	ash: fix TMOUT not restoring tty attributes function old new delta pgetc 420 500 +80 readtoken1 3202 3239 +37 read_line_input 3316 3337 +21 udhcpc_main 2610 2630 +20 file_get 266 272 +6 expandarg 958 963 +5 localcmd 257 259 +2 addLines 85 87 +2 read_line 94 95 +1 ed_main 2540 2541 +1 timed_out 1 - -1 lineedit_read_key 256 255 -1 alrm_sighandler 44 - -44 cmdloop 539 434 -105 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 10/2 up/down: 175/-151) Total: 24 bytes text data bss dec hex filename 887379 936 17200 905515 dd12b busybox_old 887411 936 17192 905539 dd143 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-08 05:07:02 +01:00
Denys Vlasenko	8ee2adab21	echo: do not retry on write errors function old new delta echo_main 297 336 +39 stpcpy - 22 +22 run_pipe 1561 1566 +5 pseudo_exec_argv 187 192 +5 hush_exit 75 80 +5 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 4/0 up/down: 98/0) Total: 76 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-07 02:03:51 +01:00
Denys Vlasenko	b72baeb003	hush: use FEATURE_SH_NOFORK to enable NOFORK trick Also expands docs Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-02 18:38:57 +01:00
Denys Vlasenko	a146319173	hush: improve prompt in nested {}s, remove unused in_str->promptme member function old new delta setup_string_in_str 29 38 +9 parse_and_run_stream 79 88 +9 setup_file_in_str 32 39 +7 parse_stream 2430 2422 -8 file_get 262 235 -27 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 25/-35) Total: -10 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-01-18 17:55:04 +01:00
Denys Vlasenko	98c46d10ee	hush: fix "cmd & <newline>" problem Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-01-18 17:30:07 +01:00
Denys Vlasenko	b9f2d9f7d9	mass removal of underscores from _BB_DIR_foo and _BB_SUID_foo Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-01-18 13:58:01 +01:00
Denys Vlasenko	642e71a789	hush: fix wrong prompt problem on empty interactive commants Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2011-01-07 15:16:05 +01:00
Denys Vlasenko	75eb9d20e9	hush: fix FEATURE_CLEAN_UP code (was freeing unallocated memory) Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-12-21 21:18:12 +01:00
Denys Vlasenko	0d6a4ecb30	hush: fix build breakage (variable declared in for()) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-12-18 01:34:49 +01:00
Denys Vlasenko	8da415ef25	add if guards around include <malloc.h> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-12-05 01:30:14 +01:00
Denys Vlasenko	57542ebe4f	hush: move G_x_mode define to the more appropriate place Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-28 03:59:30 +01:00
Dan Fandrich	85c62470b7	Support set -o xtrace/noexec alternates for set -x/-n Signed-off-by: Dan Fandrich <dan@coneharvesters.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-28 03:56:39 +01:00
Dan Fandrich	89ca2f99a2	hush: display useful help text Signed-off-by: Dan Fandrich <dan@coneharvesters.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-28 01:54:39 +01:00
Denys Vlasenko	26777aa1c6	fixes for bugs discovered by randomconfig builds and tests Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-22 23:49:10 +01:00
Denys Vlasenko	7b4c0fd5f4	hush: fix improper handling of newline and hash chars in few corner cases Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-11-22 17:58:14 +01:00
Denys Vlasenko	6696eac274	hush: add support for "set -o pipefail" function old new delta checkjobs 467 517 +50 builtin_set 259 286 +27 o_opt_strings - 10 +10 hush_main 1011 1013 +2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/0 up/down: 89/0) Total: 89 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-14 02:01:50 +01:00
Denys Vlasenko	c08c3f5d26	hush: preparatory patch for set -o pipefail support Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-11-14 01:59:55 +01:00
Denys Vlasenko	e4dcba1c10	*: whitespace fixes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-28 18:57:19 +02:00
Denys Vlasenko	e2069fb325	hush: remove "doesn't support brace expansion" from config help text Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-04 00:01:47 +02:00
Denys Vlasenko	bbecd74d5a	hush: remove brace expansion from TODO list in comments. No code changes. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-03 17:22:52 +02:00
Denys Vlasenko	957f79f471	hush: small code shrink function old new delta expand_on_ifs 231 222 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-03 17:15:50 +02:00
Denys Vlasenko	9e800223f1	hush: implement brace expansion When enabled: function old new delta glob_brace - 402 +402 next_brace_sub - 70 +70 expand_on_ifs 185 231 +46 bbconfig_config_bz2 4923 4929 +6 o_save_ptr 282 140 -142 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/1 up/down: 524/-142) Total: 382 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-03 14:28:04 +02:00
Denys Vlasenko	238081f750	hush: preparatory patch, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-03 14:26:26 +02:00
Denys Vlasenko	0e13b4019c	hush: use smaller EXP_FLAG_foo constants function old new delta expand_string_to_string 126 124 -2 parse_stream 2376 2370 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-8) Total: -8 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-21 12:35:39 +02:00
Denys Vlasenko	52e460b744	hush: move shell_ver from globals to main's stack. function old new delta hush_main 995 1011 +16 pseudo_exec_argv 253 251 -2 execvp_or_die 50 48 -2 maybe_set_to_sigexit 50 47 -3 hush_exit 78 75 -3 builtin_wait 274 271 -3 check_and_run_traps 205 200 -5 init_sigmasks 214 190 -24 builtin_trap 465 441 -24 reset_traps_to_defaults 238 211 -27 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/9 up/down: 16/-93) Total: -77 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-16 16:12:00 +02:00
Denys Vlasenko	bed7c81ea2	shell/math: deconvolute and explain ?: handling. Give better error message function old new delta arith_apply 1271 1283 +12 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-16 11:50:46 +02:00
Denys Vlasenko	063847d6bd	shell/math: return string error indicator, not integer function old new delta expand_and_evaluate_arith 87 106 +19 expand_one_var 1563 1570 +7 arith 12 18 +6 evaluate_string 678 680 +2 arith_apply 1269 1271 +2 builtin_umask 133 132 -1 ash_arith 118 75 -43 expand_vars_to_list 1094 1038 -56 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/3 up/down: 36/-100) Total: -64 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-15 13:33:02 +02:00
Denys Vlasenko	06d44d7dfb	shell/math.c: rename arith_eval_hooks to arith_state, put error code into it function old new delta expand_and_evaluate_arith 79 89 +10 arith 675 674 -1 arith_lookup_val 151 142 -9 ash_arith 135 122 -13 arith_apply 1304 1269 -35 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/4 up/down: 10/-58) Total: -48 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-13 12:49:03 +02:00
Denys Vlasenko	b771c654ca	shell: shrink arith code; and prepare for returning text error codes function old new delta arith 701 680 -21 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-13 00:34:26 +02:00
Denys Vlasenko	99862cbfad	hush: optional support for history saving function old new delta hush_main 945 995 +50 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-12 17:34:13 +02:00
Denys Vlasenko	de8c3f667a	hush: move the EXIT trap comment. no code changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-12 16:13:44 +02:00
Denys Vlasenko	a110c90de2	hush: fix EXIT trap display inside exit trap handler function old new delta hush_exit 84 78 -6 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-12 15:38:04 +02:00
Denys Vlasenko	acd5bc8f64	hush: fix handling of \" in quoted/unquoted `cmd` Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-12 15:05:39 +02:00
Denys Vlasenko	5277a9db70	hush: remove forgotten commented-out block. no code changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 15:34:53 +02:00
Denys Vlasenko	4f870496e7	hush: do fewer strdups in % and hash expansions function old new delta builtin_umask 133 132 -1 expand_one_var 1552 1543 -9 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 11:06:01 +02:00
Denys Vlasenko	d98e5c65c3	hush: better function and parameter names Also, trim code which isn't needed for non-bash compat. No logic changes. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 10:44:23 +02:00
Denys Vlasenko	ebee410fe2	hush: fix var_bash5.tests failure function old new delta expand_one_var 1513 1552 +39 expand_pseudo_dquoted 118 135 +17 expand_string_to_string 110 126 +16 setup_heredoc 298 308 +10 expand_and_evaluate_arith 69 79 +10 parse_stream_dquoted 233 241 +8 setup_redirects 220 225 +5 run_list 956 961 +5 expand_assignments 76 81 +5 run_pipe 1587 1590 +3 parse_stream 2371 2374 +3 builtin_umask 132 133 +1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 12/0 up/down: 122/0) Total: 122 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 10:17:53 +02:00
Denys Vlasenko	14e289b324	hush: fix var_bash3.tests failure function old new delta expand_one_var 1513 1538 +25 parse_stream_dquoted 233 241 +8 expand_pseudo_dquoted 118 126 +8 setup_heredoc 298 303 +5 expand_and_evaluate_arith 69 74 +5 parse_stream 2371 2374 +3 builtin_umask 132 133 +1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 7/0 up/down: 55/0) Total: 55 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 10:15:18 +02:00
Denys Vlasenko	a769e0225d	hush: remove useless ESC_GLOB_CHARS clears/resotres function old new delta o_addQstr 43 165 +122 expand_on_ifs 210 189 -21 expand_vars_to_list 1122 1094 -28 o_addqblock 139 - -139 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/2 up/down: 122/-188) Total: -66 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-10 10:12:34 +02:00
Denys Vlasenko	bfc02a76c5	hush: fix a bug where expand_one_var wasn't restoring 1st char of the encoded $var function old new delta expand_one_var 1515 1513 -2 expand_vars_to_list 1133 1122 -11 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-09 14:38:46 +02:00
Denys Vlasenko	101a4e3e21	hush: make parse_dollar flag quited status regardless of glob escaping status function old new delta parse_stream_dquoted 228 233 +5 parse_stream 2369 2371 +2 parse_dollar 730 717 -13 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 7/-13) Total: -6 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-09 14:04:57 +02:00
Denys Vlasenko	5b6210cf49	hush: simplification in parse_stream, parse_stream_dquoted function old new delta parse_stream 2354 2369 +15 parse_stream_dquoted 250 228 -22 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-09 13:32:21 +02:00
Denys Vlasenko	850b15bfaf	hush: simplify parse_stream_dquoted function old new delta parse_stream_dquoted 303 250 -53 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-09 12:58:19 +02:00
Denys Vlasenko	77a7b5519c	hush: straighten out the logic in parse_stream function old new delta parse_stream 2399 2354 -45 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-09 12:40:03 +02:00
Denys Vlasenko	95d48f2598	hush: eliminate redundant parameter of expand_vars_to_list() Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-08 13:58:55 +02:00
Denys Vlasenko	5b686cb8e6	hush: replace flag bytes in struct o_string with bit flags Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-08 13:44:34 +02:00
Denys Vlasenko	9b78255dca	hush: remove unused enum typedef Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-08 13:33:26 +02:00
Denys Vlasenko	1fd3d94a6c	hush: fix set -- q w e; (IFS='' echo "$"; IFS=''; echo "$"); echo "$*" Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-08 13:31:53 +02:00
Denys Vlasenko	8b2f13d84d	shell: unify endofname() in hush and ash function old new delta builtin_umask 132 133 +1 changepath 195 194 -1 expand_and_evaluate_arith 77 69 -8 ash_arith 143 135 -8 expand_one_var 1551 1515 -36 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/4 up/down: 1/-53) Total: -52 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-07 12:19:33 +02:00
Denys Vlasenko	27c56f1267	hush: a few relatively trivial simplifications function old new delta helper_export_local 130 135 +5 set_vars_and_save_old 89 85 -4 expand_variables 147 141 -6 get_ptr_to_local_var 77 70 -7 get_local_var_value 171 164 -7 delete_finished_bg_job 31 16 -15 hush_exit 101 84 -17 free_pipe_list 31 12 -19 check_and_run_traps 232 205 -27 free_pipe 205 130 -75 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/9 up/down: 5/-177) Total: -172 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-07 09:56:34 +02:00
Denys Vlasenko	da463fb007	hush: style cleanups. no code changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-07 09:53:50 +02:00
Denys Vlasenko	605067b426	hush: revert a recent buggy change which resulted in two HUSH_VERSIONs Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 12:10:51 +02:00
Denys Vlasenko	83b900fb82	fix typo in comment Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 11:47:55 +02:00
Denys Vlasenko	c3adfacd22	hush: fix another corner case with backslashes in heredocs function old new delta parse_stream 2395 2432 +37 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 11:46:03 +02:00
Denys Vlasenko	77b32ccbf2	hush: fix backslash and terminator handling in <<[-]["]heredoc["] function old new delta parse_stream 2339 2395 +56 expand_pseudo_dquoted 104 118 +14 parse_stream_dquoted 296 300 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 74/0) Total: 74 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 11:27:32 +02:00
Denys Vlasenko	c49d2d9793	hush: fix globbing+backslashes in unquoted $var expansion Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 10:26:37 +02:00
Denys Vlasenko	d383b49aef	hush: remove disabled CMD_SINGLEWORD_NOGLOB_COND, rename o_glob->perform_glob + other small tweaks to comments and such Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 10:22:13 +02:00
Denys Vlasenko	96f064d416	shell: remove lash and bbsh Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-06 10:18:21 +02:00
Denys Vlasenko	b36abf2dfc	hush: big reordering: move parser functions to the beginning. no code changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-05 14:50:59 +02:00
Denys Vlasenko	38292b68c9	hush: rename o_quoted to has_quoted_part; small code shrink Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-05 14:49:40 +02:00

... 3 4 5 6 7 ...

1037 Commits