Vladislav Grishenko
4d15068d83
zcip: fix wrong comparison of source IP with our IP
...
Commit "zcip: fix link-local IP conflict detection" has introduced
wrong comparsion of source IP with our IP. This leads to a new IP
being picked unnecessarily on every incoming ARP packet.
Signed-off-by: Vladislav Grishenko <themiron@mail.ru >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:59:34 +01:00
Ari Sundholm
911db16229
truncate: new applet
...
function old new delta
truncate_main - 161 +161
cwbkMG_suffixes - 128 +128
packed_usage 30443 30459 +16
applet_names 2512 2521 +9
applet_main 1456 1460 +4
parse_command 1460 1463 +3
applet_nameofs 728 730 +2
applet_install_loc 182 183 +1
dd_suffixes 112 - -112
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 10/3 up/down: 337/-133) Total: 204 bytes
Signed-off-by: Ari Sundholm <ari@tuxera.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:56:38 +01:00
Ari Sundholm
8893023ba2
dd: move suffix struct to xatonum.c
...
This way it can be used by other applets without duplication.
Signed-off-by: Ari Sundholm <ari@tuxera.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:41:04 +01:00
Phil Sutter
92edab1aa6
logread: implement dumpfollow mode of operation
...
This is basically a combination of the default (dump mode) and -f
(follow mode). Specifying -F makes logread first dump the log buffer and
then immediately start following it.
function old new delta
packed_usage 30412 30443 +31
logread_main 491 497 +6
Signed-off-by: Phil Sutter <phil.sutter@viprinet.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:37:20 +01:00
Denys Vlasenko
6d8ea1d50e
ifupdown: shrink a message
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:08:51 +01:00
Frank Bergmann
6ca03f2dd8
ifupdown: correct ifstate update during 'ifup -a'. Closes 6212
...
When 'if -a' runs into an failure on an interface all further
interfaces won't be correctly updated in ifstate. This patch
inserts a new variable that only tracks the current interfaces
failure so that the write to ifstate can rely on this and not
the one for the functions return value.
Fixes https://bugs.busybox.net/show_bug.cgi?id=6212
Signed-off-by: Frank Bergmann <frank.frajasalo@googlemail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 17:04:27 +01:00
Ron Yorston
75a76269ba
ash: do not split the result of tilde expansion
...
A tilde expansion generates a valid pathname. Splitting it using IFS
either leaves it unchanged or changes it to something unintended.
Example:
IFS=m HOME=/tmp; printf "%s\n" ~
Based on this commit authored by Jilles Tjoelker:
http://git.kernel.org/cgit/utils/dash/dash.git/commit/?id=834629283f6c629a4da05ef60bae9445c954a19a
Signed-off-by: Ron Yorston <rmy@tigress.co.uk >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-22 16:55:44 +01:00
Mike Frysinger
6798564b9e
trylink: respect compiler settings when probing features
...
The CPPFLAGS/CFLAGS settings might have features that matter, so make
sure we utilize them when testing the compiler.
URL: https://bugs.gentoo.org/471118
Signed-off-by: Mike Frysinger <vapier@gentoo.org >
2015-03-16 17:47:01 -04:00
Mike Frysinger
4a08e82d44
trylink: use mktemp instead of hardcoding paths
...
This way we respect standard tempdir env vars and are guaranteed to
be unique.
Signed-off-by: Mike Frysinger <vapier@gentoo.org >
2015-03-16 17:46:17 -04:00
Denys Vlasenko
49acc1a761
vi: make BACKSPACE and DELETE join lines at start/end of line
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 21:15:34 +01:00
Ron Yorston
8ec1ff350c
Use chomp to remove newlines
...
function old new delta
unix_do_one 548 540 -8
process_timer_stats 508 500 -8
process_irq_counts 532 524 -8
lpd_main 839 831 -8
hwclock_main 502 494 -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-50) Total: -40 bytes
Signed-off-by: Ron Yorston <rmy@tigress.co.uk >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 20:18:51 +01:00
Ron Yorston
53e9c51ade
od: fix printing of high-bit chars
...
Example: echo £ | od -c
Signed-off-by: Ron Yorston <rmy@tigress.co.uk >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 20:11:48 +01:00
Denys Vlasenko
8dff01d06a
libbb: introduce and use is_prefixed_with()
...
function old new delta
is_prefixed_with - 18 +18
complete_username 78 77 -1
man_main 737 735 -2
fsck_device 429 427 -2
unpack_ar_archive 80 76 -4
strip_unsafe_prefix 105 101 -4
singlemount 1054 1050 -4
rtc_adjtime_is_utc 90 86 -4
resolve_mount_spec 88 84 -4
parse_one_line 1029 1025 -4
parse_conf 1460 1456 -4
may_wakeup 83 79 -4
loadkmap_main 219 215 -4
get_irqs_from_stat 103 99 -4
get_header_cpio 913 909 -4
findfs_main 79 75 -4
fbsplash_main 1230 1226 -4
load_crontab 776 771 -5
expand_vars_to_list 1151 1146 -5
date_main 881 876 -5
skip_dev_pfx 30 24 -6
make_device 2199 2193 -6
complete_cmd_dir_file 773 767 -6
run_applet_and_exit 715 708 -7
uudecode_main 321 313 -8
pwdx_main 197 189 -8
execute 568 560 -8
i2cdetect_main 1186 1176 -10
procps_scan 1242 1230 -12
procps_read_smaps 1017 1005 -12
process_module 746 734 -12
patch_main 1903 1891 -12
nfsmount 3572 3560 -12
stack_machine 126 112 -14
process_timer_stats 449 435 -14
match_fstype 111 97 -14
do_ipaddr 1344 1330 -14
open_list_and_close 359 343 -16
get_header_tar 1795 1779 -16
prepend_new_eth_table 340 323 -17
fsck_main 1811 1794 -17
find_iface_state 56 38 -18
dnsd_main 1321 1303 -18
base_device 179 158 -21
find_keyword 104 82 -22
handle_incoming_and_exit 2785 2762 -23
parse_and_put_prompt 774 746 -28
modinfo 347 317 -30
find_action 204 171 -33
update_passwd 1470 1436 -34
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/49 up/down: 18/-540) Total: -522 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 17:48:34 +01:00
Denys Vlasenko
936c8809ca
deluser: also remove user from /etc/group
...
function old new delta
update_passwd 1270 1470 +200
deluser_main 310 332 +22
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 15:30:46 +01:00
Alexander Korolkov
748fb60f27
arping: fix iface name in error messages
...
arping: interface eth0 not found: No such device
^^^^
This is because error template is formed before parsing command line arguments,
so it always uses default interface name "eth0".
Signed-off-by: Alexander Korolkov <alexander.korolkov@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-12 13:05:33 +01:00
Denys Vlasenko
fe8b5802ba
patch: segfault fix. Closes 7916
...
Fix segfault on this case (malformed --- line):
-- dwarves.orig 2015-02-25 01:45:27.753000000 +0000
+++ dwarves 2015-02-25 01:46:08.199000000 +0000
@@ -1,7 +1,7 @@
Bashful
Doc
Dopey
-Grouchy
+Grumpy
Happy
Sleepy
Sneezy
function old new delta
patch_main 1903 1957 +54
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-11 18:01:34 +01:00
Isaac Dunham
7b434a67dc
mount: -T OTHERTAB support
...
function old new delta
mount_main 1221 1241 +20
packed_usage 30616 30610 -6
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
Signed-off-by: Isaac Dunham <ibid.ag@gmail.com >
2015-03-11 16:07:24 +01:00
Denys Vlasenko
3c31b092ac
ntpd: tweak help text
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-05 14:04:44 +01:00
Denys Vlasenko
2ec4f44225
inetd: fix order of array index check and array access
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-03 13:10:30 +01:00
Denys Vlasenko
3aef814c0b
ntpd: chnage help text about -l to say that it doesn't disable client code
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-02 20:59:13 +01:00
Denys Vlasenko
7db2a7c20e
runsvdir: if pid==1, also intercept SIGINT for -s SCRIPT
...
function old new delta
runsvdir_main 1057 1064 +7
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-02 17:39:13 +01:00
Denys Vlasenko
dac8d80f77
runsvdir: do not block SIGCHLD around poll/sleep
...
There is no reason to do so. We do not even have SIGCHLD handler.
function old new delta
runsvdir_main 1077 1057 -20
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-02 17:38:55 +01:00
Denys Vlasenko
fa535f3e48
runsvdir: (almost) close a signal race
...
We could lose a signal while processing previous one
function old new delta
runsvdir_main 1088 1077 -11
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-03-02 17:37:31 +01:00
Serj Kalichev
1eafd44947
acpid: fix logging
...
Without this patch acpid can't log the events at all. Moreover it tries
to truncate log file every time.
Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-23 15:26:47 +01:00
Denys Vlasenko
c5beaa08eb
ls: heed compiler warning
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-23 15:25:58 +01:00
Denys Vlasenko
a88db5c1a9
modinfo: fix fallout from basename removal
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-21 17:08:35 +01:00
Tito Ragusa
cb6a112f09
libpwdgrp: fix thinko in getpwnam
...
function old new delta
parse_file - 64 +64
getXXnam_r 162 138 -24
getXXnam 90 50 -40
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 64/-64) Total: 0 bytes
Signed-off-by: Tito Ragusa <farmatito@tiscali.it >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-19 22:03:56 +01:00
Bernhard Reutner-Fischer
d7bfee1edb
wget: fix --header to not append duplicate headers
...
function old new delta
wget_main 2551 2715 +164
wget_user_headers - 62 +62
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/0 up/down: 226/0) Total: 226 bytes
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-18 20:41:02 +01:00
Denys Vlasenko
54e9585e10
trivial code shrink
...
function old new delta
rdate_main 246 251 +5
show_entry 291 287 -4
daytime_stream 44 39 -5
packed_usage 30176 30168 -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 5/-17) Total: -12 bytes
text data bss dec hex filename
929453 932 17684 948069 e7765 busybox_old
929411 932 17684 948027 e773b busybox_unstripped
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-18 13:47:46 +01:00
Denys Vlasenko
0cb981c5e2
ls: trivial code shrink
...
function old new delta
display_single 914 893 -21
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-18 11:29:07 +01:00
Bernhard Reutner-Fischer
70e30e8eec
dc: tweak parsing
...
https://bugs.debian.org/538685
dc requires whitespace between language elements.
We were requiring
1 2 + p
instead of the abbreviated
1 2+p
(for example).
function old new delta
stack_machine 97 126 +29
dc_main 117 79 -38
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 29/-38) Total: -9 bytes
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-16 17:12:04 +01:00
Denys Vlasenko
8e92df15b5
ls: fix year 9999 bug :)
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-16 15:36:25 +01:00
Denys Vlasenko
402afe1cc6
modprobe-small: fix thinko in previous commit
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-13 11:53:33 +01:00
Denys Vlasenko
1fd844267c
modprobe-small: if concurrent module load did not succeed, wait
...
usecase:
two sd cards are being mounted in parallel at same time on dual core. example
modules which are getting loaded is nls_cp437. While one module is being
loaded , it makes state in /proc/modules as 'coming' and then starts doing its
module init function (in our case - registering nls). meanwhile on other core,
if modprobe returns that is has already been loaded, then it will continue
and search for the nls list which is not yet finished from first module init.
This fails resulting in not mounting sd card.
function old new delta
process_module 667 746 +79
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-12 17:05:14 +01:00
Bartosz Golaszewski
622a7aab2c
i2cget, i2cset, i2cdetect, i2cdump: new applets
...
Add a minimal implementation of i2cget, i2cset, i2cdump and i2cdetect
tools. Supports most features of upstream i2c-tools.
function old new delta
i2cdump_main - 1444 +1444
i2cset_main - 1239 +1239
i2cdetect_main - 611 +611
list_i2c_busses_and_exit - 532 +532
packed_usage 29975 30438 +463
i2cget_main - 380 +380
check_read_funcs - 140 +140
i2c_funcs_tab - 128 +128
confirm_action - 100 +100
i2c_dev_open - 57 +57
i2c_smbus_access - 44 +44
confirm_or_abort - 43 +43
check_funcs_test_end - 39 +39
i2c_smbus_read_word_data - 38 +38
i2c_smbus_read_byte_data - 38 +38
i2c_smbus_read_byte - 37 +37
i2c_set_slave_addr - 32 +32
applet_names 2480 2512 +32
adap_descs - 32 +32
i2c_set_pec - 29 +29
get_funcs_matrix - 21 +21
i2c_parse_data_addr - 18 +18
i2c_parse_bus_addr - 18 +18
i2c_bus_lookup - 18 +18
i2c_smbus_write_byte - 17 +17
applet_main 1440 1456 +16
will_skip - 14 +14
no_support - 11 +11
applet_nameofs 720 728 +8
applet_install_loc 180 182 +2
------------------------------------------------------------------------------
(add/remove: 26/0 grow/shrink: 5/0 up/down: 5601/0) Total: 5601 bytes
Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-10 03:16:25 +01:00
Denys Vlasenko
8c06bc6ba1
unzip: prevent attacks via malicious filenames
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-10 01:30:43 +01:00
Denys Vlasenko
23cfaab47d
libpwdgrp: use getpwent() instead of getpwent_r()
...
function old new delta
massage_data_for_non_r_func - 90 +90
bb_internal_getpwent - 69 +69
getXXnam_r 94 162 +68
fill_bounds 131 128 -3
deluser_main 355 310 -45
complete_username 123 78 -45
getXXnam 163 90 -73
massage_data_for_r_func 103 - -103
bb_internal_getpwent_r 121 - -121
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/5 up/down: 227/-407) Total: -163 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-07 21:21:02 +01:00
Denys Vlasenko
68c048fb23
modprobe-small: fix and simplify rmmod
...
"rmmod OUT_OF_TREE_MODULE" was not working, because module is not in depmod file.
In general, rmmod doesn't need scanning, it simply unloads every argv[i].
function old new delta
rmmod - 63 +63
modprobe_main 449 465 +16
process_module 705 667 -38
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/1 up/down: 79/-38) Total: 41 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-07 20:44:46 +01:00
Kevin Wallace
782ee2aa0e
libbb/loop: don't try to re-use existing loop device
...
loopinfo.lo_file_name is not enough to uniquely identify a file on a system with
multiple mount namespaces. We could conceivably change this to dedup on
(lo_rdevice, lo_inode), but, as the comment above the deleted code notes, this
whole approach of reusing devices is racy anyway, so it seems better to stop
doing it entirely.
Signed-off-by: Kevin Wallace <k@igneous.io >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-07 19:13:57 +01:00
Denys Vlasenko
a03195941b
examples/mdev_fat.conf: document that newer mdev exposes path
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-07 18:14:39 +01:00
Ari Sundholm
f22a838aed
dd: add optional support for status=noxfer/none
...
While at it, added 'B' number suffixes, upstream compat
function old new delta
dd_main 1469 1543 +74
dd_suffixes 88 112 +24
packed_usage 30156 30176 +20
dd_output_status 372 388 +16
static.status_words - 13 +13
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 4/0 up/down: 147/0) Total: 147 bytes
Signed-off-by: Ari Sundholm <ari@tuxera.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-07 01:41:22 +01:00
Denys Vlasenko
7e66102f76
ash: fix a SEGV case in an invalid heredoc
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-05 21:00:17 +01:00
Denys Vlasenko
a14fa79592
deluser: implement --remove-home
...
function old new delta
deluser_main 308 355 +47
packed_usage 30149 30156 +7
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 54/0) Total: 54 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-05 18:35:52 +01:00
Denys Vlasenko
3c5d133c7d
fstrim: fix help text
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-04 15:19:38 +01:00
Denys Vlasenko
a75dcd4353
route: fix bogus read error when route table is empty
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-04 10:40:10 +01:00
Denys Vlasenko
09020b1aa8
route: improve -A inet6
...
Upstream route command shows non-up routes, it shows reject and nonexthop flags.
And we had "ref" and "use" values mixed up...
function old new delta
flagvals 32 44 +12
flagchars 9 12 +3
INET_setroute 767 768 +1
INET6_setroute 495 496 +1
set_flags 43 39 -4
flags_ipvx 16 8 -8
route_main 632 623 -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/3 up/down: 17/-21) Total: -4 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-03 19:32:44 +01:00
Denys Vlasenko
b62d4d9d57
gzip: trivial code shrink -5 bytes
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-03 15:25:17 +01:00
Denys Vlasenko
a977778893
ifconfig: fix double free fatal error in INET_sprint
...
Based on the patch by Zheng Junling <zhengjunling@huawei.com >
and Chen Gang <cg.chen@huawei.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-03 12:11:30 +01:00
Denys Vlasenko
8e74adab01
libbb: make INET[6]_rresolve use sockaddr2{host,dotted}_noport
...
function old new delta
INET_rresolve 274 214 -60
INET6_rresolve 168 85 -83
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-03 12:07:40 +01:00
Denys Vlasenko
f7f70bf1b3
gzip: speed up and shrink put_16bit()
...
function old new delta
put_16bit 104 98 -6
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
2015-02-02 16:07:07 +01:00