busybox

Author	SHA1	Message	Date
Denys Vlasenko	82a6fb3ea6	ash: fix . builtin Also, move [[ ]] comment to test.c and expand it Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-14 19:42:12 +02:00
Denys Vlasenko	641dd7b080	ash: revert over-zealous usage of FAST_FUNC Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-11 19:30:19 +02:00
Denys Vlasenko	77539190ab	added comments about [[ ]] to ash and hush. no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-10 14:09:48 +02:00
Denys Vlasenko	9ca656b149	hush: add HUSH_BASH_COMPAT, make [[ special handling depend on it Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-10 13:39:35 +02:00
Denys Vlasenko	9d617c44d2	hush: specially handle [[ - suppress globbing & multiword expansion It's a bashism, but is surprisingly easy to do and costs very little code. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-09 18:40:52 +02:00
Denys Vlasenko	2634bf366b	randomconfig fixes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-09 18:40:07 +02:00
Denys Vlasenko	764b2f0ec0	hush: drop REDIRECT_INVALID; other minor tweaks Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-07 16:05:04 +02:00
Denys Vlasenko	df5131cf3d	hush: fix a segfault in export builtin Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-07 16:04:17 +02:00
Denys Vlasenko	d6b05eb9c2	hush: make builtins work in pipes (eval ... \| ...) on NOMMU Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-06 20:59:55 +02:00
Denys Vlasenko	71016baf55	printf: accept negative numbers for %x; sh: overflowed numbers are 0 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-05 16:24:29 +02:00
Denys Vlasenko	d5f1b1bbe0	*: add FAST_FUNC to function ptrs where it makes sense function old new delta evalcommand 1195 1209 +14 testcmd - 10 +10 printfcmd - 10 +10 echocmd - 10 +10 func_exec 270 276 +6 echo_dg 104 109 +5 store_nlmsg 85 89 +4 pseudo_exec_argv 195 198 +3 dotcmd 287 290 +3 machtime_stream 29 31 +2 discard_stream 24 26 +2 argstr 1299 1301 +2 killcmd 108 109 +1 evalfor 226 227 +1 daytime_stream 43 44 +1 run_list 2544 2543 -1 lookupvar 62 61 -1 ipaddr_modify 1310 1309 -1 ... parse_stream 2254 2245 -9 evalpipe 356 347 -9 collect_if 210 197 -13 read_opt 869 851 -18 handle_dollar 681 658 -23 print_addrinfo 1342 1303 -39 iterate_on_dir 156 59 -97 print_route 1709 1609 -100 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 12/130 up/down: 74/-767) Total: -693 bytes text data bss dec hex filename 841748 467 7872 850087 cf8a7 busybox_old 841061 467 7872 849400 cf5f8 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-05 12:06:05 +02:00
Denys Vlasenko	0821801349	hush: document a TODO in export builtin Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-03 14:43:56 +02:00
Denys Vlasenko	6f22624a91	hush: fix a case when backgrounded cmd makes shell hang Signed-off-by: Bayram Kurumahmut <kbayram@ubicom.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-03 14:37:30 +02:00
Denys Vlasenko	295fef80bc	hush: add support for local builtin Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-03 12:47:26 +02:00
Mike Frysinger	eab40e5885	hush_test: stop mixing tabs/spaces for indentation Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-06-01 16:33:05 -04:00
Mike Frysinger	6a46ab8b8f	hush: unify syntax_error_unterm_{ch,str} a bit Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-06-01 14:16:43 -04:00
Mike Frysinger	ef3e7fdd3b	hush: push down expansion var in handle_dollar() Declare the variable in the scope it is used rather than the entire function scope so it's obvious it is only used there. Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-06-01 14:16:43 -04:00
Mike Frysinger	dc3bc40578	hush: add support for special vars in braces Some people like to use ${?} rather than $?, so make sure we support all the special single char vars that use this form. Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-06-01 14:16:43 -04:00
Mike Frysinger	ff64fb9e31	hush_test: filter test output to avoid C lib differences The getopt function in some C libraries wraps the option in single quotes while others do not. Avoid the issue by running sed on the output and strip all quotes. Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-06-01 14:16:43 -04:00
Denys Vlasenko	28a105d867	nc, hush: cosmetic cleanups, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-01 11:26:30 +02:00
Denys Vlasenko	4b7db4f2ca	read_key: drop optimization where we read 3 bytes at once Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-29 10:39:06 +02:00
Denys Vlasenko	171932d7ca	hust: trivial simplification in builtin_type Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-28 17:07:22 +02:00
Denys Vlasenko	e640cb4ad1	hush: fix bug 353 (wrong handling of \x in assignments) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-28 16:49:11 +02:00
Denys Vlasenko	5d7cca2090	hush: optimize type builtin a bit more Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-28 09:58:43 +02:00
Denys Vlasenko	dd6b211921	hush: optimize type builtin a bit function old new delta builtin_type 130 125 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-28 09:45:50 +02:00
Mike Frysinger	93cadc2fdd	hush: implement `type` Implement support for the POSIX `type` command. Only POSIX stuff is supported here, no bash extensions like -p or -P. In the process, split the $PATH searching code out of builtin_source() and into its own find_in_path() function so we don't duplicate it. Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-27 17:06:25 -04:00
Denys Vlasenko	673e945052	hush: remove outdated TODO and superfluous macro; fix compile breakage Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-27 14:39:35 +02:00
Denys Vlasenko	68759edb6e	hush: tweak comment Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-26 14:39:41 +02:00
Denys Vlasenko	e2df5f46d0	hush: rename last_waitpid_was_0 to we_have_children Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-26 14:34:10 +02:00
Denys Vlasenko	8d7be232a3	hush: fix SIGCHLD counting code, but keep it disabled for now. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-25 16:38:32 +02:00
Denys Vlasenko	4f26c97b9a	make compound.tests executable Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-23 17:00:13 +02:00
Denys Vlasenko	e9bda90e54	hush: fix problems with case in subshells and with "case esac" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-23 16:50:07 +02:00
Mike Frysinger	342a63d659	hush_test: add some pathological compound list tests Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-21 18:35:37 -04:00
Mike Frysinger	12bcc76e9b	hush_test: test for subshell function syntax Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-21 18:35:08 -04:00
Mike Frysinger	7b424fe738	hush_test: add subshelled case tests Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-21 18:09:24 -04:00
Mike Frysinger	cc9205bda7	hush_test: update test output to match new getopt() output Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-21 17:58:15 -04:00
Mike Frysinger	33f85eeac5	hush_test: ignore generated files Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2009-05-21 17:45:26 -04:00
Mike Frysinger	38478a600f	hush: fix build failure when jobs are disabled Signed-off-by: Mike Frysinger <vapier@gentoo.org> Reported-by: Thomas Chou <thomas@wytron.com.tw>	2009-05-20 04:48:06 -04:00
Denys Vlasenko	318a8e5ed5	TODO: add some Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-13 02:18:43 +02:00
root	6245202e7f	hush: small fix for unset -f on NOMMU. Signed-off-by: root <root@localhost.localdomain>	2009-05-04 12:00:19 +02:00
Denys Vlasenko	acdc49c073	hush: add more complex case to leak testcase, fix found breakage function old new delta unset_local_var_len - 167 +167 run_list 2350 2457 +107 set_vars_and_save_old - 87 +87 free_pipe 207 227 +20 builtin_unset 220 229 +9 builtin_exit 49 47 -2 free_strings_and_unset 53 - -53 set_vars_all_and_save_old 87 - -87 unset_local_var 168 - -168 ------------------------------------------------------------------------------ (add/remove: 2/3 grow/shrink: 3/1 up/down: 390/-310) Total: 80 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-04 01:58:10 +02:00
Denys Vlasenko	cb6ff25afe	hush: fix bug where in "var=val func" var's value is not visible in func function old new delta unset_local_var - 168 +168 set_vars_all_and_save_old - 87 +87 get_ptr_to_local_var - 77 +77 free_strings_and_unset - 53 +53 builtin_export 266 274 +8 get_local_var_value 31 33 +2 putenv_all 27 - -27 free_strings_and_unsetenv 53 - -53 get_local_var 68 - -68 run_list 2475 2350 -125 builtin_unset 380 220 -160 ------------------------------------------------------------------------------ (add/remove: 4/3 grow/shrink: 2/2 up/down: 395/-433) Total: -38 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-04 00:14:30 +02:00
Denys Vlasenko	e19e1935a3	hush: fix \<newline> handling Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-03 02:15:18 +02:00
Denys Vlasenko	b1cfc45376	hush: fix handling of unterminated subshell: (<eof>. Fixes bug 229. function old new delta syntax_error_unexpected_ch 31 41 +10 parse_stream 2184 2191 +7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-02 17:18:34 +02:00
Denys Vlasenko	1dd6cf8677	hush: fix multiple redirections of the same fd (bug 227) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-02 14:17:31 +02:00
Denys Vlasenko	54e0843e7d	hush: make . cmd search $PATH function old new delta builtin_source 128 249 +121 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-02 02:34:19 +02:00
Denys Vlasenko	690ad2426e	git commit test Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-04-30 21:24:24 +02:00
Denis Vlasenko	c8653f62f2	hush: make it possible to have interactive shell on non-ctty. init=/bin/hush: shows prompt, history works, etc. function old new delta hush_main 888 925 +37 block_signals 139 152 +13 builtin_fg_bg 284 293 +9 checkjobs_and_fg_shell 35 41 +6 sigexit 65 66 +1 reset_traps_to_defaults 165 164 -1 parse_stream 2200 2184 -16 run_list 2502 2475 -27 getpgid 35 - -35 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 5/3 up/down: 66/-79) Total: -13 bytes	2009-04-27 23:29:14 +00:00
Denis Vlasenko	42e4af3119	make leak test more robust by unsetting all vars	2009-04-26 23:25:36 +00:00
Denis Vlasenko	28e67966f3	hush: make getopt32 usable in builtins. use it in unset. more uses are expected in the future. function old new delta getopt32 1356 1393 +37 builtin_export 256 266 +10 builtin_unset 418 380 -38	2009-04-26 23:22:40 +00:00
Denis Vlasenko	572930027d	hush: nommu fix for function passing	2009-04-26 20:06:14 +00:00
Denis Vlasenko	5b7589eb27	hush: fix SEGV in % expansion function old new delta expand_variables 2203 2217 +14	2009-04-26 11:25:19 +00:00
Mike Frysinger	26cf2831d7	do not tell people they can enter "help" if help has actually been disabled	2009-04-24 06:40:30 +00:00
Mike Frysinger	67c1c7b456	use get_local_var_value() rather than getenv() when working with PS1/PS2/HOME, respect the PS2 env var, and make sure that the prompt changes whenever PS1/PS2 changes so we dont have to re-exec the shell to get a changed prompt	2009-04-24 06:26:18 +00:00
Denis Vlasenko	f9d4fc3cf8	switch_root: improve behavior on error; improve help text *: make "can't execute '%s'" message uniform	2009-04-21 20:40:51 +00:00
Denis Vlasenko	950bd72966	hush: speed up set_local_var function old new delta set_local_var 265 290 +25	2009-04-21 11:23:56 +00:00
Denis Vlasenko	5e34ff29bc	*: mass renaming of USE_XXXX to IF_XXXX and SKIP_XXXX to IF_NOT_XXXX - the second one was especially badly named. It was not skipping anything!	2009-04-21 11:09:40 +00:00
Denis Vlasenko	ad4bd0548a	hush: export -n support function old new delta builtin_export 206 256 +50 set_local_var 248 265 +17 expand_variables 2204 2203 -1	2009-04-20 22:04:21 +00:00
Denis Vlasenko	d40fa397e4	hush: add two testcases	2009-04-20 10:52:31 +00:00
Denis Vlasenko	8c64e033c0	hush: fix stdin of backgrounded pipe function old new delta run_list 2450 2502 +52	2009-04-20 00:34:01 +00:00
Denis Vlasenko	dcd78c4d0f	hush: fix "export not_yet_defined_var", fix parsing of "cmd \| }" corner case; improve hush_leaktool.sh; fix some false positives in testsuite function old new delta builtin_export 191 206 +15 parse_stream 2196 2200 +4	2009-04-19 23:07:51 +00:00
Denis Vlasenko	9f8d938172	same as previous, but -100 bytes	2009-04-19 14:03:11 +00:00
Denis Vlasenko	bf25fbccb9	hush: fix handling of } which is not a closing one in { cmd; } function old new delta parse_stream 2176 2302 +126 builtin_unset 381 387 +6	2009-04-19 13:57:51 +00:00
Mike Frysinger	885b6f29ae	fix build errors when function support is turned off	2009-04-18 21:04:25 +00:00
Denis Vlasenko	6008d8a3cc	hush: fix thinko in error msg	2009-04-18 13:05:10 +00:00
Denis Vlasenko	38e626df4d	hush: fix "trap -- handler SIGs..."; escape handlers in "trap" output	2009-04-18 12:58:19 +00:00
Denis Vlasenko	730106767e	hush: fix thinko in unset_func	2009-04-18 11:25:18 +00:00
Denis Vlasenko	40e84374ec	hush: implement unset -f; beautify the handling of signal-killed pipe four TODOs are gone function old new delta builtin_unset 271 364 +93 checkjobs 394 428 +34 builtin_exit 49 47 -2	2009-04-18 11:23:38 +00:00
Denis Vlasenko	eb85849b50	hush: deal with umask TODO (symbolic modes) function old new delta builtin_umask 79 125 +46	2009-04-18 02:06:54 +00:00
Denis Vlasenko	6b9e05392b	hush: implement proper SIGHUP handling function old new delta check_and_run_traps 164 229 +65 insert_bg_job 376 366 -10 hush_main 937 927 -10	2009-04-18 01:23:21 +00:00
Denis Vlasenko	7b9e5c57ae	builtin_return's parameter is not unused	2009-04-17 23:53:15 +00:00
Denis Vlasenko	3d40d8e655	hush: return builtin by Bayram Kurumahmut (kbayram AT ubicom.com) ~+200 bytes	2009-04-17 23:44:18 +00:00
Denis Vlasenko	270b1c3f68	hush: set $n properly for "source" builtin function old new delta restore_G_args - 78 +78 save_and_replace_G_args - 64 +64 builtin_source 72 107 +35 run_list 2549 2367 -182 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 1/1 up/down: 177/-182) Total: -5 bytes	2009-04-17 18:54:50 +00:00
Denis Vlasenko	4ea187fd62	hush: fix non-interactive response to pipe being stopped. function old new delta checkjobs 380 394 +14	2009-04-17 14:35:43 +00:00
Denis Vlasenko	e4bd4f2cc8	hush: unblock TERM, INT, HUP in child shells too.	2009-04-17 13:52:51 +00:00
Denis Vlasenko	f8c1f02d2f	hush: disallow "{echo hi; }" (require whitespace) and "{ echo hi }" (require semicolon or &) function old new delta parse_stream 2098 2176 +78 done_command 98 84 -14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 78/-14) Total: 64 bytes	2009-04-17 11:55:42 +00:00
Denis Vlasenko	fa4ca7889e	hush: add a TODO	2009-04-16 12:00:15 +00:00
Denis Vlasenko	bb929517a8	hush: fix "if { echo foo; } then { echo bar; } fi" parsing function old new delta done_word 728 793 +65 parse_stream 2084 2098 +14	2009-04-16 10:59:40 +00:00
Denis Vlasenko	74a931ac9e	hush: stop ignoring ^Z in child shells	2009-04-15 23:29:44 +00:00
Denis Vlasenko	c4ada79343	hush: remove old disabled ^Z handling	2009-04-15 23:29:00 +00:00
Denis Vlasenko	41ddecd9ed	hush: fix heredoc_huge.tests broken in last commits	2009-04-15 21:58:14 +00:00
Denis Vlasenko	c376db332c	hush: remove TODO comment itself :)	2009-04-15 21:49:48 +00:00
Denis Vlasenko	27014ed5cb	hush: deal with a TODO: move argv_from_re_execing out of globals function old new delta generate_stream_from_string 156 165 +9 setup_heredoc 312 320 +8 re_execute_shell 387 391 +4 pseudo_exec_argv 129 133 +4 run_pipe 1790 1783 -7 clean_up_after_re_execute 30 - -30 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 4/1 up/down: 25/-37) Total: -12 bytes	2009-04-15 21:48:23 +00:00
Denis Vlasenko	7f9593753a	randomconfig fixes	2009-04-14 08:06:59 +00:00
Denis Vlasenko	2b2183a77d	hush: make function support configurable	2009-04-13 14:23:12 +00:00
Denis Vlasenko	bc56974062	hush: pass functions to child shells on NOMMU function old new delta new_function - 123 +123 hush_main 1198 1262 +64 re_execute_shell 341 387 +46 run_pipe 1872 1790 -82 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/1 up/down: 233/-82) Total: 151 bytes	2009-04-12 20:35:19 +00:00
Denis Vlasenko	135cecbbce	ash: fix warning in debug build	2009-04-12 00:00:57 +00:00
Denis Vlasenko	c43430f1b9	hush: remove functions from TODOs	2009-04-11 11:07:22 +00:00
Denis Vlasenko	0701dca88c	hush: improve debugging output	2009-04-11 10:38:47 +00:00
Denis Vlasenko	ed055214bb	hush: fix "while...do f1() {a;}; f1; f1 {b;}; f1; done" bug	2009-04-11 10:37:10 +00:00
Denis Vlasenko	75bccfa375	hush: tweak tests	2009-04-10 23:48:03 +00:00
Denis Vlasenko	ce4acbbab6	hush: add function tests	2009-04-10 23:23:41 +00:00
Denis Vlasenko	6ba6f546ac	hush: pass $n to functions function old new delta run_pipe 1183 1325 +142 run_list 1219 1220 +1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 143/0) Total: 143 bytes	2009-04-10 21:57:50 +00:00
Denis Vlasenko	c0ea329297	hush: fix a few thinkos in function support; make it work on NOMMU; functions in child shells now even have $n passed to them! :) (in main shell it still doesn't work)	2009-04-10 21:22:02 +00:00
Denis Vlasenko	b7d8c0dbbd	hush: first stab at function support. argv passing is not coded yet. Only very rudimentary testing was done. With function support off, code growth is zero, with it on: function old new delta run_list 2158 2339 +181 parse_stream 1929 2044 +115 find_builtin 24 67 +43 find_function - 36 +36 file_get 244 264 +20 pseudo_exec_argv 145 160 +15 free_strings - 7 +7 free_pipe 183 181 -2 done_word 735 728 -7 expand_variables 2227 2204 -23 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 5/3 up/down: 417/-32) Total: 385 bytes	2009-04-10 19:05:43 +00:00
Denis Vlasenko	835fcfd33d	hush: reinstate accidentally reverted comment fix	2009-04-10 13:51:56 +00:00
Denis Vlasenko	0b677d8337	hush: fix some TODOs. TODO in export builting: +250 bytes. simplify unexpected EOF handling. function old new delta builtin_export 117 374 +257 o_reset_to_empty_unquoted - 21 +21 parse_stream 1926 1929 +3 syntax_error_unterm_ch 31 32 +1 handle_dollar 644 641 -3 parse_stream_dquoted 307 298 -9 add_till_backquote 106 97 -9 add_till_closing_paren 303 286 -17 o_reset 21 - -21 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 3/4 up/down: 282/-59) Total: 223 bytes	2009-04-10 13:49:10 +00:00
Denis Vlasenko	1fd1ea4395	hush: tighten up "for" variable name check. Add TODOs. Disable redir4.right part where we differ from bash. It is not a bug per standards. Add a few tests, one is in hush-bugs section: and_or_and_backgrounding.right. It will likely bite users in real world usage.	2009-04-10 12:03:20 +00:00
Denis Vlasenko	551bdfecb7	hush: fix typo in comment	2009-04-10 11:13:26 +00:00
Denis Vlasenko	ed7823738c	fix segfault on syntax error code path	2009-04-10 00:45:02 +00:00
Denis Vlasenko	c96865f445	hush: readability improvements. fix some more obscure bugs. a new redir4.tests is known to fail.	2009-04-10 00:20:58 +00:00
Mike Frysinger	e05f9286a9	add test cases for parameter substitution with unset/null strings	2009-04-09 23:01:47 +00:00
Mike Frysinger	57e746781c	dont crash if the variable we do substitution on is not set	2009-04-09 23:00:33 +00:00
Denis Vlasenko	d68ae08cde	hush: shrink and make more versatile error-reporting machinery function old new delta syntax_error_unterm_ch - 31 +31 syntax_error_unterm_str - 14 +14 parse_stream 2356 2361 +5 syntax_error_at 12 14 +2 syntax_error 25 27 +2 syntax_error_unterminated 28 - -28 expand_variables 2063 2031 -32 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 3/1 up/down: 54/-60) Total: -6 bytes text data bss dec hex filename 67278 197 3184 70659 11403 busybox_old 67228 197 3184 70609 113d1 busybox_unstripped	2009-04-09 20:41:34 +00:00
Denis Vlasenko	05d3b7cc0d	hush: deal with some easier TODOs function old new delta is_well_formed_var_name - 87 +87 builtin_read 49 86 +37 die_if_script - 31 +31 syntax_error_unterminated - 28 +28 syntax_error 26 51 +25 done_word 768 788 +20 syntax_error_at - 12 +12 parse_stream_dquoted 320 328 +8 expand_variables 2064 2063 -1 run_list 1225 1220 -5 add_till_closing_paren 308 303 -5 add_till_backquote 111 106 -5 handle_dollar 812 803 -9 parse_stream 2378 2356 -22 parse_redirect 408 372 -36 maybe_die 44 - -44 is_assignment 215 134 -81 ------------------------------------------------------------------------------ (add/remove: 4/1 grow/shrink: 4/8 up/down: 248/-208) Total: 40 bytes	2009-04-09 19:16:15 +00:00
Denis Vlasenko	1943aec2ec	hush: plug the leak of expanded heredoc	2009-04-09 14:15:57 +00:00
Denis Vlasenko	efea9d2819	hush: fix EXIT trap recursion case; check redirection failures function old new delta run_pipe 1299 1328 +29 hush_exit 90 102 +12 hush_main 1172 1179 +7 run_list 1226 1225 -1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/1 up/down: 48/-1) Total: 47 bytes	2009-04-09 13:43:11 +00:00
Denis Vlasenko	f81e8dbc74	*: make "pragma GCC visibility push(hidden)" less ugly	2009-04-09 12:35:13 +00:00
Mike Frysinger	327fd47f36	skip some tests when fancy echo support is turned off	2009-04-09 07:50:18 +00:00
Mike Frysinger	c3d91952d6	we arent testing `echo -n` here so use printf instead	2009-04-09 07:50:02 +00:00
Mike Frysinger	20300d0129	source the .config so tests can signal they need to be skipped due to feature disable	2009-04-09 07:49:43 +00:00
Denis Vlasenko	f50caac53c	hush: typo in comment	2009-04-09 01:40:15 +00:00
Denis Vlasenko	a2218dd862	hush: fix thinko in re_execute_shell; pass even less junk to heredoc helper function old new delta re_execute_shell 284 314 +30 setup_heredoc 290 303 +13 execv 23 - -23	2009-04-09 01:39:02 +00:00
Denis Vlasenko	5c090a96f9	hush: more rodust detection of unterminated strings etc; fix a case where we forget to copy `cmd` text; optimize nommu heredoc helper by not passing environment to it; add several tests function old new delta add_till_closing_paren 256 308 +52 parse_stream 2337 2378 +41 add_till_backquote 82 111 +29 re_execute_shell 269 284 +15 handle_dollar 802 812 +10 parse_stream_dquoted 316 320 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 6/0 up/down: 151/0) Total: 151 bytes	2009-04-08 21:51:33 +00:00
Denis Vlasenko	ffe6f80851	expand leak_all1.tests	2009-04-08 16:59:24 +00:00
Denis Vlasenko	14725f82b6	slight tweak to the leak detector	2009-04-08 16:46:45 +00:00
Denis Vlasenko	cc90f44402	hush: plug leak in run_pipe(). NOMMU only.	2009-04-08 16:40:34 +00:00
Denis Vlasenko	08daf564ae	hush: add a leak test which currently fails	2009-04-08 12:11:23 +00:00
Denis Vlasenko	c73b70c701	hush: add leak detector helper; fix/add tests for it function old new delta builtin_memleak - 92 +92 bltins 288 300 +12	2009-04-08 11:48:57 +00:00
Denis Vlasenko	3dfb035d8d	hush: echo \2>file fix	2009-04-08 09:29:14 +00:00
Denis Vlasenko	02d6f1ad72	hush: fix heredoc expansion of $var and `cmd` function old new delta expand_pseudo_dquoted - 104 +104 setup_heredoc 215 275 +60 done_word 669 691 +22 parse_stream 1899 1902 +3 setup_redirects 196 191 -5 free_pipe 189 183 -6 expand_variables 2349 2229 -120 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/3 up/down: 189/-131) Total: 58 bytes	2009-04-07 19:56:55 +00:00
Denis Vlasenko	25af86f73d	hush: fix wrong comment	2009-04-07 13:29:27 +00:00
Denis Vlasenko	af07b7c5b6	hush: fix heredoc <<- handling. hush-misc/heredoc2.tests testcase needs only one fix now - $var and `cmd` expancsion in heredocs function old new delta parse_redirect 265 306 +41 parse_stream 1866 1899 +33	2009-04-07 13:26:18 +00:00
Denis Vlasenko	50f3aa4547	hush: NOMMU-safe support of big heredocs function old new delta setup_heredoc 116 215 +99	2009-04-07 10:52:40 +00:00
Mike Frysinger	d4a24f2aae	here documents have been added, so drop from TODO	2009-04-07 07:28:25 +00:00
Mike Frysinger	932e111418	use sleep rather than usleep	2009-04-07 06:08:14 +00:00
Mike Frysinger	b509c9c670	add a pathological test case for here doc related to eof marker and other ugly corner cases	2009-04-07 06:06:05 +00:00
Mike Frysinger	a4f331d3c3	implement support for parameter substitution via #/% operators	2009-04-07 06:03:22 +00:00
Denis Vlasenko	6c9be7f451	hush: heredoc support, based on patch by Mike Frysinger (vapier AT gentoo.org) some TODOs are to be attacked later function old new delta parse_stream 1461 1866 +405 parse_redirect - 265 +265 setup_heredoc - 116 +116 setup_redirects 151 196 +45 builtin_exit 49 47 -2 redirect_opt_num 61 55 -6 setup_redirect 212 - -212 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 2/2 up/down: 831/-220) Total: 611 bytes	2009-04-07 02:29:51 +00:00
Denis Vlasenko	ab2b064342	hush: s/last_return_code/last_exitcode/g	2009-04-06 18:42:11 +00:00
Denis Vlasenko	0e15138c03	hush: fix "if false; then...fi" exitcode; trim "keyword"-less hush by 10 bytes	2009-04-06 18:40:31 +00:00
Denis Vlasenko	4ed67dd3d5	make hush-misc/*.tests executable	2009-04-06 18:10:20 +00:00
Denis Vlasenko	cd418a2670	hush: fix a bunch of obscure while/until/continue bugs function old new delta run_list 1159 1214 +55 done_pipe 106 123 +17 done_command 86 98 +12 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 84/0) Total: 84 bytes	2009-04-06 18:08:35 +00:00
Denis Vlasenko	8f8d013afc	*.tests should be executable	2009-04-06 16:27:51 +00:00
Denis Vlasenko	715f712d15	move hush-parsing/and-or.tests to hush-misc/* (which probably needs to be renamed to hush-execution...)	2009-04-06 16:17:51 +00:00
Mike Frysinger	3a64833eb9	add some brute force logic tests	2009-04-06 14:22:54 +00:00
Denis Vlasenko	a2b11e3395	hush: fix "false && echo yes \|\| echo no" bug 265 function old new delta run_list 1159 1189 +30	2009-04-06 14:11:13 +00:00
Denis Vlasenko	0969a49c08	hush: beautify re_execute_shell more	2009-04-06 13:05:57 +00:00
Denis Vlasenko	34e573d2ce	hush: drop allocations in re_execute_shell function old new delta hush_main 1127 1138 +11 re_execute_shell 286 256 -30 clean_up_after_re_execute 66 30 -36 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 11/-66) Total: -55 bytes	2009-04-06 12:56:28 +00:00
Mike Frysinger	3c7167b508	add tests for basic fd open/close/dupe	2009-04-06 12:36:10 +00:00
Mike Frysinger	dc4178050a	fix #>&- syntax for closing fds	2009-04-06 12:35:41 +00:00
Mike Frysinger	9052600feb	fix redir1 tests -- usleep isnt standard in $PATH	2009-04-06 12:34:27 +00:00
Denis Vlasenko	5e883fb00d	hush: micro-optimization. -37 bytes	2009-04-06 12:28:34 +00:00
Denis Vlasenko	b1d11bf45e	hush: more efficient filtering of "safe" arithmetic function old new delta expand_variables 2170 2147 -23	2009-04-06 12:24:58 +00:00
Denis Vlasenko	d0b4a8c285	hush: add <> and () as "safe" arith chars	2009-04-06 12:09:55 +00:00
Denis Vlasenko	bfbc971f9f	hush: print cd error to stderr; use fopen_or_warn in builtin_source; prepare builtin_unset for function support libbb: do not clear errno in fopen_or_warn function old new delta builtin_unset 242 271 +29 fopen_or_warn 42 31 -11 builtin_cd 90 74 -16 builtin_source 89 72 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/3 up/down: 29/-44) Total: -15 bytes	2009-04-06 12:04:42 +00:00
Denis Vlasenko	b0a6478eef	hush: fix "export a=a b=b" (was not setting and exporting b) function old new delta builtin_export 103 117 +14	2009-04-06 11:33:07 +00:00
Denis Vlasenko	c8d27334a0	hush: update TODO list; + my usual pointless tweaks :(	2009-04-06 10:47:21 +00:00
Denis Vlasenko	d3f973eab2	hush: mark SIGHUP TODOs better; don't disable SIGHUP for now, small tweaks to comments	2009-04-06 10:21:42 +00:00
Denis Vlasenko	a0e65120b5	hush: cosmetics, no code changes	2009-04-05 23:39:14 +00:00
Denis Vlasenko	913a201bf0	hush: strip NULs from file input, they are PITA/impossible to handle correctly function old new delta file_peek 89 93 +4 file_get 260 264 +4	2009-04-05 22:17:04 +00:00
Mike Frysinger	258275d85f	drop HUSH_VER_STR since it has no relevance anymore -- just use BB_VER	2009-04-05 21:19:43 +00:00
Denis Vlasenko	c4a7af55e9	hush: fix trap clearing in subshells on MMU; simplify NOMMU a bit: function old new delta parse_stream_dquoted 335 324 -11 handle_dollar 849 800 -49 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-60) Total: -60 bytes	2009-04-05 20:33:27 +00:00
Denis Vlasenko	f937528571	hush: audit and fix "interactive shell" setup code. function old new delta block_signals - 139 +139 maybe_set_to_sigexit - 47 +47 run_list 2018 2030 +12 expand_variables 2155 2165 +10 maybe_set_sighandler 47 - -47 hush_main 992 918 -74 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 2/1 up/down: 208/-121) Total: 87 bytes	2009-04-05 19:13:39 +00:00
Denis Vlasenko	46f9b6db80	hush: pass $! thru re-execution; try harder on re-exec; give error msg if re-exec didn't work; other tweaks in main() function old new delta hush_main 1144 1199 +55 re_execute_shell 237 286 +49 file_get 240 260 +20 clean_up_after_re_execute 58 66 +8 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/0 up/down: 132/0) Total: 132 bytes	2009-04-05 10:39:03 +00:00
Denis Vlasenko	232be3e79b	hush: suppress bogus warning from 4.2.1	2009-04-05 09:16:00 +00:00
Denis Vlasenko	18f2a79f9b	build system tweaks to account for latest hush changes	2009-04-05 09:02:11 +00:00
Denis Vlasenko	d85a5df159	hush: randomconfig fixes	2009-04-05 08:43:57 +00:00
Denis Vlasenko	cc4c693ec5	hush: plug the leak on NOMMU re-execute path function old new delta clean_up_after_re_execute - 58 +58 re_execute_shell 226 244 +18 run_pipe 1271 1276 +5 generate_stream_from_string 133 138 +5 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/0 up/down: 86/0) Total: 86 bytes	2009-04-05 07:38:48 +00:00
Denis Vlasenko	c3ff48b921	fixing mode on hush-leak/leak_argv1.tests	2009-04-05 02:14:59 +00:00
Denis Vlasenko	8a496d5db0	fixing mode on hush-leak/leak_argv1.tests	2009-04-05 02:14:37 +00:00
Denis Vlasenko	30db43b5c5	hush: fix passing of $n on NOMMU	2009-04-05 02:10:39 +00:00
Denis Vlasenko	16a0c74f63	hush: fix hush-misc/break5.tests NOMMU failure function old new delta hush_main 1118 1144 +26 re_execute_shell 188 204 +16 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 42/0) Total: 42 bytes	2009-04-05 01:46:59 +00:00
Denis Vlasenko	0bb4a23506	hush: fix all testsuite failures on NOMMU except memory leak. known TODOs: we do not pass traps and positional args yet.	2009-04-05 01:42:59 +00:00
Denis Vlasenko	609f2ab434	hush: enable NOMMU re-execution logic. Some testsuite entries fail on NOMMU. Before it was much worse. No regressions on MMU, size: function old new delta handle_dollar 626 632 +6 run_list 2018 2022 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 10/0) Total: 10 bytes	2009-04-04 23:15:14 +00:00
Denis Vlasenko	9aa7d6fdc5	hush: preparatory patch for NOMMU-safe { list } handling. function old new delta o_addblock - 58 +58 o_addstr_with_NUL - 27 +27 builtin_exit 47 49 +2 run_list 2020 2018 -2 o_addstrauto 27 - -27 parse_stream 1508 1461 -47 o_addstr 58 - -58 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/2 up/down: 87/-134) Total: -47 bytes	2009-04-04 22:47:50 +00:00
Denis Vlasenko	34d4d89b2d	hush: fix NOMMU hangs in pseudo_exec_argv. Add forgotted setting of signal mask. Reuse same help string in all shells. function old new delta builtin_exit 49 47 -2 pseudo_exec_argv 149 145 -4 builtin_help 74 63 -11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-17) Total: -17 bytes text data bss dec hex filename 825379 476 7616 833471 cb7bf busybox_old 825341 476 7616 833433 cb799 busybox_unstripped	2009-04-04 20:24:37 +00:00
Denis Vlasenko	552433bc5a	hush: fix "var=val >file" not creating file function old new delta static.null_ptr - 4 +4 run_list 2018 2020 +2 handle_dollar 667 626 -41 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/1 up/down: 6/-41) Total: -35 bytes	2009-04-04 19:29:21 +00:00
Denis Vlasenko	a24c8caeb2	hush: remove code which errors out on $- and $_, it's useless; wrap some longish lines function old new delta handle_dollar 667 626 -41	2009-04-04 15:24:40 +00:00
Denis Vlasenko	7c9861214b	hush: remove CHAR_xxx constants	2009-04-04 12:15:42 +00:00
Denis Vlasenko	6da69cddc0	hush: get rid of charmap[] function old new delta parse_stream 1447 1508 +61 get_local_var_value - 31 +31 run_list 2018 2020 +2 pseudo_exec_argv 151 149 -2 maybe_set_sighandler 50 47 -3 hush_exit 93 90 -3 builtin_wait 275 272 -3 check_and_run_traps 169 164 -5 hush_main 985 977 -8 file_get 260 240 -20 builtin_trap 438 414 -24 set_in_charmap 30 - -30 lookup_param 31 - -31 parse_and_run_stream 153 54 -99 ------------------------------------------------------------------------------ (add/remove: 1/2 grow/shrink: 2/9 up/down: 94/-228) Total: -134 bytes	2009-04-04 12:12:58 +00:00
Mike Frysinger	dfa9de7176	simplify maybe_die() slightly	2009-04-03 22:48:10 +00:00
Denis Vlasenko	db2a9b683a	hush: finally make `cmd` safe on NOMMU function old new delta generate_stream_from_string - 157 +157 expand_variables 2050 2003 -47 generate_stream_from_list 139 - -139 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 0/1 up/down: 157/-186) Total: -29 bytes	2009-04-03 22:31:18 +00:00
Denis Vlasenko	e0755e58ca	hush: yet another randomconfig fix	2009-04-03 21:16:45 +00:00
Denis Vlasenko	cc8289dc04	shell/math: randomconfig fix	2009-04-03 21:13:31 +00:00
Denis Vlasenko	60b392fd5b	hush: randomconfig fixes	2009-04-03 19:14:32 +00:00
Denis Vlasenko	b6e6556b31	hush: improve parse_stream: does not require parsing context struct; cleans up on syntax errors (we used to leak memory in this case); much simplified interface to the rest of hush. function old new delta parse_stream 1204 1447 +243 done_word 658 669 +11 static_get 22 28 +6 builtin_source 84 89 +5 parse_and_run_file 27 30 +3 parse_and_run_string 31 27 -4 builtin_eval 55 50 -5 hush_main 991 985 -6 free_pipe_list 39 31 -8 free_pipe 210 189 -21 expand_variables 2242 2199 -43 parse_and_run_stream 289 153 -136 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/7 up/down: 268/-223) Total: 45 bytes	2009-04-03 16:49:04 +00:00
Denis Vlasenko	240c255d8b	hush: simplify parse_stream function old new delta parse_and_run_stream 292 289 -3 parse_stream 1218 1204 -14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-17) Total: -17 bytes	2009-04-03 03:45:05 +00:00
Denis Vlasenko	3718168b87	hush: fix bug with local environment vars in pipes; simplify parse_stream() function old new delta parse_stream 1238 1218 -20 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-20) Total: -20 bytes	2009-04-03 03:19:15 +00:00
Denis Vlasenko	f9f7429346	hush: explain parsing context structure plug leak in setup_redirect on error path function old new delta done_command 84 86 +2 done_word 657 658 +1 done_pipe 105 106 +1 initialize_context 39 38 -1 setup_redirect 219 212 -7 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 4/-8) Total: -4 bytes	2009-04-03 00:07:05 +00:00
Denis Vlasenko	027e3fddb5	hush: straighten parse_stream() API a bit function old new delta parse_stream 1240 1238 -2 expand_variables 2272 2242 -30 parse_and_run_stream 338 292 -46 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-78) Total: -78 bytes	2009-04-02 22:50:40 +00:00
Mike Frysinger	a36258f288	trim trailing slashes from specified subdir so we output to the right place	2009-04-02 22:46:52 +00:00
Denis Vlasenko	b7aaae9052	hush: rename ->o_quote to ->o_escape hush_test/hush-arith/*: new tests for arithmetic evaluation	2009-04-02 20:17:49 +00:00
Mike Frysinger	7a79afa3ca	Arithmetic Expansion is supported now in hush, so drop from TODO	2009-04-02 17:06:35 +00:00
Denis Vlasenko	f328e00b10	hush: do not inadvertently parse $((1 + "22")) as ok. -20 bytes code size	2009-04-02 16:55:38 +00:00
Denis Vlasenko	2f1d394214	hush: make a=55; echo $(($a + 1)) $((1 + $((2)) + `echo $a`)) work as expected function old new delta handle_dollar - 667 +667 parse_stream_dquoted - 316 +316 expand_variables 2124 2272 +148 is_assignment 134 215 +81 parse_stream 2038 1240 -798 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/1 up/down: 1212/-798) Total: 414 bytes	2009-04-02 16:31:29 +00:00
Denis Vlasenko	b29eb6ed25	shells: do not need to have math state global function old new delta ash_arith - 143 +143 expand_variables 2102 2124 +22 popstring 134 140 +6 parse_command 1460 1463 +3 trapcmd 236 238 +2 changepath 197 196 -1 raise_interrupt 86 83 -3 hush_main 1012 991 -21 ash_main 1388 1364 -24 arith_set_local_var 73 34 -39 dash_arith 117 - -117 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 4/5 up/down: 176/-205) Total: -29 bytes	2009-04-02 13:46:27 +00:00
Denis Vlasenko	0dfe1d26a9	fix ash-alias/alias.tests failure	2009-04-02 12:57:38 +00:00
Mike Frysinger	98c52645c0	split math code out of ash and into a standalone library so we can use it in any shell (like hush!)	2009-04-02 10:02:37 +00:00
Denis Vlasenko	551ffdccea	more of pointless whitespace fixes	2009-04-01 19:48:05 +00:00
Denis Vlasenko	d308106245	hust_test/*: use "$THIS_SH" instead of hush	2009-03-31 22:14:32 +00:00
Denis Vlasenko	f6fbd62760	ash: add/improve comments, no code changes	2009-03-31 19:36:58 +00:00
Denis Vlasenko	46aeab9a34	ash: fix $IFS handling in read. closes bug 235	2009-03-31 19:18:17 +00:00
Denis Vlasenko	7566bae197	hush: fix wait builtin function old new delta builtin_wait 174 275 +101 sigwaitinfo - 48 +48 __GI_sigwaitinfo - 48 +48 check_and_run_traps 133 169 +36 checkjobs 349 380 +31 hush_main 971 991 +20 static.zero_timespec - 8 +8 run_list 2010 2016 +6 file_get 254 260 +6 static.zero_ts 8 - -8 ------------------------------------------------------------------------------ (add/remove: 3/1 grow/shrink: 6/0 up/down: 304/-8) Total: 296 bytes	2009-03-31 17:24:49 +00:00
Denis Vlasenko	1b62ead313	hush: don't lie in comment	2009-03-31 13:13:17 +00:00
Denis Vlasenko	7b830e78f2	hush: fix comments, no code changes	2009-03-31 13:05:32 +00:00
Denis Vlasenko	422cd7c81c	hush: make ^C work again, ^Z probably isn't working function old new delta file_get 219 254 +35 check_and_run_traps 122 133 +11 run_list 2001 2010 +9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 55/0) Total: 55 bytes	2009-03-31 12:41:52 +00:00
Denis Vlasenko	abedaac842	hush: do not reset sighaldlers after fork - instead, prevent them from doing any harm if they will be called. saves many sigaction calls on every fork. function old new delta hush_main 887 971 +84 sigexit 54 65 +11 run_list 2006 2001 -5 maybe_set_sighandler 76 50 -26 set_fatal_sighandler 186 - -186 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 2/2 up/down: 95/-217) Total: -122 bytes	2009-03-31 12:03:40 +00:00
Denis Vlasenko	d5762932fb	hush: rework signal and trap handling. Some smaller bits are TODO, expect minor breakage function old new delta set_fatal_sighandler 12 186 +174 check_and_run_traps - 122 +122 maybe_set_sighandler - 76 +76 hush_main 831 887 +56 sigtimedwait - 50 +50 __GI_sigtimedwait - 50 +50 hush_exit 49 93 +44 set_mode 749 777 +28 pseudo_exec_argv 131 151 +20 static.zero_ts - 8 +8 expand_variables 1962 1970 +8 builtin_wait 172 174 +2 set_misc_sighandler 12 - -12 set_jobctrl_sighandler 12 - -12 handler_ctrl_c 16 - -16 builtin_set_mode 28 - -28 handle_trap 97 - -97 handler_ctrl_z 107 - -107 builtin_trap 545 438 -107 run_list 2149 2006 -143 ------------------------------------------------------------------------------ (add/remove: 5/6 grow/shrink: 7/2 up/down: 638/-522) Total: 116 bytes	2009-03-31 11:22:57 +00:00
Mike Frysinger	d690f68554	implement `unset` semantics as required by POSIX	2009-03-30 06:50:54 +00:00
Mike Frysinger	0080ea7992	update `trap` poisx link	2009-03-30 03:50:07 +00:00
Mike Frysinger	87824e0e50	do not automatically display job information when the shell is not interactive	2009-03-30 00:19:30 +00:00
Mike Frysinger	681a4b7f06	enable trap tests	2009-03-29 23:49:46 +00:00
Mike Frysinger	9f8128f480	first pass at `trap` support in hush	2009-03-29 23:49:37 +00:00
Mike Frysinger	fd303b11ef	add test cases for `trap` ... but disabled for now until trap support is committed	2009-03-29 09:54:40 +00:00
Mike Frysinger	b975febeea	mark msh as deprecated	2009-03-29 00:52:41 +00:00
Mike Frysinger	40b8dc410e	use bb_strtou() in umask/wait and check errno to see if there was a problem rather than using endp	2009-03-29 00:50:30 +00:00
Mike Frysinger	8ec1c9dc6e	make sure we check job status whenever updating the prompt	2009-03-29 00:45:26 +00:00
Mike Frysinger	0b87e4ad15	test for invalid named variables	2009-03-28 21:06:38 +00:00
Mike Frysinger	7c3e52c1bd	do not let handle_dollar() accept vars that start with a digit	2009-03-28 21:06:22 +00:00
Mike Frysinger	56bdea1b43	implement `wait` builtin	2009-03-28 20:01:58 +00:00
Denis Vlasenko	e61f07f036	remove ((expr)) bash'ism	2009-03-28 19:31:34 +00:00
Denis Vlasenko	701ac1864b	randomconfig fix	2009-03-28 19:22:08 +00:00
Mike Frysinger	5a82845f60	update the normally disabled debug code around the syntax() func to use new maybe_die()	2009-03-28 19:09:04 +00:00
Mike Frysinger	78f9d8eb7a	add hush tests for parameter expansion	2009-03-28 18:55:34 +00:00
Mike Frysinger	6379bb4fde	implement most POSIX parameter expansions (~+500bytes)	2009-03-28 18:55:03 +00:00
Mike Frysinger	42ab86520e	make sure we exit based on test failure rather than always exiting with 0	2009-03-28 15:43:47 +00:00
Mike Frysinger	25a6ca0dd4	split up feature todo by posix/bash	2009-03-28 13:59:26 +00:00
Mike Frysinger	ad88d5a4cf	unify `set` handling with command line processing, fixup `set` argv processing so it doesnt clobber argv when setting options, and barf on unhandled set options	2009-03-28 13:44:51 +00:00
Mike Frysinger	19a7ea126a	handle the "-s" command line option that POSIX requires	2009-03-28 13:02:11 +00:00
Mike Frysinger	a71cfa8aa1	rename "-f" (fake) option to "-n" to match POSIX	2009-03-28 12:57:54 +00:00
Mike Frysinger	d006edb2ca	tweak format modifier in debug code to fixup gcc warning	2009-03-28 12:43:53 +00:00
Mike Frysinger	ec2c655702	convert some of the ENABLE_FEATURE_EDITING from CPP if to C if	2009-03-28 12:24:44 +00:00
Mike Frysinger	39456a18a1	stop lying about [[ test support	2009-03-28 12:21:57 +00:00
Mike Frysinger	70a2c8d531	make lash deprecation more prominent	2009-03-28 12:12:58 +00:00
Mike Frysinger	bfc0fae952	enable most job functions on no-mmu systems	2009-03-26 18:14:16 +00:00
Mike Frysinger	b2705e1652	do not make startup banner depend on job support	2009-03-23 08:44:02 +00:00
Mike Frysinger	ddbee974b4	move parse_stream out of ENABLE_HUSH_TICK to avoid implicit decl/build error	2009-03-22 22:48:41 +00:00
Denis Vlasenko	424f79b48f	hush: rearrange functions to reduce amount of forward references. Minimal code changes.	2009-03-22 14:23:34 +00:00
Denis Vlasenko	e1300f6fc7	hush: fix segv at repeated "set -- a b c" + "shift"	2009-03-22 11:41:18 +00:00
Denis Vlasenko	786ce17d6d	hush: fix strcpy of potentially overlapping strings	2009-03-21 21:51:11 +00:00
Denis Vlasenko	ccff0b962c	msh testsuite: fix false positive, tweak run stript	2009-03-21 19:58:58 +00:00
Denis Vlasenko	feecc7b74e	hush: tweak testsuite	2009-03-20 12:12:33 +00:00
Denis Vlasenko	a8b6dff97f	hush: fix bug 207 and "hush -c" parameter passing. Now hush -c 'printf "%s\n" "$@"' (prints "\n") and hush -c 'printf "%s\n" "$@"' qwe asd (prints "asd\n") both work correctly	2009-03-20 12:05:14 +00:00
Denis Vlasenko	5368ad53e9	ash: expand comment	2009-03-20 10:20:08 +00:00
Denis Vlasenko	11fb7cf5af	hush: fix set [--] params. Closes bug 199. function old new delta builtin_set 55 194 +139 add_strings_to_strings - 130 +130 add_string_to_strings 110 26 -84 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/1 up/down: 269/-84) Total: 185 bytes	2009-03-20 10:13:08 +00:00
Denis Vlasenko	1bb3d7e450	ash: add missing comma in debug scaffolding	2009-03-20 07:45:36 +00:00
Denis Vlasenko	b9e70ddf2d	ash: fix a case where we close wrong descriptor; add debug hack for that	2009-03-20 01:24:08 +00:00
Denis Vlasenko	f173395c4a	ash: DEBUG should be 0 :)	2009-03-19 23:21:55 +00:00
Denis Vlasenko	b21f379639	ash: fix TRACE commands	2009-03-19 23:09:58 +00:00
Denis Vlasenko	653d8e79b2	ash: make evaltree save/restore int suppression depth. Hopefully this fixes bug 189. Not confirmed by users yet. function old new delta evaltree 809 842 +33 evalvar 1374 1376 +2	2009-03-19 21:59:35 +00:00
Denis Vlasenko	731de5ce76	doc update	2009-03-19 13:42:05 +00:00
Denis Vlasenko	4b875708c1	ash: in dotrap(), do not clear gotsig[] for SIGINT if there is no handler for it, otherwise raise interrupt gets confused later. The rest are readability fixes. function old new delta evaltreenr 817 818 +1 evaltree 817 818 +1 evalstring 88 89 +1 cmdloop 420 419 -1 evalskip 4 1 -3 breakcmd 84 81 -3 ash_main 1382 1379 -3 evalloop 183 177 -6 evalfor 231 225 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/6 up/down: 3/-22) Total: -19 bytes	2009-03-19 13:30:04 +00:00
Denis Vlasenko	7f88e34e1a	ash: tentatively fix bug 189.	2009-03-19 03:36:18 +00:00
Denis Vlasenko	5c2b81470d	ash: fix "ash -c 'exec 1>&0'" complaining that fd 0 is busy	2009-03-19 01:59:59 +00:00
Denis Vlasenko	73c571a5ff	*: move get_sock_lsa and xwrite_str to libbb, use where appropriate function old new delta get_sock_lsa - 72 +72 buffer_fill_and_print 179 196 +17 parse_expr 824 832 +8 read_base64 343 348 +5 nameval 202 206 +4 fbset_main 1694 1698 +4 expand 1849 1853 +4 udhcp_send_kernel_packet 249 252 +3 udhcp_get_option 223 222 -1 chat_main 1246 1245 -1 pack_gzip 1661 1659 -2 doset 299 297 -2 bb__parsespent 119 117 -2 test_main 260 257 -3 qgravechar 109 106 -3 tcpudpsvd_main 1834 1830 -4 sysctl_display_all 589 580 -9 xopen_xwrite_close 44 33 -11 prs 30 18 -12 find_main 418 406 -12 full_write2_str 25 12 -13 adduser_main 667 654 -13 evaltreenr 817 802 -15 evaltree 817 802 -15 tftpd_main 526 493 -33 ftpd_main 2050 1990 -60 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 7/18 up/down: 117/-211) Total: -94 bytes	2009-03-09 00:12:37 +00:00
Denis Vlasenko	9604e1b8fc	modprobe: emit "can't open 'modules.dep': (errno)" instead of "module not found" *: s/can't open %s/can't open '%s'/, it's better to use same string. function old new delta do_modprobe 588 601 +13 config_file_action 339 345 +6 modprobe_main 565 570 +5 unable_to_open 14 16 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/0 up/down: 26/0) Total: 26 bytes text data bss dec hex filename 816800 476 7892 825168 c9750 busybox_old 816812 476 7892 825180 c975c busybox_unstripped	2009-03-03 18:47:56 +00:00
Denis Vlasenko	8ad78e1ec7	ash: make dot command search current directory first, as bash does.	2009-02-15 12:40:30 +00:00
Denis Vlasenko	76ddc2e3e4	libbb: add bb_unsetenv (taken from hush). udhcpc: stop filtering environment passed to the script. crond: fix uncovered potential bug (failing unsetenv) mdev: fix uncovered potential bug (failing unsetenv) tcp, udpsvd: fix uncovered potential bug (failing unsetenv) function old new delta safe_setenv - 58 +58 bb_unsetenv - 55 +55 builtin_unset 139 138 -1 tcpudpsvd_main 1843 1830 -13 free_strings_and_unsetenv 87 53 -34 udhcp_run_script 1186 1133 -53 safe_setenv4 62 - -62 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 0/4 up/down: 113/-163) Total: -50 bytes	2008-12-30 05:05:31 +00:00
Denis Vlasenko	4e12b1a2a9	libbb: introduce and use xmalloc_ttyname (-32 in bss). ash: small code shrink text data bss dec hex filename 793669 504 7524 801697 c3ba1 busybox_old 793659 504 7492 801655 c3b77 busybox_unstripped	2008-12-23 23:36:47 +00:00
Denis Vlasenko	68819d1232	ash: fix CONFIG_ASH_OPTIMIZE_FOR_SIZE off + high-bit chars case (do we even need CONFIG_ASH_OPTIMIZE_FOR_SIZE conditional?)	2008-12-15 11:26:36 +00:00
Denis Vlasenko	81c3a1d0b2	ash: remove TODO which seems to actually work now. no code changes	2008-12-03 11:59:12 +00:00
Denis Vlasenko	f8535ccd65	ash: finally installed it as /bin/sh on my machine. some breakage noticed, the most dire is mishandled ^C. fixing it. function old new delta blocking_wait_with_raise_on_sig - 40 +40 waitforjob 85 100 +15 setsignal 280 278 -2 evalvar 1376 1374 -2 waitcmd 186 182 -4 dowait 350 316 -34 redirect 1231 1185 -46 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/5 up/down: 55/-88) Total: -33 bytes	2008-12-03 10:36:26 +00:00
Denis Vlasenko	e27dafd338	ash: add FIXME	2008-11-28 04:01:03 +00:00
Denis Vlasenko	7b2294edff	ash: "ash: syntax error: XXX unexpected" -> "ash: syntax error: unexpected XXX"	2008-11-28 03:50:46 +00:00
Denis Vlasenko	41eb300ff6	ash: shrink on top of previous change function old new delta readtoken1 3201 3221 +20 xxreadtoken 306 313 +7 pungetc 13 12 -1 ash_main 1380 1379 -1 setinputfile 196 192 -4 plinno 4 - -4 parsenleft 4 - -4 parsenextc 4 - -4 parselleft 4 - -4 setinputstring 67 62 -5 pushstring 123 114 -9 pgetc 455 438 -17 pushfile 69 31 -38 popfile 114 76 -38 ------------------------------------------------------------------------------ (add/remove: 0/4 grow/shrink: 2/8 up/down: 27/-129) Total: -102 bytes text data bss dec hex filename 798750 564 7756 807070 c509e busybox_old 798664 560 7748 806972 c503c busybox_unstripped	2008-11-28 03:42:31 +00:00
Denis Vlasenko	727752d2d2	ash: better fix for ash -c 'echo 5&' and ash -c 'sleep 5&' with testcase	2008-11-28 03:41:47 +00:00
Denis Vlasenko	61befda93b	ash,hush: add TODO for rare build failure *: remove some redundant includes	2008-11-25 01:36:03 +00:00
Denis Vlasenko	1689840672	ash: fix bad interaction between ash -c '....&' and bash compat	2008-11-25 01:34:52 +00:00
Denis Vlasenko	cc5feabeba	ash: NTO2 needs #if ENABLE_ASH_BASH_COMPAT	2008-11-22 01:32:40 +00:00
Denis Vlasenko	340299a8bc	ash: fix miscalculation of memory needed for eval tree found by Timo Teras (timo.teras AT iki.fi)	2008-11-21 10:36:36 +00:00
Denis Vlasenko	9504e444b8	whitespace fixes, no code changes	2008-10-29 01:19:15 +00:00
Denis Vlasenko	6214941a3a	ash: add testcase for bug 5304	2008-10-27 14:33:03 +00:00
Denis Vlasenko	be54d6bc60	ash: fix "while kill -0 $child; do true; done" looping forever.	2008-10-27 14:25:52 +00:00
Denis Vlasenko	078323010b	dc: conditionalize parts which require libm	2008-10-20 08:43:10 +00:00
Denis Vlasenko	b730474bda	ash: fix NOEXEC mode - we were forgetting to pass environment! env: promote to NOEXEC hd: promote to NOEXEC, as hexdump is NOEXEC already	2008-10-20 08:15:51 +00:00
Denis Vlasenko	d1660cb9ad	ash: fix a bug in standalone mode (corrupted getopt() state)	2008-10-20 07:52:33 +00:00
Denis Vlasenko	ddc8ae3003	hush: add TODO	2008-10-14 12:50:34 +00:00
Denis Vlasenko	371de4acf7	hush: next small step towards functions	2008-10-14 12:43:13 +00:00
Denis Vlasenko	f886fd2bc7	hush: fix NOMMU bug (analogous to preceding commit for MMU)	2008-10-13 12:36:05 +00:00
Denis Vlasenko	d29084dd7d	testcase for the last fix	2008-10-13 08:54:42 +00:00
Denis Vlasenko	22d10a0292	hush: fix trashing of environment by local env vars: a=a; a=b cmd; - a was unset! +57 bytes function old new delta add_string_to_strings - 110 +110 putenv_all - 27 +27 run_list 2086 2111 +25 free_strings - 7 +7 free_pipe 210 208 -2 add_malloced_string_to_strings 110 - -110 ------------------------------------------------------------------------------ (add/remove: 3/1 grow/shrink: 1/1 up/down: 169/-112) Total: 57 bytes	2008-10-13 08:53:43 +00:00
Denis Vlasenko	afd7a8d744	hush: fix environment and memory leaks, add tests for them function old new delta add_malloced_string_to_strings - 110 +110 run_list 1999 2086 +87 free_strings_and_unsetenv - 87 +87 hush_version_str - 18 +18 pseudo_exec_argv 139 146 +7 static.version_str 17 - -17 free_pipe 237 210 -27 done_word 790 642 -148 ------------------------------------------------------------------------------ (add/remove: 3/1 grow/shrink: 2/2 up/down: 309/-192) Total: 117 bytes	2008-10-09 16:29:44 +00:00
Denis Vlasenko	c373527e4f	hush: preparatory work for implementing functions	2008-10-09 12:58:26 +00:00
Denis Vlasenko	9af22c7626	hush: massive renaming of ill-named structures and fields hush: error out on constructs like: $ abc(def) - was working as if it was (abcdef) $ case b in abc(a\|(b) echo YES; esac - was ignoring 'abc' and extra '('	2008-10-09 12:54:58 +00:00
Denis Vlasenko	834dee785d	ash: support &> redirection (bashism). ~90 bytes of code	2008-10-07 09:18:30 +00:00
Denis Vlasenko	176d49d4f7	ash: some beautification work, no code changes	2008-10-06 09:51:47 +00:00
Denis Vlasenko	559691a3bf	ash: implement ">&file" bashism. ~100 bytes.	2008-10-05 18:39:31 +00:00
Denis Vlasenko	d6855d1b50	style fixes, no code changes	2008-09-27 14:03:25 +00:00
Bernhard Reutner-Fischer	864329d674	- fix compilation on OSF/1	2008-09-25 10:55:05 +00:00
Denis Vlasenko	34c73c499b	ash: fix "(cat < file)" hang introduced by rev 22944.	2008-08-16 11:48:02 +00:00
Bernhard Reutner-Fischer	1dbc643dd3	- fix typo	2008-08-06 17:39:30 +00:00
Denis Vlasenko	2b576b8e76	hush: fix mishandling of a'b'c=fff as assignments. They are not. function old new delta parse_stream 1920 2004 +84 done_word 715 752 +37 parse_and_run_stream 328 333 +5 builtin_exec 25 29 +4 pseudo_exec_argv 138 139 +1 run_list 2006 1999 -7 is_assignment 215 134 -81 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/2 up/down: 131/-88) Total: 43 bytes	2008-08-04 00:46:07 +00:00
Denis Vlasenko	c8bec9a085	hush: remove a comment about already fixed bug	2008-08-03 22:27:50 +00:00
Denis Vlasenko	d498131168	hush: support $_NUMBERS variable names	2008-07-31 10:34:48 +00:00
Denis Vlasenko	f173607520	hush: fix "case ... in <newline> word)..."	2008-07-31 10:09:26 +00:00
Denis Vlasenko	fbeeb328b8	hush: support "pattern1\|pattern2...)" in case statements parse_stream 1847 1861 +14 run_list 1995 2006 +11	2008-07-31 00:17:01 +00:00
Denis Vlasenko	c90e1be01b	ash: bash compat: "shift $BIGNUM" is equivalent to "shift 1"	2008-07-30 15:35:05 +00:00
Denis Vlasenko	4f504a9e57	hush: trivial code shrink function old new delta builtin_continue 48 22 -26	2008-07-29 19:48:30 +00:00
Denis Vlasenko	87a8655f46	hush: use G.xxx instead of #define xxx G.xxx. We have too many globals there and #defines get messy. Remove one write-only G.variable.	2008-07-29 19:43:10 +00:00
Denis Vlasenko	ff29b4fc42	randomconfig fix	2008-07-29 13:57:59 +00:00
Denis Vlasenko	4554b721ad	hush: small fix for repeated continue and fix for wrong loop depth count after Ctrl-C; with testcase for first one	2008-07-29 13:36:09 +00:00
Denis Vlasenko	45cb9f9581	hush: fix inverted check (was making all break's to act as "break 99999")	2008-07-29 11:47:46 +00:00
Denis Vlasenko	fcf37c3183	hush: fix break'ing out of {} and () groups; with testcase function old new delta builtin_break 93 129 +36 builtin_continue 21 47 +26 run_list 1973 1976 +3	2008-07-29 11:37:15 +00:00
Denis Vlasenko	d91afa33fd	randomconfig fixes	2008-07-29 11:10:01 +00:00
Denis Vlasenko	dadfb4975b	hush: add #defines to switch off break/continue if loops are not supported *: remove a few inline keywords no code changes	2008-07-29 10:16:05 +00:00
Denis Vlasenko	918a34b9e0	hush: fix "while false; ..." exitcode; add testsuites	2008-07-28 23:17:31 +00:00
Denis Vlasenko	6a2d40f239	hush: support "break N" and "continue N" fix non-detection of builtins and applets in "v=break; ...; $v; ..." case add testsuite entries for the above function old new delta builtin_break 12 93 +81 run_list 1948 1971 +23 builtin_continue 12 21 +9 pseudo_exec_argv 132 138 +6 builtin_exec 23 25 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/0 up/down: 121/0) Total: 121 bytes	2008-07-28 23:07:06 +00:00
Denis Vlasenko	bcb25537d0	hush: implement break and continue function old new delta bltins 252 276 +24 builtin_continue - 12 +12 builtin_break - 12 +12 static.version_str 18 17 -1 run_list 1984 1948 -36 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 1/2 up/down: 48/-27) Total: 11 bytes	2008-07-28 23:04:34 +00:00
Denis Vlasenko	cf22c89f9a	hush: in run_list(), some loop_top ops seems to be superfluous. comment them out. Also, use separate temp variable for verification loop, helps gcc to optimize better. function old new delta run_list 2039 1984 -55	2008-07-28 15:17:44 +00:00
Denis Vlasenko	12acec5ad4	hush: in run_list(), last_cond_code seems to be superfluous. comment it out function old new delta run_list 2055 2039 -16 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-16) Total: -16 bytes	2008-07-28 15:15:59 +00:00
Denis Vlasenko	5e052cab17	hush: explain run_list() in detail; small optimizations function old new delta hush_main 785 786 +1 expand_variables 1447 1448 +1 builtin_exit 48 49 +1 builtin_eval 54 55 +1 run_list 2075 2055 -20 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/1 up/down: 4/-20) Total: -16 bytes	2008-07-28 15:15:09 +00:00
Denis Vlasenko	38c89210d6	documentation fix	2008-07-28 00:06:02 +00:00
Denis Vlasenko	be709c24d4	hush: finish and enable optional case...esac support. Code size cost: function old new delta run_list 1891 2075 +184 parse_stream 1764 1847 +83 expand_strvec_to_string - 83 +83 done_word 647 715 +68 static.reserved_list 144 168 +24 static.reserved_match - 12 +12 done_pipe 95 105 +10 builtin_exit 48 46 -2 builtin_eval 127 54 -73 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 5/2 up/down: 464/-75) Total: 389 bytes	2008-07-28 00:01:16 +00:00
Denis Vlasenko	8dbea7dbb1	ash: add slightly different testcase	2008-07-26 14:20:04 +00:00
Denis Vlasenko	5c13270359	ash: fix testcase to not sleep for whole 10 seconds, gets annoying pretty fast. Also fix wrong message there.	2008-07-26 13:53:42 +00:00
Denis Vlasenko	87d5fd984e	ash: fix typo	2008-07-26 13:48:35 +00:00
Denis Vlasenko	4e19a9c81a	ash: hopefully close bug 4324. With testcase. function old new delta evaltree 621 869 +248 popstring 134 140 +6	2008-07-26 13:45:57 +00:00
Denis Vlasenko	2b2e267b43	ash: testsuite entries for last change	2008-07-25 13:40:06 +00:00
Denis Vlasenko	6a0ad25061	ash: dont allow e.g. exec <&10 to attach to stript's fd! function old new delta is_hidden_fd - 61 +61 redirect 1135 1164 +29 popstring 134 140 +6 printf_main 635 637 +2 evalvar 1374 1376 +2 echo_main 294 296 +2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/0 up/down: 102/0) Total: 102 bytes	2008-07-25 13:34:05 +00:00
Denis Vlasenko	22f7414843	ash: prevent exec NN>&- from closing fd used for script reading	2008-07-24 22:34:43 +00:00
Denis Vlasenko	5a867317bb	ash: fix a bug where redirection fds were not closed afterwards. optimize close+fcntl(DUPFD) into dup2. add testsuites. function old new delta copyfd 47 68 +21 argstr 1311 1298 -13 popredir 148 131 -17 redirect 1139 1107 -32 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/3 up/down: 21/-62) Total: -41 bytes	2008-07-24 19:46:38 +00:00
Denis Vlasenko	6fbb43bc3c	ash: teach ash about 123>file. It could take only 0..9 before function old new delta redirect 1052 1139 +87 need_to_remember - 36 +36 popredir 132 148 +16 fixredir 86 101 +15 readtoken1 3130 3143 +13 evalvar 1374 1376 +2 popstring 140 134 -6 cmdtxt 592 561 -31 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/2 up/down: 169/-37) Total: 132 bytes	2008-07-24 19:44:41 +00:00
Denis Vlasenko	6514c5e35c	ash: ducument where "no fds > 9 in redirects" limitation is. no code changes.	2008-07-24 13:41:37 +00:00
Denis Vlasenko	8d924ecf38	ash: ditch dupredirect(), it was only making code harder to read. incorporate it in its single callsite. function old new delta redirect 1054 1052 -2 changepath 196 194 -2	2008-07-24 11:34:27 +00:00
Denis Vlasenko	0b76964ae1	ash: explain redirect code a bit function old new delta redirect 1059 1054 -5	2008-07-24 07:54:57 +00:00
Denis Vlasenko	2dc240c0d6	ash: code shrink function old new delta copynode 171 180 +9 evaltreenr 615 621 +6 evaltree 615 621 +6 calcsize 121 127 +6 evalpipe 349 350 +1 redirect 1059 1057 -2 parseheredoc 129 126 -3 makename 35 32 -3 expredir 130 127 -3 parsefname 224 219 -5 popstring 140 134 -6 pipeline 276 268 -8 list 360 351 -9 readtoken1 3157 3130 -27 parse_command 1504 1460 -44 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/10 up/down: 28/-110) Total: -82 bytes	2008-07-24 06:07:50 +00:00
Bernhard Reutner-Fischer	3e8669f359	- wrap overlong lines (Cristian Ionescu-Idbohrn) - s/\. /. /g;# (me)	2008-07-22 18:27:53 +00:00
Denis Vlasenko	5415c856ea	libbb: [x]fopen_for_{read,write} introduced and used. (by Valdimir) function old new delta config_open2 - 41 +41 config_read 507 542 +35 find_pair 169 187 +18 fopen_for_write - 14 +14 fopen_for_read - 14 +14 find_main 406 418 +12 xfopen_for_write - 10 +10 xfopen_for_read - 10 +10 popstring 134 140 +6 parse_inittab 396 401 +5 next_token 923 928 +5 pack_gzip 1659 1661 +2 bb__parsespent 117 119 +2 fallbackSort 1719 1717 -2 evalvar 1376 1374 -2 qrealloc 36 33 -3 ... ... ... ... singlemount 4579 4569 -10 process_stdin 443 433 -10 patch_main 1111 1101 -10 ifupdown_main 2175 2165 -10 file_action_grep 90 80 -10 uuidcache_init 649 637 -12 hush_main 797 785 -12 read_config 230 217 -13 dpkg_main 3835 3820 -15 read_line_input 3134 3110 -24 sysctl_main 232 203 -29 config_open 40 10 -30 WARN_BAD_LINE 44 - -44 login_main 1714 1575 -139 ------------------------------------------------------------------------------ (add/remove: 5/1 grow/shrink: 8/74 up/down: 174/-737) Total: -563 bytes	2008-07-21 23:05:26 +00:00
Bernhard Reutner-Fischer	a53de7f7c2	- fix spelling	2008-07-21 13:46:54 +00:00
Denis Vlasenko	7ae1cc16b4	msh: fix "while...continue" bug 3884.	2008-07-20 23:03:23 +00:00
Denis Vlasenko	c185e290ee	config help fixes	2008-07-16 23:45:11 +00:00
Denis Vlasenko	757361f9f5	hush: fix "... pattern) cmd;; esac" case	2008-07-14 08:26:47 +00:00
Denis Vlasenko	395ae45216	hush: delete unused field in struct child. reinstate needed check for invalid syntax. document command parsing in hush_doc.txt.	2008-07-14 06:29:38 +00:00
Denis Vlasenko	17f02e79f4	hush: add case statement support. It is incomplete and disabled for now. costs ~300 bytes when enabled.	2008-07-14 04:32:29 +00:00
Denis Vlasenko	3177ba0852	ash: small code shrink	2008-07-13 20:39:23 +00:00
Denis Vlasenko	e7067e38ea	ash: fix segfault in "command -v"	2008-07-11 23:09:34 +00:00
Denis Vlasenko	6bdff08e6c	hush: compile fixes for !LOOPS case	2008-07-09 20:14:53 +00:00
Denis Vlasenko	733e3fbc2f	hush: support "for if in do done then; do echo $if; done" case function old new delta done_pipe 83 95 +12 parse_stream 1758 1764 +6 done_word 674 647 -27 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 18/-27) Total: -9 bytes	2008-07-06 10:01:13 +00:00
Denis Vlasenko	ff182a3d68	hush: support "for v; do ... done" syntax (implied 'in "$@"')	2008-07-05 20:29:59 +00:00
Denis Vlasenko	afdcd12ed7	hush: fix a case where "$@" must expand to no word at all	2008-07-05 17:40:04 +00:00
Denis Vlasenko	a60f84ebf0	*: rename ATTRIBUTE_XXX to just XXX.	2008-07-05 09:18:54 +00:00
Denis Vlasenko	fa0b56db76	sendmail: fix wrong vfork usage here too *: shorten error texts function old new delta launch_helper - 151 +151 vfork_or_die 20 - -20 sendgetmail_main 1946 1848 -98 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 0/1 up/down: 151/-118) Total: 33 bytes	2008-07-01 16:09:07 +00:00
Denis Vlasenko	82604e9730	revert last two commits. vfork cannot be used in subroutine, it trashes stack on return	2008-07-01 15:59:42 +00:00
Denis Vlasenko	58d60c3333	*: introduce and use xfork() function old new delta xfork - 20 +20 msh_main 1377 1380 +3 mod_process 455 446 -9 forkexit_or_rexec 30 17 -13 expand_variables 1434 1421 -13 open_transformer 91 76 -15 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/4 up/down: 23/-50) Total: -27 bytes	2008-07-01 11:11:24 +00:00
Denis Vlasenko	3da5572bfa	*: introduce and use xvfork() function old new delta time_main 1052 1285 +233 crontab_main 623 856 +233 ifupdown_main 2202 2403 +201 xvfork - 20 +20 passwd_main 1049 1053 +4 grave 1068 1066 -2 script_main 935 921 -14 vfork_or_die 20 - -20 vfork_compressor 206 175 -31 open_as_user 109 - -109 popen2 218 - -218 edit_file 910 690 -220 run_command 268 - -268 ------------------------------------------------------------------------------ (add/remove: 1/4 grow/shrink: 4/4 up/down: 691/-882) Total: -191 bytes	2008-07-01 10:40:41 +00:00
Denis Vlasenko	ce13b76002	libbb: shrink monotonic_XXX functions, introduce monotonic_ns (unused for now) function old new delta get_mono - 31 +31 sv_main 1228 1234 +6 expand 1693 1697 +4 get_address 178 181 +3 utoa_to_buf 108 110 +2 builtin_exit 46 48 +2 qrealloc 36 33 -3 qgravechar 109 106 -3 ash_main 1383 1380 -3 grep_file 850 846 -4 popstring 140 134 -6 monotonic_us 85 60 -25 monotonic_sec 41 16 -25 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/7 up/down: 48/-69) Total: -21 bytes	2008-06-29 02:25:53 +00:00
Denis Vlasenko	defc1ea340	*: introduce and use FAST_FUNC: regparm on i386, otherwise no-on text data bss dec hex filename 808035 611 6868 815514 c719a busybox_old 804472 611 6868 811951 c63af busybox_unstripped	2008-06-27 02:52:20 +00:00
Denis Vlasenko	26bc57d8b2	ash: improve comments	2008-06-27 00:29:34 +00:00
Denis Vlasenko	448d30ee17	ash: fix very weak $RANDOM generator; and move even more things out of data/bss text data bss dec hex filename 807935 611 6884 815430 c7146 busybox_old 808035 611 6868 815514 c719a busybox_unstripped	2008-06-27 00:24:11 +00:00
Denis Vlasenko	843cbd54d1	ash: move stuff out of data/bss text data bss dec hex filename 807939 611 6900 815450 c715a busybox_old 807935 611 6884 815430 c7146 busybox_unstripped	2008-06-27 00:23:18 +00:00
Denis Vlasenko	f5d8c90d73	style fixes, no code changes	2008-06-26 14:32:57 +00:00
Denis Vlasenko	7049ff8696	whitespace fixes. no code changes	2008-06-25 09:53:17 +00:00
Denis Vlasenko	5ec6132c98	hush: ifdef out parts which are not needed if neither loops nor ifs are supported. Code savings: function old new delta parse_stream 1758 1757 -1 checkjobs 335 318 -17 done_pipe 74 52 -22 expand_variables 1437 1407 -30 run_list 1232 1189 -43 parse_and_run_stream 328 267 -61 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-174) Total: -174 bytes	2008-06-24 00:50:07 +00:00
Denis Vlasenko	003f9fb213	hush: kill some old unused fields; small code shrink function old new delta builtin_exit 48 47 -1 checkjobs 351 335 -16 checkjobs_and_fg_shell 60 35 -25 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-42) Total: -42 bytes	2008-06-24 00:47:58 +00:00
Denis Vlasenko	cc3f20b9bd	fix breakage found by randomconfig	2008-06-23 22:31:52 +00:00
Denis Vlasenko	211b59be43	hush: trivial fix in debug code	2008-06-23 16:28:53 +00:00
Denis Vlasenko	2f5d0cd511	ash: trivial code readability fixes	2008-06-23 13:24:19 +00:00
Denis Vlasenko	2b75a94118	ash: improve readability of the code. No real code changes.	2008-06-23 13:06:34 +00:00
Denis Vlasenko	ef527f50e6	ash: optional support for $'...\t...\n...' bashism function old new delta readtoken1 2824 3172 +348 static.C_escapes - 18 +18 parse_command 1504 1500 -4 SIT 89 83 -6 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/2 up/down: 366/-10) Total: 356 bytes	2008-06-23 01:52:30 +00:00
Denis Vlasenko	b07a496229	ash: minor shrink (mostly smallints) and variable renaming function old new delta optschanged 85 91 +6 tryexec 115 118 +3 xxreadtoken 290 292 +2 raise_error_unexpected_syntax 75 77 +2 bltincmd 6 8 +2 parseheredoc 128 129 +1 static.is_interactive 4 1 -3 readtoken 156 153 -3 lasttoken 4 1 -3 evalcommand 1147 1144 -3 checkkwd 4 1 -3 back_exitstatus 4 1 -3 pipeline 282 276 -6 list 369 360 -9 ash_main 1402 1393 -9 options 616 606 -10 readtoken1 2823 2811 -12 parse_command 1529 1507 -22 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 6/12 up/down: 21/-91) Total: -70 bytes text data bss dec hex filename 807603 611 6908 815122 c7012 busybox_old 807545 611 6900 815056 c6fd0 busybox_unstripped	2008-06-22 13:16:23 +00:00
Denis Vlasenko	9cd4c76b50	ash: fix "shift BIGNUM" and "read with no variable name" bugs. omg. hush testsuite helps to find bugs in ash! what next? function old new delta static.arg_REPLY - 8 +8 readcmd 1023 1021 -2 shiftcmd 129 125 -4 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/2 up/down: 8/-6) Total: 2 bytes	2008-06-18 19:22:19 +00:00
Denis Vlasenko	1ba323e5b6	cosmetics in hush testsuites	2008-06-18 17:53:57 +00:00
Denis Vlasenko	324a3fdf87	fix globbing in unquoted $* and $@	2008-06-18 17:49:58 +00:00
Denis Vlasenko	55789c6646	hush: fix a bug with backslashes improperly handled in unquoted variables. with previous patch: function old new delta parse_stream 1638 1758 +120 expand_on_ifs 97 174 +77 free_pipe 206 237 +31 setup_redirect 217 220 +3 setup_redirects 143 144 +1 done_word 698 688 -10 free_strings 38 - -38 expand_variables 1451 1403 -48 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 5/2 up/down: 232/-96) Total: 136 bytes	2008-06-18 16:30:42 +00:00
Denis Vlasenko	ab876cd107	hush: add testsuite for "no globbing in redirection" rule. simplify redirection habdling	2008-06-18 16:29:32 +00:00
Denis Vlasenko	985de15bf3	hush: expand quote3.tests and move from hush-bugs to hush-parsing	2008-06-18 09:22:31 +00:00
Denis Vlasenko	c1c63b622d	hush: fix last hush-bugs testcase (disappearing "", $empty"" etc)	2008-06-18 09:20:35 +00:00
Denis Vlasenko	16c2fea280	hush: fix $$ handling	2008-06-17 12:28:44 +00:00
Denis Vlasenko	6eaf8deddd	hush: fix "for a in; do echo 'I should never run'; done" bug	2008-06-17 12:09:21 +00:00
Denis Vlasenko	988339259f	move glob_and_assign.tests from hush-bugs to hush-glob	2008-06-17 07:26:52 +00:00
Denis Vlasenko	30c9cc5b17	hush: continue fixing quoting and subst: fix glob_and_assign.tests.	2008-06-17 07:24:29 +00:00
Denis Vlasenko	c7985b76c5	hush: cleanup pass, the biggest is - moved builtins to the end of the file, they really annoy in the middle of parser code. no real code changes.	2008-06-17 05:43:38 +00:00
Denis Vlasenko	b61e13d247	hush: fix memory leak. it was actually rather invloved problem. Now finally glob/variable expansion is done IN THE RIGHT ORDER! It opens up a possibility to cleanly fix remaining known bugs. function old new delta o_save_ptr 115 286 +171 o_save_ptr_helper - 115 +115 done_word 591 690 +99 o_get_last_ptr - 31 +31 expand_on_ifs 125 97 -28 add_string_to_strings 28 - -28 run_list 1895 1862 -33 debug_print_strings 42 - -42 add_strings_to_strings 126 - -126 expand_variables 1550 1394 -156 o_debug_list 168 - -168 expand_strvec_to_strvec 388 10 -378 ------------------------------------------------------------------------------ (add/remove: 2/4 grow/shrink: 2/4 up/down: 416/-959) Total: -543 bytes	2008-06-17 05:11:43 +00:00
Denis Vlasenko	ccce59d562	hush: fixing fallout from last big glob fix: fix segfault; identify where we leak memory function old new delta expand_strvec_to_strvec 353 336 -17	2008-06-16 14:35:57 +00:00
Denis Vlasenko	32d8423e63	hush: delete hush-bugs/glob_and_vars.tests for real	2008-06-16 12:53:33 +00:00
Denis Vlasenko	82dfec3e4e	hush: fix hush-bugs/glob_and_vars.tests testcase: globbing is now done _after_ variable/`cmd` substitution function old new delta expand_strvec_to_strvec 7 353 +346 expand_variables 1348 1383 +35 add_string_to_strings - 28 +28 globhack 114 - -114 done_word 778 579 -199 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 2/1 up/down: 409/-313) Total: 96 bytes	2008-06-16 12:47:11 +00:00
Denis Vlasenko	5703c22a51	hush: eliminate PARSEFLAG_SEMICOLON and ctx->parse_type field. function old new delta parse_and_run_file 30 27 -3 hush_main 795 792 -3 initialize_context 45 39 -6 done_word 791 778 -13 parse_and_run_stream 375 338 -37 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-62) Total: -62 bytes	2008-06-15 11:49:42 +00:00
Denis Vlasenko	f8d01d3f66	hush: fix a bug where we were requiring semicolon here: (cmd;) also fix a bug where after error prompt is not shown. function old new delta parse_stream 1612 1638 +26 parse_and_run_stream 361 375 +14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 40/0) Total: 40 bytes	2008-06-14 17:13:20 +00:00
Denis Vlasenko	dd316dd283	hush: add support for ':'; create testsuite entries text data bss dec hex filename 809569 612 7044 817225 c7849 busybox_old 809528 612 7044 817184 c7820 busybox_unstripped	2008-06-14 15:50:55 +00:00
Denis Vlasenko	a84420062a	hush: support "! cmd \| cmd" negation function old new delta done_word 749 791 +42 run_list 1821 1859 +38 checkjobs 334 351 +17 done_pipe 61 74 +13 static.reserved_list 132 144 +12 initialize_context 53 45 -8 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 5/1 up/down: 122/-8) Total: 114 bytes	2008-06-14 11:00:17 +00:00
Denis Vlasenko	29038c06d6	ash: small cosmetic change	2008-06-14 06:14:02 +00:00
Denis Vlasenko	2659c63213	ash: fix ${var/s/r} handling, add testcase.	2008-06-14 06:04:59 +00:00
Denis Vlasenko	7e3d33b6ce	hush: speed up o_addX{chr,str} function old new delta o_addQstr - 162 +162 o_addQchr - 89 +89 o_addstr - 58 +58 o_addqchr 50 81 +31 expand_on_ifs 103 97 -6 add_till_backquote 92 82 -10 expand_variables 1281 1217 -64 parse_stream 1675 1609 -66 o_addqstr 155 - -155 ------------------------------------------------------------------------------ (add/remove: 3/1 grow/shrink: 1/4 up/down: 340/-301) Total: 39 bytes text data bss dec hex filename 759870 604 6684 767158 bb4b6 busybox_old 759909 604 6684 767197 bb4dd busybox_unstripped	2008-06-12 13:31:04 +00:00
Denis Vlasenko	76db5adbf7	hush: fix for nested $()s with escapes + testsuite	2008-06-12 12:58:20 +00:00
Denis Vlasenko	87f40bac14	hush: more backtick and quoting fixes...	2008-06-10 22:39:37 +00:00
Denis Vlasenko	43360e5178	hush: fix escaping of \[*?; add testsuites for these and for globbing	2008-06-10 20:13:40 +00:00
Denis Vlasenko	2e76c3f901	hush: fix yet another fallout hush: move fixed testsuites out of hush-bugs/*	2008-06-10 18:27:50 +00:00
Denis Vlasenko	895bea2303	hush: fix some fallout from prev commits, add testsuite	2008-06-10 18:06:24 +00:00
Denis Vlasenko	46ccdcb96e	hush: search/and/replace style cleanups, no code changes	2008-06-10 18:05:12 +00:00
Denis Vlasenko	7b4f3f13d3	hush: fix two nasty bugs: hush-bugs/tick2.tests: ok hush-bugs/tick.tests: ok function old new delta parse_stream 1332 1557 +225 b_addptr - 97 +97 add_till_backquote - 82 +82 b_addstr - 58 +58 b_grow_by - 50 +50 setup_string_in_str - 29 +29 expand_variables 1196 1199 +3 expand_on_ifs 100 97 -3 b_addqchr 57 50 -7 parse_and_run_string 48 31 -17 lookup_param 27 - -27 b_addchr 75 45 -30 count_ifs 44 - -44 process_command_subs 222 - -222 ------------------------------------------------------------------------------ (add/remove: 5/3 grow/shrink: 2/4 up/down: 544/-350) Total: 194 bytes text data bss dec hex filename 759354 604 6684 766642 bb2b2 busybox_old 759534 604 6684 766822 bb366 busybox_unstripped	2008-06-10 18:04:32 +00:00
Denis Vlasenko	76d50418b3	hush: fix a memory leak in NOMMU case	2008-06-10 16:19:39 +00:00
Denis Vlasenko	3fe4f986a0	less: fix a case when regexp matches "" hush: remove wrong comment, expand another one	2008-06-09 16:02:39 +00:00
Mike Frysinger	98a6f56d49	reword the error msg so people realize that they broke it, they buy it	2008-06-09 09:38:45 +00:00
Denis Vlasenko	598bb732e8	cosmetics	2008-06-09 07:58:53 +00:00
Denis Vlasenko	2d0529c9bc	msh_function.patch: picked it up in the wild. Fixed allocation bugs (it was allocating one too small vectors) but it still is very buggy, thus not applied.	2008-06-09 07:50:25 +00:00
Denis Vlasenko	ed9d621cf4	msh: style cleanups. No code changes.	2008-06-09 07:44:19 +00:00
Denis Vlasenko	b8c9354114	hush: add yet another bug to testsuite :(	2008-06-08 16:47:09 +00:00
Denis Vlasenko	66d56c565e	ash testsuite: modify it so that it can run hush and msh tests	2008-06-05 09:07:02 +00:00
Denis Vlasenko	cd2663f15e	ash: optional printf builtin. +25 bytes if off, +35 if on. by Cristian Ionescu-Idbohrn.	2008-06-01 22:36:39 +00:00
Denis Vlasenko	d78920675f	msh: fix ENOENT testcase	2008-06-01 14:16:54 +00:00
Denis Vlasenko	447bd66837	msh: fix the case where the file has exec bit but can't be run directly (run "$SHELL $file" instead) msh: fix exit codes when command is not found or can't be execed (with testcases)	2008-05-30 22:28:32 +00:00
Denis Vlasenko	4830fc565a	hush: make it ignore SIGINT etc in a config wich has no job control	2008-05-25 21:50:55 +00:00
Bernhard Reutner-Fischer	5e25ddb7d3	- use STD*_FILENO some more. No object-code changes	2008-05-19 09:48:17 +00:00
Bernhard Reutner-Fischer	636a1f85e8	- use EXIT_{SUCCESS,FAILURE}. No object-code changes	2008-05-19 09:29:47 +00:00
Denis Vlasenko	29eb3599e4	ash: more of -Wall fixes	2008-05-18 14:06:08 +00:00
Denis Vlasenko	6b06cb80be	more of -Wall fixes from Cristian Ionescu-Idbohrn. Some are fixing real bugs. function old new delta syslogd_main 938 958 +20 get_signum 136 143 +7 obj_load 777 782 +5 recv_from_to 210 214 +4 get_next_block 1795 1799 +4 display_topmem_process_list 1117 1121 +4 logread_main 484 487 +3 buffer_fill_and_print 73 76 +3 kill_main 687 689 +2 ll_remember_index 240 241 +1 do_stats 452 453 +1 if_readconf 166 165 -1 display_process_list 1192 1191 -1 run_applet_and_exit 507 505 -2 print_signames 33 31 -2 parse_one_line 1092 1090 -2 find_out_spec 57 55 -2 add_ksymoops_symbols 421 419 -2 ash_main 1407 1402 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 11/8 up/down: 54/-17) Total: 37 bytes	2008-05-15 21:30:45 +00:00
Mike Frysinger	b81f97bbd2	fix by Jie Zhang for exit status and POSIX compliance: http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html The exit status of a command that terminated because it received a signal shall be reported as greater than 128.	2008-05-14 11:51:04 +00:00
Denis Vlasenko	dddfaff363	ash: make set -o and set +o work as in dash/bash. by Cristian Ionescu-Idbohrn. function old new delta options 565 625 +60 getoptscmd 709 698 -11	2008-05-06 15:30:27 +00:00
Denis Vlasenko	bc1918a7a2	trivial fixes to make bbox compile with gcc 4.3.0	2008-04-15 01:17:50 +00:00

... 6 7 8 9 10 ...

1598 Commits