emo/ndhc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only process one epoll event at a time.

Browse Source 
If ndhc were a high-performance program that handled lots of events,
this change would harm performance.  But it is not, and it implicitly
believes that events come in one at a time.  Processing batches
would make it harder to assure correctness while also never allocating
memory at runtime.

The previous structure was fine when everything was handled
immediately by callbacks, but it isn't now.
This commit is contained in:
Nicholas J. Kain 2015-02-18 05:36:13 -05:00
parent 99ce918a31
commit 69cf41f1b1
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ndhc.c
View File

@ -263,14 +263,13 @@ static void fail_if_state_dir_dne(void)
suicide("state_dir path '%s' does not specify a directory", state_dir); suicide("state_dir path '%s' does not specify a directory", state_dir);
} }
#define NDHC_NUM_EP_FDS 7
static void do_ndhc_work(void) static void do_ndhc_work(void)
{ {
static bool rfkill_set; // Is the rfkill switch set? static bool rfkill_set; // Is the rfkill switch set?
static bool rfkill_nl_state_changed; // iface state changed during rfkill static bool rfkill_nl_state_changed; // iface state changed during rfkill
static int rfkill_nl_state; // current iface state during rfkill static int rfkill_nl_state; // current iface state during rfkill
struct dhcpmsg dhcp_packet; struct dhcpmsg dhcp_packet;
struct epoll_event events[NDHC_NUM_EP_FDS]; struct epoll_event events[1];
long long nowts; long long nowts;
int timeout; int timeout;