emo/ndhc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Quit using malloc entirely in ifchd and reduce buffer copies.

Browse Source 
This change also modifies the ndhc/ifchd wire protocol slightly.  The
new protocol doesn't overload the ':' character as a key:value separator
and a statement separator.  Instead ';' is now used as a statement separator.
The new format allows for more robust error-checking and reporting, and it
greatly simplifies the parser.  Old versions of ndhc/ifchd will not work
properly with ones compiled after this commit.

The 'domain' and 'search' keywords in resolv.conf updates are now used
more precisely.  The first domain in an update is the 'domain', and the
subsequent 5 domains are 'search' domains.

There are also supporting cleanups that pass struct ifchd_client pointers
to functions instead of passing index values.

This commit is large, but it cannot really be broken up into smaller
chunks since the changes are dependent on each other.
This commit is contained in:
Nicholas J. Kain
2012-07-20 17:31:15 -04:00
parent a60a5fddb1
commit f9c2059d37
5 changed files with 192 additions and 259 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
ifchd/linux.h
View File

@@ -1,6 +1,6 @@
/* linux.h - ifchd Linux-specific functions include
*
* Copyright (c) 2004-2010 Nicholas J. Kain <njkain at gmail dot com>
* Copyright (c) 2004-2012 Nicholas J. Kain <njkain at gmail dot com>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -28,15 +28,15 @@
#ifndef NJK_IFCHD_LINUX_H_
#define NJK_IFCHD_LINUX_H_
void clear_if_data(int idx);
void clear_if_data(struct ifchd_client *cl);
void initialize_if_data(void);
void add_permitted_if(char *s);
int authorized_peer(int sk, pid_t pid, uid_t uid, gid_t gid);
void perform_interface(int idx, char *str);
void perform_ip(int idx, char *str);
void perform_subnet(int idx, char *str);
void perform_router(int idx, char *str);
void perform_mtu(int idx, char *str);
void perform_broadcast(int idx, char *str);
void perform_interface(struct ifchd_client *cl, char *str);
void perform_ip(struct ifchd_client *cl, char *str);
void perform_subnet(struct ifchd_client *cl, char *str);
void perform_router(struct ifchd_client *cl, char *str);
void perform_mtu(struct ifchd_client *cl, char *str);
void perform_broadcast(struct ifchd_client *cl, char *str);
#endif