emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: make rcfile duplicate fields check more efficient

Browse Source 
Jeeze, there was no need to employ *both* strchr() and
strrchr() when ensuring fields hadn't been duplicated.

So let's avoid one of those function calls completely.

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2018-06-12 00:00:00 -05:00 committed by Craig Small
parent 949a3c9c2e
commit 291d98ee50
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
top/top.c
View File

@ -3742,7 +3742,7 @@ static const char *config_file (FILE *fp, const char *name, float *delay) {
#endif
// ensure there's been no manual alteration of fieldscur
for (n = 0 ; n < EU_MAXPFLGS; n++) {
if (strchr(w->rc.fieldscur, w->rc.fieldscur[n]) != strrchr(w->rc.fieldscur, w->rc.fieldscur[n]))
if (&w->rc.fieldscur[n] != strrchr(w->rc.fieldscur, w->rc.fieldscur[n]))
return p;
}
// be tolerant of missing release 3.3.10 graph modes additions