emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

sysctl: warn when separators are repeated

Browse Source 
For some reason sysctl earlier allowed quite strange separators.

% sysctl kernel./.pty.nr
kernel./.pty.nr = 6
% sysctl kernel///pty//////////nr
kernel...pty..........nr = 6

This commit does not disallow that sort of constructs, but will warn
about them. In future disallowing these might be reasonable thing to
do.

% sysctl kernel./.pty.nr
sysctl: separators should not be repeated: ./.pty.nr
kernel./.pty.nr = 6

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2011-10-12 23:21:34 +02:00
parent 9f89e336c3
commit 8795154eac
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sysctl.c
View File

@ -63,11 +63,16 @@ static char *pattern;
static int pattern_match(const char *string, const char *pattern);
static void slashdot(char *restrict p, char old, char new){
int warned = 1;
p = strpbrk(p,"/.");
if(!p) return; /* nothing -- can't be, but oh well */
if(*p==new) return; /* already in desired format */
while(p){
char c = *p;
if((*(p+1) == '/' || *(p+1) == '.') && warned) {
warnx(_("separators should not be repeated: %s"), p);
warned = 0;
}
if(c==old) *p=new;
if(c==new) *p=old;
p = strpbrk(p+1,"/.");