emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pgrep: fix potential null derefences [smatch scan]

Browse Source 
pgrep.c:137 split_list(19) error: potential null derefence 'list'.
pgrep.c:540 select_procs(106) error: potential null derefence 'list'.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2012-02-05 21:10:53 +01:00
parent 1689e769e6
commit b2ebca4a60
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pgrep.c
View File

@ -134,7 +134,7 @@ static struct el *split_list (const char *restrict str, int (*convert)(const cha
if (sep_pos)
*sep_pos = 0;
// Use ++i instead of i++ because slot zero is a count
if (!convert (ptr, &list[++i]))
if (list && !convert (ptr, &list[++i]))
exit (EXIT_USAGE);
if (sep_pos)
ptr = sep_pos + 1;
@ -535,12 +535,14 @@ static struct el * select_procs (int *num)
size = size * 5 / 4 + 4;
list = xrealloc(list, size * sizeof *list);
}
if (opt_long || opt_echo) {
if (list && (opt_long || opt_echo)) {
char buff[5096]; // FIXME
list[matches].num = task.XXXID;
list[matches++].str = xstrdup (cmd);
} else {
} else if (list) {
list[matches++].num = task.XXXID;
} else {
xerrx(EXIT_FAILURE, _("internal error"));
}
}