sysctl: do not report set key in case close_stream
fails
As we're using buffered I/O when writing kernel parameters, write errors may get delayed until we close the `FILE` stream. As we are currently outputting the key that is to be set disregarding the return value of `close_stream`, we may end up in a situation where we report error and success: $ sysctl kernel.printk_ratelimit=100000000000000 sysctl: setting key "kernel.printk_ratelimit": error code 22 kernel.printk_ratelimit = 100000000000000 Fix the issue by only outputting the updated value in case `close_stream` does not report an error. Signed-off-by: Patrick Steinhardt <ps@pks.im>
This commit is contained in:
parent
3eb4b5375f
commit
da82fe49b1
2
sysctl.c
2
sysctl.c
@ -465,7 +465,7 @@ static int WriteSetting(const char *setting)
|
||||
rc = 0;
|
||||
if (close_stream(fp) != 0)
|
||||
xwarn(_("setting key \"%s\""), outname);
|
||||
if (rc == 0 && !Quiet) {
|
||||
else if (rc == 0 && !Quiet) {
|
||||
if (NameOnly) {
|
||||
fprintf(stdout, "%s\n", outname);
|
||||
} else {
|
||||
|
Loading…
x
Reference in New Issue
Block a user