Jim Warner e6a78f2745 top: swat bug impacting 'idle' mode & 'user' filtering
When Other filtering was introduced the nature of what
constituted a displayed row changed. No longer would a
task_show() call guarantee that another line is shown.
Rather, a non-empty string must have also been tested.

Unfortunately, when any task window was being filtered
for 'idle' mode or a particular 'user', the proc index
was incremented twice due to the perils of copy/paste.
Combining such an index increment with the new test of
task_show results works fine if filtering is inactive.

This was a particularly insidious bug which meant that
an adjacent task would be skipped whenever the current
task met 'idle' and/or 'user' filter criteria, and was
not otherwise excluded due to 'Other' filter criteria.

And, since it was the very next task that was ignored,
the bug was very susceptible to a window's sort order.
This could be illustrated when filtering on some user,
while sorting on PID. Then, toggling Forest View could
make otherwise unseen tasks appear and then disappear.

User workarounds are possible via interactive commands
trading the 'i' and 'u'/'U' provisions for the 'o'/'O'
other filtering capability thus avoiding an extra i++.
But that is certainly less than ideal and doesn't help
the 3.3.7 and 3.3.8 distorted command line provisions.

( this little buggie may end up costing me my pocket )
( protector, my coding badge & maybe even my cubicle )

Reference(s):
http://www.freelists.org/post/procps/Idle-elides-nonidle-processes
. bug originated with 'Other' filtering
commit 5edc6fb3174f1fd02bbfca61ec6d8a3a2e12f71c

Signed-off-by: Jim Warner <james.warner@comcast.net>
2013-09-29 11:51:39 +10:00
2013-09-11 21:57:10 +10:00
2013-07-31 21:54:53 +10:00
2012-12-24 10:05:24 +11:00
2012-03-04 08:04:24 +11:00
2013-09-09 16:54:00 +02:00
2012-04-16 12:55:53 +02:00
2013-04-18 13:59:44 -04:00
2013-05-26 08:03:01 +10:00
2012-09-27 22:08:04 +10:00
2013-05-22 18:22:37 -04:00
2012-04-16 12:55:53 +02:00
2012-03-03 18:28:52 +11:00
2013-04-18 13:59:44 -04:00
2012-04-16 12:55:53 +02:00
2012-04-16 12:55:53 +02:00
w.1
2013-07-19 14:50:02 +02:00
2012-04-16 12:55:53 +02:00
2013-08-25 17:43:20 +10:00

COMPATIBILITY

    This code is intended for use with Linux 2.6.xx, 3.x and
    hopefully all future kernels.

INSTALLATION

    If you are using git version of the project you need extra step.

    ./autogen.sh

    After that, and everyone using .tar.xz version of procps-ng, can
    do normal build.  Read './configure --help' to select options for
    your needs.

    ./configure
    make
    make install

    If you have DejaGNU installed you can run optional test suite.

    make check

HOW TO CONTRIBUTE

    See Documentation/BUGS file.

PACKAGING

    If you are a downstream maintainer (packager) for a Linux
    distribution, please avoid causing troubles.  This section
    applies to you.

    Avoid maintaining distribution specific patches.  Send your
    patches to upstream, where they are at least reviewed, if not
    included.

    Please forward bug reports. If your bug database is public and
    busy enough to bother with, please make this known.  Follow
    Debian's lead in making the bug database easy to comment on via
    email without need for an account.

    For normal packages, ensure that you do not add debugging flags
    to the CFLAGS variable.

UPSTREAM & BUG REPORTS

    procps-ng <procps@freelists.org>
Description
Command line and full screen utilities for browsing procfs, a "pseudo" file system dynamically generated by Linux to provide information about the status of entries in its process table.
Readme 15 MiB
Languages
C 97.2%
Makefile 1%
Shell 0.9%
M4 0.9%