Jim Warner
fa21a6ca81
top: correct loss of keystrokes paste capability
When top introduced true line input editing, the ability to paste keystrokes was lost. This remains a necessary evil so that top has an opportunity to translate cursor motion keystrokes into terminfo escapes during line input. Motion keys themselves, of course, can never be pasted. If pasting ever became more important than input editing, then native termios support should have been available via a define called TERMIOS_ONLY. But a recent commit, eliminating what was thought to be obsolete logic, rendered the alternate linein() function virtually useless. Similar to top-3.2.8, when native termios input is functional, these abberations can be experienced: . cursor motion keys will appear as escapes . excessive input can cause line wraps . ^Z during i/p is not be honored until <Enter> . SIGWINCH during i/p corrupts screen temporarily In hindsight, it now seems that the ability to paste keystrokes may indeed outweigh any shortcomings of native termios support. This is especially true if one is preparing to search ('L') for some lengthy process command line contined in the clipboard. Thus, this patch fixes the alternate linein() function and changes TERMIOS_ONLY to TERMIO_PROXY so that top now defaults to using native termios input. In turn, that will restore the paste keystrokes capability. Reference(s): commit: 045538e01b4588e33bacc1ac57abc799b6d24d7b Reported by: sergio <mailbox@sergio.spb.ru> Bug-Debian: http://bugs.debian.org/663334 Signed-off-by: Jim Warner <james.warner@comcast.net>
…
…
…
…
…
COMPATIBILITY This code is intended for use with Linux 2.6.xx, 3.x and hopefully all future kernels. INSTALLATION If you are using git version of the project you need extra step. ./autogen.sh After that, and everyone using .tar.xz version of procps-ng, can do normal build. Read './configure --help' to select options for your needs. ./configure make make install If you have DejaGNU installed you can run optional test suite. make check HOW TO CONTRIBUTE See Documentation/BUGS file. PACKAGING If you are a downstream maintainer (packager) for a Linux distribution, please avoid causing troubles. This section applies to you. Avoid maintaining distribution specific patches. Send your patches to upstream, where they are at least reviewed, if not included. Please forward bug reports. If your bug database is public and busy enough to bother with, please make this known. Follow Debian's lead in making the bug database easy to comment on via email without need for an account. For normal packages, ensure that you do not add debugging flags to the CFLAGS variable. UPSTREAM & BUG REPORTS procps-ng <procps@freelists.org>
Description
Command line and full screen utilities for browsing procfs, a "pseudo" file system dynamically generated by Linux to provide information about the status of entries in its process table.
Languages
C
97.2%
Makefile
1%
Shell
0.9%
M4
0.9%