* src/chsh.c: Even for root, warn if an invalid shell is

specified.
This commit is contained in:
nekral-guest 2010-03-18 23:21:00 +00:00
parent 5204a15f95
commit 5e38d92a95
2 changed files with 13 additions and 1 deletions

View File

@ -1,3 +1,8 @@
2010-03-18 Nicolas François <nicolas.francois@centraliens.net>
* src/chsh.c: Even for root, warn if an invalid shell is
specified.
2010-03-18 Nicolas François <nicolas.francois@centraliens.net>
* man/limits.5.xml: Document the selection of the limits when

View File

@ -535,10 +535,17 @@ int main (int argc, char **argv)
if ( !amroot
&& ( is_restricted_shell (loginsh)
|| (access (loginsh, X_OK) != 0))) {
fprintf (stderr, _("%s: %s is an invalid shell.\n"), Prog, loginsh);
fprintf (stderr, _("%s: %s is an invalid shell\n"), Prog, loginsh);
fail_exit (1);
}
/* Even for root, warn if an invalid shell is specified. */
if (access (loginsh, F_OK) != 0) {
fprintf (stderr, _("%s: Warning: %s does not exist\n"), Prog, loginsh);
} else if (access (loginsh, X_OK) != 0) {
fprintf (stderr, _("%s: Warning: %s is not executable\n"), Prog, loginsh);
}
update_shell (user, loginsh);
SYSLOG ((LOG_INFO, "changed user '%s' shell to '%s'", user, loginsh));