emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

su.c: s/doshell/do_interactive_shell/

Browse Source 
Mechanical rename distinguishing this variable from intended changes
supporting executing commands without using an interpretive shell
(i.e. no '/bin/sh -c').
This commit is contained in:
Vito Caputo 2020-05-09 17:43:14 -07:00 committed by Serge Hallyn
parent dc732e7734
commit 6f38f43fdd
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/su.c
View File

@ -90,7 +90,7 @@ static bool caller_on_console = false;
static /*@only@*/char *caller_pass;
#endif
#endif /* !USE_PAM */
static bool doshell = false;
static bool do_interactive_shell = false;
static bool fakelogin = false;
static /*@observer@*/const char *shellstr;
static /*@null@*/char *command = NULL;
@ -327,11 +327,11 @@ static void prepare_pam_close_session (void)
if ( (sigaddset (&ourset, SIGTERM) != 0)
|| (sigaddset (&ourset, SIGALRM) != 0)
|| (sigaction (SIGTERM, &action, NULL) != 0)
|| ( !doshell /* handle SIGINT (Ctrl-C), SIGQUIT
* (Ctrl-\), and SIGTSTP (Ctrl-Z)
* since the child will not control
* the tty.
*/
|| (!do_interactive_shell /* handle SIGINT (Ctrl-C), SIGQUIT
* (Ctrl-\), and SIGTSTP (Ctrl-Z)
* since the child will not control
* the tty.
*/
&& ( (sigaddset (&ourset, SIGINT) != 0)
|| (sigaddset (&ourset, SIGQUIT) != 0)
|| (sigaddset (&ourset, SIGTSTP) != 0)
@ -866,9 +866,9 @@ static void process_flags (int argc, char **argv)
optidx++;
}
doshell = (argc == optidx); /* any arguments remaining? */
do_interactive_shell = (argc == optidx); /* any arguments remaining? */
if (NULL != command) {
doshell = false;
do_interactive_shell = false;
}
}
@ -1144,7 +1144,7 @@ int main (int argc, char **argv)
set_environment (pw);
if (!doshell) {
if (!do_interactive_shell) {
/* There is no need for a controlling terminal.
* This avoids the callee to inject commands on
* the caller's tty. */
@ -1212,7 +1212,7 @@ int main (int argc, char **argv)
cp = Basename (shellstr);
}
if (!doshell) {
if (!do_interactive_shell) {
int err;
/* Position argv to the remaining arguments */
argv += optidx;