emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* Fix typo in comment.

Browse Source 
* Move comment regarding FIRST_MEMBER_IS_ADMIN to
   where it belongs.
 * Indicate the end of the #ifdef FIRST_MEMBER_IS_ADMIN
   section.
This commit is contained in:
nekral-guest 2008-02-26 18:59:28 +00:00
parent 4160d8c1fb
commit db479122f3
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2008-02-26 Nicolas François <nicolas.francois@centraliens.net>
* src/gpasswd.c: Fix typo in comment.
* src/gpasswd.c: Move comment regarding FIRST_MEMBER_IS_ADMIN to
where it belongs.
* src/gpasswd.c: Indicate the end of the #ifdef FIRST_MEMBER_IS_ADMIN
section.
2008-02-25 Nicolas François <nicolas.francois@centraliens.net>
* man/po/Makefile.in.in: Use --previous when merging PO files of

14
src/gpasswd.c
View File

@ -423,12 +423,17 @@ static void check_perms (const struct group *gr)
#ifdef FIRST_MEMBER_IS_ADMIN
/*
* The policy here for changing a group is that 1) you must bes root
* The policy here for changing a group is that 1) you must be root
* or 2) you must be the first listed member of the group. The
* first listed member of a group can do anything to that group that
* the root user can. The rationale for this hack is that the FIRST
* user is probably the most important user in this entire group.
*/
/*
* This feature enabled by default could be a security problem when
* installed on existing systems where the first group member might
* be just a normal user. --marekm
*/
if (!amroot) {
if (gr->gr_mem[0] == (char *) 0) {
#ifdef WITH_AUDIT
@ -446,12 +451,7 @@ static void check_perms (const struct group *gr)
failure ();
}
}
#else
/*
* This feature enabled by default could be a security problem when
* installed on existing systems where the first group member might
* be just a normal user. --marekm
*/
#else /* ! FIRST_MEMBER_IS_ADMIN */
if (!amroot) {
#ifdef WITH_AUDIT
audit_logger (AUDIT_USER_CHAUTHTOK, Prog,