emo/shadow
1
0 Fork 0
Code Issues Pull Requests Packages Releases Activity
2,997 Commits 1 Branch 1 Tag
2eaea70111f65b16d55998386e4ceb4273c19eb4
Commit Graph
4 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Eggert ea3d49506f Prefer strcpy(3) to strlcpy(3) when either works 
* lib/gshadow.c (sgetsgent): Use strcpy(3) not strlcpy(3),
since the string is known to fit.

Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
 2023-03-28 13:00:38 +02:00
Paul Eggert a926a26f0c Fix change_field() buffer underrun 
* lib/fields.c (change_field): Don't point
before array start; that has undefined behavior.

Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
 2023-03-28 13:00:38 +02:00
Paul Eggert 690ca8c238 Omit unneeded test in change_field() 
* fields.c (change_field): Omit unnecessary test.

Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
 2023-03-28 13:00:38 +02:00
Paul Eggert 5686d9162e Simplify change_field() by using strcpy 
* lib/fields.c (change_field): Since we know the string fits,
use strcpy(3) rather than strlcpy(3).

Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
 2023-03-28 13:00:38 +02:00