nekral-guest
496002abc9
* lib/Makefile.am, lib/get_pid.c, lib/getulong.c: Added get_pid()
...
and getulong().
2009-04-24 23:28:15 +00:00
nekral-guest
e8dd48ac09
* lib/getlong.c: Do not check for NULL string but empty string.
2009-04-24 23:27:12 +00:00
nekral-guest
08b4253001
* lib/groupio.c: Updated splint annotations.
...
* lib/groupio.c: Added assert to help splint.
2009-04-24 23:26:31 +00:00
nekral-guest
1a87c69854
* src/useradd.c: Check assumptions on snprintf().
...
* src/useradd.c: Replace peror by an strerror and avoid an
intermediate buffer.
* src/useradd.c: Save errno between the failure and the report by
perror/strerror.
* src/useradd.c: Prefer xmalloc to malloc.
2009-04-24 23:23:51 +00:00
nekral-guest
861773bf77
* src/lastlog.c: Remove function calls from within assert().
2009-04-24 23:05:29 +00:00
nekral-guest
01e88bda16
* libmisc/obscure.c: Change some int to size_t.
2009-04-24 23:04:27 +00:00
nekral-guest
5e45ac1688
* libmisc/console.c: Use a less disturbing construct for splint.
2009-04-24 23:03:14 +00:00
nekral-guest
10396f9536
* libmisc/limits.c: Parse the limits, umask, nice, maxlogin, file
...
limit with getlog() / getulong(). This also means, in case of
non-PAM enabled systems, that the umask specified on the GECOS
fields should start with a 0 if specified in octal. (it used to be
force to octal). Do the appropriate cast and range checking.
2009-04-24 22:56:42 +00:00
nekral-guest
0c571784a3
* libmisc/salt.c: In case gettimeofday() fails, get some entropy
...
from the PID.
2009-04-24 22:49:20 +00:00
nekral-guest
7646230de2
* libmisc/setupenv.c: Prefer snprintf to sprintf, even if a small
...
context indicates no issues.
* libmisc/setupenv.c: Avoid implicit conversion of pointers to
booleans.
2009-04-24 22:46:06 +00:00
nekral-guest
42e72c418d
* libmisc/loginprompt.c: Prefer snprintf to sprintf, even if a
...
small context indicates no issues.
2009-04-24 22:27:58 +00:00
nekral-guest
37eec13774
* src/faillog.c: Remove function calls from within assert().
2009-04-24 22:27:09 +00:00
nekral-guest
f28f5f3af4
* libmisc/mail.c: Ignore the return value of puts().
...
* libmisc/mail.c: Prefer snprintf to sprintf, even if a small
context indicates no issues.
2009-04-24 22:22:57 +00:00
nekral-guest
6e357e14fc
* lib/commonio.c, lib/commonio.h, lib/groupio.c, lib/groupio.h,
...
lib/pwio.c, lib/pwio.h, lib/shadowio.c, lib/shadowio.h: Added
splint annotations. The *_locate() and *_next() functions
currently return an observer. As the structure are often modified
by the caller, it could maybe be changed to exposed later. (and
non-const).
2009-04-23 21:19:02 +00:00
nekral-guest
d0d01ffb00
* lib/pwauth.c: Use a boolean for wipe_clear_pass and use_skey.
...
* lib/pwauth.c: Added splint annotations.
* lib/pwauth.c: Added brackets and parenthesis.
* lib/pwauth.c: Avoid assignments in comparisons.
* lib/pwauth.c: Avoid implicit conversion of pointers or
characters to booleans.
2009-04-23 20:46:01 +00:00
nekral-guest
916977c5bb
* src/groupmod.c: Cast ID to ulongs and use ulong formats for IDs.
2009-04-23 20:39:29 +00:00
nekral-guest
af8ff8c1ca
* src/newgrp.c: Added splint annotations.
...
* src/newgrp.c: audit_buf is only used in newgrp. Make it static.
* src/newgrp.c: Ignore the return value of fputs().
* src/newgrp.c: Use exit(EXIT_FAILURE) instead of exit(1).
2009-04-23 20:37:00 +00:00
nekral-guest
3d2f164dca
* libmisc/pwdcheck.c (passwd_check): The progname is not used.
...
* libmisc/pwdcheck.c: Ignore the return value of sleep().
* libmisc/pwdcheck.c: Use exit(EXIT_FAILURE) instead of exit(1).
2009-04-23 20:17:02 +00:00
nekral-guest
c357e94283
* libmisc/setupenv.c: Avoid assignments in comparisons.
...
* libmisc/setupenv.c: Added brackets and parenthesis.
* libmisc/setupenv.c: Ignore the return value of fclose (file
opened read-only)
* libmisc/setupenv.c: Ignore the return value of puts().
* libmisc/setupenv.c:Avoid implicit conversion of pointers to
booleans.
2009-04-23 17:45:42 +00:00
nekral-guest
7f165aab7f
* libmisc/find_new_gid.c, libmisc/find_new_uid.c,
...
libmisc/isexpired.c, src/groupadd.c, lib/pwauth.h, lib/groupmem.c,
lib/shadowmem.c, lib/pwmem.c, lib/prototypes.h: Added splint
annotations.
2009-04-23 17:43:27 +00:00
nekral-guest
956d68c870
* libmisc/loginprompt.c: Use exit(EXIT_FAILURE) instead of
...
exit(1).
* libmisc/loginprompt.c: Avoid implicit conversion of pointers to
booleans.
* libmisc/loginprompt.c: Ignore return value of putc().
2009-04-23 17:34:46 +00:00
nekral-guest
61ebff6d97
* libmisc/env.c, libmisc/age.c: Added splint annotations.
...
* libmisc/age.c: Added brackets and parenthesis.
* libmisc/age.c: Ignore the return value of fclose (file opened
read-only)
* libmisc/age.c: Ignore puts() return value.
* libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1).
* libmisc/age.c: Avoid assignments in comparisons.
2009-04-23 17:33:21 +00:00
nekral-guest
0b1397b33b
* lib/fputsx.c, lib/gshadow.c, lib/commonio.h: Added splint
...
annotations.
2009-04-23 11:54:30 +00:00
nekral-guest
a121b9b659
* lib/gshadow.c, lib/commonio.h: Added splint annotations.
2009-04-23 11:53:55 +00:00
nekral-guest
43033b65ad
* lib/getdef.c: Added splint annotations.
...
* lib/getdef.c: Ignore fputs() return value.
* lib/getdef.c: Use EXIT_FAILURE / EXIT_SUCCESS for exit()
2009-04-23 11:46:46 +00:00
nekral-guest
0c6159650d
* lib/get_gid.c: gidstr should not be NULL, but the check was
...
meant to make sure it is not empty.
* lib/get_uid.c: Likewise.
2009-04-23 11:46:06 +00:00
nekral-guest
7b562d96b3
* src/faillog.c: Added splint annotations.
...
* src/faillog.c: Cast ID to ulongs and use ulong formats for IDs.
* src/faillog.c: Ignore fflush() return value.
* src/faillog.c: Added parenthesis.
2009-04-23 11:23:53 +00:00
nekral-guest
988ec76cf8
* src/grpck.c: Ignore puts return value.
...
* src/grpck.c: Avoid variable format string.
2009-04-23 11:21:57 +00:00
nekral-guest
87e15d7b82
* src/lastlog.c: Use EXIT_FAILURE / EXIT_SUCCESS for exit()
...
* src/lastlog.c: Added splint annotations.
* src/lastlog.c: Avoid global pwent.
* src/lastlog.c: Cast ID to ulongs and use ulong formats for IDs.
* src/lastlog.c: Avoid assignment in comparisons.
* src/lastlog.c: Ignore fclose() return value since the file is
only opened for reading.
2009-04-23 11:21:01 +00:00
nekral-guest
77c1b2a369
* src/newgrp.c: Added assertion to guide splint (and me).
2009-04-23 11:17:22 +00:00
nekral-guest
b0db85bc04
* libmisc/find_new_gid.c: Use booleans instead of char fo
...
used_gids.
* libmisc/find_new_gid.c: Use getdef_ulong and cast to git_t to
get GID values.
* libmisc/find_new_gid.c: Use UL as a prefix for ulong values.
* libmisc/find_new_uid.c: Likewise.
2009-04-23 11:16:38 +00:00
nekral-guest
cbd90eed74
* libmisc/yesno.c: Ignore the return value of puts.
2009-04-23 11:14:56 +00:00
nekral-guest
35f0a2e951
* libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1).
...
* libmisc/age.c: The return value of execl() is not used.
2009-04-23 11:14:18 +00:00
nekral-guest
614c79defc
* libmisc/xgetXXbyYY.c, libmisc/myname.c, libmisc/getgr_nam_gid.c,
...
libmisc/salt.c, libmisc/list.c, libmisc/cleanup.c, src/login.c,
lib/getdef.h, lib/groupio.c, lib/getlong.c, lib/gshadow_.h,
lib/sgroupio.c, lib/shadowio.c, lib/pwio.c, lib/commonio.h,
lib/fputsx.c, lib/prototypes.h: Added splint annotations.
* lib/groupio.c: Avoid implicit conversion of pointers to
booleans.
* lib/groupio.c: Free allocated buffers in case of failure.
2009-04-23 09:57:03 +00:00
nekral-guest
fef6f9379a
Fix typo.
2009-04-22 21:33:09 +00:00
nekral-guest
fe29344b33
* lib/defines.h: Added splint definitions to replace <locale.h>
2009-04-22 21:22:32 +00:00
nekral-guest
2c0f3ef707
* libmisc/utmp.c, libmisc/age.c, libmisc/shell.c, lib/groupio.c,
...
lib/groupio.h, lib/sgroupio.c, lib/sgroupio.h, lib/shadowio.c,
lib/pwio.c, lib/commonio.c, lib/shadowio.h, lib/pwio.h,
lib/commonio.h, lib/prototypes.h: Added splint annotations.
2009-04-22 21:21:14 +00:00
nekral-guest
aebddca35d
* libmisc/utmp.c: Added splint annotations.
2009-04-22 21:07:33 +00:00
nekral-guest
620ee81b7e
* libmisc/utmp.c: Only set ut_time and ut_tv if gettimeofday()
...
succeeds.
2009-04-22 21:06:13 +00:00
nekral-guest
e76a5df932
* libmisc/utmp.c: Fix the check for empty host in prepare_utmp()
...
and prepare_utmpx().
2009-04-22 21:04:16 +00:00
nekral-guest
7fb1063ccd
* libmisc/utmp.c: The ut argument of prepare_utmp() might be NULL.
...
ut_id needs to be forged in that case.
2009-04-22 21:02:46 +00:00
nekral-guest
811288df64
* libmisc/utmp.c: Removed old documentation of setutmp().
2009-04-22 21:00:18 +00:00
nekral-guest
31906409c8
* libmisc/utmp.c: Use xmalloc() rather than malloc().
2009-04-22 20:59:23 +00:00
nekral-guest
b05783da32
* libmisc/utmp.c: The name returned by ttyame() needs to be copied
...
locally.
2009-04-22 20:57:29 +00:00
nekral-guest
54302f6006
* src/login.c: Added splint annotations.
2009-04-22 20:53:15 +00:00
nekral-guest
2a32262725
* src/login.c: Added assert()s for NULL (or ! NULL) username, and
...
pwd. This helps splint.
2009-04-22 20:51:13 +00:00
nekral-guest
e35a7fbd89
Re-indent.
2009-04-22 20:48:42 +00:00
nekral-guest
c55311aa6d
* src/login.c: After login_prompt(), do not check for unset
...
username, but for empty username.
2009-04-22 20:46:49 +00:00
nekral-guest
3704745289
* lib/defines.h: Define USER_NAME_MAX_LENGTH, based on utmp and
...
default to 32.
* libmisc/chkname.c: Use USER_NAME_MAX_LENGTH.
* src/login.c: Use USER_NAME_MAX_LENGTH instead of the default 32.
username also needs to be bigger than USER_NAME_MAX_LENGTH because
it has to be nul-terminated.
2009-04-22 20:42:48 +00:00
nekral-guest
eae8b63d4f
* src/login.c: Use xmalloc() instead of malloc().
2009-04-22 20:21:17 +00:00