emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix suspicius code for allocating a sockaddr_un to a sockaddr ptr

Browse Source 
Remarked on by Coverity Scan.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson 2019-11-13 08:14:48 +01:00
parent e1f9a1a566
commit 0555e0989f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/socket.c
View File

@ -77,10 +77,13 @@ int socket_register(int sd, struct addrinfo *ai, void (*cb)(int, void *), void *
goto err; goto err;
if (ai) { if (ai) {
entry->ai.ai_addr = calloc(1, sizeof(struct sockaddr_un)); struct sockaddr_un *sun;
if (!entry->ai.ai_addr)
sun = calloc(1, sizeof(struct sockaddr_un));
if (!sun)
goto eaddr; goto eaddr;
entry->ai.ai_addr = (struct sockaddr *)sun;
entry->ai = *ai; entry->ai = *ai;
*entry->ai.ai_addr = *ai->ai_addr; *entry->ai.ai_addr = *ai->ai_addr;
} }