emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ulf Härnhammar <Ulf.Harnhammar.9485@student.uu.se>

Browse Source 
Added boundary check for fscanf() in InitKsyms() and CheckMapVersion()
to prevent an unintended crash when reading an incorrect System.map.

Hello,

I have discovered a potential crash bug in sysklogd. The klogd daemon
doesn't handle really malformed System.map files very well. It has
two fscanf() calls with "%s"format strings that stores to char
sym[512] arrays. This causes a crash if the string field in the
file is longer than that.

Despite being a buffer overflow, this is not a security problem, as
only root can change the System.map file. Nevertheless, I think it
is worth fixing, as the Right Thing for a program should be not to
assume anything about its input and to handle various problems well.
This commit is contained in:
Joey Schulze 2004-07-16 06:48:27 +00:00
parent 3bd7b6cfb1
commit 1836e84e94
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ksym.c
View File

@ -109,6 +109,11 @@
* Thu Apr 29 18:07:16 CEST 2004: Dmitry Levin <ldv@altlinux.org> * Thu Apr 29 18:07:16 CEST 2004: Dmitry Levin <ldv@altlinux.org>
* Close file descriptor in FindSymbolFile() in order not to leak * Close file descriptor in FindSymbolFile() in order not to leak
* file descriptors. * file descriptors.
*
* Fri Jul 16 08:32:49 CEST 2004: Ulf Härnhammar <Ulf.Harnhammar.9485@student.uu.se>
* Added boundary check for fscanf() in InitKsyms() and
* CheckMapVersion() to prevent an unintended crash when reading
* an incorrect System.map.
*/ */
@ -240,7 +245,7 @@ extern int InitKsyms(mapfile)
*/ */
while ( !feof(sym_file) ) while ( !feof(sym_file) )
{ {
if ( fscanf(sym_file, "%lx %c %s\n", &address, &type, sym) if ( fscanf(sym_file, "%lx %c %511s\n", &address, &type, sym)
!= 3 ) != 3 )
{ {
Syslog(LOG_ERR, "Error in symbol table input (#1)."); Syslog(LOG_ERR, "Error in symbol table input (#1).");
@ -539,7 +544,7 @@ static int CheckMapVersion(fname)
version = 0; version = 0;
while ( !feof(sym_file) && (version == 0) ) while ( !feof(sym_file) && (version == 0) )
{ {
if ( fscanf(sym_file, "%lx %c %s\n", &address, \ if ( fscanf(sym_file, "%lx %c %511s\n", &address, \
&type, sym) != 3 ) &type, sym) != 3 )
{ {
Syslog(LOG_ERR, "Error in symbol table input (#2)."); Syslog(LOG_ERR, "Error in symbol table input (#2).");