emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Moved the installation of the signal handler up a little bit so it

Browse Source 
guaranteed to be available when the child is forked, hence, fixing a
race condition.  This used to create problems with UML and fast
machines.  Thanks to Jon Burgess <Jon_Burgess@eur.3com.com>
This commit is contained in:
Joey Schulze 2003-09-28 10:26:22 +00:00
parent deeeb65d2b
commit ae499acae2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
syslogd.c
View File

@ -441,6 +441,11 @@ static char sccsid[] = "@(#)syslogd.c 5.27 (Berkeley) 10/10/88";
* Don't return a closed fd if `-a' is called with a wrong path. * Don't return a closed fd if `-a' is called with a wrong path.
* Thanks to Bill Nottingham <notting@redhat.com> for providing * Thanks to Bill Nottingham <notting@redhat.com> for providing
* a patch. * a patch.
* Thu Aep 13 05:08:10 2001: Jon Burgess <Jon_Burgess@eur.3com.com>
* Moved the installation of the signal handler up a little bit
* so it guaranteed to be available when the child is forked,
* hence, fixing a race condition. This used to create problems
* with UML and fast machines.
*/ */
@ -890,11 +895,11 @@ int main(argc, argv)
dprintf("Checking pidfile.\n"); dprintf("Checking pidfile.\n");
if (!check_pid(PidFile)) if (!check_pid(PidFile))
{ {
signal (SIGTERM, doexit);
if (fork()) { if (fork()) {
/* /*
* Parent process * Parent process
*/ */
signal (SIGTERM, doexit);
sleep(300); sleep(300);
/* /*
* Not reached unless something major went wrong. 5 * Not reached unless something major went wrong. 5
@ -1815,7 +1820,7 @@ void fprintlog(f, from, flags, msg)
v->iov_len = 1; v->iov_len = 1;
} }
again: again:
/* f->f_file == -1 is an indicator that the we couldn't /* f->f_file == -1 is an indicator that we couldn't
open the file at startup. */ open the file at startup. */
if (f->f_file == -1) if (f->f_file == -1)
break; break;