c20c748afa
Workaround for weird automake buglet
...
The `make distcheckclean` command fails because of lingering .o files in
lib/.libs/ which it shouldn't, since both AC_CONFIG_LIBOBJ_DIR() and the
subdir-objects automake options are set.
This workaround is ugly, but works for now.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 21:21:57 +01:00
6da50d15f7
syslogd: Minor, reduce scope of local variables
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 19:59:37 +01:00
f35aa0760e
syslogd: Minor, reduce code duplication
...
Found by clang-tidy
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 19:59:21 +01:00
d94163d721
Add unit test to check syslog.conf rule option parsing
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 10:46:59 +01:00
d22f7168e0
Revert "syslogd: cfopts(): reinit strtok() so both OPT1,OPT2 are found"
...
This reverts commit d758581troglobit@gmail.com >
2020-01-19 10:30:25 +01:00
d75858100c
syslogd: cfopts(): reinit strtok() so both OPT1,OPT2 are found
...
Signed-off-by: Steffen Nurpmeso <steffen@sdaoden.eu >
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 09:32:30 +01:00
ee47b88cd2
Follow-up to 84d70e6, fix spelling
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 09:11:15 +01:00
64257d689d
Minor, cleanup/coding-style
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 09:10:58 +01:00
5fce3001ed
Simplify handling of replacement functions; strlcpy() & C:o
...
- Drop weak bindings, use simple #define in compat.h instead
- No need to #ifdef sources with HAVE_foo, configure handles this for us
- Move utimensat() declaration to compat.h from pidfile.c to be consistent
With these changes we can let libsyslog link with the replacement objs,
just like syslogd and logger does. Because even if the C-library does
*not* have strlcpy() & C:o *and* an application has a local copy of any
of these APIs, our versions are prefixed with __ in the symbol table.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-19 09:08:48 +01:00
de4c349930
Update ChangeLog for v2.1.1 bug fix release
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-17 13:34:35 +01:00
5bfe15f767
syslogd: Fix startup issue with remote sinks
...
Only reset f_fime when the filed is in normal operation, not suspended,
otherwise the INET_SUSPEND_TIME handling is broken.
Signed-off-by: Johan Askerin <johan.askerin@gmail.com >
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-17 13:20:52 +01:00
773e69ea2e
syslogd: Ignore temporary network problems when sending remote
...
When sending to a remote syslog server, configured as an IP address or
when the DNS name has already been resolved, we may get temporary error
messages like ENETUNREACH and similar from sendmsg().
Before this patch the whole filed was placed in F_FORW_SUSP, like failed
DNS resolve, which introduces a 180 sec delay before even trying again.
A better approach is to just try again with the next syslog message.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-17 13:01:29 +01:00
84d70e63fc
Drop libcompat to simplify build deps and really fix #11
...
The original idea with libcompat was to keep as few objects as
possible for linking with libsyslog. That in turn to prevent
a user of libsyslog from suddenly also getting strong binding
to symbols like strlcpy() from libsyslog, rather than their C
library of choice.
However, this caused strlcpy.c to be built as both .o and .lo
files, which in turn caused really bizarre build problems due
to bad DAG dependency.
This patch drops libcompat and instead marks all replacement APIs
as weak symbols, which a C library can override.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-16 22:17:23 +01:00
43eee3d405
Update ChangeLog and bump version for v2.1 release
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-05 13:33:02 +01:00
f33acb2521
Travis-CI: Minor fixes
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-05 13:33:02 +01:00
0af76f37ae
Revert "Travis-CI: Disable clang temporarily for Coverity Scan run"
...
This reverts commit 100d90b452
2020-01-05 13:33:02 +01:00
100d90b452
Travis-CI: Disable clang temporarily for Coverity Scan run
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-04 10:39:35 +01:00
e0411a3a56
Fix invalid format specifier for f_prevcount, found by Coverity Scan
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-03 09:51:48 +01:00
39ea566d45
Fix minor descriptor leak, found by Coverity Scan
...
It is safe to always close() the fd here.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2020-01-03 09:46:11 +01:00
f06ab73e13
Minor updates, spell checking, etc.
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-25 08:47:31 +01:00
38d0440975
Update ChangeLog with latest fixes
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-25 08:25:48 +01:00
0f7ee8d430
syslogd: Fix variable names shadowing other global or local defs.
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 22:06:26 +01:00
ff03287d5a
syslogd: Use snprintf() rather than sprintf()
...
Protects against buffer overruns.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 22:06:26 +01:00
0afdfb4911
syslogd: Handle multiple invocations of SIGHUP
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 13:25:48 +01:00
0e7c76c3f5
.github: sudo do-what-I-mean
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 13:17:13 +01:00
753d6f0cda
.github: Attempt number 1231245432432 to install packages in runner
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 11:21:37 +01:00
9c05d380f3
Use non-interactive install
...
Why isn't the runner configured to use this by default?
2019-12-16 11:18:01 +01:00
722a77857f
Split apt-get update and install in separate steps
...
Yaml isn't really suited to writing shell scripts :-/
2019-12-16 11:11:42 +01:00
ce4a3c1f0a
Run apt-get update first
2019-12-16 11:08:57 +01:00
55a12321c0
Accept any deps. to packages in runner install
2019-12-16 11:00:56 +01:00
4bbb813f1b
Install tshark in runner
2019-12-16 10:58:39 +01:00
731078325a
Dump contents of certain log files on build failure
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-16 09:35:56 +01:00
b3f016aaf1
syslogd: Minor, fix size_t format specifier %zd vs %zu
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-14 10:13:48 +01:00
0cd3bf1ee6
Relocate GitHub docs to .github/
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-14 09:48:59 +01:00
c280058e47
Disable clang-tidy check and SoundClound scan for now
2019-12-14 09:47:00 +01:00
b3694592cf
Fix action, must run autogen.sh first
2019-12-14 09:40:41 +01:00
65abc37809
Test GitHub action to build and test code
2019-12-14 09:36:03 +01:00
48bfe6edf4
syslogd: Refactor, use sigaction() instead of deprecated signal()
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-14 08:46:36 +01:00
dec90a25ab
syslogd: Set pipe fd non-blocking in timer backend
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-14 08:00:00 +01:00
2179d5a862
syslogd: Minor coding style cleanups
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-14 07:59:39 +01:00
2bbafcbd16
syslogd: Audit usage text, slim down, fix -R to -r conversion
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-10 08:34:49 +01:00
84f8e51541
man: Add Emacs nroff hinting to all man pages
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:29:59 +01:00
864ddaeb7d
man: Change formatting of log msg examples using Li instead of Cm
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:29:14 +01:00
06f669f32e
man: Try Li instead of Ql, possibly better in HTML rendition
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:24:23 +01:00
af37f47f91
man: Add more whitespace to HISTORY to make it more readable
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:20:28 +01:00
dca20067c6
man: Try Ql for inline literal display rather than Cm
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:20:03 +01:00
5efd1cffd8
build: Put all GNU autotools support files in aux/
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 18:08:07 +01:00
7abb1b9137
man: Use .Os to detail project name and version
...
Also, by convention .Dt should always be in upper case.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 17:32:46 +01:00
49d66e43a1
Revert "Travis-CI: Disable clang temporarily for Coverity Scan run"
...
This reverts commit ede638e9fd
2019-12-09 17:01:45 +01:00
c01636fa71
README: Add pointers to HTML versions of man pages
...
Signed-off-by: Joachim Nilsson <troglobit@gmail.com >
2019-12-09 17:01:02 +01:00
