emo
/
thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use an auto_ptr to remove an explicit try/catch in the cache

This commit is contained in:
Joe Thornber 2011-11-08 10:38:52 +00:00
parent 6dc6110684
commit 8859451df5
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
cache.h
View File

@ -8,6 +8,7 @@
#include <boost/optional.hpp>
#include <list>
#include <map>
#include <memory>
#include <stdexcept>
//----------------------------------------------------------------
@ -182,17 +183,11 @@ namespace base {
cache<ValueTraits>::insert(value_type const &v) {
make_space();
// FIXME: use an auto_ptr to avoid the explicit try/catch
value_entry *node = new value_entry(v);
try {
value_ptr_cmp cmp;
lookup_algo::insert_equal(&lookup_header_, &lookup_header_, node, cmp);
current_entries_++;
} catch (...) {
delete node;
throw;
}
std::auto_ptr<value_entry> node(new value_entry(v));
value_ptr_cmp cmp;
lookup_algo::insert_equal(&lookup_header_, &lookup_header_, node.get(), cmp);
node.release();
current_entries_++;
}
template <typename ValueTraits>