927ed47b58
Print explicit warning messages when ARP packets fail in arp_validate().
2011-06-02 10:41:34 -04:00
8ede75738f
When setting route, don't print an error if EEXIST is returned by the ioctl().
...
This 'error' merely means that the installed route already exists.
2011-05-31 11:55:26 -04:00
bec1d30279
Add arpreply_clear() helper.
2011-05-31 11:24:40 -04:00
96fee03a16
Use memcmp() rather than pointer type aliasing in handle_arp_response().
...
Cosmetic improvements to ARP code.
2011-05-31 11:14:50 -04:00
96f640e36c
More strictly validate ARP responses from remote servers.
2011-05-31 11:01:08 -04:00
d72b24a2fe
Theoretical correctness fix:
...
Handle EAGAIN and EWOULDBLOCK more gracefully when dealing with safe_read().
All occurrences of safe_read() should only be invoked on fds that have signaled
ready-to-read state via the epoll() mechanism, so this change should not
result in any observable difference, but it is best to be safe.
Additionally, a constant stack variable is converted to an equivalent
macro define for cleanliness.
Finally, print the error type encountered if reading data from an ARP response
fails with a read error.
2011-05-30 10:54:05 -04:00
03f0e8719e
Tidy up DESIGN. It was hopelessly out of date.
2011-05-01 21:05:39 -04:00
59beb159d3
Place the ifchange socket in /var/state/ifchange within the chroot
...
jail and change configuration instructions as well.
Change default configuration instructions to specify setting root
of the chroot jail as owned by root.root.
2011-05-01 20:43:29 -04:00
b3f9115689
Add a -V --verbose flag to enable the overly verbose list reciept logging.
...
Update interface flags only if it would provoke an actual change.
2011-04-30 07:30:07 -04:00
e96dab80fe
lseek() after ftruncate() just to be safe.
2011-04-25 01:08:03 -04:00
da193ae35a
Add support for writing lease files.
2011-04-19 16:37:43 -04:00
c7ff945be8
Shrink a delay and whitespace fix.
2011-03-31 15:28:32 -04:00
996983143e
Only query gateway hwaddr when binding a new lease. Don't bother when just
...
renewing or rebinding a lease.
2011-03-31 15:05:05 -04:00
a7db2c4bd2
Make arp code more robust and refactor it a bit.
...
Handle failure to create arp sockets more gracefully.
Add initial support for retransmitting arp requests if no reply is met after
a certain number of spurious packets.
2011-03-31 02:32:34 -04:00
f4aa2058db
Get rid of a very old blocking sleep that triggered after a DHCP NAK is
...
received.
2011-03-31 00:03:07 -04:00
a6fa236700
Massive cosmetic patch: update or add copyright headers, untabify, and
...
change all unsigned char to uint8_t.
2011-03-30 23:59:22 -04:00
147e2d0fd9
Untabify and headerize config.h.
2011-03-30 23:33:46 -04:00
b5e5685d01
Fetch the gateway hardware address after receiving a router option in a DHCP
...
lease.
Be more aggressive about closing old arp file descriptors.
Check the ARP headers to make sure that received ARP packets are addressed to
our machine. Whatever bug may have existed before doesn't exist on modern
Linux kernels, if it ever did.
Use the stored gateway hardware address to validate a restored link in the
DS_ARP_GW_CHECK state.
If an ARP message is received while we are in a state that does not expect
ARP messages, close the ARP socket and log a message.
2011-03-30 23:17:27 -04:00
e1eb41e1c0
Remove a debugging print.
2011-03-30 20:21:44 -04:00
03717e1593
If physical link state changes to UP and a lease is bound, check to see if
...
the currently assigned gateway/router still replies to ARP queries. If so,
keep the lease. If not, get a new lease.
Save the IP address of the current gateway/router.
Remove an outdated check for a buggy compiler.
Fix a typo in the previous commit that caused timeouts to be 1000x faster than
they should be.
2011-03-30 20:13:48 -04:00
de23d2241d
Improve timeout backoff. It's a capped linear backoff. RFC specifies
...
capped randomized exponential, but I don't feel like incurring the cost
when the cap is so low.
Add comments for the dhcpMessage structure members.
2011-03-30 18:58:09 -04:00
18e6f8d2c6
Remove a unnecessary debug print from add_u32_option().
2011-03-30 16:41:29 -04:00
953443f688
Untabify and headerize ifchange.[ch].
2011-03-30 16:38:53 -04:00
6265a0e973
Untabify options.[ch].
2011-03-30 16:35:23 -04:00
09613fd77a
Fold req_opts[] and list_opts[] into options[].type, and modify accessors
...
accordingly.
2011-03-30 16:34:09 -04:00
5d7bcbb2d4
Change parameters for add_option_request_list().
...
Make all unsigned char into uint8_t in options.[ch].
2011-03-30 16:05:28 -04:00
ddf9daf8e4
Do more boundary and sanity checking when adding dhcp options.
...
Simplify parameter list for ifchd_cmd().
2011-03-30 15:57:01 -04:00
0e62d46f8b
Explicitly track length in get_end_option_idx().
...
Rename get_options() to get_option_data() and end_options() to
get_end_option_idx().
2011-03-30 12:04:38 -04:00
97978711de
Isolate the dhcp_option options[] array to options.c and provide abstract
...
accessors for its data.
2011-03-30 11:36:27 -04:00
16460699fc
Use inet_ntop() in ifchange.c rather than a homebrew function.
...
Get rid of a lousy hack in ifchange.c that translated the output of ifchd_cmd()
by changing every '=' to a ':'. ifchd_cmd() is not called anywhere else, so
just make ifchd_cmd() generate the proper output.
Make buffer size accounting stricter.
2011-03-30 11:16:38 -04:00
97137ec3fc
Handle STRING options properly in fill_options and refactor a bit.
2011-03-30 10:39:11 -04:00
7c32f968c9
Perform length and type checking in ifchange.c:fill_options.c().
2011-03-30 10:13:34 -04:00
1437f520ca
Rewrite get_option(): new version fixes at least one bug, and is much easier
...
to understand and verify as correct. It also returns the length of the
extracted option.
2011-03-30 09:35:17 -04:00
f0865812d2
Kill unused function find_options() and unused struct option_set.
2011-03-30 08:21:06 -04:00
2719d12d3c
struct dhcp_option flags field is now exclusively for type, so rename it.
...
Remove unused struct dhcp_option types.
2011-03-30 08:19:08 -04:00
f28c0c7445
OPTION_LIST is unused, remove it.
2011-03-30 08:12:56 -04:00
d4171420a1
Fix sending DHCP_MAX_SIZE option.
...
Move DHCP_PARAM_REQ message types out of the options[] structure.
Make ipchange.c:translation_option() less insane.
2011-03-30 08:02:25 -04:00
811cc67e16
Move add_requests() from dhcpmsg.c to options.c. Fixes a layering violation.
...
Document an ugly-as-hell code bit in ifchange.c.
Add some debugging messages for the netlink response code.
Clean headers a bit more.
2011-03-30 07:26:42 -04:00
3c85228aaf
Add new code for creating DHCP option data, and use it in ndhc.c.
2011-03-30 07:05:00 -04:00
13d9119f3a
Remove dhcpd.h.
2011-03-30 05:55:12 -04:00
ef9d9d26df
Move some defines out of dhcpd.h.
2011-03-30 05:37:22 -04:00
6869a3ba20
Reduce log spam by removing the "adding option" print.
2011-03-30 05:33:44 -04:00
d01b104d48
Handle netlink interface-up notification for non-DS_BOUND states.
2011-03-30 05:24:16 -04:00
1ef44c1e4b
Document DHCP options in bound_if().
2011-03-30 05:23:46 -04:00
9d03795a15
Wire up the netlink socket to the epoll handler. Still need to actually
...
react to events in the processing function.
Pass the client_state structure to the netlink code explicitly rather than
making it a global variable.
2011-03-29 15:34:00 -04:00
55bc002ad6
Use netlink for getting interface mac and index in ndhc instead of ioctl.
2011-03-29 14:37:45 -04:00
a53a82bbc5
After fork(), a signalfd-created file descriptor still returns signal info
...
for the parent. Close and recreate a new signalfd after forking into the
background.
2010-12-27 10:05:43 -05:00
03d3cbfdb9
Do not treat a failure to write the pid file after backgrounding after
...
obtaining a lease as a fatal error.
2010-12-26 18:21:58 -05:00
11e71837fd
Set arp socket as nonblocking.
2010-12-26 18:19:39 -05:00
6f483045f4
Remove redundant #include.
2010-12-26 18:17:41 -05:00
