Iker Pedrosa 5d0d784197 Fix covscan BUFFER_SIZE ...

Error: BUFFER_SIZE (CWE-170): [#def6]
shadow-4.8.1/libmisc/failure.c:101: buffer_size_warning: Calling "strncpy" with a maximum size argument of 12 bytes on destination array "fl->fail_line" of size 12 bytes might leave the destination string unterminated.
   99|   	}
  100|
  101|-> 	strncpy (fl->fail_line, tty, sizeof fl->fail_line);
  102|   	(void) time (&fl->fail_time);
  103|

Error: BUFFER_SIZE (CWE-170): [#def9]
shadow-4.8.1/libmisc/log.c:103: buffer_size_warning: Calling "strncpy" with a maximum size argument of 32 bytes on destination array "newlog.ll_line" of size 32 bytes might leave the destination string unterminated.
  101|   	(void) time (&ll_time);
  102|   	newlog.ll_time = ll_time;
  103|-> 	strncpy (newlog.ll_line, line, sizeof newlog.ll_line);
  104|   #if HAVE_LL_HOST
  105|   	strncpy (newlog.ll_host, host, sizeof newlog.ll_host);

Error: BUFFER_SIZE (CWE-170): [#def10]
shadow-4.8.1/libmisc/log.c:105: buffer_size_warning: Calling "strncpy" with a maximum size argument of 256 bytes on destination array "newlog.ll_host" of size 256 bytes might leave the destination string unterminated.
  103|   	strncpy (newlog.ll_line, line, sizeof newlog.ll_line);
  104|   #if HAVE_LL_HOST
  105|-> 	strncpy (newlog.ll_host, host, sizeof newlog.ll_host);
  106|   #endif
  107|   	if (   (lseek (fd, offset, SEEK_SET) != offset)

Error: BUFFER_SIZE (CWE-170): [#def13]
shadow-4.8.1/libmisc/utmp.c:260: buffer_size_warning: Calling "strncpy" with a maximum size argument of 32 bytes on destination array "utent->ut_line" of size 32 bytes might leave the destination string unterminated.
  258|   #endif				/* HAVE_STRUCT_UTMP_UT_TYPE */
  259|   	utent->ut_pid = getpid ();
  260|-> 	strncpy (utent->ut_line, line,      sizeof (utent->ut_line));
  261|   #ifdef HAVE_STRUCT_UTMP_UT_ID
  262|   	if (NULL != ut) {

Error: BUFFER_SIZE (CWE-170): [#def14]
shadow-4.8.1/libmisc/utmp.c:266: buffer_size_warning: Calling "strncpy" with a maximum size argument of 4 bytes on destination array "utent->ut_id" of size 4 bytes might leave the destination string unterminated.
  264|   	} else {
  265|   		/* XXX - assumes /dev/tty?? */
  266|-> 		strncpy (utent->ut_id, line + 3, sizeof (utent->ut_id));
  267|   	}
  268|   #endif				/* HAVE_STRUCT_UTMP_UT_ID */

Error: BUFFER_SIZE (CWE-170): [#def15]
shadow-4.8.1/libmisc/utmp.c:273: buffer_size_warning: Calling "strncpy" with a maximum size argument of 32 bytes on destination array "utent->ut_user" of size 32 bytes might leave the destination string unterminated.
  271|   #endif				/* HAVE_STRUCT_UTMP_UT_NAME */
  272|   #ifdef HAVE_STRUCT_UTMP_UT_USER
  273|-> 	strncpy (utent->ut_user, name,      sizeof (utent->ut_user));
  274|   #endif				/* HAVE_STRUCT_UTMP_UT_USER */
  275|   	if (NULL != hostname) {

Error: BUFFER_SIZE (CWE-170): [#def16]
shadow-4.8.1/libmisc/utmp.c:278: buffer_size_warning: Calling "strncpy" with a maximum size argument of 256 bytes on destination array "utent->ut_host" of size 256 bytes might leave the destination string unterminated.
  276|   		struct addrinfo *info = NULL;
  277|   #ifdef HAVE_STRUCT_UTMP_UT_HOST
  278|-> 		strncpy (utent->ut_host, hostname, sizeof (utent->ut_host));
  279|   #endif				/* HAVE_STRUCT_UTMP_UT_HOST */
  280|   #ifdef HAVE_STRUCT_UTMP_UT_SYSLEN

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>

2021-06-16 09:50:53 +02:00

..

.indent.pro

Commit the last version from the PLD CVS repository.

2007-10-07 14:36:51 +00:00

addgrps.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

age.c

* libmisc/env.c, libmisc/age.c: Added splint annotations.

2009-04-23 17:33:21 +00:00

audit_help.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

basename.c

Miscellaneous:

2011-09-18 21:02:43 +00:00

btrfs.c

silence compiler warnings

2020-01-12 07:31:26 -06:00

chkname.c

chkname.c, pwck.c, useradd.c, usermod.c, newusers.c: Allow names that do not conform to standards

2019-10-04 18:40:41 -05:00

chkname.h

Updated copyright dates.

2008-05-25 23:31:10 +00:00

chowndir.c

* libmisc/chowndir.c: Add splint annotations.

2011-08-14 14:00:14 +00:00

chowntty.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

cleanup_group.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

cleanup_user.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

cleanup.c

* lib/prototypes.h, libmisc/cleanup.c, lib/spawn.c, src/chage.c:

2011-10-18 20:23:33 +00:00

console.c

Fix some issues found in Coverity scan.

2018-10-10 12:22:04 +02:00

copydir.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

entry.c

Make sure every source files are distributed with a copyright and license.

2008-04-27 00:40:09 +00:00

env.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

failure.c

Fix covscan BUFFER_SIZE

2021-06-16 09:50:53 +02:00

failure.h

spelling: cumulative

2017-10-22 18:33:13 +00:00

find_new_gid.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

find_new_sub_gids.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

find_new_sub_uids.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

find_new_uid.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

getdate.h

* libmisc/limits.c: Avoid implicit conversion of integer to

2010-08-22 19:13:53 +00:00

getdate.y

spelling: gratuitously

2017-10-22 19:17:02 +00:00

getgr_nam_gid.c

* lib/prototypes.h, libmisc/getgr_nam_gid.c: getgr_nam_gid()

2011-08-14 13:16:26 +00:00

getrange.c

* libmisc/get_gid.c, libmisc/get_uid.c, libmisc/Makefile.am,

2009-03-08 20:26:56 +00:00

gettime.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

hushed.c

* libmisc/limits.c: Avoid implicit conversion of integer to

2010-08-22 19:13:53 +00:00

idmapping.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

idmapping.h

subids: support nsswitch

2021-04-16 21:02:37 -05:00

isexpired.c

* libmisc/isexpired.c: Added parenthesis.

2011-06-16 21:25:36 +00:00

limits.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

list.c

* libmisc/console.c, libmisc/motd.c, libmisc/setupenv.c,

2010-08-21 15:32:53 +00:00

log.c

Fix covscan BUFFER_SIZE

2021-06-16 09:50:53 +02:00

loginprompt.c

* libmisc/salt.c (SHA_salt_rounds): It is statically ensured that

2011-09-18 20:41:38 +00:00

mail.c

* libmisc/mail.c, libmisc/copydir.c: Added missing include of

2009-04-27 20:09:18 +00:00

Makefile.am

try again to fix libmisc sharing problem

2021-04-11 17:42:04 -05:00

motd.c

* libmisc/console.c, libmisc/motd.c, libmisc/setupenv.c,

2010-08-21 15:32:53 +00:00

myname.c

* libmisc/myname.c: Updated splint annotations.

2009-04-26 17:10:49 +00:00

obscure.c

Add yescrypt support

2021-02-01 22:11:10 +01:00

pam_pass_non_interactive.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

pam_pass.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

prefix_flag.c

usermod, newusers, prefix: enforce absolute paths for homedir

2021-06-01 22:12:24 -05:00

pwd2spwd.c

Make the sp_lstchg shadow field reproducible (re. #71)

2019-03-31 16:00:01 +01:00

pwd_init.c

Make sure every source files are distributed with a copyright and license.

2008-04-27 00:40:09 +00:00

pwdcheck.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

remove_tree.c

Integrate review comments from Julien Cristau

2010-09-05 15:34:42 +00:00

rlogin.c

* lib/exitcodes.h: Define E_SUCCESS as EXIT_SUCCESS. Added FIXMEs.

2009-04-30 21:08:49 +00:00

root_flag.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

salt.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

setugid.c

Updated copyrights.

2010-08-22 13:04:54 +00:00

setupenv.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

shell.c

* libmisc/limits.c: Avoid implicit conversion of integer to

2010-08-22 19:13:53 +00:00

strtoday.c

spelling: cumulative

2017-10-22 18:33:13 +00:00

sub.c

Fix typo in comment.

2013-08-04 15:56:32 +02:00

sulog.c

Updated copyrights.

2010-08-22 13:04:54 +00:00

ttytype.c

* libmisc/limits.c: Avoid implicit conversion of integer to

2010-08-22 19:13:53 +00:00

tz.c

Updated copyrights.

2010-08-22 13:04:54 +00:00

ulimit.c

* libmisc/limits.c: Add brackets and parenthesis.

2008-06-15 21:59:41 +00:00

user_busy.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

utmp.c

Fix covscan BUFFER_SIZE

2021-06-16 09:50:53 +02:00

valid.c

crypt() in glibc/eglibc 2.17 now fails if passed

2013-07-28 18:41:11 +02:00

xgetgrgid.c

* libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetgrnam.c,

2009-06-11 21:33:00 +00:00

xgetgrnam.c

* libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetgrnam.c,

2009-06-11 21:33:00 +00:00

xgetpwnam.c

* libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetgrnam.c,

2009-06-11 21:33:00 +00:00

xgetpwuid.c

* libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetgrnam.c,

2009-06-11 21:33:00 +00:00

xgetspnam.c

* libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetgrnam.c,

2009-06-11 21:33:00 +00:00

xgetXXbyYY.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

xmalloc.c

libsubid: don't print error messages on stderr by default

2021-05-15 12:38:55 -05:00

yesno.c

* libmisc/yesno.c: Ignore the return value of puts.

2009-04-23 11:14:56 +00:00