emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Coverity CID 1406626, avoid strncat() in favor of snprintf()

Browse Source 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson 2019-11-05 09:35:59 +01:00
parent 1f4877e21f
commit f6ecb8b47b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/syslogd.c
View File

@ -1880,7 +1880,7 @@ void wallmsg(struct filed *f, struct iovec *iov, int iovcnt)
static int reenter = 0;
struct utmp *uptr;
struct utmp ut;
char p[sizeof(_PATH_DEV) + UNAMESZ];
char p[sizeof(_PATH_DEV) + UNAMESZ + 1];
char greetings[200];
int ttyf, len, i;
@ -1932,8 +1932,7 @@ void wallmsg(struct filed *f, struct iovec *iov, int iovcnt)
}
/* compute the device name */
strcpy(p, _PATH_DEV);
strncat(p, ut.ut_line, UNAMESZ);
snprintf(p, sizeof(p), "%s%s", _PATH_DEV, ut.ut_line);
if (f->f_type == F_WALL) {
iov[0].iov_base = greetings;