2007-10-07 17:17:57 +05:30
|
|
|
/*
|
2008-04-27 06:10:09 +05:30
|
|
|
* Copyright (c) 2000 , International Business Machines
|
|
|
|
* George Kraft IV, gk4@us.ibm.com, 03/23/2000
|
|
|
|
* Copyright (c) 2000 - 2006, Tomasz Kłoczko
|
|
|
|
* Copyright (c) 2007 - 2008, Nicolas François
|
2007-10-07 17:17:57 +05:30
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
2008-04-27 06:10:09 +05:30
|
|
|
* 3. The name of the copyright holders or contributors may not be used to
|
|
|
|
* endorse or promote products derived from this software without
|
|
|
|
* specific prior written permission.
|
2007-10-07 17:17:57 +05:30
|
|
|
*
|
2008-04-27 06:10:09 +05:30
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
* ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
|
|
|
|
* PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
* HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
2007-10-07 17:17:57 +05:30
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <getopt.h>
|
|
|
|
#include <grp.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <sys/types.h>
|
|
|
|
#ifdef USE_PAM
|
|
|
|
#include "pam_defs.h"
|
|
|
|
#endif /* USE_PAM */
|
2007-10-07 17:18:07 +05:30
|
|
|
#include <pwd.h>
|
2007-10-07 17:17:57 +05:30
|
|
|
#include "defines.h"
|
|
|
|
#include "groupio.h"
|
|
|
|
|
|
|
|
/* Exit Status Values */
|
|
|
|
|
|
|
|
#define EXIT_SUCCESS 0 /* success */
|
|
|
|
#define EXIT_USAGE 1 /* invalid command syntax */
|
|
|
|
#define EXIT_GROUP_FILE 2 /* group file access problems */
|
2007-10-07 20:06:51 +05:30
|
|
|
#define EXIT_NOT_ROOT 3 /* not superuser */
|
|
|
|
#define EXIT_NOT_EROOT 4 /* not effective superuser */
|
2007-10-07 17:17:57 +05:30
|
|
|
#define EXIT_NOT_PRIMARY 5 /* not primary owner of group */
|
|
|
|
#define EXIT_NOT_MEMBER 6 /* member of group does not exist */
|
|
|
|
#define EXIT_MEMBER_EXISTS 7 /* member of group already exists */
|
2008-07-26 21:41:49 +05:30
|
|
|
#define EXIT_INVALID_USER 8 /* specified user does not exist */
|
|
|
|
#define EXIT_INVALID_GROUP 9 /* specified group does not exist */
|
2007-10-07 17:17:57 +05:30
|
|
|
|
|
|
|
#define TRUE 1
|
|
|
|
#define FALSE 0
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Global variables
|
|
|
|
*/
|
|
|
|
static char *adduser = NULL;
|
|
|
|
static char *deluser = NULL;
|
|
|
|
static char *thisgroup = NULL;
|
|
|
|
static int purge = FALSE;
|
|
|
|
static int list = FALSE;
|
|
|
|
static int exclusive = 0;
|
2008-07-26 21:41:49 +05:30
|
|
|
static char *Prog;
|
2007-10-07 17:17:57 +05:30
|
|
|
|
|
|
|
static int isroot (void)
|
|
|
|
{
|
|
|
|
return getuid ()? FALSE : TRUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int isgroup (void)
|
|
|
|
{
|
|
|
|
gid_t g = getgid ();
|
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-19 04:45:26 +05:30
|
|
|
struct group *grp = getgrgid (g); /* local, no need for xgetgrgid */
|
2007-10-07 17:17:57 +05:30
|
|
|
|
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static char *whoami (void)
|
|
|
|
{
|
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-19 04:45:26 +05:30
|
|
|
/* local, no need for xgetgrgid */
|
2007-10-07 17:17:57 +05:30
|
|
|
struct group *grp = getgrgid (getgid ());
|
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-19 04:45:26 +05:30
|
|
|
/* local, no need for xgetpwuid */
|
2007-10-07 17:17:57 +05:30
|
|
|
struct passwd *usr = getpwuid (getuid ());
|
|
|
|
|
|
|
|
if (0 == strcmp (usr->pw_name, grp->gr_name)) {
|
|
|
|
return (char *) strdup (usr->pw_name);
|
|
|
|
} else {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void addtogroup (char *user, char **members)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; NULL != members[i]; i++) {
|
|
|
|
if (0 == strcmp (user, members[i])) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Member already exists\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_MEMBER_EXISTS);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-02-19 03:06:03 +05:30
|
|
|
members = (char **) realloc (members, sizeof (char *) * (i+2));
|
2007-10-07 17:17:57 +05:30
|
|
|
members[i] = user;
|
|
|
|
members[i + 1] = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void rmfromgroup (char *user, char **members)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int found = FALSE;
|
|
|
|
|
|
|
|
i = 0;
|
|
|
|
while (!found && NULL != members[i]) {
|
|
|
|
if (0 == strcmp (user, members[i])) {
|
|
|
|
found = TRUE;
|
|
|
|
} else {
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
while (found && NULL != members[i]) {
|
2007-11-20 01:55:36 +05:30
|
|
|
members[i] = members[i+1];
|
|
|
|
i++;
|
2007-10-07 17:17:57 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
if (!found) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Member to remove could not be found\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_NOT_MEMBER);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nomembers (char **members)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; NULL != members[i]; i++) {
|
|
|
|
members[i] = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void members (char **members)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; NULL != members[i]; i++) {
|
|
|
|
printf ("%s ", members[i]);
|
|
|
|
|
|
|
|
if (NULL == members[i + 1]) {
|
|
|
|
printf ("\n");
|
|
|
|
} else {
|
|
|
|
printf (" ");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void usage (void)
|
|
|
|
{
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Usage: groupmems -a username | -d username | -D | -l [-g groupname]\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_USAGE);
|
|
|
|
}
|
|
|
|
|
|
|
|
int main (int argc, char **argv)
|
|
|
|
{
|
|
|
|
int arg;
|
|
|
|
char *name;
|
|
|
|
struct group *grp;
|
|
|
|
|
|
|
|
#ifdef USE_PAM
|
|
|
|
pam_handle_t *pamh = NULL;
|
|
|
|
int retval;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
int option_index = 0;
|
|
|
|
static struct option long_options[] = {
|
|
|
|
{"add", required_argument, NULL, 'a'},
|
|
|
|
{"delete", required_argument, NULL, 'd'},
|
|
|
|
{"group", required_argument, NULL, 'g'},
|
|
|
|
{"list", no_argument, NULL, 'l'},
|
|
|
|
{"purge", no_argument, NULL, 'p'},
|
|
|
|
{NULL, 0, NULL, '\0'}
|
|
|
|
};
|
|
|
|
|
2008-07-26 21:41:49 +05:30
|
|
|
/*
|
|
|
|
* Get my name so that I can use it to report errors.
|
|
|
|
*/
|
|
|
|
Prog = Basename (argv[0]);
|
|
|
|
|
2008-06-10 01:39:38 +05:30
|
|
|
(void) setlocale (LC_ALL, "");
|
|
|
|
(void) bindtextdomain (PACKAGE, LOCALEDIR);
|
|
|
|
(void) textdomain (PACKAGE);
|
|
|
|
|
2007-10-07 17:17:57 +05:30
|
|
|
while ((arg =
|
|
|
|
getopt_long (argc, argv, "a:d:g:lp", long_options,
|
|
|
|
&option_index)) != EOF) {
|
|
|
|
switch (arg) {
|
|
|
|
case 'a':
|
|
|
|
adduser = strdup (optarg);
|
|
|
|
++exclusive;
|
|
|
|
break;
|
|
|
|
case 'd':
|
|
|
|
deluser = strdup (optarg);
|
|
|
|
++exclusive;
|
|
|
|
break;
|
|
|
|
case 'p':
|
|
|
|
purge = TRUE;
|
|
|
|
++exclusive;
|
|
|
|
break;
|
|
|
|
case 'g':
|
|
|
|
thisgroup = strdup (optarg);
|
|
|
|
break;
|
|
|
|
case 'l':
|
|
|
|
list = TRUE;
|
|
|
|
++exclusive;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
usage ();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (exclusive > 1 || optind < argc) {
|
|
|
|
usage ();
|
|
|
|
}
|
|
|
|
|
2008-07-26 21:41:49 +05:30
|
|
|
if (getpwnam(adduser) == NULL) {
|
|
|
|
fprintf (stderr, _("%s: user `%s' does not exist\n")
|
|
|
|
Prog, adduser);
|
|
|
|
exit (EXIT_INVALID_USERNAME);
|
|
|
|
}
|
|
|
|
|
2007-10-07 17:17:57 +05:30
|
|
|
if (!isroot () && NULL != thisgroup) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Only root can add members to different groups\n"),
|
|
|
|
stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_NOT_ROOT);
|
|
|
|
} else if (isroot () && NULL != thisgroup) {
|
|
|
|
name = thisgroup;
|
|
|
|
} else if (!isgroup ()) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Group access is required\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_NOT_EROOT);
|
|
|
|
} else if (NULL == (name = whoami ())) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Not primary owner of current group\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_NOT_PRIMARY);
|
|
|
|
}
|
|
|
|
#ifdef USE_PAM
|
|
|
|
retval = PAM_SUCCESS;
|
|
|
|
|
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-19 04:45:26 +05:30
|
|
|
{
|
|
|
|
struct passwd *pampw;
|
|
|
|
pampw = getpwuid (getuid ()); /* local, no need for xgetpwuid */
|
|
|
|
if (pampw == NULL) {
|
|
|
|
retval = PAM_USER_UNKNOWN;
|
|
|
|
}
|
2007-10-07 17:17:57 +05:30
|
|
|
|
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-19 04:45:26 +05:30
|
|
|
if (retval == PAM_SUCCESS) {
|
|
|
|
retval = pam_start ("groupmod", pampw->pw_name,
|
|
|
|
&conv, &pamh);
|
|
|
|
}
|
2007-10-07 17:17:57 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
if (retval == PAM_SUCCESS) {
|
|
|
|
retval = pam_authenticate (pamh, 0);
|
|
|
|
if (retval != PAM_SUCCESS) {
|
2008-06-10 01:39:38 +05:30
|
|
|
(void) pam_end (pamh, retval);
|
2007-10-07 17:17:57 +05:30
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (retval == PAM_SUCCESS) {
|
|
|
|
retval = pam_acct_mgmt (pamh, 0);
|
|
|
|
if (retval != PAM_SUCCESS) {
|
2008-06-10 01:39:38 +05:30
|
|
|
(void) pam_end (pamh, retval);
|
2007-10-07 17:17:57 +05:30
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (retval != PAM_SUCCESS) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("PAM authentication failed for\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
if (!gr_lock ()) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Unable to lock group file\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_GROUP_FILE);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!gr_open (O_RDWR)) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Unable to open group file\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_GROUP_FILE);
|
|
|
|
}
|
|
|
|
|
|
|
|
grp = (struct group *) gr_locate (name);
|
|
|
|
|
2008-07-26 21:41:49 +05:30
|
|
|
if (grp == NULL) {
|
|
|
|
fprintf (stderr, _("%s: `%s' not found in /etc/group\n"),
|
|
|
|
Prog, name);
|
|
|
|
exit (EXIT_READ_GROUP);
|
|
|
|
}
|
|
|
|
|
2007-10-07 17:17:57 +05:30
|
|
|
if (NULL != adduser) {
|
|
|
|
addtogroup (adduser, grp->gr_mem);
|
|
|
|
gr_update (grp);
|
|
|
|
} else if (NULL != deluser) {
|
|
|
|
rmfromgroup (deluser, grp->gr_mem);
|
|
|
|
gr_update (grp);
|
|
|
|
} else if (purge) {
|
|
|
|
nomembers (grp->gr_mem);
|
|
|
|
gr_update (grp);
|
|
|
|
} else if (list) {
|
|
|
|
members (grp->gr_mem);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!gr_close ()) {
|
2008-01-25 02:12:12 +05:30
|
|
|
fputs (_("Cannot close group file\n"), stderr);
|
2007-10-07 17:17:57 +05:30
|
|
|
exit (EXIT_GROUP_FILE);
|
|
|
|
}
|
|
|
|
|
|
|
|
gr_unlock ();
|
|
|
|
|
|
|
|
#ifdef USE_PAM
|
|
|
|
if (retval == PAM_SUCCESS) {
|
2008-06-10 01:39:38 +05:30
|
|
|
(void) pam_end (pamh, PAM_SUCCESS);
|
2007-10-07 17:17:57 +05:30
|
|
|
}
|
|
|
|
#endif /* USE_PAM */
|
|
|
|
exit (EXIT_SUCCESS);
|
|
|
|
}
|