Port my fix from gramps34: [ecdcca] [aa9deb]
The enable/disable code behaves worse under gtk3, need further polish
(this is not related to the current fix). Sometimes the changes
to the d/m/y edit fields don't fire the "changed" signal with the
UI value seen by build_date_from_ui
the currently used LANG
With patch works like:
* default to dictionary in system locale if exist (language Gramps use)
* if no system-locale dictionary default to English dictionary if exist but
allow selection of any other installed one
* if both English and system-locale dictionary is not available,
disable spellchecking
Port gramps34 [429c18]
Applying patch from 2013-12-24 by Enno Borgsteede,
fixing attribute processing on the path that handled _UID
and adding another extension, _FSFTID.
In preparation for fixing the bug, discovered minor glitches
in the open/lock/close logic on error paths. Using the RAII syntax
for xml_file and removing redundant unlock-before-close.
The parse errors now have friendlier verbiage, give action suggestions,
and point to the actual file location for better usability and
maintainability.
Port my fixes based on the patch from Matthias Basler from gramps34
[2eca30] 7290: use simpler math in image_dpi
[2f5e22] 7290: align warning with the image_dpi fix logic
[36f84e] 7290: image_dpi default calc based on gtk.gdk
[161ce3] 7290: ImgManip.image_dpi shouldn't return None
[460e63] 7288/7290 refactor out crop_percentage_to_pixel
[a8a38f] 7288/7290 refactor out crop_percentage_to_subpixel
[0d61bb] 7288/7290: refactor fix from matthiasbasler
[088146] rm relict RCS kwd
[76df5d] 7288/7290: image cropping fixes in ODFDoc
Using legacy gtk interface in image.py at the moment, need to port
to the new style.
Tested with python2.
If the date is invalid, it will be converted to text mode,
and the text field will be set to the problematic XML.
A warning will be printed on the console as well.
The log message will use the invalid date attached as
DateError.date, see [8e1659].
Revalidate the date upon every change, and disable
OKing the dialog when it is not valid, for usability review.
If it is not good, we can always revert this commit.
when Date.set throws during the date fields sanity
check validation, it now attaches an (undocumented) .date field
to the exception -- proof of concept for 7198 and potentially
for 7212 as well
Improve user experience as promised in [98d8e6].
Now, if one clicks OK in the date editor and the date is invalid,
it's switched into text mode and the dialog remains open,
so the user can either correct the date or type it as text,
no more loss of entered data happens.
Now it just autoconverts into MOD_TEXT and returns whatever
text was there. This fixes the crash on the master branch,
but is not the final user experience yet.
All date tests pass cleanly on gramps40 branch.
Merged the following commits.
commit a90139cb9a
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Fri Nov 15 15:04:03 2013 +0200
7197, 7100: missing recalc_sort_value in ny code
Fix bug #7197
commit baae6ac615
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Thu Nov 14 22:45:42 2013 +0200
7197: readjust sanity date wrt newyear/slash
Attempt to fix the failing
DateHandlerTest.test_invalid_month_with_ny
(see 7197:32625). Tests still fail, investigation shows
there's a problem in Date.set setting Julian+Mar25 date even if the
date validation check is disabled by inserting a return before
the validation block, i.e., before this line
if modifier != Date.MOD_TEXTONLY:
which seems to be the root cause of the remaining failing tests.
which seems to be the root cause of the remaining failing tests.
To investigate, add the return and try
LC_ALL=en_GB.utf8 LANG=en_GB.utf8 GRAMPS_RESOURCES=$PWD \
python -m unittest -v \
gramps.gen.lib.test.date_test.MatchDateTest.test_match
commit 4147721112
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Wed Nov 13 22:34:24 2013 +0200
7197: refactor code
extract Date._adjust_newyear out of Date.set
commit b3ab87bc5a
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Wed Nov 13 22:02:21 2013 +0200
7197: refactor code
replace all copies of logging with a single point at the exception
rethrow point
commit c4daa151a5
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Wed Nov 13 17:39:47 2013 +0200
7197: date sanity check breaks on Julian+Mar25
Date.convert_calendar resets the new year setting to 0,
so the sanity check fails. Commit the initial fix that
unblocks the failing test.
Merge from master:
commit 93ca90f3b8
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Thu Nov 14 22:41:46 2013 +0200
7197: more failing tests
commit 78cae43a32
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Wed Nov 13 16:59:26 2013 +0200
7197: better diagnostics from test for debugging
Use unittest -v/--verbose flag to trigger it.
commit 626353a0b3
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Wed Nov 13 13:52:47 2013 +0200
7197: failing test demonstrating the bug
It's actually on both PPC and Intel, and it's from forgetting to update
gramps.accel after upgrading Gtk past 2.24.10, which changed the mapping
of alt/option from Mod5 to Mod1.
For gramps40 and master, the problem was masked by the bundler putting
the file in the wrong directory.
Port from gramps34 branch my fix after retest by the bug submitter.
Add a hack protection for descendants like we already have
for ancestors, and add a debug printout.
svn: r23161
Back-merge from trunk changes to date.py and date_test.py
from the following commits (cumulative, clean apply).
Tests pass (but need to block the CAL_FRENCH on date_test.py:199,
because of bug# 7068 -- skipping it wasn't back-ported in this commit as
it is about the fully fixed issues only!)
commit fa49752824bd58802773439b35faa39f2d34b151
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 15:44:04 2013 +0000
provide sensible defautls for all Date.set params
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23126 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 3f32597699f3b372324ad87e6f7a04abac6d19e7
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 15:11:09 2013 +0000
7045: Setting an invalid date does not raise
do the sanity checks on a separate date object,
so that the uncertainty expressed with 0 d/m isn't removed
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23124 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 12edf7e97626e01931c4063b2d94bec3b299a2ed
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 14:23:58 2013 +0000
7065: Calendar conversion broken for negative date
fixed, repro steps work as expected now
date_test still broken due to further blocking issues,
see #7045
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23123 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 091d4461e9715ab06f1ef6ab3b67517d6608daf3
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 13:24:40 2013 +0000
7045: Date.set on invalid date does not raise
refactor _zero_adjust_ymd out of 3 cut-and-paste cases
the bug with the code inside it remains -- the negative years
should not be clamped to positive ones!!!!
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23122 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 5987046ac4cac407a4be506da9242f7a5000d878
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 13:00:19 2013 +0000
7045: Date.set on invalid date does not raise
Now it does, but another test breaks:
Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/loader.py", line 252, in _find_tests
module = self._get_module_from_name(name)
File "/usr/lib/python2.7/unittest/loader.py", line 230, in _get_module_from_name
__import__(name)
File "/home/vassilii/Gramps/gramps/gen/lib/test/date_test.py", line 136, in <module>
d.set(quality,modifier,calendar,(4,11,-90,False),"Text comment")
File "/home/vassilii/Gramps/gramps/gen/lib/date.py", line 1600, in set
format(original, value))
DateError: Invalid year -90 passed in value (4, 11, -90, False)
because the corresponding year gets adjusted from -90 to 1...
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23121 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit d8876cceb64629ce0a025ff714e4875768ab88a6
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 11:50:58 2013 +0000
7034: fix test_copy_ymd_preserves_orig
broken in r23083
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23120 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 7c163636c8e48149a5b09c211ff3dc146ebd84b2
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Tue Sep 10 17:19:16 2013 +0000
7034: add remove_stop_date parameter
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23083 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit b45e20da3bd67d864420f99cf59fbb9929c58851
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Mon Sep 9 19:31:13 2013 +0000
7034: probably_alive() failing when no birth-death
further refactoring of set_.../set2_... common code
added accessor get_stop_ymd analogous to get_ymd
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23068 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit f13a3fc23e7f0763c49e605b428b6a175c3f9eeb
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Mon Sep 9 19:31:00 2013 +0000
7034: probably_alive() failing when no birth-death
docstring update
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23067 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 9ee312d7ed02520b99d2ca1b28f75c87846aa3c6
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:35:15 2013 +0000
refactor test
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23059 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 07ca997ebd885ad4d1b205907a00509099ac8f9a
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:23:23 2013 +0000
consistency between offset and non-offset setters
added ugly parameter _update2 to set_yr_mon_day, needs refactoring
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23058 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 67a904c529642668fbe34bfc97ef2915278ecbdb
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:23:12 2013 +0000
fix set_yr_mon_day_offset for compound dates
now calls set2_yr_mon_day_offset
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23057 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 3db06c36d6449ec75cde49b433349cddad40d596
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:23:02 2013 +0000
refactor set_yr_mon_day and set2_yr_mon_day
refactor common base
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23056 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 4192680c72cc0028c22fa207fe3f1ff0940358b3
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:22:52 2013 +0000
raise DateError in set2_... if not is_compound()
refactor Date to always use is_compound instead of repeating
its logic everywhere
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23055 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 44195ede18c5a887d4440b4132bd5321f76ce5ff
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:22:40 2013 +0000
Add some UT for Date.set2_... and fix bugs
Cut and paste is evil ;-) fix bugs before I refactor the code...
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23054 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
commit 14f6e3a3f35e0ff7b67006bf4996ce63ae665098
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sun Sep 8 19:22:30 2013 +0000
7034: probably_alive() failing when no birth-death
docstring fix
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23053 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
svn: r23156
Merged from
commit dbae40dd1edad52023b828d5eef0fe7eb3684fb6
Author: Vassilii Khachaturov <vassilii@tarunz.org>
Date: Sat Sep 14 19:42:48 2013 +0000
7066: use sdn module from Calendar package on pypi
Unfortunately, no package on ubuntu for sdn...
Bug fixed on trunk, when sdn is present on the system.
Verified that sdn roundtrip works.
date_test now fails on 1789-13-4(French) recognized as invalid,
as it probably should -- I guess this one is a test bug.
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@23127 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
M gramps/gen/lib/calendar.py
--->M gramps/grampsapp.py
svn: r23132
OOPS. This was tested only with "runtest.sh", but turns out
things are broken with GUI :-) Reverting for now @gramps40,
will investigate on trunk!
svn: r23098
Reapply from trunk.
Now that #7061 is done, all the old code should no longer use
User.begin_.../step_.../end_progress directly any more, preferring
the context manager instead.
The only reject is on gramps/gen/merge/diff.py that doesn't have
any progress callbacks on gramps40. I'm leaving it untouched.
svn: r23097
0006848: citationtreeview corrupts when search bar open and edit occurs
0006829: Searching into source/citation selector disallows to select all related citations, only matching rows
by fixing treebasemodel so it properly deals with secondary objects, and also citationtreemodel so it adds secondary odes even when the parent is not present.
svn: r22940
constfunc.has_display() was using check_init(),
which, on Gtk3, was happy to initalize even that the display was N/A.
Amended the test with an attempt to actually get the Gdk default display.
svn: r22909
Port my fix from gramps34.
In addition, the Check tool now has a hardwired dependency
on ProgressMeter. Make a nullifying mock locally and
only set it to the real thing only under GUI.
Tested with impex.sh (further stages after check still fail,
see bug #6878).
svn: r22899
Preparing to port my fix for 6953: remove "undo history warning"
when the BatchTool run from cli (e.g., "check")
from gramps34, the ground state was worse in gramps40...
svn: r22898
_remaining_events method did the _dump_event_stats indiscriminately,
even if the event in question was skipped during processing as
a birth/death one. Moving the call into the _process_person_event
thus aligning the logic with _remaining_events's docstring.
svn: r22851
Port my fix from gramps34 branch.
Ditches old PSDrawDoc code, instead we have a common backend
for PDF and PS generation using Cairo.
Added bonus: PS is now an available backend for text reports, too!
svn: r22810
Porting from gramps34 my fix for 6935, 6937, 6938.
Import with full "gramps." qualification from the tests,
to overcome the relative import problem (see bug# 6938 for context).
All testing code has been adjusted to the filename and paths
changes since gramps34.
Same as on gramps34, one test fails still, will investigate if
it is a test or a code bug:
ERROR: test_buffer_recall
(ErrorReportAssistant_Test.ErrorReportAssistantTest)
Test that simple recall of messages works.
----------------------------------------------------------------------
Traceback (most recent call last):
File "./GrampsLogger/ErrorReportAssistant_Test.py", line 60, in
test_buffer_recall
rotate_handler=rh)
File "../gramps/gui/logger/_errorreportassistant.py", line 81, in
__init__
self.build_page1()
File "../gramps/gui/logger/_errorreportassistant.py", line 267, in
build_page1
self._reset_error_details()
File "../gramps/gui/logger/_errorreportassistant.py", line 178, in
_reset_error_details
self._error_detail.get_record()))
AttributeError: 'str' object has no attribute 'get_record'
svn: r22729
in some cases produce empty PDF sheets or force graphviz to crash
Problem was due to calling localized float() when parsing a C-locale xml file
svn: r22706
Merged fix from trunk:
Fixed the file locations to work for the gramps40/trunk layout.
Also porting my fix from gramps34 branch for
6837: runtest.sh runs some reports that no longer exist
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@22684 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
svn: r22686
Merge the fix from trunk:
Give a dev-oriented warning on console and pop up a UI
warning dialog for the user, when an inconsistent
translation configuration is detected between gramps and gtk
(happens when a langpack is missing on Ubuntu systems, e.g.)
git-svn-id: svn+ssh://svn.code.sf.net/p/gramps/code/trunk@22683 4ae1f11a-8b86-4847-b8af-ab372f36d1fd
svn: r22685
To data and images so that they're together with the other resources
instead of in site-package/gramps. Aside from a better source and
installation layout, this makes it easier to bundle them.
svn: r22577
Merged as follows:
msgmerge --no-wrap -C ru.po.trunk ru.po gramps.pot -o newru.po
Then resolved all fuzzy strings.
Thanks to Paul Franklin for prodding me so the current new
translations from the trunk available "for free" are included
on gramps40 as well!
svn: r22523
Merged as follows:
msgmerge --no-wrap -C ru.po.trunk ru.po gramps.pot -o newru.po
Then resolved all fuzzy strings.
Thanks to Paul Franklin for prodding me so the current new
translations from the trunk available "for free" are included
on gramps40 as well!
svn: r22491
Update spawnve() to subprocess.check_output()
Pop an ErrorDialog if the system's open command fails in
open_file_with_default_application()
svn: r22418
<_p>Gramps is a genealogy program that is both intuitive for hobbyists and feature-complete for professional genealogists.
It gives you the ability to record the many details of the life of an individual as well as the complex relationships between various people, places and events.
All of your research is kept organized, searchable and as precise as you need it to be.
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
