nekral-guest
dcedc12f36
Add forgotten files in the previous ChangeLog entry.
2007-11-18 23:20:02 +00:00
nekral-guest
9adfc136b6
* lib/prototypes.h, configure.in, libmisc/Makefile.am,
...
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c,
libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c:
Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(),
xgetgrgid(), and xgetspnam(). They allocate memory for the
returned structure and are more robust to successive calls. They
are implemented with the libc's getxxyyy_r() functions if
available.
* libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c,
libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c,
libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c,
src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c,
src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c,
src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c,
src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/suauth.c,
src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the
usage of one of the getpwnam(), getpwuid(), getgrnam(),
getgrgid(), and getspnam() functions. It was noticed on
http://bugs.debian.org/341230 that chfn and chsh use a passwd
structure after calling a pam function, which result in using
information from the passwd structure requested by pam, not the
original one. It is much easier to use the new xget... functions
to avoid these issues. I've checked which call to the original
get... functions could be left (reducing the scope of the
structure if possible), and I've left comments to ease future
reviews (e.g. /* local, no need for xgetpwnam */).
Note: the getpwent/getgrent calls should probably be checked also.
* src/groupdel.c, src/expiry.c: Fix typos in comments.
* src/groupmod.c: Re-indent.
* libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c,
lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup
functions (used by the xget... functions) from the <xx>io.c files
to the new <xx>mem.c files. This avoid linking some utils against
the SELinux library.
2007-11-18 23:15:26 +00:00
nekral-guest
69525890db
Fix typo introduced while fixing http://bugs.debian.org/451521 (compile fix).
2007-11-18 22:52:56 +00:00
nekral-guest
cd1089e6f0
Fix a typo in a comment.
2007-11-18 01:20:10 +00:00
nekral-guest
311f4baa27
Do not document the behavior compared to old versions.
2007-11-17 23:11:02 +00:00
nekral-guest
0743a7236d
Same fixes as applied to usermod: refuse to unlock an account when it
...
would result in a passwordless account.
2007-11-17 22:05:31 +00:00
nekral-guest
85463e754d
Refuse to unlock an account when it would result in a passwordless
...
account. Based on Openwall's patch shadow-4.0.4.1-owl-usermod-unlock.diff
2007-11-17 22:02:22 +00:00
nekral-guest
5e438aa46c
Make sure that the prefix is the name of a directory (not only the
...
beginning of a directory).
Openwall patch shadow-4.0.4.1-owl-userdel-path_prefix.diff.
2007-11-17 21:24:06 +00:00
nekral-guest
1f4488f963
* src/newgrp.c: Do not give an indication that the group has no
...
password.
* src/newgrp.c: Do not only bail on syslog if the password is not
valid. Also give an indication to the user on stderr.
2007-11-17 21:03:33 +00:00
nekral-guest
225b096838
Remove a comment which states that an user shall provide a password to
...
switch to her group.
2007-11-17 20:41:49 +00:00
nekral-guest
8e568ef697
Last parts of the Openwall patch shadow-4.0.4.1-owl-chage-drop-priv.diff:
...
* src/chage.c: Make chage -l also drop the saved GID.
* src/chage.c: Prefer setregid/setreuid to setgid/setuid.
2007-11-17 20:28:32 +00:00
nekral-guest
24cfb1c158
* src/chage.c: Remove cleanup(). pw_lock is never called. Replace
...
cleanup(2) by spw_unlock and remove the calls to cleanup(1).
* src/chage.c: Remove variable pwrw. It is always set to 0. The
password database is always read only.
2007-11-17 20:09:54 +00:00
nekral-guest
0fd1ed4517
Avoid terminating the PAM library in the forked child. This is done later
...
in the parent after closing the PAM session.
This fixes http://bugs.debian.org/412061 .
Debian patch 405_su_no_pam_end_before_exec.
2007-11-17 17:19:44 +00:00
nekral-guest
be972d7db3
Fix typo: the warndays option was called warning. This is now warndays,
...
as documented in the manpage and usage. Debian patch 417_passwd_warndays.
2007-11-17 16:57:37 +00:00
nekral-guest
fb6cb07a60
Remove the preprocessor check SHADOWPWD. The variable is no more defined
...
(and always assumed). Debian patch 493_pwck_no_SHADOWPWD.
2007-11-17 16:50:26 +00:00
nekral-guest
e47ee90033
-l/-u options: edit the shadow account expiry field *in addition* to
...
editing the password field. Debian patch 494_passwd_lock.
2007-11-17 16:40:39 +00:00
nekral-guest
5d2ca8b240
Do not request a password when a user uses newgrp to switch to her primary
...
group. Debian patch 497_newgrp_primary_group.
2007-11-17 16:19:00 +00:00
nekral-guest
90ef765c2e
Log an error if the password entry could not be
...
found (respect LOG_UNKFAIL_ENAB to avoid logging a password). This
fixes the Debian bug http://bugs.debian.org/451521
2007-11-17 16:05:54 +00:00
nekral-guest
e39a941413
Allow the -b option even without the -D option.
2007-11-17 15:07:59 +00:00
nekral-guest
87b5ce3036
Use the same error message for the below errors.
...
(option working ONLY if another is specified).
2007-11-17 14:49:39 +00:00
nekral-guest
af045a0733
Make usermod -o and -u work independently of the argument order.
2007-11-17 14:40:54 +00:00
nekral-guest
488184394e
Validate that two of the -L, -p, and -U options are not used at the same
...
time after the parsing of options. -U used to be allowed after -p or -L,
but not before.
2007-11-17 14:33:26 +00:00
nekral-guest
71392cdc8f
Make usermod -d and -m work independant of the argument order. Thanks to
...
Justin Pryzby <jpryzby+d@quoininc.com> for the patch. This fixes Debian's
bug #451518 .
2007-11-17 14:21:05 +00:00
nekral-guest
6c2e7c124f
Remove remaining return value in update_group.
2007-11-17 13:48:56 +00:00
nekral-guest
24e742d202
* src/usermod.c (fail_exit): Add static variables pw_locked,
...
spw_locked, gr_locked, and sgr_locked to indicate which files must
be unlocked.
* src/usermod.c (open_files, close_files): Open and close the
group files as well as the passwd files. This permit to check if
the group files modification are allowed before writing the passwd
files.
* src/usermod.c (grp_update, update_gshadow, update_group): Do not
return a status code, but call fail_exit() in case of error. The
group files are no more opened and closed in update_gshadow() and
update_group().
* src/usermod.c (main): move the call to grp_update between
open_files and close_files.
* src/usermod.c: Differentiate failure to add a group entry and
failure to add a shadow group entry.
2007-11-17 11:42:47 +00:00
nekral-guest
326074388c
Differentiate failure to update a group entry and failure to update a shadow group entry.
2007-11-17 11:31:06 +00:00
nekral-guest
9afe59af3e
Inform the user if out of memory while updating a group database.
2007-11-16 23:39:42 +00:00
nekral-guest
7ecdf9b71f
Update the group database before flushing the nscd caches.
2007-11-16 23:29:41 +00:00
nekral-guest
0325483ee4
Abort if an error is found while updating the user or group database. No
...
changes will be written in the databases.
2007-11-16 23:26:56 +00:00
nekral-guest
b370e1502e
It is no more needed to check that the user's groups are specified only
...
once in the group file. This is checked by gr_update().
2007-11-16 23:05:24 +00:00
nekral-guest
449f17385a
* libmisc/salt.c: Make sure the salt string is terminated at the
...
right place (either 8th, or 11th position).
* NEWS, src/chgpasswd.c, src/chpasswd.c: The protocol + salt does
not need 15 chars. No need for a temporary buffer.
This change the fix committed on 2007-11-10. The salt provided to
pw_encrypt could have been too long.
2007-11-16 19:02:00 +00:00
nekral-guest
e0edb7db17
Add support for systems with no innetgr(). On those systems, username
...
with an @ will be treated like any other username (i.e. lookup in the
local database for an user with an @). Thanks to Mike Frysinger for the
patch.
2007-11-16 11:32:42 +00:00
nekral-guest
690f7aee2e
Indentation fix.
2007-11-16 10:50:38 +00:00
nekral-guest
8d527f156d
Declare the child and pid variable at the beginning of a block. This
...
fixes a compilation issue with gcc 2.95. The intent is the same as
Gentoo's patch shadow-4.0.12-gcc2.patch.
2007-11-14 13:46:15 +00:00
nekral-guest
15f43716c1
Add a variable to set the suid permissions. This should simplify Gentoo's
...
patch shadow-4.0.11.1-perms.patch.
2007-11-14 13:32:25 +00:00
nekral-guest
b2120265fd
Added the subversion svn:keywords property (Id) for proper identification.
2007-11-10 23:46:11 +00:00
nekral-guest
f9de15fdcf
Don't ask for a password if there are no group passwords. Just directly
...
give up. This comes from the Fedora's patch shadow-4.0.13-newgrpPwd.patch,
and seems to be the only part with an effect.
2007-11-10 18:54:40 +00:00
nekral-guest
1bdb92706e
Fix chpasswd and chgpasswd stack overflow. Based on Fedora's shadow-4.0.18.1-overflow.patch.
2007-11-10 18:48:23 +00:00
nekral-guest
6a051e1544
Allow non numerical group identifier to be specified with useradd's -g
...
option. Applied Debian patch 397_non_numerical_identifier. Thanks also to
Greg Schafer <gschafer@zip.com.au>.
2007-11-10 15:51:38 +00:00
bubulle
3ada732dc0
Mention the GNU origin of some parts from su. Debian patch 438
2007-10-27 13:50:40 +00:00
bubulle
84b79dd20d
Merge Debian patch 402: clarify usermod "-a" help
2007-10-27 13:01:19 +00:00
bubulle
d059ef6780
No longer apologize to users
2007-10-27 12:46:30 +00:00
nekral-guest
e3f303fdb5
If compiled without PAM support, enforce the limits from /etc/limits when
...
one of the -, -l, or --login options is set, even if called by root.
Thanks to Justin Bronder.
2007-10-12 22:36:26 +00:00
nekral-guest
79bf2081fe
Commit the last version from the PLD CVS repository.
...
(last changelog entry: 2007-02-01)
This also adds the files which were present in the CVS repository, but not
present in the shadow archives.
2007-10-07 14:36:51 +00:00
nekral-guest
0d93a36930
Remove generated files present in the shadow archives but not in the CVS
...
repository.
2007-10-07 13:59:23 +00:00
nekral-guest
c187b2be78
[svn-upgrade] Integrating new upstream version, shadow (4.0.18.1)
2007-10-07 11:48:07 +00:00
nekral-guest
5e20c4359f
[svn-upgrade] Integrating new upstream version, shadow (4.0.18)
2007-10-07 11:47:57 +00:00
nekral-guest
8a78a8d68c
[svn-upgrade] Integrating new upstream version, shadow (4.0.17)
2007-10-07 11:47:45 +00:00
nekral-guest
0fa9083026
[svn-upgrade] Integrating new upstream version, shadow (4.0.16)
2007-10-07 11:47:33 +00:00
nekral-guest
591830e43b
[svn-upgrade] Integrating new upstream version, shadow (4.0.15)
2007-10-07 11:47:22 +00:00
nekral-guest
24178ad677
[svn-upgrade] Integrating new upstream version, shadow (4.0.14)
2007-10-07 11:47:11 +00:00
nekral-guest
8451bed8b0
[svn-upgrade] Integrating new upstream version, shadow (4.0.13)
2007-10-07 11:47:01 +00:00
nekral-guest
e89f3546f2
[svn-upgrade] Integrating new upstream version, shadow (4.0.12)
2007-10-07 11:46:52 +00:00
nekral-guest
1de90a599c
[svn-upgrade] Integrating new upstream version, shadow (4.0.11.1)
2007-10-07 11:46:43 +00:00
nekral-guest
b48129fcbb
[svn-upgrade] Integrating new upstream version, shadow (4.0.11)
2007-10-07 11:46:34 +00:00
nekral-guest
8c50e06102
[svn-upgrade] Integrating new upstream version, shadow (4.0.10)
2007-10-07 11:46:25 +00:00
nekral-guest
7c47e0fde3
[svn-upgrade] Integrating new upstream version, shadow (4.0.9)
2007-10-07 11:46:16 +00:00
nekral-guest
8e167d28af
[svn-upgrade] Integrating new upstream version, shadow (4.0.8)
2007-10-07 11:46:07 +00:00
nekral-guest
0ee095abd8
[svn-upgrade] Integrating new upstream version, shadow (4.0.7)
2007-10-07 11:45:58 +00:00
nekral-guest
164b557066
[svn-upgrade] Integrating new upstream version, shadow (4.0.6)
2007-10-07 11:45:49 +00:00
nekral-guest
b0e078d9c8
[svn-upgrade] Integrating new upstream version, shadow (4.0.5)
2007-10-07 11:45:40 +00:00
nekral-guest
effd479bff
[svn-upgrade] Integrating new upstream version, shadow (4.0.4)
2007-10-07 11:45:23 +00:00
nekral-guest
4903ce068e
[svn-upgrade] Integrating new upstream version, shadow (4.0.3)
2007-10-07 11:45:14 +00:00
nekral-guest
37dc61340b
[svn-upgrade] Integrating new upstream version, shadow (4.0.2)
2007-10-07 11:45:07 +00:00
nekral-guest
9db6abfa42
[svn-upgrade] Integrating new upstream version, shadow (4.0.1)
2007-10-07 11:44:59 +00:00
nekral-guest
3bc4996775
[svn-upgrade] Integrating new upstream version, shadow (4.0.0)
2007-10-07 11:44:51 +00:00
nekral-guest
4e3fe42600
[svn-upgrade] Integrating new upstream version, shadow (20001012)
2007-10-07 11:44:38 +00:00
nekral-guest
d6e9891ad7
[svn-upgrade] Integrating new upstream version, shadow (20000902)
2007-10-07 11:44:32 +00:00
nekral-guest
be1f391d2a
[svn-upgrade] Integrating new upstream version, shadow (20000826)
2007-10-07 11:44:26 +00:00
nekral-guest
5cd76a407a
[svn-upgrade] Integrating new upstream version, shadow (20000902)
2007-10-07 11:44:20 +00:00
nekral-guest
efd7efa9f1
[svn-upgrade] Integrating new upstream version, shadow (20000826)
2007-10-07 11:44:14 +00:00
nekral-guest
446e664caa
[svn-upgrade] Integrating new upstream version, shadow (19990827)
2007-10-07 11:44:08 +00:00
nekral-guest
45c6603cc8
[svn-upgrade] Integrating new upstream version, shadow (19990709)
2007-10-07 11:44:02 +00:00